Tony Cho [Wed, 30 Sep 2015 09:44:36 +0000 (18:44 +0900)]
staging: wilc1000: rename strPowerMgmtparam
This patch renames strPowerMgmtparam to pwr_mgmt_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:35 +0000 (18:44 +0900)]
staging: wilc1000: remove struct timer_cb
This patch removes struct timer_cb which is not used.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:34 +0000 (18:44 +0900)]
staging: wilc1000: rename strEditStaParam
This patch renames strEditStaParam to edit_sta_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:33 +0000 (18:44 +0900)]
staging: wilc1000: rename strDelStaParam
This patch renames strDelStaParam to del_sta_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:32 +0000 (18:44 +0900)]
staging: wilc1000: rename strAddStaParam
This patch renames strAddStaParam to add_sta_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:31 +0000 (18:44 +0900)]
staging: wilc1000: rename strHostIFSetBeacon
This patch renames strHostIFSetBeacon to beacon_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:30 +0000 (18:44 +0900)]
staging: wilc1000: rename struct set_beacon
This patch renames struct set_beacon to beacon_attr to keep the naming
convention as scan_attr, connect_attr and channel_attr.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:29 +0000 (18:44 +0900)]
staging: wilc1000: remove struct del_beacon
This patch removes struct del_beacon which is not necessary. This patch
also changes Handle_DelBeacon function by removing 2nd parameter, struct
del_beacon because it is not used inside.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:28 +0000 (18:44 +0900)]
staging: wilc1000: rename strHostIFSetChan
This patch renames strHostIFSetChan to channel_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:27 +0000 (18:44 +0900)]
staging: wilc1000: rename struct set_channel
This patch renames struct set_channel to channel_attr to keep the naming
convention such as scan_attr and connect_attr.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:26 +0000 (18:44 +0900)]
staging: wilc1000: remove struct get_channel
This patch removes struct get_channel from the driver because it is not
used anywhere.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:25 +0000 (18:44 +0900)]
staging: wilc1000: rename strHostIFCfgParamAttr
This patch renames strHostIFCfgParamAttr to cfg_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:24 +0000 (18:44 +0900)]
staging: wilc1000: rename strHostIFkeyAttr
This patch renames strHostIFkeyAttr to key_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:23 +0000 (18:44 +0900)]
staging: wilc1000: rename strRcvdGnrlAsyncInfo
This patch renames strRcvdGnrlAsyncInfo to async_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:22 +0000 (18:44 +0900)]
staging: wilc1000: rename strRcvdNetworkInfo
This patch renames strRcvdNetworkInfo to net_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:21 +0000 (18:44 +0900)]
staging: wilc1000: rename strHostIFconnectAttr
This patch renames strHostIFconnectAttr to con_info to avoid CamelCase
naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:20 +0000 (18:44 +0900)]
staging: wilc1000: rename strHostIFscanAttr
This patch renames strHostIFscanAttr to scan_info in order to avoid
CamelCase naming convention.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:19 +0000 (18:44 +0900)]
staging: wilc1000: remove AGING_ALG
This patch removes AGING_ALG from the Makefile because it is always in
use.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 30 Sep 2015 09:44:18 +0000 (18:44 +0900)]
staging: wilc1000: remove PLL_WORKAROUND
This patch removes unnecessary definition, PLL_WORKAROUND from the
Makefile. There is no use throughout the driver.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Fri, 2 Oct 2015 05:52:56 +0000 (21:52 -0800)]
Staging: rtl8192u: Remove spaces at the start of lines
This is a patch to correct indentation in one instance in
ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Fri, 2 Oct 2015 05:52:52 +0000 (21:52 -0800)]
Staging: rtl8192u: Correct open brace placement
This is a patch to move open braces to the appropriate lines in
two instances in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Fri, 2 Oct 2015 05:52:47 +0000 (21:52 -0800)]
Staging: rtl8192u: Fix block comment formatting
This is a patch to correct block comment formatting in two
instances in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Fri, 2 Oct 2015 05:52:43 +0000 (21:52 -0800)]
Staging: rtl8192u: missing blank lines after declarations
This is a patch to add missing lines after variable decalarations
in two functions in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Fri, 2 Oct 2015 05:52:37 +0000 (21:52 -0800)]
Staging: rtl8192u: quoted strings split across lines
This is a patch to fix up instances where quoted strings are split
across multiple lines in several instances in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Thu, 1 Oct 2015 09:14:04 +0000 (12:14 +0300)]
staging: sm750fb: remove clear method from lynxfb_{crtc,output}
The clear methods of lynxfb_crtc and lynxfb_output are empty and
therefore they can be removed.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Thu, 1 Oct 2015 09:14:03 +0000 (12:14 +0300)]
staging: sm750fb: remove proc_checkMode method from lynxfb_output
The proc_checkMode of lynxfb_output is set to function that always
returns 0. Calling that function and checking for its return value is
meaningless.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Thu, 1 Oct 2015 09:14:02 +0000 (12:14 +0300)]
staging: sm750fb: remove unneeded switch statement
The lynxfb_ops_check_var function has two switch statements, the first
one checks for validity of var->bits_per_pixel and it is is immediatly
followed by another one that sets parameters according to
var->bits_per_pixel value. These switch statements can be merged into
one.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Iban Rodriguez [Thu, 1 Oct 2015 20:21:40 +0000 (22:21 +0200)]
Staging: rtl8188eu: Correct two coding style errors
Correct two errors reported by checkpatch.pl because space prohibited
before ','.
Also split both lines into multiple lines as they are longer than
80 characters
Signed-off-by: Iban Rodriguez <iban.rodriguez@ono.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andy Shevchenko [Thu, 1 Oct 2015 13:18:07 +0000 (16:18 +0300)]
staging: rtl8712: re-use mac_pton()
...instead of custom approach
Cc: Joshua Clayton <stillcompiling@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bryan Paul [Wed, 30 Sep 2015 17:05:09 +0000 (11:05 -0600)]
staging:rtl8188eu style fix
Fixed style issue if comparison should place constant on right of test
Signed-off-by: Bryan Paul <bryan.paul@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luis de Bethencourt [Wed, 30 Sep 2015 12:12:11 +0000 (13:12 +0100)]
staging: rtl8192e: rtl_wx: fix negative noise value
wstats->qual.noise is of type uint8, so it shouldn't be assigned a
negative number. Assigning it 0x100 - 100, which is the equivalent
to -100 dBm when IW_QUAL_DBM is set.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Tested-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Wed, 30 Sep 2015 15:20:47 +0000 (10:20 -0500)]
staging: rtl8188eu: Add missing include
In commit
0a0796eb16f3, there is no include to mon.h, a newly created
header file. This omission leads to the following Sparse warnings:
CHECK drivers/staging/rtl8188eu/os_dep/mon.c
drivers/staging/rtl8188eu/os_dep/mon.c:81:6: warning: symbol 'rtl88eu_mon_recv_hook' was not declared. Should it be static?
drivers/staging/rtl8188eu/os_dep/mon.c:113:6: warning: symbol 'rtl88eu_mon_xmit_hook' was not declared. Should it be static?
drivers/staging/rtl8188eu/os_dep/mon.c:167:19: warning: symbol 'rtl88eu_mon_init' was not declared. Should it be static?
drivers/staging/rtl8188eu/os_dep/mon.c:188:6: warning: symbol 'rtl88eu_mon_deinit' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jakub Sitnicki <jsitnicki@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arjun Krishna Babu [Wed, 30 Sep 2015 12:54:22 +0000 (18:24 +0530)]
staging: vt6655: Fixed two lines over 80 characters long
Two lines of code that were over 80 characters long is fixed
by splitting them across multiple lines.
The lines of code are now easier to comprehend.
Issue found by checkpatch.
Signed-off-by: Arjun Krishna Babu <arjunkrishnababu96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Wed, 30 Sep 2015 16:37:13 +0000 (17:37 +0100)]
staging: comedi: comedi_usb.c: improve function documentation
Expand the descriptions of the functions and document the return values.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Wed, 30 Sep 2015 16:10:57 +0000 (17:10 +0100)]
staging: comedi: comedi_pcmcia.c: improve function documentation
Expand the descriptions of the functions and document the return values.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Wed, 30 Sep 2015 15:43:55 +0000 (16:43 +0100)]
staging: comedi: comedi_pci.c: Fix kernel-doc Return tags
Fix the 'Return' tags in the kernel-doc comments as they currently say
'Returns', which is not recognized by kernel-doc.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rohit kumar [Wed, 30 Sep 2015 05:37:35 +0000 (11:07 +0530)]
staging: ion: Fix error handling in ion_buffer_create
This patch fixes error handling case when buffer->pages allocation
fails. Also, it removes unreachable code of checking ret variable
although it is not updated.
Signed-off-by: Rohit kumar <rohit.kr@samsung.com>
Reviewed-by: Laura Abbott <labbott@redhat.com>
Suggested-by: Pintu Kumar <pintu.k@samsung.com>
Reviewed-by: Pintu Kumar <pintu.k@samsung.com>
Reviewed-by: Gioh Kim <gioh.kim@lge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Sell [Thu, 1 Oct 2015 16:41:59 +0000 (12:41 -0400)]
staging: unisys: visorhid: remove unnecessary include of serio.h
No need for serio.h to be included.
Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Sell [Thu, 1 Oct 2015 16:41:58 +0000 (12:41 -0400)]
staging: unisys: visorhid: correctly map keys with extended scancodes
The most-noticed key that wasn't being mapped correctly was Right-Alt,
which is the AltGr key on many non-US keyboards, used to select many
extended characters.
Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Thu, 1 Oct 2015 15:52:30 +0000 (11:52 -0400)]
staging: unisys: correctly handle return value from queue_delayed_work()
Properly handle the return value from queue_delayed_work() - it's a
bool, not an int, so using a less than comparison isn't appropriate.
This mistake was found by David Binderman <dcb314@hotmail.com>.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Thu, 1 Oct 2015 15:52:29 +0000 (11:52 -0400)]
staging: unisys: get rid of list of devices
We don't need the list of devices, we can loop through the one
provided by the network api and filter on ours.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Thu, 1 Oct 2015 15:52:28 +0000 (11:52 -0400)]
staging: unisys: get rid of devnum pool and dev num
devnum pool and devnum are no longer needed.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Thu, 1 Oct 2015 15:52:27 +0000 (11:52 -0400)]
staging: unisys: remove devdata->name use netdev->name
The net device already has a name, so use that instead.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Thu, 1 Oct 2015 21:27:03 +0000 (02:57 +0530)]
Staging: xgifb: vb_util: Fixed sparse warning of bit truncation due to cast
Fixed the warning generated by sparse that 'cast truncates bits from
constant value' by typecasting unsigned values to u8 as their logical
operation is being performed with and stored in a u8 type variable.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cristina Moraru [Thu, 1 Oct 2015 19:10:52 +0000 (22:10 +0300)]
staging: iio: Fix comment style warning
Move final */ to the next line, in accordance with the suggestion of
checkpatch
Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cristina Moraru [Thu, 1 Oct 2015 18:43:57 +0000 (21:43 +0300)]
staging: dgnc: Fix indentation warning
Fixed 'suspect code indent for conditional statements (8, 24)' Warning
Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Thu, 1 Oct 2015 13:42:16 +0000 (16:42 +0300)]
Staging: octeon: Use preferred kernel type
This patch "uint*_t" type instead of "u*" type was used.
checkpatch.pl issue in octeon driver.
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Wed, 30 Sep 2015 12:58:54 +0000 (18:28 +0530)]
Staging: fbtft: Remove debug messages related to DEBUG_BACKLIGHT
Remove debug messages related to fbtft_par_dbg(DEBUG_BACKLIGHT.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Wed, 30 Sep 2015 12:58:53 +0000 (18:28 +0530)]
Staging: fbtft: Remove debug messages related to DEBUG_WRITE_VMEM
Remove debug messages related to fbtft_par_dbg(DEBUG_WRITE_VMEM.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioana Ciornei [Wed, 30 Sep 2015 19:28:32 +0000 (22:28 +0300)]
staging: wlan-ng: fix block comment indentation
Update indentation of block comments to follow linux coding style
Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 1 Oct 2015 09:37:58 +0000 (15:07 +0530)]
Staging: lustre: obdclass: Declare structure as static.
Declare structure as static since it is not accessed anywhere
apart from this particular file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:42 +0000 (00:12 -0400)]
staging/lustre/ldlm: Make ldlm_add_ast_work_item() static
Now that ldlm_flock code no longer uses it.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:41 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove posix lock (flock) deadlock detection
This is server-side code that cannot work on the client
(vfs would do this check on the local node).
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:40 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_namespace_inactive_list()
Since there are no server namespaces, just replace it with
ldlm_cli_inactive_namespace_list pointer.
Also make ldlm_cli_inactive_namespace_list static as it's only
used in ldlm_resource.c
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:39 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused exported symbols.
This rather large patch prunes all unused EXPORT_SYMBOLS and
marks functions only used locally as static lustre ldlm module.
The only two remaining nonstatic functions that should be static
now are:
ldlm_cancel_lru_local
ldlm_resource_putref_locked
But some bigger code shuffling around is needed to achieve that, so
it's left for a future patch.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:38 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove server side code from pool support.
Server-side scanning is not really used in the client code,
so it's ok to drop it.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:37 +0000 (00:12 -0400)]
staging/lustre: Remove ns_is_server()
Since the code we have is Lustre-client only, this function
always returns 0, so drop it and amend all the callsites to
drop dead code.
One of the places also sets LDLM_FL_NS_SRV to indicate a lock
is in a server namespace. This too cannot happen in this code,
so drop all such checks as well.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:36 +0000 (00:12 -0400)]
staging/lustre: Remove ns_is_client()
Since staging tree code is just the client, ns_is_client is always
true, so change all callers as such and drop all the
dead code for when it's false.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:35 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_blocking_ast/_nocheck()
All users are gone, and they were used on the server anyway.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:34 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_resource_insert_lock_after()
It was only used on the server.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:33 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_reprocess_all*()
They are only used on the server.
Also remove helper functions and cleanup callsites.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:32 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove intent policies handler.
This includes ldlm_register_intent(), ns_policy field in the namespace
and all of it's users, as this could only happen on the server.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:31 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_refresh/del_waiting_lock()
Nothing adds locks into waiting list on the client, so no
point in retaining those.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:30 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_pool_set_slv()
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:29 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_pool_get_clv()
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:28 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_namespace_free()
It was directly used only on the server. Client side part
was split into smaller chunks to avoid deadlocks.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:27 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_lock_fail_match()
It's not used anywhere.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:26 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_glimpse_ast()
Only used on the server.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:25 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_errno2error()
This particular incarnation is only used on the server.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:24 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_enqueue_pack()
Not used anywhere
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:23 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_init/fini_flock_export
And all supporting export infrastructure. There's no use for it
all on client.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:22 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_cli_enqueue_local()
This is only used on the server.
Also while we are at it, remove unused prototypes for
ldlm_server_ast and ldlm_handle_enqueue0() that are not
defined anywhere
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:21 +0000 (00:12 -0400)]
staging/lustre/ldlm: Get rid of lr_converting queue
Now that we removed all the lock conversion functions,
also get rid of the converson queue since nothing could ever
get there anyway.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:20 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unimplemented lock conversion traces.
Lock conversion is not really implemented, so let's stop
pretending here.
This removes ldlm_lock_convert, ldlm_cli_lock_convert
and ldlm_lock_downgrade.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:19 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_init/destroy_export()
These functions are used on the server-only, so get rid of them.
Also get rid of ldlm export hash operations and the struct.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:18 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_cancel_locks_for_exports()
This is only used on the server in case a client gets disconnected.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:17 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused interval tree bits
On client side interval-tree code operations are pretty basic,
so get rid of the code that is only used on the server to figure
out how much to extend the locks and such.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:16 +0000 (00:12 -0400)]
staging/lustre/lov: Remove unused lov_lsm_decref()
Also lov_lsm_addref is only used in the file it is defined,
so make it static
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:15 +0000 (00:12 -0400)]
staging/lustre/lov: Remove unused lov_dump_lmm/pool()
These generic switch functions appear to be unused as all the
individual ones are called directly.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:14 +0000 (00:12 -0400)]
staging/lustre/llite: Remove unused ll_rmdir_entry()
The ioctl for this function was removed, but the function was
forgotten, so kill it now.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:13 +0000 (00:12 -0400)]
staging/lustre: Remove ununused ll_ra_read_get()
Also ll_ra_read_get_locked that was only used by it.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:12 +0000 (00:12 -0400)]
staging/lustre: KEY_DEFAULT/MAX_COOKIESIZE key is unused, remove them
Also remove the lmv and mdc infrastructure to query these keys.
In fact this whole "unlink cookies" thing becomes irrelevant
with newer servers, but since we still retain 2.[123] servers
commpatibility, we cannot completely remove all traces of it yet.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:11 +0000 (00:12 -0400)]
staging/lustre/llite: Remove unused ll_get_default/max_cookiesize()
This was used for a function that's no longer important, but
is no longer used anywhere.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ronit Halder [Wed, 30 Sep 2015 06:09:45 +0000 (11:39 +0530)]
staging: dgap: fix memory leak in dgap_parsefile()
In dgap_parsefile() char pointers are set with kstrdup()
without checking that some string is allocated to that
char pointer before. This patch frees the memory if already allocated
and then set the poniter with kstrdup().
Signed-off-by: Ronit halder <ronit.crj@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:59 +0000 (08:24 +0300)]
staging: sm750fb: remove unused enable{ZVPort,SSP,PWM} functions
The functions that enable/disable power for some sub-devices are not
used and therefore they can be removed.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:58 +0000 (08:24 +0300)]
staging: sm750fb: staticize getPowerMode function
The getPowerMode function is not used outside ddk750_power, make it
static.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:57 +0000 (08:24 +0300)]
staging: sm750fb: remove unused macros
Several macros defined in sm750.h and sm750_help.h are not used and
therefore they can be removed
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:56 +0000 (08:24 +0300)]
staging: sm750fb: remove unused ddk750_initDVIDisp function
The ddk750_initDVIDisp function is never used and therefore it can be
removed.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:55 +0000 (08:24 +0300)]
staging: sm750fb: remove unused calcPllValue2 function
The calcPllValue2 function is never called and therefore it can be
removed.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:54 +0000 (08:24 +0300)]
staging: sm750fb: staticize local functions in ddk750_chip
Several functions in ddk750_chip are not used elsewhere, let's make them
static.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Wed, 30 Sep 2015 08:52:14 +0000 (17:52 +0900)]
staging: wilc1000: fix build error for openrisc-allmodconfig
The kbuild test robot reports the following build error for
openrisc-allmodconfig.
>> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit
>> declaration of function 'memset'
The error occurs due to missing a standard header file as
<linux/string.h> so that three .c files are included it.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 30 Sep 2015 02:59:24 +0000 (11:59 +0900)]
staging: wilc1000: remove define CONNECT_DIRECT
The driver use CONNECT_DIRECT define as always. No need to provide as feature.
This patch removes ifdef/ifndef CONNECT_DIRECT line and it's related codes
inside ifndef CONNECT_DIRECT.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 30 Sep 2015 02:59:23 +0000 (11:59 +0900)]
staging: wilc1000: remove define WILC_PARSE_SCAN_IN_HOST
The define WILC_PARSE_SCAN_IN_HOST is always used in the driver, so just
delete ifdef WILC_PARSE_SCAN_IN_HOST line, ifndef WILC_PARSE_SCAN_IN_HOST
line and it's related codes. Finally, remove define in Makefile.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 29 Sep 2015 23:15:42 +0000 (08:15 +0900)]
staging: wilc1000: delete wilc_oswrapper.h
This patch deletes wilc_oswrapper.h that has nothing inside.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 29 Sep 2015 23:15:41 +0000 (08:15 +0900)]
staging: wilc1000: remove wilc_platform include file
This patch removes wilc_platform.h include file in wilc_oswrapper.h
wilc_platform.h have several standard header files so that some header
files should be included to avoid compilation errors.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Tue, 29 Sep 2015 19:15:49 +0000 (12:15 -0700)]
wilc1000 : Use BIT() macro where possible
Replace (1 << x) by BIT(x) as recommended by
checkpatch.pl
Signed-off-by: Anish Bhatt <anish@gatech.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Tue, 29 Sep 2015 19:15:48 +0000 (12:15 -0700)]
wilc1000 : Remove leftover comment delimiters
Remove leftover comment delimiters that were only partially removed
in a previous cleanup.
Fixes :
c3ca63728ad8 ("staging: wilc1000: remove useless comment")
Signed-off-by: Anish Bhatt <anish@gatech.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cristina Moraru [Tue, 29 Sep 2015 21:47:25 +0000 (14:47 -0700)]
staging:emxx_udc: Fixed comparison style warnings
Fixed 'Comparisons should place the constant on the right side of the
test' Warnings
Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 29 Sep 2015 19:21:28 +0000 (00:51 +0530)]
Staging: media: lirc: Use USB API functions rather than constants
Introduce use of function usb_endpoint_is_int_in() and
usb_endpoint_is_int_out(). Also remove the variables
ep_dir and ep_type as they are not used anymore.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Wed, 30 Sep 2015 01:46:43 +0000 (03:46 +0200)]
staging: iio: iio_dummy_evgen: handle_simple_irq() build fix
handle_simple_irq() has dropped the first parameter, so fix it up in the
iio_dummy_evgen.c driver to prevent the build from breaking.
Cc: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>