Matthias Schmidt [Fri, 15 Jan 2021 10:08:04 +0000 (11:08 +0100)]
Use monospace font for template listener code field in devtools
Matthias Schmidt [Fri, 15 Jan 2021 10:04:33 +0000 (11:04 +0100)]
Add missing calls to parent constructors in subclasses of `TextFormField`
Matthias Schmidt [Fri, 15 Jan 2021 08:54:04 +0000 (09:54 +0100)]
Merge branch '5.3'
Matthias Schmidt [Fri, 15 Jan 2021 08:53:55 +0000 (09:53 +0100)]
Merge branch '5.2' into 5.3
Matthias Schmidt [Fri, 15 Jan 2021 08:53:37 +0000 (09:53 +0100)]
Fix displaying error messages for devtool projects' instructions
Matthias Schmidt [Fri, 15 Jan 2021 08:50:00 +0000 (09:50 +0100)]
Remove incorrect devtools form field description
Matthias Schmidt [Fri, 15 Jan 2021 08:37:54 +0000 (09:37 +0100)]
Improve variable name
Matthias Schmidt [Fri, 15 Jan 2021 08:35:36 +0000 (09:35 +0100)]
Merge pull request #3871 from WoltLab/devtools_project_typescript
Convert devtools project JavaScript code to TypeScript
Matthias Schmidt [Fri, 15 Jan 2021 08:33:00 +0000 (09:33 +0100)]
Fix required packages' `file` value when editing devtools project
Alexander Ebert [Thu, 14 Jan 2021 18:36:21 +0000 (19:36 +0100)]
Missing signature for `$.ui.messageTabMenu`
Tim Düsterhus [Wed, 13 Jan 2021 10:30:15 +0000 (11:30 +0100)]
Do not take X locks in read-only methods of the MFA Setup class
This was a fun one. Apparently even a query locking exactly a single row by
leveraging an UNIQUE KEY outside of a transaction can deadlock with another
transaction.
Sending two requests to regenerate MFA backup codes at the same time caused the
following to happen within the database:
T1: Within a transaction locks the Setup by using Setup::lock(), putting an X
onto the PRIMARY KEY.
T2: Outside of a transaction reads a Setup using Setup::find(), hitting exactly
a single entry within the `userID` UNIQUE KEY (i.e. a specific
`(userID, objectTypeID)` tuple).
-> This puts an X onto the `userID` UNIQUE KEY.
-> This wants to also put an X onto the corresponding PRIMARY KEY.
-> The PRIMARY KEY is already locked by T1.
-> This query (and thus this transaction) waits within this specific query
for the lock to be granted.
T1: Within the transaction calls Setup::find() with the same parameters as T2.
-> This needs to put the X onto the same row in the `userID` UNIQUE KEY.
-> This row is locked by T2.
-> This transaction needs to wait for that lock to be granted.
Now T1 needs to wait for T2 which already waits for T1 and we're experiencing a
deadlock.
Fix this issue by not taking an X within Setup::find() (i.e. removing the `FOR
UPDATE`). I've verified that nothing calls Setup::find() within a transaction
(without locking the Setup by a different means). Thus this change does not
result in a difference with regard to lock safety. Everything that needs to
modify a Setup already calls Setup::lock() which locks the PRIMARY KEY only.
Fixes #3874
Tim Düsterhus [Wed, 13 Jan 2021 08:20:19 +0000 (09:20 +0100)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Wed, 13 Jan 2021 08:19:25 +0000 (09:19 +0100)]
Merge branch '5.3'
- Dropped update_com.woltlab.wcf_5.3.3_style.php
Tim Düsterhus [Wed, 13 Jan 2021 08:13:00 +0000 (09:13 +0100)]
Merge pull request #3865 from WoltLab/fix-style-preview
Fix the style preview images
Tim Düsterhus [Wed, 13 Jan 2021 08:12:57 +0000 (09:12 +0100)]
Merge pull request #3872 from WoltLab/codemirror-media
Convert `Acp/Ui/CodeMirror/Media` to TypeScript
Alexander Ebert [Tue, 12 Jan 2021 11:53:31 +0000 (12:53 +0100)]
Unified the exception type for GD and Imagick
Tim Düsterhus [Tue, 12 Jan 2021 11:03:00 +0000 (12:03 +0100)]
Use an `enum` for the InsertType
Tim Düsterhus [Tue, 12 Jan 2021 10:59:20 +0000 (11:59 +0100)]
Convert `Acp/Ui/CodeMirror/Media` to TypeScript
Matthias Schmidt [Tue, 12 Jan 2021 10:25:52 +0000 (11:25 +0100)]
Apply suggestions from code review
Matthias Schmidt [Tue, 12 Jan 2021 09:59:37 +0000 (10:59 +0100)]
Convert `Acp/Form/Builder/Field/Devtools/Project/Instructions` to TypeScript
Matthias Schmidt [Tue, 12 Jan 2021 09:58:15 +0000 (10:58 +0100)]
Convert `Acp/Form/Builder/Field/Devtools/Project/RequiredPackages` to TypeScript
Matthias Schmidt [Tue, 12 Jan 2021 09:57:50 +0000 (10:57 +0100)]
Convert `Acp/Form/Builder/Field/Devtools/Project/OptionalPackages` to TypeScript
Matthias Schmidt [Tue, 12 Jan 2021 09:57:26 +0000 (10:57 +0100)]
Convert `Acp/Form/Builder/Field/Devtools/Project/ExcludedPackages` to TypeScript
Matthias Schmidt [Tue, 12 Jan 2021 09:57:15 +0000 (10:57 +0100)]
Convert `Acp/Form/Builder/Field/Devtools/Project/AbstractPackageList` to TypeScript
Matthias Schmidt [Tue, 12 Jan 2021 09:56:50 +0000 (10:56 +0100)]
Add devtools form builder-related TypeScript interfaces
Matthias Schmidt [Tue, 12 Jan 2021 09:35:40 +0000 (10:35 +0100)]
Use DomUtil for element visibility in form builder modules
Alexander Ebert [Mon, 11 Jan 2021 19:10:50 +0000 (20:10 +0100)]
Convert `WCF.Message.Quote.Handler` to TypeScript (#3860)
* Convert `WCF.Message.Quote.Handler` to TypeScript
* Export the class separately
Alexander Ebert [Mon, 11 Jan 2021 17:33:56 +0000 (18:33 +0100)]
Image adapters now support saving to GIF/JPG/PNG/WebP (#3869)
* Image adapters now support saving to GIF/JPG/PNG/WebP
* Adjusted the usage of exception
* Missing remark on the version support
Tim Düsterhus [Mon, 11 Jan 2021 15:59:48 +0000 (16:59 +0100)]
Merge branch '5.3'
Tim Düsterhus [Mon, 11 Jan 2021 15:59:19 +0000 (16:59 +0100)]
Fix check for deleted notifications in NotificationEmailDeliveryBackgroundJob
Alexander Ebert [Mon, 11 Jan 2021 15:02:46 +0000 (16:02 +0100)]
Support for WebP images (#3861)
* Support for WebP images
* Inconsistent quote style
Matthias Schmidt [Mon, 11 Jan 2021 13:22:31 +0000 (14:22 +0100)]
Merge pull request #3849 from WoltLab/media_typescript
Convert media-related JavaScript to TypeScript
joshuaruesweg [Mon, 11 Jan 2021 12:54:23 +0000 (13:54 +0100)]
Fix multiple queries for user online list stats
Joshua Rüsweg [Mon, 11 Jan 2021 12:36:54 +0000 (13:36 +0100)]
Merge pull request #3855 from WoltLab/rank-image-upload
Allow upload of rank images via admin panel
joshuaruesweg [Thu, 7 Jan 2021 16:19:32 +0000 (17:19 +0100)]
Add rank image upload migration script
joshuaruesweg [Thu, 7 Jan 2021 14:53:15 +0000 (15:53 +0100)]
Add user rank image upload
Tim Düsterhus [Mon, 11 Jan 2021 11:40:24 +0000 (12:40 +0100)]
Merge branch '5.3'
Tim Düsterhus [Mon, 11 Jan 2021 11:33:09 +0000 (12:33 +0100)]
Merge pull request #3867 from WoltLab/smtp-auth-fail
Fail SMTP auth if credentials are configured but all mechanisms fail
Tim Düsterhus [Mon, 11 Jan 2021 11:18:00 +0000 (12:18 +0100)]
Properly detect EOF in SmtpEmailTransport::read()
Tim Düsterhus [Mon, 11 Jan 2021 10:51:23 +0000 (11:51 +0100)]
Disconnect SMTP session for all types of Exception during connect / auth
Tim Düsterhus [Mon, 11 Jan 2021 10:49:20 +0000 (11:49 +0100)]
Fail SMTP auth if credentials are configured but all mechanisms fail
Tim Düsterhus [Mon, 11 Jan 2021 10:57:31 +0000 (11:57 +0100)]
Merge pull request #3853 from WoltLab/oauth-refactor
Refactor OAuth 2 login
Tim Düsterhus [Mon, 11 Jan 2021 08:44:05 +0000 (09:44 +0100)]
Fix the style preview images
The update 5.3.1 -> 5.3.2 detached all the style preview images in the
database, while leaving the actual image files in the file system. This new
update script *should* fix this situation again, by scanning the asset folder
and reattaching the newest image.
Tim Düsterhus [Fri, 8 Jan 2021 15:51:44 +0000 (16:51 +0100)]
Check for a logged in user in ReauthenticationForm
needsReauthentication() may only be called for logged in users.
Tim Düsterhus [Fri, 8 Jan 2021 15:03:23 +0000 (16:03 +0100)]
Remove MultifactorAuthenticationAbort from ACP guest controller whitelist
Matthias Schmidt [Fri, 8 Jan 2021 10:58:09 +0000 (11:58 +0100)]
Fix eslint issue
Matthias Schmidt [Fri, 8 Jan 2021 10:55:13 +0000 (11:55 +0100)]
Remove obsolete code
Only `insertType = "separate"` was ever supported.
Matthias Schmidt [Fri, 8 Jan 2021 10:53:23 +0000 (11:53 +0100)]
Apply suggestions from code review
Tim Düsterhus [Fri, 8 Jan 2021 09:36:15 +0000 (10:36 +0100)]
Merge pull request #3854 from WoltLab/typescript-no-implicit-any
Improve TypeScript safety
Tim Düsterhus [Thu, 7 Jan 2021 16:13:43 +0000 (17:13 +0100)]
Simplify formatter selection in Date/Picker.ts
Tim Düsterhus [Thu, 7 Jan 2021 14:32:27 +0000 (15:32 +0100)]
Fix typing in TabMenu.ts
Tim Düsterhus [Thu, 7 Jan 2021 14:26:07 +0000 (15:26 +0100)]
Improve type safety of Plural.ts
Tim Düsterhus [Thu, 7 Jan 2021 13:57:53 +0000 (14:57 +0100)]
Various TypeScript fixes detected using noImplicitAny
Matthias Schmidt [Fri, 8 Jan 2021 09:26:58 +0000 (10:26 +0100)]
Apply suggestions from code review
Tim Düsterhus [Fri, 8 Jan 2021 09:08:26 +0000 (10:08 +0100)]
Merge pull request #3857 from WoltLab/commit-message-check
Add pull_request workflow
Tim Düsterhus [Fri, 8 Jan 2021 08:55:18 +0000 (09:55 +0100)]
Add pull_request workflow
Tim Düsterhus [Thu, 7 Jan 2021 15:29:14 +0000 (16:29 +0100)]
Add proper error handling to OAuth2 client
Tim Düsterhus [Thu, 7 Jan 2021 15:09:10 +0000 (16:09 +0100)]
Specify timeout for OAuth 2 requests
Tim Düsterhus [Thu, 7 Jan 2021 13:07:17 +0000 (14:07 +0100)]
Send 403 to spiders accessing the social login
Tim Düsterhus [Thu, 7 Jan 2021 11:43:24 +0000 (12:43 +0100)]
Implement the OAuth 2 providers using AbstractOauth2Action.
Tim Düsterhus [Thu, 7 Jan 2021 11:37:54 +0000 (12:37 +0100)]
Add AbstractOauth2Action
Tim Düsterhus [Thu, 7 Jan 2021 15:07:24 +0000 (16:07 +0100)]
Configure a 60 second timeout for Guzzle by default
This is acting as a safety net, because the default timeout is infinite.
joshuaruesweg [Sat, 19 Dec 2020 13:37:26 +0000 (14:37 +0100)]
Add dir for rank images
Tim Düsterhus [Thu, 7 Jan 2021 08:20:36 +0000 (09:20 +0100)]
Merge pull request #3813 from WoltLab/session-cookie
Session Cookie Updates
joshuaruesweg [Wed, 6 Jan 2021 15:40:26 +0000 (16:40 +0100)]
Merge branch '5.3'
joshuaruesweg [Wed, 6 Jan 2021 15:40:00 +0000 (16:40 +0100)]
Merge branch '5.2' into 5.3
joshuaruesweg [Wed, 6 Jan 2021 15:39:26 +0000 (16:39 +0100)]
Merge branch '3.1' into 5.2
Joshua Rüsweg [Wed, 6 Jan 2021 15:38:31 +0000 (16:38 +0100)]
Merge pull request #3844 from WoltLab/fix-failing-cronjobs
Fix failing cronjobs
Alexander Ebert [Wed, 6 Jan 2021 14:59:23 +0000 (15:59 +0100)]
Incorrect year
Old habits die hard…
Tim Düsterhus [Wed, 6 Jan 2021 14:58:41 +0000 (15:58 +0100)]
Merge branch '5.3'
Alexander Ebert [Wed, 6 Jan 2021 14:57:01 +0000 (15:57 +0100)]
Release 5.3.2
Joshua Rüsweg [Wed, 6 Jan 2021 14:55:55 +0000 (15:55 +0100)]
Merge pull request #3814 from WoltLab/delete-content-multiple-users
Delete content from multiple users simultaneously
Tim Düsterhus [Wed, 6 Jan 2021 14:52:47 +0000 (15:52 +0100)]
Merge pull request #3852 from WoltLab/3rdParty-remove-profileFields
Stop filling in the user's profile on social registration
WoltLab [Wed, 6 Jan 2021 14:44:19 +0000 (14:44 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Wed, 23 Dec 2020 13:17:49 +0000 (14:17 +0100)]
Stop filling in the user's profile on social registration
The behavior of this was very inconsistent across providers, required a custom
implementation for each of those and over the years less and less data was
provided (most notably Facebook drastically limited the available fields).
The benefit of filling in the gender and avatar here and there is almost nil,
nothing of real value is lost when removing this and it keeps the code simpler.
joshuaruesweg [Wed, 6 Jan 2021 14:28:14 +0000 (15:28 +0100)]
Simplify retrieving objectTypes for delete content types
joshuaruesweg [Fri, 1 Jan 2021 11:59:46 +0000 (12:59 +0100)]
Simplify delete logic by using a flat array
joshuaruesweg [Tue, 22 Dec 2020 19:37:57 +0000 (20:37 +0100)]
Rename class variable `$user` to `$users`
joshuaruesweg [Wed, 16 Dec 2020 15:26:54 +0000 (16:26 +0100)]
Add clipboard action to delete user content
joshuaruesweg [Wed, 16 Dec 2020 15:25:59 +0000 (16:25 +0100)]
Make `UserAction::prepareRemoveContent()` work with multiple users
joshuaruesweg [Sat, 28 Nov 2020 10:04:28 +0000 (11:04 +0100)]
Make UserContentRemoveWorker work with multiple userIDs
Tim Düsterhus [Wed, 6 Jan 2021 13:43:11 +0000 (14:43 +0100)]
Merge pull request #3851 from WoltLab/scssphp
Update to scssphp/scssphp 1.4
Tim Düsterhus [Wed, 6 Jan 2021 13:33:20 +0000 (14:33 +0100)]
Update use of scssphp
Setting output formatters is deprecated as of scssphp/scssphp 1.4.
Tim Düsterhus [Wed, 6 Jan 2021 13:28:58 +0000 (14:28 +0100)]
Update to scssphp/scssphp 1.4
Tim Düsterhus [Wed, 6 Jan 2021 13:27:02 +0000 (14:27 +0100)]
Mark lib/system/api/** as linguist-vendored
Tim Düsterhus [Wed, 6 Jan 2021 13:13:34 +0000 (14:13 +0100)]
Merge pull request #3850 from WoltLab/intl
Recommend intl during WCFSetup
Tim Düsterhus [Wed, 6 Jan 2021 12:46:06 +0000 (13:46 +0100)]
Recommend intl during WCFSetup
Resolves #3811
Tim Düsterhus [Wed, 6 Jan 2021 10:59:54 +0000 (11:59 +0100)]
Update update_com.woltlab.wcf_5.4_session_1_cookies for new cookie format
Tim Düsterhus [Wed, 16 Dec 2020 11:45:30 +0000 (12:45 +0100)]
Fix username suggestion in ACP's LoginForm
Resolves #3725
Tim Düsterhus [Wed, 16 Dec 2020 11:42:20 +0000 (12:42 +0100)]
Refresh the session cookie only once it aged a bit
Resolves #3611
Tim Düsterhus [Wed, 16 Dec 2020 11:41:05 +0000 (12:41 +0100)]
Encode additional data into the session cookie
The cookie now stores:
- sessionID
- userID
- an compact representation of the last update that repeats every 64 days.
Tim Düsterhus [Wed, 6 Jan 2021 11:19:35 +0000 (12:19 +0100)]
Merge branch '5.3'
Tim Düsterhus [Wed, 6 Jan 2021 11:19:16 +0000 (12:19 +0100)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Wed, 6 Jan 2021 11:18:29 +0000 (12:18 +0100)]
Fix VarbinaryDatabaseTableColumn
> Call to undefined method wcf\system\database\table\column\VarbinaryDatabaseTableColumn::traitGetLength()
see
4a65b1e27cc85fc9fb9bbcdf6a6d7a5f9cc76187
Tim Düsterhus [Wed, 16 Dec 2020 11:43:12 +0000 (12:43 +0100)]
Remove obsolete import from LoginForm
Matthias Schmidt [Tue, 5 Jan 2021 17:43:55 +0000 (18:43 +0100)]
Add media-related TypeScript interfaces
Matthias Schmidt [Tue, 5 Jan 2021 17:43:41 +0000 (18:43 +0100)]
Convert `Controller/Media/List` to TypeScript
Matthias Schmidt [Tue, 5 Jan 2021 17:43:33 +0000 (18:43 +0100)]
Convert `Media/Manager/Select` to TypeScript
Matthias Schmidt [Tue, 5 Jan 2021 17:43:24 +0000 (18:43 +0100)]
Convert `Media/Manager/Search` to TypeScript
Matthias Schmidt [Tue, 5 Jan 2021 17:43:16 +0000 (18:43 +0100)]
Convert `Media/Manager/Editor` to TypeScript