Alexander Ebert [Tue, 18 Jun 2019 10:28:02 +0000 (12:28 +0200)]
Merge pull request #2938 from WoltLab/selection_tree_support
Add abstract object tree node used for selection form fields
Jens Hausdorf [Mon, 17 Jun 2019 16:24:49 +0000 (18:24 +0200)]
Fix now invalid usages of CryptoException (#2908)
* Fix now invalid usages of CryptoException
The \random_{bytes,int} functions are now called directly instead through
wcf\util\CryptoUtil, which means that the exceptions may not be caught
with CryptoException anymore. Instead, they must be caught with the
generic \Throwable interface.
This commit also fixes usages of those functions to prevent malicious code
to overwrite these critical functions in userland code.
* Make sure to generate a truly random ID
by disallowing user modification.
Adding the `\` in front of the function call makes sure PHP does not use
any overwritten (user-land) function, potentially destroying our efforts of
having a CSRPNG ID
* Remove no longer necessary try-catch block.
Alexander Ebert [Mon, 17 Jun 2019 16:22:07 +0000 (18:22 +0200)]
Merge branch 'master' into next
Alexander Ebert [Mon, 17 Jun 2019 16:18:51 +0000 (18:18 +0200)]
Merge branch '3.0'
Alexander Ebert [Mon, 17 Jun 2019 16:18:13 +0000 (18:18 +0200)]
Merge pull request #2931 from WoltLab/30-reaction-backport
Backport reaction related interfaces
Alexander Ebert [Mon, 17 Jun 2019 16:15:21 +0000 (18:15 +0200)]
Merge pull request #2933 from WoltLab/queue-failure-callback
Add on(Final)?Failure callbacks to AbstractBackgroundJob
Alexander Ebert [Mon, 17 Jun 2019 16:14:52 +0000 (18:14 +0200)]
Merge pull request #2941 from WoltLab/database-options
Support custom database driver options
Marcel Werk [Tue, 11 Jun 2019 14:59:22 +0000 (16:59 +0200)]
Fixed required PHP version
Marcel Werk [Mon, 10 Jun 2019 17:41:03 +0000 (19:41 +0200)]
Overhauled test.php
Tim Düsterhus [Tue, 4 Jun 2019 20:25:14 +0000 (22:25 +0200)]
Support custom database driver options
Matthias Schmidt [Sat, 8 Jun 2019 18:04:02 +0000 (20:04 +0200)]
Fix parameter documentation
See #2852
Alexander Ebert [Sat, 8 Jun 2019 17:42:50 +0000 (19:42 +0200)]
Merge pull request #2914 from SoftCreatR/patch-4
Fix password comparison
Matthias Schmidt [Sat, 8 Jun 2019 13:36:14 +0000 (15:36 +0200)]
Add html message support for `WCF.Table.EmptyTableHandler`
Matthias Schmidt [Thu, 6 Jun 2019 17:13:32 +0000 (19:13 +0200)]
Automatically mark published new articles written in ACP as read
Matthias Schmidt [Thu, 6 Jun 2019 17:09:05 +0000 (19:09 +0200)]
Redirect user to published article created in frontend
See #2681
Tim Düsterhus [Mon, 3 Jun 2019 19:32:46 +0000 (21:32 +0200)]
Merge branch 'master' into next
Tim Düsterhus [Mon, 3 Jun 2019 19:32:23 +0000 (21:32 +0200)]
Merge branch '3.0'
Tim Düsterhus [Mon, 3 Jun 2019 19:31:24 +0000 (21:31 +0200)]
Rename Piwik to Matomo in Footer Code description
Tim Düsterhus [Mon, 3 Jun 2019 19:30:14 +0000 (21:30 +0200)]
Fix typo in de.xml
Matthias Schmidt [Mon, 3 Jun 2019 17:35:56 +0000 (19:35 +0200)]
Merge branch 'master' into next
Matthias Schmidt [Mon, 3 Jun 2019 17:35:28 +0000 (19:35 +0200)]
Fix type of `$user` property after assigning trophy to user
Joshua Rüsweg [Mon, 3 Jun 2019 15:19:52 +0000 (17:19 +0200)]
Fix typo
Marcel Werk [Mon, 3 Jun 2019 14:48:55 +0000 (16:48 +0200)]
unnecessary complicated code simplified
Marcel Werk [Mon, 3 Jun 2019 13:51:49 +0000 (15:51 +0200)]
Merge branch '3.0'
Marcel Werk [Mon, 3 Jun 2019 13:51:28 +0000 (15:51 +0200)]
wcf1_user.authData was missing in GDPR export
CLoses #2906
Marcel Werk [Mon, 3 Jun 2019 13:35:21 +0000 (15:35 +0200)]
ArticleAddForm doesn't validate imageIDs (teaser)
See #2935
Marcel Werk [Mon, 3 Jun 2019 13:34:40 +0000 (15:34 +0200)]
Merge branch '3.0'
Marcel Werk [Mon, 3 Jun 2019 13:33:57 +0000 (15:33 +0200)]
ArticleAddForm doesn't validate imageIDs
Closes #2935
Tim Düsterhus [Mon, 3 Jun 2019 12:42:52 +0000 (14:42 +0200)]
Fix typos in en.xml
Marcel Werk [Mon, 3 Jun 2019 10:46:02 +0000 (12:46 +0200)]
Always display the second level categories for articles
Closes #2886
Matthias Schmidt [Sun, 2 Jun 2019 14:31:41 +0000 (16:31 +0200)]
Fix phrasing of devools-related error language item
See #2772
Matthias Schmidt [Sun, 2 Jun 2019 07:31:02 +0000 (09:31 +0200)]
Add abstract object tree node used for selection form fields
Matthias Schmidt [Sun, 2 Jun 2019 07:20:08 +0000 (09:20 +0200)]
Add reCAPTCHA key fields to first setup form
See #2797
Matthias Schmidt [Sun, 2 Jun 2019 06:58:14 +0000 (08:58 +0200)]
Fix wrong parameter type issue in `CategoryNode::isVisibleInNestedList()`
See #2886
Matthias Schmidt [Sat, 1 Jun 2019 12:32:36 +0000 (14:32 +0200)]
Add missing cover photo-related language item
See #2876
Matthias Schmidt [Sat, 1 Jun 2019 12:27:01 +0000 (14:27 +0200)]
Merge branch 'master' into next
Matthias Schmidt [Sat, 1 Jun 2019 12:25:41 +0000 (14:25 +0200)]
Remove unused, non-existent language items from JS code
Joshua Rüsweg [Thu, 30 May 2019 19:34:00 +0000 (21:34 +0200)]
Merge branch 'master' into next
Joshua Rüsweg [Thu, 30 May 2019 19:33:13 +0000 (21:33 +0200)]
Merge branch '3.0'
Joshua Rüsweg [Thu, 30 May 2019 19:31:31 +0000 (21:31 +0200)]
Encode JSON variables in AMP article page
Matthias Schmidt [Thu, 30 May 2019 12:35:31 +0000 (14:35 +0200)]
Fix typo in English StopForumSpam-related language item
See #2692
Matthias Schmidt [Mon, 27 May 2019 17:44:42 +0000 (19:44 +0200)]
Unify modification log names in German (frontend/backend)
See #2597
Alexander Ebert [Mon, 27 May 2019 14:23:40 +0000 (16:23 +0200)]
Merge pull request #2921 from WoltLab/exception-request-id
Log Request-ID header in Exceptions
Joshua Rüsweg [Mon, 27 May 2019 11:38:05 +0000 (13:38 +0200)]
Fix reactions for non unique containers
Sometimes it is necessary to reload object containers (e.g. if something is sorted via JavaScript and the elements have to be reloaded in the background). This was not possible with the implementation, each object could exist only once in the DOM.
See #2508
Joshua Rüsweg [Sun, 26 May 2019 18:30:58 +0000 (20:30 +0200)]
Fix reaction list buttons in user profile
See #2508
Matthias Schmidt [Sun, 26 May 2019 14:59:07 +0000 (16:59 +0200)]
Fix width issue with button to add new project instructions
In German, the button label is too wide for the previous column width.
See 2772
Matthias Schmidt [Sun, 26 May 2019 14:55:50 +0000 (16:55 +0200)]
Fix typos in German language items
Tim Düsterhus [Fri, 24 May 2019 15:26:24 +0000 (17:26 +0200)]
Merge branch 'master' into next
Tim Düsterhus [Fri, 24 May 2019 15:26:04 +0000 (17:26 +0200)]
Merge branch '3.0'
Peter Lohse [Thu, 9 May 2019 06:21:45 +0000 (08:21 +0200)]
Fix submitButton selector in Ui/Message/Reply
Closes #2927
Joshua Rüsweg [Fri, 24 May 2019 14:06:01 +0000 (16:06 +0200)]
Fix reaction sorting function
See #2508
Joshua Rüsweg [Fri, 24 May 2019 13:59:24 +0000 (15:59 +0200)]
Optimize javascript code
See #2508
Joshua Rüsweg [Fri, 24 May 2019 13:03:42 +0000 (15:03 +0200)]
Merge pull request #2937 from WoltLab/next-reaction-improvement
Next reaction improvement
Joshua Rüsweg [Fri, 24 May 2019 12:44:05 +0000 (14:44 +0200)]
Add single reaction type modus
See #2508
Joshua Rüsweg [Fri, 24 May 2019 09:04:36 +0000 (11:04 +0200)]
Merge pull request #2936 from derpierre65/next
Show DatePicker clear button on setDate
derpierre65 [Wed, 22 May 2019 11:48:37 +0000 (13:48 +0200)]
Remove unused variables
derpierre65 [Wed, 22 May 2019 11:45:01 +0000 (13:45 +0200)]
Remove code duplicates
derpierre65 [Wed, 22 May 2019 10:48:37 +0000 (12:48 +0200)]
Show DatePicker clear button on setDate
Tim Düsterhus [Mon, 20 May 2019 10:30:14 +0000 (12:30 +0200)]
Fix typo in de.xml
Joshua Rüsweg [Sun, 19 May 2019 17:58:14 +0000 (19:58 +0200)]
Fix typo
See #2716
Joshua Rüsweg [Sun, 19 May 2019 17:43:45 +0000 (19:43 +0200)]
Fix typo
See #2716
Matthias Schmidt [Sun, 19 May 2019 12:59:26 +0000 (14:59 +0200)]
Use package name instead of identifier on modification log list page
See #2597
Matthias Schmidt [Sun, 19 May 2019 12:29:54 +0000 (14:29 +0200)]
Improve wording of SFS-related language item
See #2692
Joshua Rüsweg [Sun, 19 May 2019 08:48:28 +0000 (10:48 +0200)]
Fixes overlapping dialog container
See #2716
Matthias Schmidt [Sun, 19 May 2019 07:52:20 +0000 (09:52 +0200)]
Fix name of JavaScript module
See #2716
Joshua Rüsweg [Wed, 15 May 2019 15:01:19 +0000 (17:01 +0200)]
Backport TReactionUserNotificationEvent to version 3.0
This backport ensures the compatibility for version 3.0 (and above) and version 5.2. With this commit, plugins can fully support the reaction system and the like system, previously this was only possible to a limited extent.
See #2508
Tim Düsterhus [Wed, 15 May 2019 17:12:26 +0000 (19:12 +0200)]
Add on(Final)?Failure callbacks to AbstractBackgroundJob
Tim Düsterhus [Wed, 15 May 2019 16:30:15 +0000 (18:30 +0200)]
Merge branch 'master' into next
Tim Düsterhus [Wed, 15 May 2019 16:28:48 +0000 (18:28 +0200)]
Merge branch '3.0'
Tim Düsterhus [Wed, 15 May 2019 16:27:26 +0000 (18:27 +0200)]
Fix PHP 5.5 compatibility
PHP 5.5 does not support constant expressions in static variable declarations.
Simply remove the `static`, it brings no real benefit.
Tim Düsterhus [Wed, 15 May 2019 16:21:07 +0000 (18:21 +0200)]
Increase the number of email retries to better match the RFCs (#2932)
* Increase the number of email retries to better match the RFCs
* Improve readability of running total comment in email job
Joshua Rüsweg [Wed, 15 May 2019 15:12:28 +0000 (17:12 +0200)]
Merge pull request #2930 from WoltLab/next-passwordreset
Allow multiple calls of the link to set a new password
Joshua Rüsweg [Wed, 15 May 2019 15:00:44 +0000 (17:00 +0200)]
Backport IReactionObject to version 3.0
This backport ensures the compatibility for version 3.0 (and above) and version 5.2. With this commit, plugins can fully support the reaction system and the like system, previously this was only possible to a limited extent.
See #2508
Joshua Rüsweg [Wed, 15 May 2019 13:32:04 +0000 (15:32 +0200)]
Allow multiple calls of the link to set a new password
See #2923
Sascha Greuel [Sun, 5 May 2019 17:44:56 +0000 (19:44 +0200)]
Fix blocking all users within the registration process
See #2692
See #2920
Joshua Rüsweg [Mon, 13 May 2019 19:52:50 +0000 (21:52 +0200)]
Improve UI for reaction recent activity
See #2508
Joshua Rüsweg [Mon, 13 May 2019 19:28:54 +0000 (21:28 +0200)]
Improve UI of reaction overview list
See #2508
Matthias Schmidt [Sun, 12 May 2019 16:26:49 +0000 (18:26 +0200)]
Ignore invalid values passed to `ShowOrderFormField::value()`
See #2509
Joshua Rüsweg [Sun, 12 May 2019 15:24:06 +0000 (17:24 +0200)]
Restruct showOrder after object deletion
See #2508
Joshua Rüsweg [Sun, 12 May 2019 15:18:39 +0000 (17:18 +0200)]
Simplify showOrder input
See #2508
Joshua Rüsweg [Sun, 12 May 2019 15:16:54 +0000 (17:16 +0200)]
Set default sort oder for reaction types
See #2508
Matthias Schmidt [Sun, 12 May 2019 09:56:12 +0000 (11:56 +0200)]
Unify sort button HTML code
Close #2929
Matthias Schmidt [Sun, 12 May 2019 09:44:14 +0000 (11:44 +0200)]
Fix double `(first position)` when using callable for show order field options
See #2509
Marcel Werk [Fri, 10 May 2019 15:56:59 +0000 (17:56 +0200)]
Merge branch '3.0'
Marcel Werk [Fri, 10 May 2019 15:56:37 +0000 (17:56 +0200)]
Added missing language variable
Marcel Werk [Fri, 10 May 2019 15:44:23 +0000 (17:44 +0200)]
Merge branch '3.0'
Marcel Werk [Fri, 10 May 2019 15:44:05 +0000 (17:44 +0200)]
Hide language drop-down if a multilingual page has only one language
Marcel Werk [Fri, 10 May 2019 15:34:57 +0000 (17:34 +0200)]
Merge branch '3.0'
Marcel Werk [Fri, 10 May 2019 15:34:12 +0000 (17:34 +0200)]
Fixed missing title in link to user profile
Joshua Rüsweg [Fri, 10 May 2019 11:25:48 +0000 (13:25 +0200)]
Fix article report button if reaction system is disabled
Fix #2926
Joshua Rüsweg [Fri, 10 May 2019 11:04:20 +0000 (13:04 +0200)]
Fix showOrder value for reactionTypes
See #2508
Matthias Schmidt [Thu, 9 May 2019 16:21:17 +0000 (18:21 +0200)]
Merge global modification log's source and action filter
See #2597
Matthias Schmidt [Thu, 9 May 2019 15:58:41 +0000 (17:58 +0200)]
Add missing description for reaction type show order field
See #2508
Matthias Schmidt [Thu, 9 May 2019 15:58:16 +0000 (17:58 +0200)]
Fix first position option not being shown for show order form fields
See #2509
Matthias Schmidt [Tue, 7 May 2019 16:21:15 +0000 (18:21 +0200)]
Enfore unified directory separators for project path
Close #2925
Matthias Schmidt [Tue, 7 May 2019 16:16:21 +0000 (18:16 +0200)]
Explicitly handle misformatted package.xml files when editing project
Close #2924
Matthias Schmidt [Mon, 6 May 2019 17:17:28 +0000 (19:17 +0200)]
Ignore guests when marking comment notifications as confirmed
See #2835
Matthias Schmidt [Mon, 6 May 2019 16:53:27 +0000 (18:53 +0200)]
Preserve selected recipient if validation of contact form fails
Tim Düsterhus [Sun, 5 May 2019 19:17:52 +0000 (21:17 +0200)]
Support adding a request ID to logged / printed exceptions
This can be used to correlate requests in logfiles across the whole
stack from reverse proxy / CDN through web server to PHP and WoltLab
Suite.
Tim Düsterhus [Sun, 5 May 2019 18:39:28 +0000 (20:39 +0200)]
Clean up stripping of newlines in logThrowable