GitHub/WoltLab/WCF.git
3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:56:41 +0000 (13:56 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:54:49 +0000 (13:54 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 7 Dec 2020 20:00:31 +0000 (21:00 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 7 Dec 2020 20:00:11 +0000 (21:00 +0100)]
Merge branch '3.1' into 5.2

3 years agoForce the use of the attachment thumbnail if the original is inaccessible
Alexander Ebert [Mon, 7 Dec 2020 19:58:02 +0000 (20:58 +0100)]
Force the use of the attachment thumbnail if the original is inaccessible

3 years agoWorkaround for the misaligned caret in Safari caused by 0x200B
Alexander Ebert [Mon, 7 Dec 2020 19:02:58 +0000 (20:02 +0100)]
Workaround for the misaligned caret in Safari caused by 0x200B

3 years agoImproved the iOS WebKit click detection inside the editor margin
Alexander Ebert [Mon, 7 Dec 2020 17:16:08 +0000 (18:16 +0100)]
Improved the iOS WebKit click detection inside the editor margin

3 years agoForce a whitespace before and after inserted smileys
Alexander Ebert [Mon, 7 Dec 2020 16:27:54 +0000 (17:27 +0100)]
Force a whitespace before and after inserted smileys

3 years agoMerge pull request #3793 from WoltLab/style-import-permissions
Tim Düsterhus [Mon, 7 Dec 2020 15:52:12 +0000 (16:52 +0100)]
Merge pull request #3793 from WoltLab/style-import-permissions

Validate package installation permissions in StyleImportForm

3 years agoValidate package installation permissions in StyleImportForm
Tim Düsterhus [Mon, 7 Dec 2020 14:56:53 +0000 (15:56 +0100)]
Validate package installation permissions in StyleImportForm

3 years agoMerge pull request #3786 from WoltLab/like-rebuild
Joshua Rüsweg [Mon, 7 Dec 2020 12:59:44 +0000 (13:59 +0100)]
Merge pull request #3786 from WoltLab/like-rebuild

Optimize LikeRebuildDataWorker performance

3 years agoOnly close the user panel drop-downs if no key modifier was pressed
Alexander Ebert [Sun, 6 Dec 2020 21:48:54 +0000 (22:48 +0100)]
Only close the user panel drop-downs if no key modifier was pressed

3 years agoDiscard the current selection when saving a quote
Alexander Ebert [Sun, 6 Dec 2020 20:16:16 +0000 (21:16 +0100)]
Discard the current selection when saving a quote

3 years agoPrevent the tooltip being selectable while the user changes the selection
Alexander Ebert [Sun, 6 Dec 2020 20:10:59 +0000 (21:10 +0100)]
Prevent the tooltip being selectable while the user changes the selection

3 years agoUnified behavior of the notification list and the corresponding menu drop-down
Alexander Ebert [Sun, 6 Dec 2020 19:35:08 +0000 (20:35 +0100)]
Unified behavior of the notification list and the corresponding menu drop-down

3 years agoConsistent width of menus in the mobile menu
Alexander Ebert [Sun, 6 Dec 2020 19:19:58 +0000 (20:19 +0100)]
Consistent width of menus in the mobile menu

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 6 Dec 2020 14:09:45 +0000 (15:09 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix dependencies for single media form field
Matthias Schmidt [Sun, 6 Dec 2020 14:09:17 +0000 (15:09 +0100)]
Fix dependencies for single media form field

3 years agoAdd missing space after comma in ReactionHandler::renderInlineList()
Tim Düsterhus [Sat, 5 Dec 2020 18:08:14 +0000 (19:08 +0100)]
Add missing space after comma in ReactionHandler::renderInlineList()

3 years agoSimplify selection of existing like objects in LikeRebuildDataWorker
Tim Düsterhus [Fri, 4 Dec 2020 14:59:43 +0000 (15:59 +0100)]
Simplify selection of existing like objects in LikeRebuildDataWorker

Since the previous commit it is expected that only a single objectTypeID is hit
per worker execution in the usual case, because all objects for a single
objectTypeID are processed before proceeding to the next objectTypeID. This
patch optimizes this case by sending a separate query per objectTypeID to fetch
the existing like objects instead of combining all the objects in a single
query.

This should help MySQL in optimizing the query, because the objectTypeID (which
is the first column in the UNIQUE KEY on wcf1_like_object) is fixed for a
single query and this is immediately obvious without needing to scan all the
tuples passed to the IN(…) condition.

In the general case the number of queries does not change. In the iterations
where the last objectID for an objectTypeID is reached two queries will be sent
instead of a single one. Those two combined should be more efficient that the
single old query, though.

3 years agoAllow LikeRebuildDataWorker to leverage the wcf1_like.objectTypeID key for sorting
Tim Düsterhus [Fri, 4 Dec 2020 14:52:10 +0000 (15:52 +0100)]
Allow LikeRebuildDataWorker to leverage the wcf1_like.objectTypeID key for sorting

3 years agoMerge branch '5.2'
joshuaruesweg [Fri, 4 Dec 2020 10:35:16 +0000 (11:35 +0100)]
Merge branch '5.2'

3 years agoIgnore invalid file ids during deleting uploaded files
joshuaruesweg [Fri, 4 Dec 2020 10:33:53 +0000 (11:33 +0100)]
Ignore invalid file ids during deleting uploaded files
There can be several reasons why the files are no longer known. We can ignore this and simply return a success message so that it doesn't pop up in the frontend when unknown files are deleted.

3 years agoFix detecting images with capitalised file extensions
joshuaruesweg [Fri, 4 Dec 2020 10:23:53 +0000 (11:23 +0100)]
Fix detecting images with capitalised file extensions

3 years agoOnly rebuild favicons if there is a new image uploaded
joshuaruesweg [Fri, 4 Dec 2020 10:05:10 +0000 (11:05 +0100)]
Only rebuild favicons if there is a new image uploaded

3 years agoFix updating pageLogo in StyleAction
joshuaruesweg [Fri, 4 Dec 2020 09:09:32 +0000 (10:09 +0100)]
Fix updating pageLogo in StyleAction

3 years agoImproved wrapping of reaction filter buttons on mobile
Marcel Werk [Wed, 2 Dec 2020 15:38:11 +0000 (16:38 +0100)]
Improved wrapping of reaction filter buttons on mobile

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Tue, 1 Dec 2020 12:35:47 +0000 (13:35 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Tue, 1 Dec 2020 12:34:59 +0000 (13:34 +0100)]
Merge branch '3.1' into 5.2

3 years agoIncorrect version comparison for accessible packages
Alexander Ebert [Tue, 1 Dec 2020 12:32:47 +0000 (13:32 +0100)]
Incorrect version comparison for accessible packages

3 years agoPrevent rewriting filenames for processed files
joshuaruesweg [Tue, 1 Dec 2020 10:58:14 +0000 (11:58 +0100)]
Prevent rewriting filenames for processed files

3 years agoFix copy and paste error in en.xml
Tim Düsterhus [Fri, 27 Nov 2020 08:40:14 +0000 (09:40 +0100)]
Fix copy and paste error in en.xml

see 9e2ccd976daa8646b2b86f4d27e52d3f226ff94e

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 26 Nov 2020 12:51:25 +0000 (13:51 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3763 from WoltLab/http-request-timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:33:41 +0000 (12:33 +0100)]
Merge pull request #3763 from WoltLab/http-request-timeout

HTTP request timeouts

3 years agoSet an explicit timeout for ImageProxyAction's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:29:23 +0000 (12:29 +0100)]
Set an explicit timeout for ImageProxyAction's HttpClient

3 years agoSet an explicit timeout for FontManager's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:28:03 +0000 (12:28 +0100)]
Set an explicit timeout for FontManager's HttpClient

3 years agoReplace HTTPRequest's timeout by connect_timeout + read_timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:26:00 +0000 (12:26 +0100)]
Replace HTTPRequest's timeout by connect_timeout + read_timeout

The timeout in 5.2 only applied to the connect() syscall. Guzzle's timeout
option applies to the total transfer. Replace it by connect_timeout +
read_timeout for backwards compatibility for code that expected the actual
transfer to take an arbitrary amount of time.

3 years agoFix typo in de.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:34:03 +0000 (09:34 +0100)]
Fix typo in de.xml

3 years agoUpdate the orphanedComments remark in package.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:18:46 +0000 (09:18 +0100)]
Update the orphanedComments remark in package.xml

3 years agoFix typo in informal German phrases
Jannis Grimm [Wed, 25 Nov 2020 03:04:31 +0000 (04:04 +0100)]
Fix typo in informal German phrases

Verweide -> Vermeide

Closes #3752

[Tim: rephrased the commit message]

3 years agoImproved randomized sort order of related articles
Marcel Werk [Tue, 24 Nov 2020 17:44:34 +0000 (18:44 +0100)]
Improved randomized sort order of related articles

3 years agoRelease 5.3.1 5.3.1
Alexander Ebert [Mon, 23 Nov 2020 15:38:18 +0000 (16:38 +0100)]
Release 5.3.1

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 15:34:03 +0000 (16:34 +0100)]
Merge branch '5.2' into 5.3

3 years agoMissing check for empty object ids 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 15:11:56 +0000 (16:11 +0100)]
Missing check for empty object ids

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 14:55:09 +0000 (15:55 +0100)]
Merge branch '5.2' into 5.3

3 years agorandomized sort order of related articles
Marcel Werk [Mon, 23 Nov 2020 14:19:48 +0000 (15:19 +0100)]
randomized sort order of related articles

3 years agoChanged related articles to new layout
Marcel Werk [Mon, 23 Nov 2020 14:19:02 +0000 (15:19 +0100)]
Changed related articles to new layout

3 years agoRelease 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 13:43:06 +0000 (14:43 +0100)]
Release 5.2.10

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 23 Nov 2020 13:36:42 +0000 (14:36 +0100)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.18 3.1.18
Alexander Ebert [Mon, 23 Nov 2020 13:29:11 +0000 (14:29 +0100)]
Release 3.1.18

3 years agoUse modified package servers when running in enterprise mode
Alexander Ebert [Mon, 23 Nov 2020 11:30:45 +0000 (12:30 +0100)]
Use modified package servers when running in enterprise mode

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 23 Nov 2020 08:31:54 +0000 (09:31 +0100)]
Merge branch '5.2' into 5.3

3 years agoWhitelist `iterator_count` in enterprise mode
Tim Düsterhus [Mon, 23 Nov 2020 08:27:54 +0000 (09:27 +0100)]
Whitelist `iterator_count` in enterprise mode

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Sun, 22 Nov 2020 17:36:43 +0000 (18:36 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sun, 22 Nov 2020 17:31:49 +0000 (18:31 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #3744 from Krymonota/patch-18
Alexander Ebert [Sun, 22 Nov 2020 16:58:44 +0000 (17:58 +0100)]
Merge pull request #3744 from Krymonota/patch-18

Add missing JSDoc to `EmailSmtpTest`

3 years agoMerge pull request #3745 from Krymonota/patch-19
Alexander Ebert [Sun, 22 Nov 2020 16:58:12 +0000 (17:58 +0100)]
Merge pull request #3745 from Krymonota/patch-19

Fix JSDoc module typo in `RewriteGenerator`

3 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Sat, 21 Nov 2020 21:00:14 +0000 (22:00 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix point calculation for removing reactions from an object
joshuaruesweg [Sat, 21 Nov 2020 20:56:27 +0000 (21:56 +0100)]
Fix point calculation for removing reactions from an object

3 years agoRelease 5.3.1
Alexander Ebert [Sat, 21 Nov 2020 18:59:08 +0000 (19:59 +0100)]
Release 5.3.1

3 years agoFix JSDoc module typo in `RewriteGenerator`
Niklas [Sat, 21 Nov 2020 18:41:47 +0000 (19:41 +0100)]
Fix JSDoc module typo in `RewriteGenerator`

3 years agoAdd missing JSDoc to `EmailSmtpTest`
Niklas [Sat, 21 Nov 2020 18:39:56 +0000 (19:39 +0100)]
Add missing JSDoc to `EmailSmtpTest`

3 years agoForce the removal of orphaned comments during the upgrade
Alexander Ebert [Sat, 21 Nov 2020 18:36:16 +0000 (19:36 +0100)]
Force the removal of orphaned comments during the upgrade

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 19:11:59 +0000 (19:11 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Fri, 20 Nov 2020 19:08:26 +0000 (20:08 +0100)]
Merge branch '5.2' into 5.3

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 19:03:30 +0000 (19:03 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Fri, 20 Nov 2020 18:59:24 +0000 (19:59 +0100)]
Merge branch '3.1' into 5.2

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 18:06:23 +0000 (18:06 +0000)]
Updating minified JavaScript files

3 years agoWorkaround for a Chromium bug on Windows
Alexander Ebert [Fri, 20 Nov 2020 17:39:33 +0000 (18:39 +0100)]
Workaround for a Chromium bug on Windows

3 years agoVerbose style compatibility for 5.2/5.3
Alexander Ebert [Fri, 20 Nov 2020 16:16:19 +0000 (17:16 +0100)]
Verbose style compatibility for 5.2/5.3

Fixes #3737

3 years agoPermit images uploaded as media to be wrapped in a link
Alexander Ebert [Fri, 20 Nov 2020 12:38:01 +0000 (13:38 +0100)]
Permit images uploaded as media to be wrapped in a link

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Fri, 20 Nov 2020 10:19:32 +0000 (11:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoClean up comments when removing moderation queues (#3740)
Alexander Ebert [Thu, 19 Nov 2020 18:24:52 +0000 (19:24 +0100)]
Clean up comments when removing moderation queues (#3740)

* Delete comments when moderation queues are being removed

See #3707

* Clean-up script for orphaned comments

* Use the `CommentHandler` to remove comments

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoEnabled three column layout for boxes top / bottom
Marcel Werk [Thu, 19 Nov 2020 18:02:23 +0000 (19:02 +0100)]
Enabled three column layout for boxes top / bottom

3 years agoSkip DOM updates when the article is not present
Alexander Ebert [Thu, 19 Nov 2020 15:56:12 +0000 (16:56 +0100)]
Skip DOM updates when the article is not present

3 years agoMerge pull request #3739 from WoltLab/fix-style-preview
Tim Düsterhus [Thu, 19 Nov 2020 15:17:08 +0000 (16:17 +0100)]
Merge pull request #3739 from WoltLab/fix-style-preview

Fix style preview images when upgrading from 5.2

3 years agoFix style preview images when upgrading from 5.2
Tim Düsterhus [Thu, 19 Nov 2020 15:09:29 +0000 (16:09 +0100)]
Fix style preview images when upgrading from 5.2

3 years agoFixed html in acp search results
Marcel Werk [Thu, 19 Nov 2020 14:27:41 +0000 (15:27 +0100)]
Fixed html in acp search results

3 years agoAdd note about the email_html.tpl update to package.xml
Tim Düsterhus [Thu, 19 Nov 2020 13:18:04 +0000 (14:18 +0100)]
Add note about the email_html.tpl update to package.xml

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 19 Nov 2020 13:13:46 +0000 (14:13 +0100)]
Merge branch '5.2' into 5.3

3 years agoReplace the selector for the font-family in email_html.tpl
Tim Düsterhus [Thu, 19 Nov 2020 13:06:01 +0000 (14:06 +0100)]
Replace the selector for the font-family in email_html.tpl

The Emogrifier version used in 5.2 does not fully support all features
of the `:not()` selector. Depending on the environment the use of
`:not()` results in slightly different output. Specifically the number
of `:not()`s chained there caused the result to have a very large
specificity, possibly overriding the font-size of the headline tags.

Use `body, body *` instead, it will not put any useless CSS onto heading
tags and still catch all relevant elements. The biggest difference is
that the `<br>` tag will carry a `font-family` and `font-size`.

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Wed, 18 Nov 2020 19:02:11 +0000 (20:02 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 18 Nov 2020 19:01:46 +0000 (20:01 +0100)]
Merge branch '3.1' into 5.2

3 years agoMutable variable access inside a callback
Alexander Ebert [Wed, 18 Nov 2020 19:00:04 +0000 (20:00 +0100)]
Mutable variable access inside a callback

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 16:32:58 +0000 (17:32 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Wed, 18 Nov 2020 16:32:41 +0000 (17:32 +0100)]
Merge branch '3.1' into 5.2

3 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:32:21 +0000 (17:32 +0100)]
Fix ACL buttons when editing media files successively

Replaces 3a7740a3704339c79d08fd2f5094fa1a1973318b by backporting and using parts of 6ee58cd2865980cd7fa16a1f3ebc660131fc7fd6.

3 years agoRevert "Fix ACL buttons when editing media files successively"
Matthias Schmidt [Wed, 18 Nov 2020 16:26:26 +0000 (17:26 +0100)]
Revert "Fix ACL buttons when editing media files successively"

This reverts commit 3a7740a3704339c79d08fd2f5094fa1a1973318b.

3 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:24:30 +0000 (17:24 +0100)]
Fix ACL buttons when editing media files successively

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 15:28:34 +0000 (16:28 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix file icon update after upload on media list page
Matthias Schmidt [Wed, 18 Nov 2020 15:28:18 +0000 (16:28 +0100)]
Fix file icon update after upload on media list page

3 years agoMerge pull request #3727 from WoltLab/favicon-template-typo
Tim Düsterhus [Wed, 18 Nov 2020 08:22:32 +0000 (09:22 +0100)]
Merge pull request #3727 from WoltLab/favicon-template-typo

Fix typo in favicon template filename

3 years agoUpdating minified JavaScript files
WoltLab [Tue, 17 Nov 2020 14:56:24 +0000 (14:56 +0000)]
Updating minified JavaScript files

3 years agoFix typo in favicon template filename
Tim Düsterhus [Tue, 17 Nov 2020 14:25:44 +0000 (15:25 +0100)]
Fix typo in favicon template filename

5.2 used `favicon-template.ext` instead of `favicon.template.ext`.

3 years agoForce the synchronization of the `codeMetaCode` template
Alexander Ebert [Tue, 17 Nov 2020 14:25:36 +0000 (15:25 +0100)]
Force the synchronization of the `codeMetaCode` template

3 years agoPlace the `@charset` at the very beginning of the generated CSS (#3726)
Alexander Ebert [Tue, 17 Nov 2020 14:17:49 +0000 (15:17 +0100)]
Place the `@charset` at the very beginning of the generated CSS (#3726)

* Place the `@charset` at the very beginning of the generated CSS

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoFix wrong user disable/enable label in user profile
joshuaruesweg [Tue, 17 Nov 2020 13:51:28 +0000 (14:51 +0100)]
Fix wrong user disable/enable label in user profile

3 years agoMerge pull request #3724 from WoltLab/upgrade-53-ignore-missing-imagePath
Tim Düsterhus [Tue, 17 Nov 2020 11:30:12 +0000 (12:30 +0100)]
Merge pull request #3724 from WoltLab/upgrade-53-ignore-missing-imagePath

Verify the existence of the old imagePath in update_com.woltlab.wcf_5.3_style.php

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 17 Nov 2020 11:10:59 +0000 (12:10 +0100)]
Merge branch '5.2' into 5.3

3 years agoEncode HTML special chars in form builder's action
Tim Düsterhus [Tue, 17 Nov 2020 11:10:32 +0000 (12:10 +0100)]
Encode HTML special chars in form builder's action