GitHub/WoltLab/WCF.git
19 months agoFix the use of Google Fonts
Tim Düsterhus [Fri, 21 Apr 2023 08:24:46 +0000 (10:24 +0200)]
Fix the use of Google Fonts

Due to the move to proper CSS variables, instead of just SCSS variables, the
variables need to be available during `->bootstrap()` and thus they are
prepared early in the compilation process. This preparation included quoting
the Google Font. Later in the bootstrap, when loading the CSS for the Google
Font, the corresponding CSS file could not be found due to this quoting.

It appears that the quoting of the variable itself is no longer be necessary.
The previous comment stated that font names with 'and' or 'or' in their name
cause issues. While the current list of fonts does not include any font with
'or' in its name, I successfully tested the `Black And White Picture` font.

The SCSS compiled just fine, possibly due to an upgrade of the SCSS compiler
that fixed a limitation. So this is going to be the bugfix.

Fixes #5400

19 months agoImprove Ckeditor/Types.ts
Tim Düsterhus [Thu, 20 Apr 2023 13:07:17 +0000 (15:07 +0200)]
Improve Ckeditor/Types.ts

19 months agoUnify the general styling of CKEditor
Alexander Ebert [Thu, 20 Apr 2023 12:15:38 +0000 (14:15 +0200)]
Unify the general styling of CKEditor

Fixes #5428

19 months agoFix incorrect phrase reference in styleAdd.tpl
Tim Düsterhus [Thu, 20 Apr 2023 09:14:19 +0000 (11:14 +0200)]
Fix incorrect phrase reference in styleAdd.tpl

19 months agoMerge branch '5.5'
Tim Düsterhus [Thu, 20 Apr 2023 08:40:02 +0000 (10:40 +0200)]
Merge branch '5.5'

19 months agoAdd parameter types from psr/http-message to LegacyPlaceholderResponse
Tim Düsterhus [Thu, 20 Apr 2023 08:38:09 +0000 (10:38 +0200)]
Add parameter types from psr/http-message to LegacyPlaceholderResponse

19 months agoMerge pull request #5429 from WoltLab/username-spoof
Tim Düsterhus [Thu, 20 Apr 2023 07:02:30 +0000 (09:02 +0200)]
Merge pull request #5429 from WoltLab/username-spoof

Extend REGISTER_USERNAME_FORCE_ASCII to support ICU spoofchecking

19 months agoMerge pull request #5430 from WoltLab/generic-share-button
Marcel Werk [Wed, 19 Apr 2023 16:44:24 +0000 (18:44 +0200)]
Merge pull request #5430 from WoltLab/generic-share-button

Add generic position for share button in the content interaction section

19 months agoUse new position in article template
Marcel Werk [Wed, 19 Apr 2023 14:51:11 +0000 (16:51 +0200)]
Use new position in article template

19 months agoAdd generic position for share button in the content interaction section
Marcel Werk [Wed, 19 Apr 2023 14:43:37 +0000 (16:43 +0200)]
Add generic position for share button in the content interaction section

19 months agoAdd support for button-type share buttons
Marcel Werk [Wed, 19 Apr 2023 14:37:49 +0000 (16:37 +0200)]
Add support for button-type share buttons

19 months agoExtend REGISTER_USERNAME_FORCE_ASCII to support ICU spoofchecking
Tim Düsterhus [Wed, 19 Apr 2023 11:41:06 +0000 (13:41 +0200)]
Extend REGISTER_USERNAME_FORCE_ASCII to support ICU spoofchecking

19 months agoRelease 5.5.11 5.5.11
Alexander Ebert [Wed, 19 Apr 2023 13:32:44 +0000 (15:32 +0200)]
Release 5.5.11

19 months agoMerge branch '5.4' into 5.5
Alexander Ebert [Wed, 19 Apr 2023 12:57:09 +0000 (14:57 +0200)]
Merge branch '5.4' into 5.5

19 months agoRelease 5.4.27 5.4.27
Alexander Ebert [Wed, 19 Apr 2023 12:56:08 +0000 (14:56 +0200)]
Release 5.4.27

19 months agoRequire usernames to be valid UTF-8
Tim Düsterhus [Wed, 19 Apr 2023 12:54:33 +0000 (14:54 +0200)]
Require usernames to be valid UTF-8

19 months agoGenerally consider usernames with bytes less than 0x20 as invalid
Tim Düsterhus [Wed, 19 Apr 2023 12:51:15 +0000 (14:51 +0200)]
Generally consider usernames with bytes less than 0x20 as invalid

NUL bytes, newlines (LF was already restricted) and other ASCII control
characters have no business of existing within an username.

19 months agoMerge branch '5.3' into 5.4
Alexander Ebert [Wed, 19 Apr 2023 12:50:28 +0000 (14:50 +0200)]
Merge branch '5.3' into 5.4

19 months agoRelease 5.3.28 5.3.28 5.3.final
Alexander Ebert [Wed, 19 Apr 2023 12:48:51 +0000 (14:48 +0200)]
Release 5.3.28

19 months agoMerge branch '5.5'
Tim Düsterhus [Wed, 19 Apr 2023 12:00:13 +0000 (14:00 +0200)]
Merge branch '5.5'

19 months agoUpdating minified JavaScript files
WoltLab [Wed, 19 Apr 2023 11:59:20 +0000 (11:59 +0000)]
Updating minified JavaScript files

19 months agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 19 Apr 2023 11:58:03 +0000 (13:58 +0200)]
Merge branch '5.4' into 5.5

19 months agoUpdating minified JavaScript files
WoltLab [Wed, 19 Apr 2023 11:57:15 +0000 (11:57 +0000)]
Updating minified JavaScript files

19 months agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 19 Apr 2023 11:55:57 +0000 (13:55 +0200)]
Merge branch '5.3' into 5.4

19 months agoUpdating minified JavaScript files
WoltLab [Wed, 19 Apr 2023 11:55:07 +0000 (11:55 +0000)]
Updating minified JavaScript files

19 months agoMerge branch '5.5'
Tim Düsterhus [Wed, 19 Apr 2023 11:52:42 +0000 (13:52 +0200)]
Merge branch '5.5'

19 months agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 19 Apr 2023 11:51:47 +0000 (13:51 +0200)]
Merge branch '5.4' into 5.5

19 months agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 19 Apr 2023 11:51:31 +0000 (13:51 +0200)]
Merge branch '5.3' into 5.4

19 months agoMerge branch 'article-clipboard' into 5.3
Tim Düsterhus [Wed, 19 Apr 2023 11:45:04 +0000 (13:45 +0200)]
Merge branch 'article-clipboard' into 5.3

19 months agoMerge branch 'js-unescape-html' into 5.3
Tim Düsterhus [Wed, 19 Apr 2023 11:44:42 +0000 (13:44 +0200)]
Merge branch 'js-unescape-html' into 5.3

19 months agoMerge pull request #5427 from SoftCreatR/patch-1
Alexander Ebert [Tue, 18 Apr 2023 12:46:28 +0000 (14:46 +0200)]
Merge pull request #5427 from SoftCreatR/patch-1

Apply small style optimization

19 months agoFix StyleEditor::update() for absent variables
Tim Düsterhus [Tue, 18 Apr 2023 09:12:14 +0000 (11:12 +0200)]
Fix StyleEditor::update() for absent variables

see d7fad3385012cd86b33b9262c47040b1c7267826

19 months agoFix style variable update in StyleEditor::update()
Tim Düsterhus [Tue, 18 Apr 2023 08:59:27 +0000 (10:59 +0200)]
Fix style variable update in StyleEditor::update()

The previous version overwrote the input variables before processing them. It
also did not support missing a `variables` key, whereas 5.5 did.

see f573c802cc70e929641b7145c1e28ff557ec61ff

19 months agoApplied small stylig optimization
Sascha Greuel [Tue, 18 Apr 2023 07:51:26 +0000 (09:51 +0200)]
Applied small stylig optimization

Adding the `userExceptionMessage` makes it look better. However, I was also thinking about moving from inline CSS. But I wasn't sure, whether this is not intentional. So I left that.

19 months agoFix `StringUtil.unescapeHTML()`
Tim Düsterhus [Tue, 18 Apr 2023 07:42:25 +0000 (09:42 +0200)]
Fix `StringUtil.unescapeHTML()`

The HTML was unescaped in an incorrect order, causing incorrect results for
inputs like:

    StringUtil.unescapeHTML('"')

19 months agoDo not allow setting an inaccessible category in ArticleAction::validateSetCategory()
Tim Düsterhus [Tue, 28 Mar 2023 12:42:51 +0000 (14:42 +0200)]
Do not allow setting an inaccessible category in ArticleAction::validateSetCategory()

19 months agoValidate if an article may be edited in `setCategory` clipboard action
Tim Düsterhus [Tue, 28 Mar 2023 12:41:54 +0000 (14:41 +0200)]
Validate if an article may be edited in `setCategory` clipboard action

19 months agoMerge pull request #5272 from WoltLab/formbuilder-immutable
Tim Düsterhus [Tue, 18 Apr 2023 07:35:12 +0000 (09:35 +0200)]
Merge pull request #5272 from WoltLab/formbuilder-immutable

Always load object data for immutable form fields

19 months agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Mon, 17 Apr 2023 20:04:42 +0000 (22:04 +0200)]
Merge remote-tracking branch 'origin/master'

19 months agoUpdate composer dependencies
Tim Düsterhus [Mon, 17 Apr 2023 20:04:29 +0000 (22:04 +0200)]
Update composer dependencies

19 months agoMerge branch '5.5'
Tim Düsterhus [Mon, 17 Apr 2023 20:03:47 +0000 (22:03 +0200)]
Merge branch '5.5'

19 months agoMerge pull request #5409 from WoltLab/pending-packages
Tim Düsterhus [Mon, 17 Apr 2023 17:27:24 +0000 (19:27 +0200)]
Merge pull request #5409 from WoltLab/pending-packages

 Remove incorrect modification of `$pendingPackages` in PackageInstallationNodeBuilder::buildRequirementNodes()

19 months agoUpdate laminas/laminas-diactoros
Tim Düsterhus [Mon, 17 Apr 2023 17:22:50 +0000 (19:22 +0200)]
Update laminas/laminas-diactoros

see laminas/laminas-diactoros@2bc0d0bc2d15a3182d7853f761b6b7d2754821fe

19 months agoMerge branch '5.4' into 5.5
Tim Düsterhus [Mon, 17 Apr 2023 17:20:13 +0000 (19:20 +0200)]
Merge branch '5.4' into 5.5

19 months agoMerge pull request #5336 from WoltLab/first-time-setup
Alexander Ebert [Mon, 17 Apr 2023 16:59:35 +0000 (18:59 +0200)]
Merge pull request #5336 from WoltLab/first-time-setup

Improve FirstTimeSetup

19 months agoFix PHPDoc comments for first time setup
Tim Düsterhus [Fri, 14 Apr 2023 15:02:45 +0000 (17:02 +0200)]
Fix PHPDoc comments for first time setup

19 months agoRemove incorrect `.externalURL` in firstTimeSetupCompleted
Tim Düsterhus [Fri, 14 Apr 2023 14:57:38 +0000 (16:57 +0200)]
Remove incorrect `.externalURL` in firstTimeSetupCompleted

19 months agoHide the container for the license credentials when a skip is requested
Alexander Ebert [Fri, 14 Apr 2023 14:36:47 +0000 (16:36 +0200)]
Hide the container for the license credentials when a skip is requested

19 months agoAdd the final step of the first time setup
Alexander Ebert [Fri, 14 Apr 2023 14:36:00 +0000 (16:36 +0200)]
Add the final step of the first time setup

19 months agoImprove the UI/UX of the license form
Alexander Ebert [Sat, 8 Apr 2023 15:26:13 +0000 (17:26 +0200)]
Improve the UI/UX of the license form

19 months agoAdd description to first time setup option forms
Tim Düsterhus [Tue, 7 Mar 2023 10:29:51 +0000 (11:29 +0100)]
Add description to first time setup option forms

19 months agoAdd `page_description` to first time setup
Tim Düsterhus [Tue, 7 Mar 2023 10:15:15 +0000 (11:15 +0100)]
Add `page_description` to first time setup

19 months agoSplit email options into a separate page during first time setup
Tim Düsterhus [Tue, 7 Mar 2023 10:13:01 +0000 (11:13 +0100)]
Split email options into a separate page during first time setup

19 months agoAdd FirstTimeSetupLicenseForm
Tim Düsterhus [Mon, 6 Mar 2023 14:16:33 +0000 (15:16 +0100)]
Add FirstTimeSetupLicenseForm

19 months agoDrop active menu item in FirstTimeSetupOptionsForm
Tim Düsterhus [Mon, 6 Mar 2023 13:54:47 +0000 (14:54 +0100)]
Drop active menu item in FirstTimeSetupOptionsForm

19 months agoDisallow accessing FirstTimeSetupOptionsForm once first time setup is completed
Tim Düsterhus [Mon, 6 Mar 2023 13:52:56 +0000 (14:52 +0100)]
Disallow accessing FirstTimeSetupOptionsForm once first time setup is completed

19 months agoRemove “Index” button in first time setup options template
Tim Düsterhus [Mon, 6 Mar 2023 13:51:14 +0000 (14:51 +0100)]
Remove “Index” button in first time setup options template

19 months agoSplit first time setup into multiple pages
Tim Düsterhus [Mon, 6 Mar 2023 13:47:15 +0000 (14:47 +0100)]
Split first time setup into multiple pages

19 months agoRemove privacy options from first time setup
Tim Düsterhus [Mon, 6 Mar 2023 13:24:27 +0000 (14:24 +0100)]
Remove privacy options from first time setup

The defaults are fine.

19 months agoRemove reCAPTCHA options from first time setup
Tim Düsterhus [Mon, 6 Mar 2023 13:23:08 +0000 (14:23 +0100)]
Remove reCAPTCHA options from first time setup

The administrator likely does not have them at hand. Showing these fields thus
is likely not actionable to them and easily overwhelming when starting with a
completely new software.

19 months agoRedirect ACP IndexPage to FirstTimeSetup until submitted
Tim Düsterhus [Mon, 6 Mar 2023 13:21:54 +0000 (14:21 +0100)]
Redirect ACP IndexPage to FirstTimeSetup until submitted

19 months agoAdd `first_time_setup_state` option
Tim Düsterhus [Mon, 6 Mar 2023 13:11:46 +0000 (14:11 +0100)]
Add `first_time_setup_state` option

19 months agoDisable offline mode when completing FirstTimeSetup
Tim Düsterhus [Mon, 6 Mar 2023 13:14:49 +0000 (14:14 +0100)]
Disable offline mode when completing FirstTimeSetup

19 months agoAutomatically disable offline mode in developer mode setup
Tim Düsterhus [Mon, 6 Mar 2023 13:14:33 +0000 (14:14 +0100)]
Automatically disable offline mode in developer mode setup

19 months agoEnable offline mode by default
Tim Düsterhus [Mon, 6 Mar 2023 13:14:14 +0000 (14:14 +0100)]
Enable offline mode by default

19 months agoAdd a hint for possible errors in the custom CSS for the dark mode
Alexander Ebert [Mon, 17 Apr 2023 16:43:21 +0000 (18:43 +0200)]
Add a hint for possible errors in the custom CSS for the dark mode

Fixes #5378

19 months agoMark the style description as optional
Alexander Ebert [Mon, 17 Apr 2023 16:37:45 +0000 (18:37 +0200)]
Mark the style description as optional

Fixes #5379

19 months agoFix the import of updated styles
Alexander Ebert [Mon, 17 Apr 2023 16:36:47 +0000 (18:36 +0200)]
Fix the import of updated styles

Fixes #5363

19 months agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 17 Apr 2023 16:23:38 +0000 (18:23 +0200)]
Merge branch '5.3' into 5.4

19 months agoUpdate guzzlehttp/psr7
Tim Düsterhus [Mon, 17 Apr 2023 16:21:29 +0000 (18:21 +0200)]
Update guzzlehttp/psr7

see guzzle/psr7@18fd8915823bd9ca4156e84849e18970057dc7e4

19 months agoMerge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Mon, 17 Apr 2023 16:05:43 +0000 (18:05 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF

19 months agoFix indentation
Marcel Werk [Mon, 17 Apr 2023 16:05:35 +0000 (18:05 +0200)]
Fix indentation

19 months agoAdd additional template event in comment list
Marcel Werk [Mon, 17 Apr 2023 16:04:39 +0000 (18:04 +0200)]
Add additional template event in comment list

19 months agoUpdate the CSS for the mobile unread indicator
Alexander Ebert [Mon, 17 Apr 2023 16:01:23 +0000 (18:01 +0200)]
Update the CSS for the mobile unread indicator

The HTML was overhauled but the CSS itself was still targeting the previous markup.

Fixes #5390

19 months agoFix the comparison and storing of style variables
Alexander Ebert [Mon, 17 Apr 2023 15:46:27 +0000 (17:46 +0200)]
Fix the comparison and storing of style variables

Fixes #5377

19 months agoMove the helper method for dark mode sensitive variables
Alexander Ebert [Mon, 17 Apr 2023 15:45:51 +0000 (17:45 +0200)]
Move the helper method for dark mode sensitive variables

19 months agoImprove the filter for variables with a dark mode variant
Alexander Ebert [Mon, 17 Apr 2023 15:06:42 +0000 (17:06 +0200)]
Improve the filter for variables with a dark mode variant

19 months agoDiscard intermediate values for the dark mode values
Alexander Ebert [Mon, 17 Apr 2023 14:57:12 +0000 (16:57 +0200)]
Discard intermediate values for the dark mode values

Fixes #5398

19 months agoRemove incorrect modification of `$pendingPackages` in PackageInstallationNodeBuilder...
Tim Düsterhus [Thu, 6 Apr 2023 09:32:52 +0000 (11:32 +0200)]
Remove incorrect modification of `$pendingPackages` in PackageInstallationNodeBuilder::buildRequirementNodes()

Previously the `$pendingPackages` were only used to resolve dependencies, thus
the exact position for registering the new version does not really matter.
However with 5df3e65185d4d3f1be7464b1999b949946a5c765 the version is also used
to select the correct update instructions.

Thus the new package version must only be registered after the nodes for the
package in question have actually been built, similarly to the change in
2406351b19c5fac66b8413ba1f6660a376b7e18f.

In fact the registration in `buildRequirementNodes()` is completely redundant
since commit 7ddf2af9528be4c114d4ad83b804c3529769f24c, as the new version will
be registered in `->buildNodes()` a few lines afterwards. The
`$pendingPackages` variable is not read in-between. Thus this will be our fix:
The incorrect line is simply removed without replacement.

19 months agoFix package uninstallation
Tim Düsterhus [Mon, 17 Apr 2023 13:48:13 +0000 (15:48 +0200)]
Fix package uninstallation

see #5426

19 months agoDrop the intermediate field for custom SCSS code
Alexander Ebert [Mon, 17 Apr 2023 13:57:15 +0000 (15:57 +0200)]
Drop the intermediate field for custom SCSS code

Fixes #5398

19 months agoMerge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Mon, 17 Apr 2023 13:38:52 +0000 (15:38 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF

19 months agoRemove obsolete code
Marcel Werk [Mon, 17 Apr 2023 13:38:50 +0000 (15:38 +0200)]
Remove obsolete code

The primary entity is already set by the statement `itemprop="mainEntity"`.

19 months agoMerge pull request #5426 from WoltLab/update-safety-check
Tim Düsterhus [Mon, 17 Apr 2023 13:35:22 +0000 (15:35 +0200)]
Merge pull request #5426 from WoltLab/update-safety-check

Add package update safety check with regard to version numbers

19 months agoFix the recognition of non namespaced variable values when editing a style
Alexander Ebert [Mon, 17 Apr 2023 13:30:24 +0000 (15:30 +0200)]
Fix the recognition of non namespaced variable values when editing a style

See #5376

19 months agoFixed the compilation of styles when editing them
Alexander Ebert [Mon, 17 Apr 2023 12:09:26 +0000 (14:09 +0200)]
Fixed the compilation of styles when editing them

Fixes #5376

19 months agoAdd package update safety check with regard to version numbers
Tim Düsterhus [Mon, 17 Apr 2023 12:07:02 +0000 (14:07 +0200)]
Add package update safety check with regard to version numbers

During a multi-package update, e.g. when upgrading to a new major release, the
entire installation plan is built upfront. Do to so the package system needs to
keep track of the to-be-installed packages and package versions to properly
resolve update instructions and dependencies.

This is done using the `PackageInstallationNodeBuilder::$pendingPackages`
variable which needs to be updated at exactly the right locations. Historically
there were a few issues with incorrect versions being stored in that variable
which in turn might cause the installation to use the wrong instructions based
on the wrong assumed version number.

To ensure that such a broken installation plan does not cause havoc, the
assumed version is now stored within the start marker node. When it's time to
actually install the package this assumed version is compared to the actual
version. If there's a mismatch, the update is aborted at a safe point: The
previous package is fully installed. For the current package with the wrongly
selected instructions no actual installation logic was performed yet. The admin
can retry the update and now the installation process will (hopefully) select
correct instructions when starting from a clean state.

see #5409

19 months agoUpdate composer dependencies
Tim Düsterhus [Mon, 17 Apr 2023 11:35:33 +0000 (13:35 +0200)]
Update composer dependencies

19 months agoSlightly increase the spacing between a category and its first item
Alexander Ebert [Sun, 16 Apr 2023 18:33:25 +0000 (20:33 +0200)]
Slightly increase the spacing between a category and its first item

19 months agoUse CSS classes for text alignment
Alexander Ebert [Fri, 14 Apr 2023 13:47:34 +0000 (15:47 +0200)]
Use CSS classes for text alignment

Fixes WoltLab/editor#31

19 months agoUpdate fileDelete.xml
Tim Düsterhus [Fri, 14 Apr 2023 13:39:53 +0000 (15:39 +0200)]
Update fileDelete.xml

19 months agoAlign the generated HTML of quotes with the editor’s expectations
Alexander Ebert [Fri, 14 Apr 2023 13:39:59 +0000 (15:39 +0200)]
Align the generated HTML of quotes with the editor’s expectations

Fixes WoltLab/editor#32

19 months agoFix the update instructions
Alexander Ebert [Fri, 14 Apr 2023 13:29:54 +0000 (15:29 +0200)]
Fix the update instructions

19 months agoAdd proper types to various RouteHandler symbols
Tim Düsterhus [Fri, 14 Apr 2023 13:20:32 +0000 (15:20 +0200)]
Add proper types to various RouteHandler symbols

19 months agoChange `protected` to `private` in RouteHandler
Tim Düsterhus [Fri, 14 Apr 2023 13:17:36 +0000 (15:17 +0200)]
Change `protected` to `private` in RouteHandler

The RouteHandler is final anyway.

19 months agoFix the use of route values using a PSR request
Tim Düsterhus [Fri, 14 Apr 2023 13:13:27 +0000 (15:13 +0200)]
Fix the use of route values using a PSR request

19 months agoFix submit button in editHistory.tpl
Tim Düsterhus [Fri, 14 Apr 2023 13:05:43 +0000 (15:05 +0200)]
Fix submit button in editHistory.tpl

19 months agoFix PHP codestyle
Tim Düsterhus [Fri, 14 Apr 2023 12:56:56 +0000 (14:56 +0200)]
Fix PHP codestyle

19 months agoMove the “exception escapes from middleware” detection further out
Tim Düsterhus [Fri, 14 Apr 2023 12:41:23 +0000 (14:41 +0200)]
Move the “exception escapes from middleware” detection further out

Since abd060c56250c1a340732b8180c90efd49727ee9 there should not be such an
exception even during routing, not just after the middleware stack terminates.

19 months agoMerge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Fri, 14 Apr 2023 12:35:43 +0000 (14:35 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF