GitHub/WoltLab/WCF.git
3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Mon, 1 Mar 2021 16:08:05 +0000 (17:08 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge branch '3.0' into 3.1
Tim Düsterhus [Mon, 1 Mar 2021 16:07:24 +0000 (17:07 +0100)]
Merge branch '3.0' into 3.1

3 years agoRelease 3.0.27
Tim Düsterhus [Mon, 1 Mar 2021 16:01:25 +0000 (17:01 +0100)]
Release 3.0.27

3 years agoAdjust upgrade notice
Tim Düsterhus [Mon, 1 Mar 2021 15:59:43 +0000 (16:59 +0100)]
Adjust upgrade notice

see f4a8700ae34fa3120576c5ab4e2096f514cffdc5
see 14a6db14f1ac63da83098dc648288ae07df62e80

3 years agoAdd upgrade instructions for 2.1.24 pl 3
Tim Düsterhus [Mon, 1 Mar 2021 15:55:23 +0000 (16:55 +0100)]
Add upgrade instructions for 2.1.24 pl 3

3 years agoProperly handle empty logfiles in ExceptionLogUtil::splitLog()
Tim Düsterhus [Tue, 23 Feb 2021 14:11:55 +0000 (15:11 +0100)]
Properly handle empty logfiles in ExceptionLogUtil::splitLog()

3 years agoProperly handle corrupted or huge log files in exception mailer
Tim Düsterhus [Tue, 23 Feb 2021 14:10:22 +0000 (15:10 +0100)]
Properly handle corrupted or huge log files in exception mailer

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 23 Feb 2021 08:47:42 +0000 (09:47 +0100)]
Merge branch '3.1' into 5.2

3 years agoMatch all prefixes for store.woltlab.com in PackageAction::validateSearchForPurchased...
Tim Düsterhus [Tue, 23 Feb 2021 08:46:31 +0000 (09:46 +0100)]
Match all prefixes for store.woltlab.com in PackageAction::validateSearchForPurchasedItems()

see #3910

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 16 Feb 2021 11:40:03 +0000 (12:40 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge branch '3.0' into 3.1
Tim Düsterhus [Tue, 16 Feb 2021 11:38:24 +0000 (12:38 +0100)]
Merge branch '3.0' into 3.1

3 years agoMerge pull request #3997 from WoltLab/major-upgrade-no-upload
Tim Düsterhus [Tue, 16 Feb 2021 11:37:59 +0000 (12:37 +0100)]
Merge pull request #3997 from WoltLab/major-upgrade-no-upload

Reject major com.woltlab.wcf upgrades via package upload

3 years agoReject major com.woltlab.wcf upgrades via package upload
Tim Düsterhus [Tue, 16 Feb 2021 11:11:21 +0000 (12:11 +0100)]
Reject major com.woltlab.wcf upgrades via package upload

3 years agoFixes twitch clips which contain a dash char
Sir-Will [Mon, 15 Feb 2021 18:48:20 +0000 (19:48 +0100)]
Fixes twitch clips which contain a dash char

Twitch clips can contain a dash (´-`).
Example: https://clips.twitch.tv/NeighborlyManlyBaconMikeHogu-_9zfXbRK47vik1WO

Resolves #3996

3 years agoFix deleting an empty list of objects
joshuaruesweg [Sun, 14 Feb 2021 12:35:03 +0000 (13:35 +0100)]
Fix deleting an empty list of objects

It can happen that content that was previously counted no longer exists and therefore fewer runs are required than initially assumed. This can happen if, for example, a user's posts and threads are deleted and the user has only written posts in his or her own threads (the posts are then deleted along with the threads). This may have led to errors before because an empty list of objects was passed.

3 years agoAdditional template event in articleAdd template
Marcel Werk [Thu, 11 Feb 2021 08:52:33 +0000 (09:52 +0100)]
Additional template event in articleAdd template

3 years agoFix mixed boolean operators in condition in `TI18nFormField::validate()`
Matthias Schmidt [Fri, 5 Feb 2021 10:33:03 +0000 (11:33 +0100)]
Fix mixed boolean operators in condition in `TI18nFormField::validate()`

… and improve the preceding comment.

See #3926

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Wed, 3 Feb 2021 09:06:55 +0000 (10:06 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge branch '3.0' into 3.1
Tim Düsterhus [Wed, 3 Feb 2021 09:06:19 +0000 (10:06 +0100)]
Merge branch '3.0' into 3.1

3 years agoFix typo in phrases
Tim Düsterhus [Wed, 3 Feb 2021 08:18:31 +0000 (09:18 +0100)]
Fix typo in phrases

3 years agoIgnore name of primary keys during creation (#3921)
Matthias Schmidt [Tue, 2 Feb 2021 12:26:09 +0000 (13:26 +0100)]
Ignore name of primary keys during creation (#3921)

3 years agoRelease 5.2.12 5.2.12
Alexander Ebert [Mon, 1 Feb 2021 12:00:53 +0000 (13:00 +0100)]
Release 5.2.12

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 1 Feb 2021 11:59:33 +0000 (12:59 +0100)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.20 3.1.20
Alexander Ebert [Mon, 1 Feb 2021 11:56:07 +0000 (12:56 +0100)]
Release 3.1.20

3 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Mon, 1 Feb 2021 11:55:02 +0000 (12:55 +0100)]
Merge branch '3.0' into 3.1

3 years agoRelease 3.0.26 3.0.26
Alexander Ebert [Mon, 1 Feb 2021 11:50:17 +0000 (12:50 +0100)]
Release 3.0.26

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 1 Feb 2021 11:47:42 +0000 (12:47 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Mon, 1 Feb 2021 11:47:24 +0000 (12:47 +0100)]
Merge branch '3.0' into 3.1

3 years agoMissing check for accessible user groups
Alexander Ebert [Mon, 1 Feb 2021 11:47:09 +0000 (12:47 +0100)]
Missing check for accessible user groups

3 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Mon, 1 Feb 2021 11:38:59 +0000 (12:38 +0100)]
Merge branch '3.0' into 3.1

3 years agoNotify users of the expiring support
Alexander Ebert [Mon, 1 Feb 2021 11:38:49 +0000 (12:38 +0100)]
Notify users of the expiring support

3 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Mon, 1 Feb 2021 11:38:11 +0000 (12:38 +0100)]
Merge branch '3.0' into 3.1

3 years agoIgnore top-level node_modules/
Tim Düsterhus [Fri, 16 Oct 2020 11:57:29 +0000 (13:57 +0200)]
Ignore top-level node_modules/

3 years agoFix which index object is used when dropping indices with PHP API
Matthias Schmidt [Fri, 29 Jan 2021 15:22:50 +0000 (16:22 +0100)]
Fix which index object is used when dropping indices with PHP API

Only `$matchingExistingIndex` is guaranteed to have the correct index name.

3 years agoFix checked property when adding indices to `DatabaseTable`
Matthias Schmidt [Fri, 29 Jan 2021 14:55:26 +0000 (15:55 +0100)]
Fix checked property when adding indices to `DatabaseTable`

3 years agoRelease 5.2.11 5.2.11
Alexander Ebert [Fri, 29 Jan 2021 14:01:03 +0000 (15:01 +0100)]
Release 5.2.11

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Fri, 29 Jan 2021 13:56:16 +0000 (14:56 +0100)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.19 3.1.19
Alexander Ebert [Fri, 29 Jan 2021 13:44:59 +0000 (14:44 +0100)]
Release 3.1.19

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 29 Jan 2021 13:38:27 +0000 (13:38 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Fri, 29 Jan 2021 12:32:24 +0000 (13:32 +0100)]
Merge branch '3.1' into 5.2

3 years agoFix converting float value to integer
joshuaruesweg [Fri, 29 Jan 2021 12:30:56 +0000 (13:30 +0100)]
Fix converting float value to integer

3 years agoMerge pull request #3908 from WoltLab/pr_build_package
Joshua Rüsweg [Wed, 27 Jan 2021 14:57:30 +0000 (15:57 +0100)]
Merge pull request #3908 from WoltLab/pr_build_package

Add wcfsetup workflow

3 years agoAdd wcfsetup workflow
joshuaruesweg [Wed, 27 Jan 2021 14:30:47 +0000 (15:30 +0100)]
Add wcfsetup workflow
This workflow generates the WCFSetup and stores it as an artifact.

3 years agoMerge pull request #3900 from WoltLab/hasOwnerAccess
Tim Düsterhus [Tue, 26 Jan 2021 14:11:49 +0000 (15:11 +0100)]
Merge pull request #3900 from WoltLab/hasOwnerAccess

Fix User::hasOwnerAccess()

3 years agoCheck owner access after checking controller blacklist in RequestHandler
Tim Düsterhus [Tue, 26 Jan 2021 14:03:22 +0000 (15:03 +0100)]
Check owner access after checking controller blacklist in RequestHandler

This ensures that the check only happens when absolute required.

3 years agoRemove caching from User::hasOwnerAccess()
Tim Düsterhus [Tue, 26 Jan 2021 14:00:28 +0000 (15:00 +0100)]
Remove caching from User::hasOwnerAccess()

The current caching logic is buggy as reported in issue #3899. This patch
removes this caching, as this method already is quite fast and it also is
seldomly called. Within the frontend it is only called when the user is banned.

Fixes #3899

3 years agoWhitelist `array_fill` in enterprise mode
Tim Düsterhus [Mon, 25 Jan 2021 08:17:56 +0000 (09:17 +0100)]
Whitelist `array_fill` in enterprise mode

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 20 Jan 2021 12:12:17 +0000 (12:12 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '3.1' into 5.2
Marcel Werk [Mon, 18 Jan 2021 15:19:54 +0000 (16:19 +0100)]
Merge branch '3.1' into 5.2

3 years agoPermissions for media were not saved correctly
Marcel Werk [Mon, 18 Jan 2021 15:19:25 +0000 (16:19 +0100)]
Permissions for media were not saved correctly

3 years agoFix double html encoding in trophy activity events
joshuaruesweg [Mon, 18 Jan 2021 12:54:21 +0000 (13:54 +0100)]
Fix double html encoding in trophy activity events

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Fri, 15 Jan 2021 12:46:45 +0000 (13:46 +0100)]
Merge branch '3.1' into 5.2

3 years agoSet explicit value for invalid select options
joshuaruesweg [Fri, 15 Jan 2021 12:45:59 +0000 (13:45 +0100)]
Set explicit value for invalid select options

3 years agoSupport WysiwygFormContainer as children of ITabMenuFormContainer
Titus Kirch [Wed, 30 Dec 2020 01:11:55 +0000 (02:11 +0100)]
Support WysiwygFormContainer as children of ITabMenuFormContainer

3 years agoFix displaying error messages for devtool projects' instructions
Matthias Schmidt [Fri, 15 Jan 2021 08:53:37 +0000 (09:53 +0100)]
Fix displaying error messages for devtool projects' instructions

3 years agoRemove incorrect devtools form field description
Matthias Schmidt [Fri, 15 Jan 2021 08:50:00 +0000 (09:50 +0100)]
Remove incorrect devtools form field description

3 years agoImprove variable name
Matthias Schmidt [Fri, 15 Jan 2021 08:37:54 +0000 (09:37 +0100)]
Improve variable name

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Wed, 6 Jan 2021 15:39:26 +0000 (16:39 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #3844 from WoltLab/fix-failing-cronjobs
Joshua Rüsweg [Wed, 6 Jan 2021 15:38:31 +0000 (16:38 +0100)]
Merge pull request #3844 from WoltLab/fix-failing-cronjobs

Fix failing cronjobs

3 years agoFix VarbinaryDatabaseTableColumn
Tim Düsterhus [Wed, 6 Jan 2021 11:18:29 +0000 (12:18 +0100)]
Fix VarbinaryDatabaseTableColumn

> Call to undefined method wcf\system\database\table\column\VarbinaryDatabaseTableColumn::traitGetLength()

see 4a65b1e27cc85fc9fb9bbcdf6a6d7a5f9cc76187

3 years agoHide article-related notification events if articles are disabled
Matthias Schmidt [Sun, 3 Jan 2021 16:20:06 +0000 (17:20 +0100)]
Hide article-related notification events if articles are disabled

Close #3845

3 years agofixup! Disable disabling of failed system cronjobs Fixes #3841
joshuaruesweg [Sun, 3 Jan 2021 16:10:32 +0000 (17:10 +0100)]
fixup! Disable disabling of failed system cronjobs Fixes #3841

3 years agoDisable disabling of failed system cronjobs
joshuaruesweg [Sat, 2 Jan 2021 15:10:37 +0000 (16:10 +0100)]
Disable disabling of failed system cronjobs
Fixes #3841

3 years agoPrevent failing cronjobs from blocking other cronjobs by executing them last
joshuaruesweg [Sat, 2 Jan 2021 15:06:56 +0000 (16:06 +0100)]
Prevent failing cronjobs from blocking other cronjobs by executing them last

3 years agoFix validation of required single media form fields
Matthias Schmidt [Mon, 28 Dec 2020 15:29:17 +0000 (16:29 +0100)]
Fix validation of required single media form fields

3 years agoImprove readability of form field template code
Matthias Schmidt [Sun, 27 Dec 2020 13:11:32 +0000 (14:11 +0100)]
Improve readability of form field template code

3 years agoFix validation of form builder node attributes
Matthias Schmidt [Sun, 27 Dec 2020 13:10:31 +0000 (14:10 +0100)]
Fix validation of form builder node attributes

Close #3827

3 years agoThrow exception for VARBINARY columns without length
Matthias Schmidt [Sun, 27 Dec 2020 12:54:55 +0000 (13:54 +0100)]
Throw exception for VARBINARY columns without length

Close #3827

3 years agoValidate column names in indices when using PHP DB API (#3832)
Matthias Schmidt [Tue, 22 Dec 2020 13:07:39 +0000 (14:07 +0100)]
Validate column names in indices when using PHP DB API (#3832)

Close  #3828

3 years agoFix case of non-existing table in DatabaseTableChangeProcessor::getColumnByName()
Matthias Schmidt [Tue, 22 Dec 2020 12:04:22 +0000 (13:04 +0100)]
Fix case of non-existing table in DatabaseTableChangeProcessor::getColumnByName()

Close #3829

3 years agoConsider package during event listeners' name validation in PIP GUI
Matthias Schmidt [Tue, 22 Dec 2020 11:59:18 +0000 (12:59 +0100)]
Consider package during event listeners' name validation in PIP GUI

Close #3831

3 years agoFix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4
Matthias Schmidt [Fri, 18 Dec 2020 18:33:23 +0000 (19:33 +0100)]
Fix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4

See #3792

3 years agoFix missing variable error in DatabaseTableChangeProcessor
Matthias Schmidt [Fri, 18 Dec 2020 18:32:51 +0000 (19:32 +0100)]
Fix missing variable error in DatabaseTableChangeProcessor

See #3792

3 years agoFix updating action of foreign key
Matthias Schmidt [Fri, 18 Dec 2020 18:26:29 +0000 (19:26 +0100)]
Fix updating action of foreign key

See c64a33b40a7e601a6005f7ca247f7d2ecb52a393

3 years agoFix hiding/showing tab menu entries due to form builder dependencies
Matthias Schmidt [Tue, 15 Dec 2020 17:19:21 +0000 (18:19 +0100)]
Fix hiding/showing tab menu entries due to form builder dependencies

3 years agoExcempt the admin panel from application overrides
Alexander Ebert [Mon, 14 Dec 2020 19:13:04 +0000 (20:13 +0100)]
Excempt the admin panel from application overrides

Fixes #3762

3 years agoMerge pull request #3799 from WoltLab/nonnull_in_primary_key
Matthias Schmidt [Sat, 12 Dec 2020 14:00:52 +0000 (15:00 +0100)]
Merge pull request #3799 from WoltLab/nonnull_in_primary_key

Validate primary indices with null columns in PHP DB API

3 years agoFix doubled validation errors for CaptchaFormField
Matthias Schmidt [Wed, 9 Dec 2020 17:42:41 +0000 (18:42 +0100)]
Fix doubled validation errors for CaptchaFormField

3 years agoValidate primary indices with null columns in PHP DB API
Matthias Schmidt [Wed, 9 Dec 2020 16:13:59 +0000 (17:13 +0100)]
Validate primary indices with null columns in PHP DB API

Close #3792

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 7 Dec 2020 20:00:11 +0000 (21:00 +0100)]
Merge branch '3.1' into 5.2

3 years agoForce the use of the attachment thumbnail if the original is inaccessible
Alexander Ebert [Mon, 7 Dec 2020 19:58:02 +0000 (20:58 +0100)]
Force the use of the attachment thumbnail if the original is inaccessible

3 years agoMerge pull request #3793 from WoltLab/style-import-permissions
Tim Düsterhus [Mon, 7 Dec 2020 15:52:12 +0000 (16:52 +0100)]
Merge pull request #3793 from WoltLab/style-import-permissions

Validate package installation permissions in StyleImportForm

3 years agoValidate package installation permissions in StyleImportForm
Tim Düsterhus [Mon, 7 Dec 2020 14:56:53 +0000 (15:56 +0100)]
Validate package installation permissions in StyleImportForm

3 years agoMerge pull request #3786 from WoltLab/like-rebuild
Joshua Rüsweg [Mon, 7 Dec 2020 12:59:44 +0000 (13:59 +0100)]
Merge pull request #3786 from WoltLab/like-rebuild

Optimize LikeRebuildDataWorker performance

3 years agoFix dependencies for single media form field
Matthias Schmidt [Sun, 6 Dec 2020 14:09:17 +0000 (15:09 +0100)]
Fix dependencies for single media form field

3 years agoSimplify selection of existing like objects in LikeRebuildDataWorker
Tim Düsterhus [Fri, 4 Dec 2020 14:59:43 +0000 (15:59 +0100)]
Simplify selection of existing like objects in LikeRebuildDataWorker

Since the previous commit it is expected that only a single objectTypeID is hit
per worker execution in the usual case, because all objects for a single
objectTypeID are processed before proceeding to the next objectTypeID. This
patch optimizes this case by sending a separate query per objectTypeID to fetch
the existing like objects instead of combining all the objects in a single
query.

This should help MySQL in optimizing the query, because the objectTypeID (which
is the first column in the UNIQUE KEY on wcf1_like_object) is fixed for a
single query and this is immediately obvious without needing to scan all the
tuples passed to the IN(…) condition.

In the general case the number of queries does not change. In the iterations
where the last objectID for an objectTypeID is reached two queries will be sent
instead of a single one. Those two combined should be more efficient that the
single old query, though.

3 years agoAllow LikeRebuildDataWorker to leverage the wcf1_like.objectTypeID key for sorting
Tim Düsterhus [Fri, 4 Dec 2020 14:52:10 +0000 (15:52 +0100)]
Allow LikeRebuildDataWorker to leverage the wcf1_like.objectTypeID key for sorting

3 years agoIgnore invalid file ids during deleting uploaded files
joshuaruesweg [Fri, 4 Dec 2020 10:33:53 +0000 (11:33 +0100)]
Ignore invalid file ids during deleting uploaded files
There can be several reasons why the files are no longer known. We can ignore this and simply return a success message so that it doesn't pop up in the frontend when unknown files are deleted.

3 years agoFix detecting images with capitalised file extensions
joshuaruesweg [Fri, 4 Dec 2020 10:23:53 +0000 (11:23 +0100)]
Fix detecting images with capitalised file extensions

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Tue, 1 Dec 2020 12:34:59 +0000 (13:34 +0100)]
Merge branch '3.1' into 5.2

3 years agoIncorrect version comparison for accessible packages
Alexander Ebert [Tue, 1 Dec 2020 12:32:47 +0000 (13:32 +0100)]
Incorrect version comparison for accessible packages

4 years agoUpdate the orphanedComments remark in package.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:18:46 +0000 (09:18 +0100)]
Update the orphanedComments remark in package.xml

4 years agoMissing check for empty object ids 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 15:11:56 +0000 (16:11 +0100)]
Missing check for empty object ids

4 years agoRelease 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 13:43:06 +0000 (14:43 +0100)]
Release 5.2.10

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 23 Nov 2020 13:36:42 +0000 (14:36 +0100)]
Merge branch '3.1' into 5.2

4 years agoRelease 3.1.18 3.1.18
Alexander Ebert [Mon, 23 Nov 2020 13:29:11 +0000 (14:29 +0100)]
Release 3.1.18

4 years agoWhitelist `iterator_count` in enterprise mode
Tim Düsterhus [Mon, 23 Nov 2020 08:27:54 +0000 (09:27 +0100)]
Whitelist `iterator_count` in enterprise mode

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sun, 22 Nov 2020 17:31:49 +0000 (18:31 +0100)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3744 from Krymonota/patch-18
Alexander Ebert [Sun, 22 Nov 2020 16:58:44 +0000 (17:58 +0100)]
Merge pull request #3744 from Krymonota/patch-18

Add missing JSDoc to `EmailSmtpTest`

4 years agoMerge pull request #3745 from Krymonota/patch-19
Alexander Ebert [Sun, 22 Nov 2020 16:58:12 +0000 (17:58 +0100)]
Merge pull request #3745 from Krymonota/patch-19

Fix JSDoc module typo in `RewriteGenerator`