H Hartley Sweeten [Mon, 12 Oct 2015 18:01:33 +0000 (11:01 -0700)]
staging: comedi: adv_pci1710: tidy up remaining PCI171x_* registers
Rename these CamelCase defines.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 18:01:32 +0000 (11:01 -0700)]
staging: comedi: adv_pci1710: tidy up control register and bits
Rename the CamelCase and use the BIT macro to define the bits.
Also, rename the associated CamelCase members of the private data.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 18:01:31 +0000 (11:01 -0700)]
staging: comedi: adv_pci1710: tidy up status register and bits
Rename the CamelCase and use the BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 18:01:30 +0000 (11:01 -0700)]
staging: comedi: adv_pci1710: tidy up multi-line comments
Reformat the multi-line comments in the kernel CodingStyle. And
refactor them to follow the normal format for comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 17:42:32 +0000 (10:42 -0700)]
staging: comedi: adl_pci9111: fix alignment issue
Use a local variable for the 'devpriv->ai_bounce_buffer' to shorten
the lines in pci9111_handle_fifo_half_full() and gix the checkpath.pl
issue about:
CHECK: Alignment should match open parenthesis
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 17:42:31 +0000 (10:42 -0700)]
staging: comedi: adl_pci9111: rename CamelCase parameters
Rename the CamelCase parameters of plx9050_interrupt_control().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 17:42:30 +0000 (10:42 -0700)]
staging: comedi: adl_pci9111: tidy up multi-line comments
Reformat the multi-line comments in the kernel CodingStyle.
Remove the unnecessary CHANGELOG information, git provided this
better.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 17:42:29 +0000 (10:42 -0700)]
staging: comedi: adl_pci9111: define a macro for the ai range bits
For aesthetics, define a macro to set the analog input range bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Mon, 12 Oct 2015 17:42:28 +0000 (10:42 -0700)]
staging: comedi: adl_pci9111: prefer using the BIT macro
As suggested by checkpatch.pl, use the BIT macro to define the
register bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Tue, 13 Oct 2015 13:03:42 +0000 (16:03 +0300)]
staging: lustre: add a blank line after function/struct/union/enum declarations
Fixes checkpatch.pl CHECK:LINE_SPACING: Please use a blank line after
function/struct/union/enum declarations
The patch is generated using checkpatch.pl --fix-inplace:
for f in $(find drivers/staging/lustre/ -type f) ; do
./scripts/checkpatch.pl --types "LINE_SPACING" --fix-inplace -f $f
done
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Tue, 13 Oct 2015 13:03:41 +0000 (16:03 +0300)]
staging: lustre: remove multiple blank lines
Fixes checkpatch.pl CHECK:LINE_SPACING: Please don't use multiple blank
lines.
The patch is generated using checkpatch.pl --fix-inplace:
for f in $(find drivers/staging/lustre/ -type f) ; do
./scripts/checkpatch.pl --types "LINE_SPACING" --test-only=multiple \
--fix-inplace -f $f
done
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Tue, 13 Oct 2015 13:03:40 +0000 (16:03 +0300)]
staging: lustre: add missing blank line after declarations
Fixes checkpatch.pl WARNING:LINE_SPACING: Missing a blank line after
declarations.
The patch is generated using checkpatch.pl --fix-inplace:
for f in $(find drivers/staging/lustre/ -type f) ; do
./scripts/checkpatch.pl --types "LINE_SPACING" --test-only=Missing \
--fix-inplace -f $f
done
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Tue, 13 Oct 2015 17:09:21 +0000 (19:09 +0200)]
Staging: rtl8723au: Use snprintf instead rsprintf
Macro rsprintf is useless, remove it and use existing function
snprintf instead.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Tue, 13 Oct 2015 17:08:03 +0000 (19:08 +0200)]
Staging: comedi: dt9812: Use mutex instead of semaphore
Replace binary semaphore with mutex. Mutex also gives better performance
than semaphore.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 13 Oct 2015 16:50:28 +0000 (22:20 +0530)]
Staging: lustre: lov: Remove unused #include header file
Remove lclient.h header since it is not used.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 13 Oct 2015 15:37:49 +0000 (21:07 +0530)]
Staging: most: Remove exceptional & on function name
In this file, function names are otherwise used as pointers without &.
A simplified version of the Coccinelle semantic patch that makes this
change is as follows:
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 13 Oct 2015 15:37:48 +0000 (21:07 +0530)]
Staging: iio: Remove exceptional & on function name
In this file, function names are otherwise used as pointers without &.
A simplified version of the Coccinelle semantic patch that makes this
change is as follows:
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 13 Oct 2015 15:37:47 +0000 (21:07 +0530)]
Staging: comedi: Remove exceptional & on function name
n this file, function names are otherwise used as pointers without &.
A simplified version of the Coccinelle semantic patch that makes this
change is as follows:
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Tue, 13 Oct 2015 13:21:10 +0000 (18:51 +0530)]
staging: lustre: llite: Remove useless cast on void pointer
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Tue, 13 Oct 2015 13:20:18 +0000 (18:50 +0530)]
staging: lustre: llite: Remove useless cast on void pointer
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Tue, 13 Oct 2015 11:34:48 +0000 (17:04 +0530)]
Staging: wilc1000: wilc_wlan: Remove unnecessary cast
Remove cast which is not required.
Semantic patch used:
@@
type T;
T e;
identifier x;
@@
* T x = (T)e;
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Tue, 13 Oct 2015 09:48:38 +0000 (15:18 +0530)]
Staging: wilc1000: wilc_wfi_cfgoperations: Remove unused code
Remove the declaration, initialization and statement having a
variable that is not used anywhere in the code.
Semantic patch used:
@@
type T;
identifier i;
constant C;
position p != e.p;
@@
- T i@p;
<+... when != i
- i = C;
...+>
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:11 +0000 (20:02 +0900)]
staging: wilc1000: rename u32Length of struct rcvd_net_info
This patch renames u32Length of struct rcvd_net_info to len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:10 +0000 (20:02 +0900)]
staging: wilc1000: rename pu8Buffer of struct rcvd_net_info
This patch renames pu8Buffer of struct rcvd_net_info to buffer to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:09 +0000 (20:02 +0900)]
staging: wilc1000: rename au8IPAddr of struct set_ip_addr
This patch renames au8IPAddr of struct set_ip_addr to ip_addr to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:08 +0000 (20:02 +0900)]
staging: wilc1000: rename u32Timeout of struct power_mgmt_param
This patch renames u32Timeout of struct power_mgmt_param to timeout to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:07 +0000 (20:02 +0900)]
staging: wilc1000: rename bIsEnabled of struct power_mgmt_param
This patch renames bIsEnabled of struct power_mgmt_param to enabled to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:06 +0000 (20:02 +0900)]
staging: wilc1000: rename au8MacAddr of struct del_sta
This patch renames au8MacAddr of struct del_sta to mac_addr to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:05 +0000 (20:02 +0900)]
staging: wilc1000: rename u32count of struct set_multicast
This patch renames u32count of struct set_multicast to cnt to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 11:02:04 +0000 (20:02 +0900)]
staging: wilc1000: rename bIsEnabled of struct set_multicast
This patch renames bIsEnabled of struct set_multicast to enabled to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:10 +0000 (19:50 +0900)]
staging: wilc1000: rename u8Num_AssocSta of struct del_all_sta
This patch renames u8Num_AssocSta of struct del_all_sta to assoc_sta to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:09 +0000 (19:50 +0900)]
staging: wilc1000: rename au8Sta_DelAllSta of struct del_all_sta
This patch renames au8Sta_DelAllSta of struct del_all_sta to del_all_sta to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:08 +0000 (19:50 +0900)]
staging: wilc1000: rename pu8Tail of struct beacon_attr
This patch renames pu8Tail of struct beacon_attr to tail to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:07 +0000 (19:50 +0900)]
staging: wilc1000: rename u32TailLen of struct beacon_attr
This patch renames u32TailLen of struct beacon_attr to tail_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:06 +0000 (19:50 +0900)]
staging: wilc1000: rename pu8Head of struct beacon_attr
This patch renames pu8Head of struct beacon_attr to head to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:05 +0000 (19:50 +0900)]
staging: wilc1000: rename u32HeadLen of struct beacon_attr
This patch renames u32HeadLen of struct beacon_attr to head_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:04 +0000 (19:50 +0900)]
staging: wilc1000: rename u32DTIMPeriod of struct beacon_attr
This patch renames u32DTIMPeriod of struct beacon_attr to dtim_period to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:03 +0000 (19:50 +0900)]
staging: wilc1000: rename u32Interval of struct beacon_attr
This patch renames u32Interval of struct beacon_attr to interval to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:02 +0000 (19:50 +0900)]
staging: wilc1000: rename u8SetChan of struct channel_attr
This patch renames u8SetChan of struct channel_attr to set_ch to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:01 +0000 (19:50 +0900)]
staging: wilc1000: rename u32Length of struct rcvd_async_info
This patch renames u32Length of struct rcvd_async_info to len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:50:00 +0000 (19:50 +0900)]
staging: wilc1000: rename pu8Buffer of struct rcvd_async_info
This patch renames pu8Buffer of struct rcvd_async_info to buffer to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:59 +0000 (19:49 +0900)]
staging: wilc1000: rename pJoinParams of struct connect_attr
This patch renames pJoinParams of struct connect_attr to params to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:58 +0000 (19:49 +0900)]
staging: wilc1000: rename u8channel of struct connect_attr
This patch renames u8channel of struct connect_attr to ch to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:57 +0000 (19:49 +0900)]
staging: wilc1000: rename tenuAuth_type of struct connect_attr
This patch renames tenuAuth_type of struct connect_attr to auth_type to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:56 +0000 (19:49 +0900)]
staging: wilc1000: rename pvUserArg of struct connect_attr
This patch renames pvUserArg of struct connect_attr to arg to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:55 +0000 (19:49 +0900)]
staging: wilc1000: rename pfConnectResult of struct connect_attr
This patch renames pfConnectResult of struct connect_attr to result to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:54 +0000 (19:49 +0900)]
staging: wilc1000: rename u8security of struct connect_attr
This patch renames u8security of struct connect_attr to security to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:53 +0000 (19:49 +0900)]
staging: wilc1000: rename IEsLen of struct connect_attr
This patch renames IEsLen of struct connect_attr to ies_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:52 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8IEs of struct connect_attr
This patch renames pu8IEs of struct connect_attr to ies to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:51 +0000 (19:49 +0900)]
staging: wilc1000: rename ssidLen of struct connect_attr
This patch renames ssidLen of struct connect_attr to ssid_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:50 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8ssid of struct connect_attr
This patch renames pu8ssid of struct connect_attr to ssid to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:49 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8bssid of struct connect_attr
This patch renames pu8bssid of struct connect_attr to bssid to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:48 +0000 (19:49 +0900)]
staging: wilc1000: remove duplicate copy routine
This patch remove the duplicate bssid copy routine.
Already ahead bssid copy routine execute.
Therefore do not necessary in this routine.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:47 +0000 (19:49 +0900)]
staging: wilc1000: fix "ERROR: do not initialise globals to 0 or NULL"
This patch fixes the checkpatch.pl error to host_interface.c.
- ERROR: do not initialise globals to 0 or NULL
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:46 +0000 (19:49 +0900)]
staging: wilc1000: rename strHiddenNetwork of struct scan_attr
This patch renames strHiddenNetwork of struct scan_attr to hidden_network to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:45 +0000 (19:49 +0900)]
staging: wilc1000: rename pvUserArg of struct scan_attr
This patch renames pvUserArg of struct scan_attr to arg to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:44 +0000 (19:49 +0900)]
staging: wilc1000: rename pfScanResult of struct scan_attr
This patch renames pfScanResult of struct scan_attr to result to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:43 +0000 (19:49 +0900)]
staging: wilc1000: rename IEsLen of struct scan_attr
This patch renames IEsLen of struct scan_attr to ies_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:42 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8IEs of struct scan_attr
This patch renames pu8IEs of struct scan_attr to ies to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:41 +0000 (19:49 +0900)]
staging: wilc1000: rename u8ChnlListLen of struct scan_attr
This patch renames u8ChnlListLen of struct scan_attr to ch_list_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:40 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8ChnlFreqList of struct scan_attr
This patch renames pu8ChnlFreqList of struct scan_attr to ch_freq_list to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:39 +0000 (19:49 +0900)]
staging: wilc1000: remove duplicate null check routine
This patch removes the duplicate null check routine. The same null check
routine is twice executed. Therefore the duplicated routine is not necessary.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:38 +0000 (19:49 +0900)]
staging: wilc1000: rename u8ScanType of struct scan_attr
This patch renames u8ScanType of struct scan_attr to type to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:37 +0000 (19:49 +0900)]
staging: wilc1000: rename u8ScanSource of struct scan_attr
This patch renames u8ScanSource of struct scan_attr to src to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:36 +0000 (19:49 +0900)]
staging: wilc1000: rename u8Ciphermode of struct host_if_wpa_attr
This patch renames u8Ciphermode of struct host_if_wpa_attr to mode to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:35 +0000 (19:49 +0900)]
staging: wilc1000: rename u8Keylen of struct host_if_wpa_attr
This patch renames u8Keylen of struct host_if_wpa_attr to key_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:34 +0000 (19:49 +0900)]
staging: wilc1000: rename u8keyidx of struct host_if_wpa_attr
This patch renames u8keyidx of struct host_if_wpa_attr to index to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:33 +0000 (19:49 +0900)]
staging: wilc1000: rename u8seqlen of struct host_if_wpa_attr
This patch renames u8seqlen of struct host_if_wpa_attr to seq_len to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:32 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8seq of struct host_if_wpa_attr
This patch renames pu8seq of struct host_if_wpa_attr to seq to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:31 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8macaddr of struct host_if_wpa_attr
This patch renames pu8macaddr of struct host_if_wpa_attr to mac_addr to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:30 +0000 (19:49 +0900)]
staging: wilc1000: rename pu8key of struct host_if_wpa_attr
This patch renames pu8key of struct host_if_wpa_attr to key to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:29 +0000 (19:49 +0900)]
staging: wilc1000: rename uniHostIFkeyAttr of struct key_attr
This patch renames uniHostIFkeyAttr of struct key_attr to attr to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:28 +0000 (19:49 +0900)]
staging: wilc1000: rename u8KeyAction of struct key_attr
This patch renames u8KeyAction of struct key_attr to action to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:27 +0000 (19:49 +0900)]
staging: wilc1000: rename enuKeyType of struct key_attr
This patch renames enuKeyType of struct key_attr to type to
avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 13 Oct 2015 10:49:26 +0000 (19:49 +0900)]
staging: wilc1000: host_interface.c : remove over-commenting
There are over-commenting in the host_interface.c file and most of them
are not helpful to explain what the code does and generate 80 ending
line over warnings. So, all of comments are removed in this patch and the
comments will later be added if necessary with the preferred Linux style.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Tue, 13 Oct 2015 15:20:23 +0000 (20:50 +0530)]
Staging: unisys: visorinput: Remove unused code
Remove the code which is not used anywhere in the program.
Semantic patch used:
@@
type T;
identifier i;
constant C;
position p != e.p;
@@
- T i@p;
<+... when != i
- i = C;
...+>
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Tue, 13 Oct 2015 15:37:23 +0000 (11:37 -0400)]
staging: unisys: vmcallinterface.h: convert pragma to __packed
Convert from pragma to __packed
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 9 Oct 2015 18:53:49 +0000 (11:53 -0700)]
staging: comedi: adq12b: usleep_range is preferred over udelay
Fix checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt
Replace the udelay() with usleep_range() with a reasonable upper limit.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 9 Oct 2015 18:53:48 +0000 (11:53 -0700)]
staging: comedi: adq12b: prefer using the BIT macro
As suggested by checkpatch.pl, use the BIT macro to define the
register bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 9 Oct 2015 18:53:47 +0000 (11:53 -0700)]
staging: comedi: adq12b: tidy up multi-line comments
Reformat the multi-line comments in the kernel CodingStyle. And
refactor them to follow the normal format for comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:29 +0000 (10:48 -0700)]
staging: comedi: dt3000: update the MODULE_DESCRIPTION
Change the MODULE_DESCRIPTION to something more ueeful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:28 +0000 (10:48 -0700)]
staging: comedi: dt3000: remove #if 0'ed out code
Replace the disabled code in dt3k_dio_config() with a comment in case
it's actually needed.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:27 +0000 (10:48 -0700)]
staging: comedi: dt3000: tidy up memory subdevice init
Remove the unnecessary 'len_chanlist' initialization. This member is
only used by subdevices that support async commands.
For aesthetics, reorder the initialization a bit.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:26 +0000 (10:48 -0700)]
staging: comedi: dt3000: tidy up digital i/o subdevice init
Remove the unnecessary 'len_chanlist' initialization. This member is
only used by subdevices that support async commands.
For aesthetics, reorder the initialization a bit.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:25 +0000 (10:48 -0700)]
staging: comedi: dt3000: rename dt3k_ai_insn()
For aesthetics, rename this subdevice (*insn_read) function to follow
the normal naming in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:24 +0000 (10:48 -0700)]
staging: comedi: dt3000: the dt3002 board does not have analog outputs
According to the boardinfo, the dt3002 board does not have analog outputs.
The rest of the board have two 12-bit analog output channels.
Replace the 'dachan' and 'dabits' members of the boardinfo with a bit-
field flag 'has_ao'. Use the new member to conditionally initialize
the analog output subdevice.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:23 +0000 (10:48 -0700)]
staging: comedi: dt3000: refactor 'adbits' boardinfo
All the board supported by this driver have analog inputs. The input
resolution is either 12-bit or 16-bit.
Replace the 'adbits' member of the boardinfo with a bit-field flag
'ai_is_16bits' and just set if for the 16-bit boards.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:22 +0000 (10:48 -0700)]
staging: comedi: dt3000: remove proc subdevice
This subdevice is not allocated or defined in the driver. Remove the
disabled subdevice initialization.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:21 +0000 (10:48 -0700)]
staging: comedi: dt3000: tidy up remaining defines
Move the remaining defines and prefix them with 'DPR_' for consistency.
Define a macro to set the analog input trigger bits to fix the
checkpatch.pl issues about:
CHECK: spaces preferred around that '<<' (ctx:VxV)
CHECK: Prefer using the BIT macro
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:20 +0000 (10:48 -0700)]
staging: comedi: dt3000: rename the interrupt flag defines
For aesthetics, rename these defines so they have association
with the register. Move them closer to the register define and
use the BIT macro to define them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:19 +0000 (10:48 -0700)]
staging: comedi: dt3000: rename the SUBS_* defines
For aesthetics, rename these defines to avoid any confusion with the
similar comedi defines. Move them closer to the register they are
associated with.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:18 +0000 (10:48 -0700)]
staging: comedi: dt3000: tidy up the command mailbox defines
For aesthetics, rename these defines so they are associated with
the register. Move the defines closer to the register define.
Define some macros for the "completion" and "cmd" bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:17 +0000 (10:48 -0700)]
staging: comedi: dt3000: rename dual-ported RAM location defines
Rename these CamelCase defines and fix the checkpatch.pl issues:
CHECK: Avoid CamelCase: <DPR_{various}>
CHECK: spaces preferred around that '*' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
For aesthetics, move the defines to after the includes.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:48:16 +0000 (10:48 -0700)]
staging: comedi: dt3000: tidy up multi-line comments
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 9 Oct 2015 18:09:35 +0000 (11:09 -0700)]
staging: comedi: adl_pci9118: rename Compute_and_setup_dma()
Rename this CamelCase function.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 9 Oct 2015 18:09:34 +0000 (11:09 -0700)]
staging: comedi: adl_pci9118: prefer using the BIT macro
As suggested by checkpatch.pl, use the BIT macro to define the
register bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 9 Oct 2015 17:47:45 +0000 (10:47 -0700)]
staging: comedi: addi_apci_2032: document the spinlock_t definition
Add some comments to the private data tp quiet the checkpatch.pl
issue about:
CHECK: spinlock_t definition without comment
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 9 Oct 2015 17:47:44 +0000 (10:47 -0700)]
staging: comedi: addi_apci_2032: prefer using the BIT macro
As suggested by checkpatch.pl, use the BIT macro to define the
register bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:30:45 +0000 (10:30 -0700)]
staging: comedi: ii_pci20kc: update the MODULE_DESCRIPTION
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 8 Oct 2015 17:30:44 +0000 (10:30 -0700)]
staging: comedi: ii_pci20kc: use comedi_offset_munge()
For aesthetics, use the helper function to handle the munging of the
analog output data from offset binary to 2's complement and the analog
input data from 2's complement to offset binary.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / log