GitHub/LineageOS/android_kernel_motorola_exynos9610.git
12 years ago[media] stkwebcam: Fix sparse warning on undeclared symbol
Ezequiel Garcia [Thu, 1 Nov 2012 11:42:00 +0000 (08:42 -0300)]
[media] stkwebcam: Fix sparse warning on undeclared symbol

The sparse warning is:
"drivers/media/usb/stkwebcam/stk-webcam.c:59:5:
warning: symbol 'first_init' was not declared. Should it be static?"
Declare variable 'first_init' as static and local to the function.
Found by Hans Verkuil's daily build. Tested by compilation only.

Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add entries for some RC devices
Sean Young [Mon, 19 Nov 2012 13:32:53 +0000 (10:32 -0300)]
MAINTAINERS: add entries for some RC devices

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: Add entry for Davinci video drivers
Lad, Prabhakar [Mon, 19 Nov 2012 08:48:21 +0000 (05:48 -0300)]
MAINTAINERS: Add entry for Davinci video drivers

This patch adds an entry in MAINTAINERS file for
TI Davinci media drivers.

Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add an entry for radio-mr800 driver
Alexey Klimov [Fri, 16 Nov 2012 20:43:59 +0000 (17:43 -0300)]
MAINTAINERS: add an entry for radio-mr800 driver

This patch adds MAINTAINERS entry for radio-mr800 usb radio driver.

Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: Add entry for S3C24XX/S3C64XX SoC CAMIF driver
Sylwester Nawrocki [Thu, 15 Nov 2012 21:05:15 +0000 (18:05 -0300)]
MAINTAINERS: Add entry for S3C24XX/S3C64XX SoC CAMIF driver

Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: Update maintainer for smiapp and adp1653 drivers
Sakari Ailus [Mon, 12 Nov 2012 21:14:39 +0000 (18:14 -0300)]
MAINTAINERS: Update maintainer for smiapp and adp1653 drivers

And the smiapp-pll which is in a way part of the smiapp driver.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] media:davinci: clk - {prepare/unprepare} for common clk
Murali Karicheri [Mon, 22 Oct 2012 14:41:36 +0000 (11:41 -0300)]
[media] media:davinci: clk - {prepare/unprepare} for common clk

As a first step towards migrating davinci platforms to use common clock
framework, replace all instances of clk_enable() with clk_prepare_enable()
and clk_disable() with clk_disable_unprepare().
Also fixes some issues related to clk clean up in the driver

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Tested-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] media: davinci: vpbe: set device capabilities
Lad, Prabhakar [Mon, 22 Oct 2012 12:27:14 +0000 (09:27 -0300)]
[media] media: davinci: vpbe: set device capabilities

set device_caps and also change the driver and
bus_info to proper values as per standard.

Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] media: davinci: vpbe: migrate driver to videobuf2
Lad, Prabhakar [Mon, 22 Oct 2012 12:27:13 +0000 (09:27 -0300)]
[media] media: davinci: vpbe: migrate driver to videobuf2

This patch migrates VPBE display driver to videobuf2 framework.

Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] media: davinci: vpbe: fix build warning
Lad, Prabhakar [Fri, 9 Nov 2012 08:59:32 +0000 (05:59 -0300)]
[media] media: davinci: vpbe: fix build warning

Warnings were generated because of the following commit changed data type for
address pointer
195bbca ARM: 7500/1: io: avoid writeback addressing modes for __raw_ accessors
add  __iomem annotation to fix following warnings
drivers/media/platform/davinci/vpbe_osd.c: In function ‘osd_read’:
drivers/media/platform/davinci/vpbe_osd.c:49:2: warning: passing
 argument 1 of ‘__raw_readl’ makes pointer from integer without a cast [enabled by default]
arch/arm/include/asm/io.h:104:19: note: expected ‘const volatile
 void *’ but argument is of type ‘long unsigned int’
This patch stores the ioremap_nocache() returned address in a
void __iomem * instead of a unsigned long and passes the same to
readl/writel functions which fixes the above warnings.

Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] v4l, smiapp, smiapp-pll, adp1653: Update contact information
Sakari Ailus [Sun, 28 Oct 2012 09:44:17 +0000 (06:44 -0300)]
[media] v4l, smiapp, smiapp-pll, adp1653: Update contact information

Update contact information to correspond my e-mail address changes.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] staging/media: Use dev_ printks in go7007/go7007-fw.c
YAMANE Toshiaki [Mon, 5 Nov 2012 10:38:46 +0000 (07:38 -0300)]
[media] staging/media: Use dev_ printks in go7007/go7007-fw.c

fixed below checkpatch warning.
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] staging/media: Use dev_ or pr_ printks in go7007/wis-saa7113.c
YAMANE Toshiaki [Mon, 5 Nov 2012 10:38:12 +0000 (07:38 -0300)]
[media] staging/media: Use dev_ or pr_ printks in go7007/wis-saa7113.c

fixed below checkpatch warnings.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] Staging/media: fixed spacing coding style in go7007/wis-saa7113.c
YAMANE Toshiaki [Mon, 5 Nov 2012 10:36:48 +0000 (07:36 -0300)]
[media] Staging/media: fixed spacing coding style in go7007/wis-saa7113.c

fixed below checkpatch error.
- ERROR: that open brace { should be on the previous line

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] staging/media: Use dev_ or pr_ printks in go7007/wis-saa7115.c
YAMANE Toshiaki [Mon, 5 Nov 2012 10:36:26 +0000 (07:36 -0300)]
[media] staging/media: Use dev_ or pr_ printks in go7007/wis-saa7115.c

fixed below checkpatch warnings.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] Staging/media: fixed spacing coding style in go7007/wis-saa7115.c
YAMANE Toshiaki [Mon, 5 Nov 2012 10:35:45 +0000 (07:35 -0300)]
[media] Staging/media: fixed spacing coding style in go7007/wis-saa7115.c

fixed below checkpatch error.
- ERROR: that open brace { should be on the previous line

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] Staging/media: Use dev_ printks in go7007/wis-ov7640.c
YAMANE Toshiaki [Fri, 2 Nov 2012 11:09:29 +0000 (08:09 -0300)]
[media] Staging/media: Use dev_ printks in go7007/wis-ov7640.c

fixed below checkpatch warnings.
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] Staging/media: fixed spacing coding style in go7007/wis-ov7640.c
YAMANE Toshiaki [Fri, 2 Nov 2012 11:08:41 +0000 (08:08 -0300)]
[media] Staging/media: fixed spacing coding style in go7007/wis-ov7640.c

fixed below checkpatch error.
- ERROR: that open brace { should be on the previous line

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] gspca-sonixb: Add USB-id for Genius Eye 310
Hans de Goede [Sun, 4 Nov 2012 20:12:10 +0000 (17:12 -0300)]
[media] gspca-sonixb: Add USB-id for Genius Eye 310

Reported through:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1046608
https://bugzilla.kernel.org/show_bug.cgi?id=48111

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] MAINTAINERS: Add an entry for the pwc webcam driver
Hans de Goede [Sun, 4 Nov 2012 20:05:59 +0000 (17:05 -0300)]
[media] MAINTAINERS: Add an entry for the pwc webcam driver

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] MAINTAINERS: Add entries for the radioShark and radioShark2 drivers
Hans de Goede [Sun, 4 Nov 2012 20:03:58 +0000 (17:03 -0300)]
[media] MAINTAINERS: Add entries for the radioShark and radioShark2 drivers

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] pwc: Fix codec1 cameras no longer working
Hans de Goede [Mon, 8 Oct 2012 09:05:24 +0000 (06:05 -0300)]
[media] pwc: Fix codec1 cameras no longer working

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] gspca_pac7302: use registers 0x01 and 0x03 for red and blue balance controls
Frank Schäfer [Sun, 23 Sep 2012 13:29:43 +0000 (10:29 -0300)]
[media] gspca_pac7302: use registers 0x01 and 0x03 for red and blue balance controls

Currently used registers 0xc5 and 0xc7 provide only a very coarse
adjustment possibility within a very small value range (0-3).
With registers 0x01 and 0x03, a fine grained adjustment with
255 steps is possible. This is also what the Windows driver does.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] gspca_pac7302: correct register documentation
Frank Schäfer [Sun, 23 Sep 2012 13:29:42 +0000 (10:29 -0300)]
[media] gspca_pac7302: correct register documentation

R,G,B balance registers are 0x01-0x03 instead of 0x02-0x04,
which lead to the wrong conclusion that values are inverted.
Exposure is controlled via page 3 registers and this is already documented.
Also fix a whitespace issue.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] stk1160: Try to continue with fewer transfer buffers
Ezequiel Garcia [Wed, 24 Oct 2012 00:20:30 +0000 (21:20 -0300)]
[media] stk1160: Try to continue with fewer transfer buffers

Many people are trying to use stk1160 on low memory devices.
Instead of failing if one allocation fails, we allow the driver
to continue working if fewer transfer buffers are available.

Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] vivi: Kill TSTAMP_* macros
Kirill Smelkov [Tue, 23 Oct 2012 16:07:55 +0000 (13:07 -0300)]
[media] vivi: Kill TSTAMP_* macros

Usage of TSTAMP_* macros has gone in 2010 in 730947bc (V4L/DVB: vivi:
clean up and a major overhaul) but the macros remain. Say goodbye to
them.

Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] siano: fix build with allmodconfig
Mauro Carvalho Chehab [Tue, 13 Nov 2012 13:06:28 +0000 (11:06 -0200)]
[media] siano: fix build with allmodconfig

As reported by Stephen:

After merging the v4l-dvb tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "sms_ir_exit" [drivers/media/common/siano/smsmdtv.ko] undefined!
ERROR: "sms_ir_event" [drivers/media/common/siano/smsmdtv.ko] undefined!
ERROR: "sms_ir_init" [drivers/media/common/siano/smsmdtv.ko] undefined!

The smsir file should be part of the smsmdtv core, if RC is defined.
Fix it.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] siano: fix RC compilation
Mauro Carvalho Chehab [Wed, 7 Nov 2012 10:09:08 +0000 (11:09 +0100)]
[media] siano: fix RC compilation

As reported by Antti and by Stephen:
drivers/built-in.o: In function `sms_ir_event':
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:48: undefined reference to `ir_raw_event_store'
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:50: undefined reference to `ir_raw_event_handle'
drivers/built-in.o: In function `sms_ir_init':
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:56: undefined reference to `smscore_get_board_id'
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:60: undefined reference to `rc_allocate_device'
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:72: undefined reference to `sms_get_board'
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:92: undefined reference to `sms_get_board'
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:97: undefined reference to `rc_register_device'
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:100: undefined reference to `rc_free_device'
drivers/built-in.o: In function `sms_ir_exit':
/home/david/checkouts/linux/drivers/media/common/siano/smsir.c:111: undefined reference to `rc_unregister_device'
make: *** [vmlinux] Error 1

Caused by commit fdd1eeb49d36 "[media] siano: allow compiling it without RC support"
And it happens when CONFIG_SMS_SIANO_RC=y and CONFIG_RC_CORE=m .

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] add MAINTAINERS entry for a few dvb files
Malcolm Priestley [Sun, 4 Nov 2012 18:16:31 +0000 (19:16 +0100)]
[media] add MAINTAINERS entry for a few dvb files

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] firedtv: add MAINTAINERS entry
Stefan Richter [Sat, 3 Nov 2012 08:25:20 +0000 (09:25 +0100)]
[media] firedtv: add MAINTAINERS entry

There is currently discussion to add MAINTAINERS records for media
drivers that don't have one yet, possibly with 'orphan' or 'odd fixes'
status.  Here is a proper entry for the firedtv driver (for 1394
attached DVB STBs and 1394 attached DVB cards from Digital Everywhere).

The L: linux-media and T: linux-media.git lines in this entry are
redundant to what scripts/get_maintainer.pl would show automatically but
I added them for folks who read MAINTAINERS directly.  The "(firedtv)"
string is for those folks as well if they look for driver name rather
than file path.

The F: drivers/media/firewire/ pattern and the "FireWire media drivers"
title are currently synonymous with firedtv.  If more drivers get added
there, this can be revisited.

I don't have documentation or DVB-S2 devices to test, but I have DVB-C
and DVB-T devices for testing.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add support for tea5761/tea5767 tuners
Mauro Carvalho Chehab [Fri, 2 Nov 2012 14:09:00 +0000 (12:09 -0200)]
MAINTAINERS: add support for tea5761/tea5767 tuners

Those two tuners were always maintained. As I have devices with
tea5767, this is marked as Maintained.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add an entry for tuner-xc2028 driver
Mauro Carvalho Chehab [Fri, 2 Nov 2012 14:05:07 +0000 (12:05 -0200)]
MAINTAINERS: add an entry for tuner-xc2028 driver

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add an entry for az6007 DVB driver
Mauro Carvalho Chehab [Fri, 2 Nov 2012 14:00:30 +0000 (12:00 -0200)]
MAINTAINERS: add an entry for az6007 DVB driver

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: fix/add missing uapi entries for media files
Mauro Carvalho Chehab [Fri, 2 Nov 2012 13:56:03 +0000 (11:56 -0200)]
MAINTAINERS: fix/add missing uapi entries for media files

The uapi patches forgot to update the MAINTAINERS entries.
Fix them and add missing entries.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add an explicit entry for tm6000
Mauro Carvalho Chehab [Fri, 2 Nov 2012 13:41:01 +0000 (11:41 -0200)]
MAINTAINERS: add an explicit entry for tm6000

While this file was always maintained, there was no explicit entry
for it.

There aren't many things happening at tm6000 side for a long time:
Driver works. This chip is already not sold anymore, so I don't
expect much changes on its side.

So, add a new entry with status equal to Odd fixes to better
reflect it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add an explicit entry for em28xx
Mauro Carvalho Chehab [Fri, 2 Nov 2012 13:38:23 +0000 (11:38 -0200)]
MAINTAINERS: add an explicit entry for em28xx

While this file was always maintained, there was no explicit entry
for it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add an explicit entry for saa7134
Mauro Carvalho Chehab [Fri, 2 Nov 2012 13:34:14 +0000 (11:34 -0200)]
MAINTAINERS: add an explicit entry for saa7134

While this file was always maintained, there was no explicit entry
for it.

There aren't many things happening at saa7134 side for a long time:
Driver works, and it is stable. When new patches are submitted,
they're new boards addition for hardware I don't have.

So, add a new entry with status equal to Odd fixes to better
reflect it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: add an explicit entry for cx88
Mauro Carvalho Chehab [Fri, 2 Nov 2012 13:33:44 +0000 (11:33 -0200)]
MAINTAINERS: add an explicit entry for cx88

While this file was always maintained, there was no explicit entry
for it.

There aren't many things happening at cx88 side for a long time:
Driver works, and it is stable. When new patches are submitted,
they're new boards addition for hardware I don't have.

So, add a new entry with status equal to Odd fixes to better
reflect it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoMAINTAINERS: change BTTV status to Odd fixes
Mauro Carvalho Chehab [Fri, 2 Nov 2012 13:14:18 +0000 (11:14 -0200)]
MAINTAINERS: change BTTV status to Odd fixes

There aren't many things happening at bttv side for a long time:
Driver works, and it is stable. When new patches are submitted,
they're new boards addition for hardware I don't have. So,
move its status to Odd fixes to better reflect it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] hid-picolcd_cir: fix compilation
David Härdeman [Wed, 31 Oct 2012 07:22:08 +0000 (04:22 -0300)]
[media] hid-picolcd_cir: fix compilation

Commit c003ab1bedf0 ("[media] rc-core: add separate defines for
protocol bitmaps and numbers") overlooked hid-picolcd.
This patch (against git.linuxtv.org/media_tree.git, branch
staging/for_v3.8) fixes the compilation breakage.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] smiapp-pll: Constify limits argument to smiapp_pll_calculate()
Laurent Pinchart [Mon, 22 Oct 2012 14:40:57 +0000 (11:40 -0300)]
[media] smiapp-pll: Constify limits argument to smiapp_pll_calculate()

The limits are input parameters and should not be modified by the
smiapp_pll_calculate() function. Make them const.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] smiapp-pll: Create a structure for OP and VT limits
Laurent Pinchart [Mon, 22 Oct 2012 14:40:56 +0000 (11:40 -0300)]
[media] smiapp-pll: Create a structure for OP and VT limits

OP and VT limits have identical fields, create a shared structure for
both.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] smiapp-pll: Parallel bus support
Sakari Ailus [Sat, 20 Oct 2012 13:35:25 +0000 (10:35 -0300)]
[media] smiapp-pll: Parallel bus support

Support sensors with parallel interface.
Make smiapp_pll.flags also 8-bit so it fits nicely into two 32-bit words
with the other 8-bit fields.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] smiapp: Input for PLL configuration is mostly static
Sakari Ailus [Sat, 20 Oct 2012 13:17:02 +0000 (10:17 -0300)]
[media] smiapp: Input for PLL configuration is mostly static

The input values for PLL configuration are mostly static. So set them when
the sensor is registered.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] smiapp-pll: Try other pre-pll divisors
Sakari Ailus [Mon, 22 Oct 2012 19:27:27 +0000 (16:27 -0300)]
[media] smiapp-pll: Try other pre-pll divisors

The smiapp pll calculator assumed that the minimum pre-pll divisor was
perfect. That may not always be the case, so let's try the others, too.
Typically there are just a few alternatives.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] smiapp-pll: Correct type for min_t()
Sakari Ailus [Sat, 20 Oct 2012 12:08:22 +0000 (09:08 -0300)]
[media] smiapp-pll: Correct type for min_t()

Unsigned.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] smiapp-pll: Add missing trailing newlines to warning messages
Laurent Pinchart [Thu, 18 Oct 2012 13:31:44 +0000 (10:31 -0300)]
[media] smiapp-pll: Add missing trailing newlines to warning messages

Two warning messages are missing a trailing newline. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] xc4000: Fix a few warnings
Mauro Carvalho Chehab [Mon, 29 Oct 2012 10:02:31 +0000 (08:02 -0200)]
[media] xc4000: Fix a few warnings

drivers/media/tuners/xc4000.c: In function ‘check_firmware’:
drivers/media/tuners/xc4000.c:1048:45: warning: ‘fw_minor’ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/media/tuners/xc4000.c:1048:39: warning: ‘fw_major’ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/media/tuners/xc4000.c:1062:39: warning: ‘hw_minor’ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/media/tuners/xc4000.c:1062:33: warning: ‘hw_major’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] drxk_hard: fix the return code from an error handler
Mauro Carvalho Chehab [Mon, 29 Oct 2012 09:58:59 +0000 (07:58 -0200)]
[media] drxk_hard: fix the return code from an error handler

While it is very unlikely, if the number of parameters for
QAMDemodulatorCommand is not 2 or 4, status become undefined:

/home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c: In function ‘QAMDemodulatorCommand’:
/home/hans/work/build/v4l-dvb-git/drivers/media/dvb-frontends/drxk_hard.c:5452:5: warning: ‘status’ may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] mem2mem: replace BUG_ON with WARN_ON
Nicolas THERY [Tue, 23 Oct 2012 07:47:19 +0000 (04:47 -0300)]
[media] mem2mem: replace BUG_ON with WARN_ON

See following thread for rationale:
http://www.spinics.net/lists/linux-media/msg52462.html
Tested by compilation only.

Signed-off-by: Nicolas Thery <nicolas.thery@st.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] v4l2: Fix typo in struct v4l2_captureparm description
Kirill Smelkov [Mon, 22 Oct 2012 17:14:01 +0000 (14:14 -0300)]
[media] v4l2: Fix typo in struct v4l2_captureparm description

Judging from what drivers do and from my experience temeperframe
fraction is set in seconds - look e.g. here
    static int bttv_g_parm(struct file *file, void *f,
                                    struct v4l2_streamparm *parm)
    {
            struct bttv_fh *fh = f;
            struct bttv *btv = fh->btv;
            v4l2_video_std_frame_period(bttv_tvnorms[btv->tvnorm].v4l2_id,
                                        &parm->parm.capture.timeperframe);
    ...
    void v4l2_video_std_frame_period(int id, struct v4l2_fract *frameperiod)
    {
            if (id & V4L2_STD_525_60) {
                    frameperiod->numerator = 1001;
                    frameperiod->denominator = 30000;
            } else {
                    frameperiod->numerator = 1;
                    frameperiod->denominator = 25;
            }
and also v4l2-ctl in userspace decodes this as seconds:
    if (doioctl(fd, VIDIOC_G_PARM, &parm, "VIDIOC_G_PARM") == 0) {
            const struct v4l2_fract &tf = parm.parm.capture.timeperframe;
            ...
            printf("\tFrames per second: %.3f (%d/%d)\n",
                            (1.0 * tf.denominator) / tf.numerator,
                            tf.denominator, tf.numerator);
The typo was there from day 1 - added in 2002 in e028b61b ([PATCH]
add v4l2 api)(*)
(*) found in history tree
    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git

Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] vivi: Kill BUFFER_TIMEOUT macro
Kirill Smelkov [Mon, 22 Oct 2012 12:54:43 +0000 (09:54 -0300)]
[media] vivi: Kill BUFFER_TIMEOUT macro

Usage of BUFFER_TIMEOUT has gone in 2008 in 78718e5d (V4L/DVB (7492):
vivi: Simplify the vivi driver and avoid deadlocks), but the macro
remains. Say goodbye to it.

Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] v4l: Correct definition of v4l2_buffer.flags related to cache management
Sakari Ailus [Sun, 21 Oct 2012 18:30:02 +0000 (15:30 -0300)]
[media] v4l: Correct definition of v4l2_buffer.flags related to cache management

V4L2_BUF_FLAG_NO_CACHE_INVALIDATE and V4L2_BUF_FLAG_NO_CACHE_CLEAN were
define incorrectly in the documentation. Fix this by changing the
documentation to match reality.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] it913x [BUG] Enable endpoint 3 on devices with HID interface
Malcolm Priestley [Sat, 20 Oct 2012 20:03:15 +0000 (17:03 -0300)]
[media] it913x [BUG] Enable endpoint 3 on devices with HID interface

On some USB controllers when endpoint 3 (used by HID) is not enabled
this causes a USB reset.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] Add Fujitsu Siemens Amilo Pi 2530 to gspca upside down table
Gregor Jasny [Thu, 18 Oct 2012 11:20:47 +0000 (08:20 -0300)]
[media] Add Fujitsu Siemens Amilo Pi 2530 to gspca upside down table

I've got an webcam upside down report for the following system:
     System Information
             Manufacturer: FUJITSU SIEMENS
             Product Name: AMILO Pi 2530
             Version:
             Serial Number:
             UUID: <removed>
             Wake-up Type: Power Switch
             SKU Number: Not Specified
             Family: Not Specified
     Base Board Information
             Manufacturer: FUJITSU SIEMENS
             Product Name: F42
             Version: 00030D0000000001
             Serial Number: <removed>
Currently an entry in the gspca/m5602 quirk table is missing.

Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Acked-by: Erik Andrén <erik.andren@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] winbond-cir: do not rename input name
Sean Young [Wed, 17 Oct 2012 14:38:21 +0000 (11:38 -0300)]
[media] winbond-cir: do not rename input name

"54fd321 [media] winbond: remove space from driver name" inadvertently
renamed the input device name.

Signed-off-by: Sean Young <sean@mess.org>
Acked-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] i2c/s5k4ecgx: fix printk format warning
Randy Dunlap [Tue, 16 Oct 2012 19:17:59 +0000 (16:17 -0300)]
[media] i2c/s5k4ecgx: fix printk format warning

Fix printk format warning for size_t variable:
drivers/media/i2c/s5k4ecgx.c:346:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()
Jesper Juhl [Fri, 12 Oct 2012 22:16:37 +0000 (19:16 -0300)]
[media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()

Remember to collect the exit status from 'stk1160_read_reg()' in 'rc'
before testing it for less than zero.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] ene-ir: Fix cleanup on probe failure
Matthijs Kooijman [Mon, 15 Oct 2012 10:13:44 +0000 (07:13 -0300)]
[media] ene-ir: Fix cleanup on probe failure

This makes the cleanup on probe failure more consistent with other
drivers. This is similar to what commit
f27b853ea24a9b70585f9251384d97929e6551c3 ("[media] rc: Fix invalid
free_region and/or free_irq on probe failure") did for some other
drivers.
In addition to making the cleanup more consistent, this also fixes a
case where (on a ene_hw_detect failure) free_region would be called on a
region that was not requested yet.
This last problem was probably introduced by the moving of code in
commit b31b021988fed9e3741a46918f14ba9b063811db ("[media] ene_ir: Fix
driver initialisation") and commit
9ef449c6b31bb6a8e6dedc24de475a3b8c79be20 ("[media] rc: Postpone ISR
registration").

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] staging: lirc_serial: silence GCC warning
Paul Bolle [Sun, 14 Oct 2012 18:50:11 +0000 (15:50 -0300)]
[media] staging: lirc_serial: silence GCC warning

Building lirc_serial.o triggers this GCC warning:
    drivers/staging/media/lirc/lirc_serial.c: In function '__check_sense':
    drivers/staging/media/lirc/lirc_serial.c:1301:1: warning: return from incompatible pointer type [enabled by default]
This can be trivially fixed by changing the 'sense' parameter from bool
to int. But, to be safe, we also need to make sure 'sense' will only be
-1, 0, or 1. There's no need to document the new values that are now
allowed for the 'sense' parameter, since they're basically useless.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Cc: Jarod Wilson <jarod@wilsonet.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agoradio tea5764, si4713: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 20:35:46 +0000 (18:35 -0200)]
radio tea5764, si4713: get rid of warning: no previous prototype
drivers/media/radio/radio-tea5764.c:148:5: warning: no previous prototype for 'tea5764_i2c_read' [-Wmissing-prototypes]
drivers/media/radio/radio-tea5764.c:168:5: warning: no previous prototype for 'tea5764_i2c_write' [-Wmissing-prototypes]
drivers/media/radio/si4713-i2c.c:1772:6: warning: no previous prototype for 'si4713_ioctl' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years agofintek-cir: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 20:34:23 +0000 (18:34 -0200)]
fintek-cir: get rid of warning: no previous prototype
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
drivers/media/rc/fintek-cir.c:687:5: warning: no previous prototype for 'fintek_init' [-Wmissing-prototypes]
drivers/media/rc/fintek-cir.c:692:6: warning: no previous prototype for 'fintek_exit' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] fmdrv: Don't check if unsigned are below zero
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:43:41 +0000 (16:43 -0300)]
[media] fmdrv: Don't check if unsigned are below zero

drivers/media/radio/wl128x/fmdrv_common.c:745:3: warning: comparison is always false due to limited range of data type [-Wtype-limits]
drivers/media/radio/wl128x/fmdrv_rx.c:308:2: warning: comparison is always false due to limited range of data type [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] soc_camera: ret is never used. get rid of it
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:42:05 +0000 (16:42 -0300)]
[media] soc_camera: ret is never used. get rid of it

drivers/media/platform/soc_camera/soc_camera.c:1051:8: warning: variable 'ret' set but not used [-Wunused-but-set-variable]

Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] au0828-dvb: ret is never tested. Get rid of it
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:36:34 +0000 (16:36 -0300)]
[media] au0828-dvb: ret is never tested. Get rid of it

drivers/media/usb/au0828/au0828-dvb.c:275:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] cx25840-core: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:34:31 +0000 (16:34 -0300)]
[media] cx25840-core: get rid of warning: no previous prototype

drivers/media/i2c/cx25840/cx25840-core.c:2068:6: warning: no previous prototype for 'cx23885_dif_setup' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] bttv-driver: fix two warnings
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:33:41 +0000 (16:33 -0300)]
[media] bttv-driver: fix two warnings

drivers/media/pci/bt8xx/bttv-driver.c:308:3: warning: initialized field overwritten [-Woverride-init]
drivers/media/pci/bt8xx/bttv-driver.c:308:3: warning: (near initialization for 'bttv_tvnorms[0].cropcap.bounds.height') [-Woverride-init]
drivers/media/pci/bt8xx/bttv-driver.c: In function 'bttv_remove':
drivers/media/pci/bt8xx/bttv-driver.c:4467:29: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] zr364xx: urb actual_length is unsigned
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:30:47 +0000 (16:30 -0300)]
[media] zr364xx: urb actual_length is unsigned

drivers/media/usb/zr364xx/zr364xx.c:1010:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Cc: Antoine Jacquet <royale@zerezo.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] usbvision-core: fix a warning
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:30:20 +0000 (16:30 -0300)]
[media] usbvision-core: fix a warning

drivers/media/usb/usbvision/usbvision-core.c:1749:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] s2255drv: index is always positive
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:29:34 +0000 (16:29 -0300)]
[media] s2255drv: index is always positive

drivers/media/usb/s2255/s2255drv.c:1654:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] em28xx-cards: fix a warning
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:29:20 +0000 (16:29 -0300)]
[media] em28xx-cards: fix a warning

drivers/media/usb/em28xx/em28xx-cards.c:3309:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] anysee: fix a warning
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:28:00 +0000 (16:28 -0300)]
[media] anysee: fix a warning

drivers/media/usb/dvb-usb-v2/anysee.c:1179:5: warning: 'tmp' may be used uninitialized in this function [-Wmaybe-uninitialized]

Cc: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] tua9001: fix a warning
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:26:56 +0000 (16:26 -0300)]
[media] tua9001: fix a warning

drivers/media/tuners/tua9001.c:211:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Cc: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] v4l2-common: h_bp var is unused at v4l2_detect_gtf()
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:26:15 +0000 (16:26 -0300)]
[media] v4l2-common: h_bp var is unused at v4l2_detect_gtf()

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] fmdrv: better define fmdbg() macro to avoid warnings
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:24:02 +0000 (16:24 -0300)]
[media] fmdrv: better define fmdbg() macro to avoid warnings

drivers/media/radio/wl128x/fmdrv_common.c:1619:47: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] tlg2300: index is unsigned, so never below zero
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:23:03 +0000 (16:23 -0300)]
[media] tlg2300: index is unsigned, so never below zero

drivers/media/usb/tlg2300/pd-video.c:891:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/usb/tlg2300/pd-video.c:926:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Cc: Huang Shijie <shijie8@gmail.com>
Cc: Kang Yong <kangyong@telegent.com>
Cc: Zhang Xiaobing <xbzhang@telegent.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] m2m-deinterlace: remove unused vars
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:22:25 +0000 (16:22 -0300)]
[media] m2m-deinterlace: remove unused vars

drivers/media/platform/m2m-deinterlace.c:229:15: warning: variable 'd_size' set but not used [-Wunused-but-set-variable]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] meye: fix a warning
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:21:42 +0000 (16:21 -0300)]
[media] meye: fix a warning

drivers/media/pci/meye/meye.c:1948:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] saa7134,saa7164: warning: comparison of unsigned fixes
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:20:27 +0000 (16:20 -0300)]
[media] saa7134,saa7164: warning: comparison of unsigned fixes

drivers/media/pci/saa7134/saa7134-core.c:947:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/saa7164/saa7164-core.c:413:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/pci/saa7164/saa7164-core.c:489:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/pci/saa7134/saa7134-video.c:2514:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] ngene: better comment unused code to avoid warnings
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:17:39 +0000 (16:17 -0300)]
[media] ngene: better comment unused code to avoid warnings

get rid of a few warnings about empty body:
drivers/media/pci/ngene/ngene-core.c:756:3: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
drivers/media/pci/ngene/ngene-cards.c:429:5: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
Those are due to some commented code.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] soc_camera/ov2640: Don't use a temp var for an unused value
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:16:34 +0000 (16:16 -0300)]
[media] soc_camera/ov2640: Don't use a temp var for an unused value

drivers/media/i2c/soc_camera/ov2640.c:899:32: warning: variable 'win' set but not used [-Wunused-but-set-variable]

Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] dvb-frontends: get rid of some "always false" warnings
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:14:01 +0000 (16:14 -0300)]
[media] dvb-frontends: get rid of some "always false" warnings

On gcc, enums are generally unsigned, except if a negative value
is declared. Due to that, warnings may happen there:
drivers/media/dvb-frontends/cx22700.c:142:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/dvb-frontends/cx22700.c:155:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/dvb-frontends/cx24123.c:341:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/dvb-frontends/l64781.c:183:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/dvb-frontends/l64781.c:187:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/dvb-frontends/mt312.c:552:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/dvb-frontends/mt312.c:560:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
As other compilers might be using signed values, the better is to
keep the checks there, casting the value to avoid the warning.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] drxk: get rid of some unused vars
Mauro Carvalho Chehab [Sat, 27 Oct 2012 19:12:00 +0000 (16:12 -0300)]
[media] drxk: get rid of some unused vars

drivers/media/dvb-frontends/drxk_hard.c:68:13: warning: 'IsA1WithPatchCode' defined but not used [-Wunused-function]
drivers/media/dvb-frontends/drxk_hard.c:73:13: warning: 'IsA1WithRomCode' defined but not used [-Wunused-function]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] dmxdev: fix a comparition of unsigned expression warning
Mauro Carvalho Chehab [Sat, 27 Oct 2012 18:30:47 +0000 (15:30 -0300)]
[media] dmxdev: fix a comparition of unsigned expression warning

drivers/media/dvb-core/dmxdev.c: In function 'dvb_dmxdev_pes_filter_set':
drivers/media/dvb-core/dmxdev.c:880:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] cx88: get rid of a warning at dprintk() macro
Mauro Carvalho Chehab [Sat, 27 Oct 2012 18:25:02 +0000 (15:25 -0300)]
[media] cx88: get rid of a warning at dprintk() macro

drivers/media/pci/cx88/cx88-mpeg.c: In function 'cx8802_mpeg_irq':
drivers/media/pci/cx88/cx88-mpeg.c:419:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-mpeg.c: In function 'cx8802_irq':
drivers/media/pci/cx88/cx88-mpeg.c:453:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-alsa.c: In function 'snd_cx88_create':
drivers/media/pci/cx88/cx88-alsa.c:818:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-alsa.c:837:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-alsa.c: In function 'cx88_audio_initdev':
drivers/media/pci/cx88/cx88-alsa.c:912:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_mbox_func':
drivers/media/pci/cx88/cx88-blackbird.c:327:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:333:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:360:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_find_mailbox':
drivers/media/pci/cx88/cx88-blackbird.c:421:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_load_firmware':
drivers/media/pci/cx88/cx88-blackbird.c:444:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:451:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:453:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:459:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:466:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:487:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:492:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:503:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_initialize_codec':
drivers/media/pci/cx88/cx88-blackbird.c:560:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:566:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/cx88/cx88-blackbird.c:569:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] cx88: reorder inline to prevent a gcc warning
Mauro Carvalho Chehab [Sat, 27 Oct 2012 18:18:16 +0000 (15:18 -0300)]
[media] cx88: reorder inline to prevent a gcc warning

drivers/media/pci/cx88/cx88.h:97:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
drivers/media/pci/cx88/cx88.h:103:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
drivers/media/pci/cx88/cx88-core.c:649:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
drivers/media/pci/cx88/cx88-core.c:654:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
drivers/media/pci/cx88/cx88-core.c:659:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
drivers/media/pci/cx88/cx88-core.c:664:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
drivers/media/pci/cx88/cx88-core.c:684:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
drivers/media/pci/cx88/cx88-core.c:695:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] dvb_frontend: Don't declare values twice at a table
Mauro Carvalho Chehab [Sat, 27 Oct 2012 18:04:14 +0000 (15:04 -0300)]
[media] dvb_frontend: Don't declare values twice at a table

drivers/media/dvb-core/dvb_frontend.c:1032:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1032:2: warning: (near initialization for 'dtv_cmds[36]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1033:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1033:2: warning: (near initialization for 'dtv_cmds[37]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1034:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1034:2: warning: (near initialization for 'dtv_cmds[38]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1035:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1035:2: warning: (near initialization for 'dtv_cmds[39]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1036:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1036:2: warning: (near initialization for 'dtv_cmds[40]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1037:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1037:2: warning: (near initialization for 'dtv_cmds[60]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1045:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1045:2: warning: (near initialization for 'dtv_cmds[46]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1051:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1051:2: warning: (near initialization for 'dtv_cmds[52]') [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1060:2: warning: initialized field overwritten [-Woverride-init]
drivers/media/dvb-core/dvb_frontend.c:1060:2: warning: (near initialization for 'dtv_cmds[61]') [-Woverride-init]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] go7007-v4l2: warning fix: index is unsigned, so it will never be below 0
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:58:45 +0000 (14:58 -0300)]
[media] go7007-v4l2: warning fix: index is unsigned, so it will never be below 0

drivers/staging/media/go7007/go7007-v4l2.c: In function 'vidioc_qbuf':
drivers/staging/media/go7007/go7007-v4l2.c:815:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] dt3155v4l: vb2_queue_init() can now fail. Check is required
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:57:31 +0000 (14:57 -0300)]
[media] dt3155v4l: vb2_queue_init() can now fail. Check is required

drivers/staging/media/dt3155v4l/dt3155v4l.c: In function 'dt3155_open':
drivers/staging/media/dt3155v4l/dt3155v4l.c:399:17: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] gspca: warning fix: index is unsigned, so it will never be below 0
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:55:20 +0000 (14:55 -0300)]
[media] gspca: warning fix: index is unsigned, so it will never be below 0

drivers/media/usb/gspca/gspca.c: In function 'vidioc_querybuf':
drivers/media/usb/gspca/gspca.c:1590:6: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] jeilinj: fix return of the response code
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:54:01 +0000 (14:54 -0300)]
[media] jeilinj: fix return of the response code

drivers/media/usb/gspca/jeilinj.c: In function 'jlj_read1':
drivers/media/usb/gspca/jeilinj.c:117:66: warning: parameter 'response' set but not used [-Wunused-but-set-parameter]
The code still doesn't make much sense, as response is never tested
there.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] gscpa: get rid of warning: suggest braces around empty body
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:43:54 +0000 (14:43 -0300)]
[media] gscpa: get rid of warning: suggest braces around empty body

There are hundreds of messages like this one, when GSPCA debug is
disabled, when compiled with W=1:
drivers/media/usb/gspca/spca500.c:725:46: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
Get rid of it, especially as it might actually cause troubles on
some places.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] dib9000: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:31:09 +0000 (14:31 -0300)]
[media] dib9000: get rid of warning: no previous prototype

drivers/media/dvb-frontends/dib9000.h:100:5: warning: no previous prototype for 'dib9000_remove_slave_frontend' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] pwc-if: must check vb2_queue_init() success
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:26:25 +0000 (14:26 -0300)]
[media] pwc-if: must check vb2_queue_init() success

drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe':
drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]
In the past, it used to have a logic there at queue init that would
BUG() on errors. This logic got removed. Drivers are now required
to explicitly handle the queue initialization errors, or very bad
things may happen.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] pwc-if: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:26:35 +0000 (14:26 -0300)]
[media] pwc-if: get rid of warning: no previous prototype

drivers/media/usb/pwc/pwc-if.c:158:23: warning: no previous prototype for 'pwc_get_next_fill_buf' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] pvrusb2: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:17:42 +0000 (14:17 -0300)]
[media] pvrusb2: get rid of warning: no previous prototype

drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:199:5: warning: no previous prototype for 'pvr2_s_std' [-Wmissing-prototypes]
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:368:5: warning: no previous prototype for 'pvr2_s_frequency' [-Wmissing-prototypes]

Acked-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] vp702x: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:16:36 +0000 (14:16 -0300)]
[media] vp702x: get rid of warning: no previous prototype

drivers/media/usb/dvb-usb/vp702x.c:70:5: warning: no previous prototype for 'vp702x_usb_out_op_unlocked' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb/vp702x.c:89:5: warning: no previous prototype for 'vp702x_usb_out_op' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] lmedm04: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:11:15 +0000 (14:11 -0300)]
[media] lmedm04: get rid of warning: no previous prototype

drivers/media/usb/dvb-usb-v2/lmedm04.c:802:13: warning: no previous prototype for 'lme_firmware_switch' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] dvb-usb-v2: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:08:45 +0000 (14:08 -0300)]
[media] dvb-usb-v2: get rid of warning: no previous prototype

drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:227:5: warning: no previous prototype for 'dvb_usbv2_adapter_stream_init' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:239:5: warning: no previous prototype for 'dvb_usbv2_adapter_stream_exit' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:372:5: warning: no previous prototype for 'dvb_usbv2_adapter_dvb_init' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:444:5: warning: no previous prototype for 'dvb_usbv2_adapter_dvb_exit' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:460:5: warning: no previous prototype for 'dvb_usbv2_device_power_ctrl' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:557:5: warning: no previous prototype for 'dvb_usbv2_adapter_frontend_init' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:626:5: warning: no previous prototype for 'dvb_usbv2_adapter_frontend_exit' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/usb_urb.c:115:5: warning: no previous prototype for 'usb_urb_free_urbs' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/usb_urb.c:208:5: warning: no previous prototype for 'usb_free_stream_buffers' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb-v2/usb_urb.c:226:5: warning: no previous prototype for 'usb_alloc_stream_buffers' [-Wmissing-prototypes]

Cc: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
12 years ago[media] az6027: get rid of warning: no previous prototype
Mauro Carvalho Chehab [Sat, 27 Oct 2012 17:05:59 +0000 (14:05 -0300)]
[media] az6027: get rid of warning: no previous prototype

drivers/media/usb/dvb-usb/az6027.c:1054:5: warning: no previous prototype for 'az6027_identify_state' [-Wmissing-prototypes]
drivers/media/usb/dvb-usb/az6027.c:301:5: warning: no previous prototype for 'az6027_usb_in_op' [-Wmissing-prototypes]

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>