GitHub/WoltLab/WCF.git
2 years agoRevert "Suppress errors when disabling the focus trap"
Tim Düsterhus [Mon, 16 May 2022 09:37:27 +0000 (11:37 +0200)]
Revert "Suppress errors when disabling the focus trap"

This commit duplicates commit e9ffefb4d0db61bf8e12b3824c6515ac16fe3812 which is
the cleaner fix, but was accidentally commited to `master` only. We revert this
one to allow for a clean cherry-picking of
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812.

This reverts commit e7439c4f5fc7daf8d45d2de478c488798ddf463a.

2 years agoInstall phpcs via `shivammathur/setup-php`
Tim Düsterhus [Fri, 13 May 2022 09:45:32 +0000 (11:45 +0200)]
Install phpcs via `shivammathur/setup-php`

Apparently the previously used actions uses an out of date phpcs.

(cherry picked from commit c5cd836751c3fb357b8ddce52a95a83f3ac46347)

2 years agoMerge pull request #4805 from WoltLab/package-xsd
Marcel Werk [Mon, 16 May 2022 07:51:10 +0000 (09:51 +0200)]
Merge pull request #4805 from WoltLab/package-xsd

Added documentation of the void element

2 years agoUse correct CodeMirror mode for SCSS inputs
Tim Düsterhus [Mon, 16 May 2022 07:42:33 +0000 (09:42 +0200)]
Use correct CodeMirror mode for SCSS inputs

`sass` is the indentation based SASS syntax.

2 years agoIncorrect markup in the authentication dialog
Alexander Ebert [Sun, 15 May 2022 11:20:40 +0000 (13:20 +0200)]
Incorrect markup in the authentication dialog

2 years agoSuppress errors when disabling the focus trap
Alexander Ebert [Sun, 15 May 2022 11:04:54 +0000 (13:04 +0200)]
Suppress errors when disabling the focus trap

2 years agoUse CSS variable to apply the dialog offset
Alexander Ebert [Sun, 15 May 2022 11:00:09 +0000 (13:00 +0200)]
Use CSS variable to apply the dialog offset

2 years agoRevert "Dynamic width of code box line numbers"
Alexander Ebert [Sun, 15 May 2022 10:38:59 +0000 (12:38 +0200)]
Revert "Dynamic width of code box line numbers"

This reverts commit d3853740d8304f9703876006db990c2e01642656.

2 years agoDynamic width of code box line numbers
Alexander Ebert [Sun, 15 May 2022 10:37:51 +0000 (12:37 +0200)]
Dynamic width of code box line numbers

This avoids indenting short code listings too much, especially on screens with limited space.

2 years agoDo not wrap code boxes on mobile
Alexander Ebert [Sun, 15 May 2022 09:17:08 +0000 (11:17 +0200)]
Do not wrap code boxes on mobile

Having long lines wrap multiple times is horrible, overflow scrolling is much better and also quite natural on touch devices.

2 years agoBetter accessibility of code box buttons
Alexander Ebert [Sun, 15 May 2022 09:16:26 +0000 (11:16 +0200)]
Better accessibility of code box buttons

2 years agoNewer iOS versions permit a click near the bottom
Alexander Ebert [Sun, 15 May 2022 09:04:40 +0000 (11:04 +0200)]
Newer iOS versions permit a click near the bottom

2 years agoPrevent the "external url" indicator to wrap
Alexander Ebert [Sat, 14 May 2022 17:13:45 +0000 (19:13 +0200)]
Prevent the "external url" indicator to wrap

See https://www.woltlab.com/community/thread/295487-einzelnes-umbrechen-des-externalurl-icons-verhindern/

2 years agoExpand the active menu item by default
Alexander Ebert [Sat, 14 May 2022 17:01:48 +0000 (19:01 +0200)]
Expand the active menu item by default

2 years agoMerge pull request #4807 from WoltLab/55-desktop-notifications
Alexander Ebert [Sat, 14 May 2022 16:12:55 +0000 (18:12 +0200)]
Merge pull request #4807 from WoltLab/55-desktop-notifications

Remove the option to disable desktop notifications

2 years agoAlign the mobile main menu to the right
Alexander Ebert [Sat, 14 May 2022 15:10:15 +0000 (17:10 +0200)]
Align the mobile main menu to the right

See https://www.woltlab.com/community/thread/295627-mobil-men%C3%BC-links/

2 years agoSuppress error messages when aborting `fetch()`
Alexander Ebert [Sat, 14 May 2022 14:32:17 +0000 (16:32 +0200)]
Suppress error messages when aborting `fetch()`

See https://www.woltlab.com/community/thread/295566-fetch-is-aborted-bei-suchergebnissen/

2 years agoRemove the option to disable desktop notifications
Alexander Ebert [Sat, 14 May 2022 14:07:03 +0000 (16:07 +0200)]
Remove the option to disable desktop notifications

Fixes #4806

2 years agoAdded documentation of the void element
Marcel Werk [Sat, 14 May 2022 14:03:45 +0000 (16:03 +0200)]
Added documentation of the void element

2 years agoMerge branch '5.4' into 5.5
Marcel Werk [Sat, 14 May 2022 11:46:27 +0000 (13:46 +0200)]
Merge branch '5.4' into 5.5

2 years agoTruncate error message in cronjob log if necessary
Marcel Werk [Sat, 14 May 2022 11:46:05 +0000 (13:46 +0200)]
Truncate error message in cronjob log if necessary

2 years agoSupport for meta tags during article import
Marcel Werk [Sat, 14 May 2022 10:59:48 +0000 (12:59 +0200)]
Support for meta tags during article import

2 years agoTypo
Marcel Werk [Sat, 14 May 2022 10:35:35 +0000 (12:35 +0200)]
Typo

2 years agoRemove obsolete workaround for PHP_CodeSniffer bug
Tim Düsterhus [Fri, 13 May 2022 09:38:41 +0000 (11:38 +0200)]
Remove obsolete workaround for PHP_CodeSniffer bug

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 14:08:05 +0000 (16:08 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge pull request #4798 from pehbeh/patch-1
Tim Düsterhus [Thu, 12 May 2022 13:38:20 +0000 (15:38 +0200)]
Merge pull request #4798 from pehbeh/patch-1

Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl

2 years agoUpdate URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl
pehbeh [Thu, 12 May 2022 13:31:54 +0000 (15:31 +0200)]
Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl

2 years agoFix incorrect use of `mb_strpos` in MysqlSearchEngine
Tim Düsterhus [Thu, 12 May 2022 12:48:06 +0000 (14:48 +0200)]
Fix incorrect use of `mb_strpos` in MysqlSearchEngine

The return value of `mb_strpos` needs to be checked type-safely, as both `0`
and `false` are falsy. In this case this likely was safe, as the inner join may
not appear at the start of the query, it was a questionable nonetheless.

Fix this by using `str_contains()` which makes the intent even clearer.

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 11:48:37 +0000 (13:48 +0200)]
Merge branch '5.4' into 5.5

2 years agoUpdate URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl
Tim Düsterhus [Thu, 12 May 2022 11:48:13 +0000 (13:48 +0200)]
Update URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl

2 years agoMerge pull request #4787 from WoltLab/user-online-list
Marcel Werk [Wed, 11 May 2022 13:06:27 +0000 (15:06 +0200)]
Merge pull request #4787 from WoltLab/user-online-list

User online statistics were invisible when all active users were invisible

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 12:57:23 +0000 (14:57 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:56:48 +0000 (14:56 +0200)]
Merge branch '5.3' into 5.4

2 years agoAdd the `required` attribute to the recipientID select in contact.tpl
Tim Düsterhus [Wed, 11 May 2022 12:56:09 +0000 (14:56 +0200)]
Add the `required` attribute to the recipientID select in contact.tpl

see a8490749c3ba7014380d55462fc45dd635c1d71c

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 12:50:53 +0000 (14:50 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:49:48 +0000 (14:49 +0200)]
Merge branch '5.3' into 5.4

2 years agoIndicate that selecting a recipient is required in contact.tpl
Tim Düsterhus [Wed, 11 May 2022 12:49:24 +0000 (14:49 +0200)]
Indicate that selecting a recipient is required in contact.tpl

2 years agoApplied code suggestions
Marcel Werk [Wed, 11 May 2022 11:09:44 +0000 (13:09 +0200)]
Applied code suggestions

2 years agoShow legend only when users are listed
Marcel Werk [Wed, 11 May 2022 10:25:15 +0000 (12:25 +0200)]
Show legend only when users are listed

2 years agoUser online statistics were invisible when all active users were invisible
Marcel Werk [Wed, 11 May 2022 10:24:06 +0000 (12:24 +0200)]
User online statistics were invisible when all active users were invisible

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 09:39:12 +0000 (11:39 +0200)]
Merge branch '5.4' into 5.5

2 years agoDrop obsolete update_com.woltlab.wcf_5.4.15_deleteDsStore.php
Tim Düsterhus [Wed, 11 May 2022 09:38:47 +0000 (11:38 +0200)]
Drop obsolete update_com.woltlab.wcf_5.4.15_deleteDsStore.php

2 years agoDrop obsolete fileDelete_5.5.xml
Tim Düsterhus [Wed, 11 May 2022 09:37:38 +0000 (11:37 +0200)]
Drop obsolete fileDelete_5.5.xml

2 years agoFix language items in recommended section of system requirements in WCFSetup
Tim Düsterhus [Wed, 11 May 2022 08:40:35 +0000 (10:40 +0200)]
Fix language items in recommended section of system requirements in WCFSetup

see 3445cbe2a005ead9843d9e17709a915631dd11b5
see e88d06dc88bc263b7424fbccfa47c13907413b8c

2 years agoRelease 5.5.0 Beta 2 5.5.0_Beta_2
Alexander Ebert [Tue, 10 May 2022 20:58:18 +0000 (22:58 +0200)]
Release 5.5.0 Beta 2

2 years agoIncorrect dialog position on smartphones
Alexander Ebert [Tue, 10 May 2022 16:06:08 +0000 (18:06 +0200)]
Incorrect dialog position on smartphones

See https://www.woltlab.com/community/thread/295560-neues-thema-erstellen-au%C3%9Ferhalb-des-bildschirms/

2 years agoAdd the 5.5 branch to GitHub workflows
Tim Düsterhus [Tue, 10 May 2022 15:33:34 +0000 (17:33 +0200)]
Add the 5.5 branch to GitHub workflows

2 years agoRelease 5.5.0 Beta 1 5.5.0_Beta_1
Alexander Ebert [Tue, 10 May 2022 14:30:34 +0000 (16:30 +0200)]
Release 5.5.0 Beta 1

2 years agoRemoved the upgrade instructions from 5.4.*
Alexander Ebert [Tue, 10 May 2022 14:12:26 +0000 (16:12 +0200)]
Removed the upgrade instructions from 5.4.*

2 years agoUpdating minified JavaScript files
WoltLab [Tue, 10 May 2022 13:53:32 +0000 (13:53 +0000)]
Updating minified JavaScript files

2 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 10 May 2022 07:26:40 +0000 (09:26 +0200)]
Merge branch '5.4'

2 years agoFix English versions of `wcf.user.security.multifactor.backup.authenticationEmail...
Tim Düsterhus [Tue, 10 May 2022 07:25:42 +0000 (09:25 +0200)]
Fix English versions of `wcf.user.security.multifactor.backup.authenticationEmail.body.*`

The phrases contained broken template scripting, due to the use of the `'`
apostroph within a single quoted string.

2 years agoDialogs could become too wide with lots of text
Alexander Ebert [Mon, 9 May 2022 13:51:17 +0000 (15:51 +0200)]
Dialogs could become too wide with lots of text

2 years agoSuppress the redundant loading indicator
Alexander Ebert [Mon, 9 May 2022 12:17:55 +0000 (14:17 +0200)]
Suppress the redundant loading indicator

See https://www.woltlab.com/community/thread/295539-doppelte-ladebalken/

2 years agoMerge pull request #4781 from WoltLab/ci-check
Tim Düsterhus [Mon, 9 May 2022 11:31:31 +0000 (13:31 +0200)]
Merge pull request #4781 from WoltLab/ci-check

Flip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFilesystemCaseSensitive()

2 years agoAdd fileDelete_5.5.xml
Tim Düsterhus [Mon, 9 May 2022 10:42:53 +0000 (12:42 +0200)]
Add fileDelete_5.5.xml

These files never were part of the git repository, but were accidentally
included in an upgrade package, because an unclean source directory was used
when building the upgrade.

2 years agoFlip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFile...
Tim Düsterhus [Mon, 9 May 2022 09:06:38 +0000 (11:06 +0200)]
Flip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFilesystemCaseSensitive()

Flipping the whole path does not provide any real benefit, because we only care
about whether the file system where WoltLab Suite resides is case sensitive or
not. It does however break when `open_basedir` is configured.

2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 9 May 2022 08:49:45 +0000 (10:49 +0200)]
Merge branch '5.4'

2 years agoRemove the codestyle workflow from branches that are not master
Tim Düsterhus [Fri, 6 May 2022 13:11:45 +0000 (15:11 +0200)]
Remove the codestyle workflow from branches that are not master

2 years agoLazy loading the user’s avatar causes flashes
Alexander Ebert [Sun, 8 May 2022 11:54:02 +0000 (13:54 +0200)]
Lazy loading the user’s avatar causes flashes

Safari (macOS and iOS) does not handle lazy loaded images above the fold gracefully. This causes the user’s avatar to flicker noticeably on ever page navigation.

2 years agoMerge pull request #4779 from WoltLab/search-result-pagination
Alexander Ebert [Sun, 8 May 2022 11:42:21 +0000 (13:42 +0200)]
Merge pull request #4779 from WoltLab/search-result-pagination

Tracked the result page number in the url

2 years agoMerge pull request #4777 from WoltLab/article-comment-like-notifications
Alexander Ebert [Sun, 8 May 2022 11:38:09 +0000 (13:38 +0200)]
Merge pull request #4777 from WoltLab/article-comment-like-notifications

Notifications about reactions to article comments

2 years agoMerge pull request #4776 from WoltLab/scroll-to-comments
Alexander Ebert [Sun, 8 May 2022 11:29:21 +0000 (13:29 +0200)]
Merge pull request #4776 from WoltLab/scroll-to-comments

Scrolling to a comment not visible by default did not work

2 years agoProper prototype creation
Marcel Werk [Sat, 7 May 2022 17:11:55 +0000 (19:11 +0200)]
Proper prototype creation

2 years agoTracked the result page number in the url
Marcel Werk [Sat, 7 May 2022 17:09:50 +0000 (19:09 +0200)]
Tracked the result page number in the url

2 years agoProper history navigation for searches
Marcel Werk [Sat, 7 May 2022 16:51:22 +0000 (18:51 +0200)]
Proper history navigation for searches

2 years agoTrack the page number of search result in the url
Marcel Werk [Sat, 7 May 2022 16:38:01 +0000 (18:38 +0200)]
Track the page number of search result in the url

2 years agoVisual separator for specialized search filters
Alexander Ebert [Sat, 7 May 2022 16:13:12 +0000 (18:13 +0200)]
Visual separator for specialized search filters

See https://www.woltlab.com/community/thread/295502-kategorie-auswahl-ist-verrutscht/

2 years agoMerge branch '5.4'
Marcel Werk [Sat, 7 May 2022 15:42:08 +0000 (17:42 +0200)]
Merge branch '5.4'

2 years agoMerge branch '5.3' into 5.4
Marcel Werk [Sat, 7 May 2022 15:41:59 +0000 (17:41 +0200)]
Merge branch '5.3' into 5.4

2 years agoMerge branch '5.2' into 5.3
Marcel Werk [Sat, 7 May 2022 15:41:46 +0000 (17:41 +0200)]
Merge branch '5.2' into 5.3

2 years agoRevert "Show always an no selection option in custom select options build with the...
Marcel Werk [Sat, 7 May 2022 15:40:48 +0000 (17:40 +0200)]
Revert "Show always an no selection option in custom select options build with the OptionHandler"

This reverts commit 6fef8b82e15794eee5317e6b15bb0670f137315c.

2 years agoIncorrect margin of `.formSubmit` in dialogs
Alexander Ebert [Sat, 7 May 2022 14:59:03 +0000 (16:59 +0200)]
Incorrect margin of `.formSubmit` in dialogs

This was caused by the negative margin introduced in 1d224f10cdd05e7f5d09f869ee1fbbbdff025749 which caused the calculation to be off by 10px, causing a visible gap.

See https://www.woltlab.com/community/thread/295497-fehlerhafte-mobile-darstellung-von-dialogen/

2 years agoRemoved obsolete imports
Marcel Werk [Fri, 6 May 2022 21:54:31 +0000 (23:54 +0200)]
Removed obsolete imports

2 years agoNotifications about reactions to article comments
Marcel Werk [Fri, 6 May 2022 21:47:38 +0000 (23:47 +0200)]
Notifications about reactions to article comments

2 years agoUse generic trait in existing notifications for article comments
Marcel Werk [Fri, 6 May 2022 21:47:11 +0000 (23:47 +0200)]
Use generic trait in existing notifications for article comments

2 years agoAdded generic trait for article comment tests
Marcel Werk [Fri, 6 May 2022 21:46:46 +0000 (23:46 +0200)]
Added generic trait for article comment tests

2 years agoNotification type was not hidden when modules were disabled
Marcel Werk [Fri, 6 May 2022 15:57:21 +0000 (17:57 +0200)]
Notification type was not hidden when modules were disabled

2 years agoScrolling to a comment not visible by default did not work
Marcel Werk [Fri, 6 May 2022 15:49:54 +0000 (17:49 +0200)]
Scrolling to a comment not visible by default did not work

2 years agoInline editors had been not initialized properly
Alexander Ebert [Fri, 6 May 2022 15:27:59 +0000 (17:27 +0200)]
Inline editors had been not initialized properly

2 years agoUnified phrases
Marcel Werk [Fri, 6 May 2022 15:19:44 +0000 (17:19 +0200)]
Unified phrases

2 years agoMerge pull request #4774 from WoltLab/focus-trap-tabbable
Tim Düsterhus [Fri, 6 May 2022 07:20:09 +0000 (09:20 +0200)]
Merge pull request #4774 from WoltLab/focus-trap-tabbable

Update focus-trap and tabbable npm dependencies

2 years agoFix dependency sync check in javascript.yml
Tim Düsterhus [Fri, 6 May 2022 07:17:19 +0000 (09:17 +0200)]
Fix dependency sync check in javascript.yml

2 years agoAdd check that dependencies are in sync to javascript.yml
Tim Düsterhus [Fri, 6 May 2022 07:12:15 +0000 (09:12 +0200)]
Add check that dependencies are in sync to javascript.yml

2 years agoUpdate focus-trap and tabbable npm dependencies
Tim Düsterhus [Thu, 5 May 2022 13:25:48 +0000 (15:25 +0200)]
Update focus-trap and tabbable npm dependencies

2 years agoMerge branch '5.4'
Tim Düsterhus [Thu, 5 May 2022 13:24:11 +0000 (15:24 +0200)]
Merge branch '5.4'

2 years agoUpdate npm dependencies
Tim Düsterhus [Thu, 5 May 2022 13:23:19 +0000 (15:23 +0200)]
Update npm dependencies

2 years agoAdd PHP 8.1 to the php.yml workflow
Tim Düsterhus [Thu, 5 May 2022 12:52:05 +0000 (14:52 +0200)]
Add PHP 8.1 to the php.yml workflow

2 years agoDrop obsolete exclude in php.yml workflow
Tim Düsterhus [Thu, 5 May 2022 12:42:57 +0000 (14:42 +0200)]
Drop obsolete exclude in php.yml workflow

This should no longer be required since 123aedf297e0402e6bd3562fe08e2d74e24760d1.

2 years agoUpdate version constraints in composer.json
Tim Düsterhus [Thu, 5 May 2022 09:04:03 +0000 (11:04 +0200)]
Update version constraints in composer.json

Require the currently locked versions as the minimum versions.

2 years agoMerge pull request #4772 from WoltLab/htmlpurifier-4.14
Tim Düsterhus [Thu, 5 May 2022 07:04:44 +0000 (09:04 +0200)]
Merge pull request #4772 from WoltLab/htmlpurifier-4.14

Update to ezyang/htmlpurifier 4.14.*

2 years agoLabeling for buttons (trash and delete) was identical
Marcel Werk [Wed, 4 May 2022 16:32:08 +0000 (18:32 +0200)]
Labeling for buttons (trash and delete) was identical

2 years agoUpdate to ezyang/htmlpurifier 4.14.*
Tim Düsterhus [Wed, 4 May 2022 15:32:26 +0000 (17:32 +0200)]
Update to ezyang/htmlpurifier 4.14.*

2 years agoSort dependencies in composer.json
Tim Düsterhus [Wed, 4 May 2022 15:26:27 +0000 (17:26 +0200)]
Sort dependencies in composer.json

2 years agoAdd explicit composer dependency for guzzlehttp/psr7
Tim Düsterhus [Wed, 4 May 2022 15:25:13 +0000 (17:25 +0200)]
Add explicit composer dependency for guzzlehttp/psr7

2 years agoRemove validation attributes from __sourceCodeFormField.tpl
Tim Düsterhus [Wed, 4 May 2022 13:27:22 +0000 (15:27 +0200)]
Remove validation attributes from __sourceCodeFormField.tpl

These are not supported with CodeMirror, because it only syncs the entered data
upon `submit()` which notably runs *after* validation.

see codemirror/CodeMirror#5092
Fixes #4732

2 years agoFix typo in function name in AbstractFileDeletePackageInstallationPlugin
Tim Düsterhus [Tue, 3 May 2022 21:36:15 +0000 (23:36 +0200)]
Fix typo in function name in AbstractFileDeletePackageInstallationPlugin

This must be `strtr` not `strstr`.

see #4714

2 years agoLoad the page logo using the `eager` policy
Alexander Ebert [Wed, 4 May 2022 12:34:15 +0000 (14:34 +0200)]
Load the page logo using the `eager` policy

Using `loading="lazy"` for the page logo causes the image to flicker noticeably in Safari on both macOS and iOS.

See https://www.woltlab.com/community/thread/295403-logo-auf-der-startseite-beim-aktualisieren-ein-rechteck/

2 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 3 May 2022 13:26:36 +0000 (15:26 +0200)]
Merge branch '5.4'

2 years agoMerge pull request #4768 from WoltLab/sitemap-page
Tim Düsterhus [Tue, 3 May 2022 13:07:53 +0000 (15:07 +0200)]
Merge pull request #4768 from WoltLab/sitemap-page

Fix handling of CMS pages in sitemap