Alexander Ebert [Mon, 10 Jul 2023 11:51:13 +0000 (13:51 +0200)]
Do not scroll the editor into the view if it is already (partially) visible
See https://www.woltlab.com/community/thread/300513-durch-ein-im-editor-eingef%C3%BCgter-smiley-wird-die-seite-nach-oben-geschoben/
Alexander Ebert [Mon, 10 Jul 2023 10:06:33 +0000 (12:06 +0200)]
Merge branch '5.5'
Alexander Ebert [Mon, 10 Jul 2023 10:04:39 +0000 (12:04 +0200)]
Merge branch '5.4' into 5.5
Alexander Ebert [Mon, 10 Jul 2023 09:59:31 +0000 (11:59 +0200)]
Migrate the ACP news from Twitter to woltlab.com
Tim Düsterhus [Mon, 10 Jul 2023 07:44:37 +0000 (09:44 +0200)]
Update focus-trap
https://www.woltlab.com/community/thread/300576-benachrichtungen-unter-firefox-102-13-0esr/?postID=
1930817#post1930817
Alexander Ebert [Fri, 7 Jul 2023 11:14:14 +0000 (13:14 +0200)]
Fix the selection of color variables in Safari
Alexander Ebert [Thu, 6 Jul 2023 15:47:57 +0000 (17:47 +0200)]
Sync the appearance of suggestions with the style
See https://www.woltlab.com/community/thread/300529-styling-men%C3%BC-erw%C3%A4hnungen/
Alexander Ebert [Thu, 6 Jul 2023 14:57:34 +0000 (16:57 +0200)]
Fix the notification counter on the favicon
The selector was no longer valid when the `rel` property of the favicon was updated in
a1513aeb5fffb4a540e817e5e3424bf45ff5609b
Alexander Ebert [Thu, 6 Jul 2023 14:41:20 +0000 (16:41 +0200)]
Fix the check of quoted users
The check against the host was simplified in
2e238f48617d5d2a97d1e2b7a0d296337570b396, but the condition was incorrectly modified.
Marcel Werk [Thu, 6 Jul 2023 14:06:09 +0000 (16:06 +0200)]
Merge pull request #5568 from WoltLab/breadcrumbs-css
Overhaul CSS for breadcrumbs
Marcel Werk [Thu, 6 Jul 2023 12:06:39 +0000 (14:06 +0200)]
Fix/unify use of title case
Marcel Werk [Thu, 6 Jul 2023 11:27:36 +0000 (13:27 +0200)]
Overhaul CSS for breadcrumbs
Alexander Ebert [Thu, 6 Jul 2023 10:28:09 +0000 (12:28 +0200)]
Suppress hover states for `.tabularListRow` on touch devices
See https://www.woltlab.com/community/thread/300514-hover-sieht-mobil-nach-wie-vor-doof-aus-in-themenlisten/
Alexander Ebert [Thu, 6 Jul 2023 10:26:09 +0000 (12:26 +0200)]
Suppress the content border at the top of the first message
Alexander Ebert [Thu, 6 Jul 2023 10:18:51 +0000 (12:18 +0200)]
Fix the calculation of element positions with unrestricted body heights
Alexander Ebert [Thu, 6 Jul 2023 10:18:39 +0000 (12:18 +0200)]
Allow the `<html>` and `<body>` element to grow
Alexander Ebert [Thu, 6 Jul 2023 09:18:17 +0000 (11:18 +0200)]
Fix parts of the editor showing through the loading overlay
See https://www.woltlab.com/community/thread/300450-ladezustand-nach-absenden-eines-beitrags-zeigt-drop-down-icons/
Alexander Ebert [Wed, 5 Jul 2023 18:02:56 +0000 (20:02 +0200)]
Migrate the mobile sidebar box layout to CSS grids
This allows us to abandon the utterly broken `columns` and greatly simplifies the `gap` logic.
See https://www.woltlab.com/community/thread/300330-mobile-boxen-beim-darkmode-haben-einen-rahmenfehler/
Alexander Ebert [Wed, 5 Jul 2023 17:36:31 +0000 (19:36 +0200)]
Reintroduce the fixed height of html/body
This is required to force the layout calculation of element positions to be consistent.
See
10cd0f106eafc17411ead418189ddf3a90a439aa
Alexander Ebert [Wed, 5 Jul 2023 17:10:01 +0000 (19:10 +0200)]
Fix the color scheme of `.boxInfo`
See https://www.woltlab.com/community/thread/300490-com-woltlab-wcf-registerbutton-s-boxinfo-class-has-no-effect/
Alexander Ebert [Wed, 5 Jul 2023 16:50:38 +0000 (18:50 +0200)]
Improve the visuals of the mobile message list
See https://www.woltlab.com/community/thread/300501-border-radius-in-mobiler-ansicht-der-messagesidebar/
Alexander Ebert [Wed, 5 Jul 2023 16:29:45 +0000 (18:29 +0200)]
Fix layout jumps causing by collapsing content heights
This is a recurring issue caused by `height: 100%` in this context means “100% of the height”.
`100vh` is relative to the viewport and forces 100% of its height as the elements min-height.
This wasn’t used before, because the browser support was lackluster back then (tm).
Alexander Ebert [Wed, 5 Jul 2023 16:23:56 +0000 (18:23 +0200)]
Prevent content from overflowing the window
Alexander Ebert [Wed, 5 Jul 2023 14:35:29 +0000 (16:35 +0200)]
Reduce repeated `<hr>`, `<br>` and empty `<p>`
Tim Düsterhus [Wed, 5 Jul 2023 12:43:56 +0000 (14:43 +0200)]
Increase MySQL minimum version to 8.0.30 from 8.0.29
MySQL 8.0.29 is so critically broken that the release was officially yanked and
thus is no longer available for download:
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-29.html
> This release is no longer available for download. It was removed due to a
> critical issue that could cause data in InnoDB tables having added columns to
> be interpreted incorrectly. Please upgrade to MySQL 8.0.30 instead.
There is no reason for *anyone* to be running MySQL 8.0.29 and thus we exclude
this version from being supported.
Alexander Ebert [Wed, 5 Jul 2023 11:22:34 +0000 (13:22 +0200)]
Add a preview feature when restoring a draft
See https://www.woltlab.com/community/thread/300352-dialog-entwurf-wiederherstellen-verbessern/
Alexander Ebert [Wed, 5 Jul 2023 10:39:34 +0000 (12:39 +0200)]
Remove a legacy workaround for scroll disable
See https://www.woltlab.com/community/thread/300504-woltlab-suite-6-seite-scrollt-bei-schlie%C3%9Fen-von-modal-fenster-kurz-nach-oben/
Alexander Ebert [Tue, 4 Jul 2023 15:39:03 +0000 (17:39 +0200)]
Fix the support for the alignment of embedded media
Tim Düsterhus [Tue, 4 Jul 2023 14:57:58 +0000 (16:57 +0200)]
Fix PHP 8.2 deprecation in TagCloudCacheBuilder
Alexander Ebert [Tue, 4 Jul 2023 14:43:52 +0000 (16:43 +0200)]
Release 6.0.0 Alpha 4
WoltLab [Tue, 4 Jul 2023 14:37:59 +0000 (14:37 +0000)]
Updating minified JavaScript files
Alexander Ebert [Tue, 4 Jul 2023 14:36:31 +0000 (16:36 +0200)]
Update the CKEditor 5 bundle
Tim Düsterhus [Tue, 4 Jul 2023 14:32:47 +0000 (16:32 +0200)]
Merge pull request #5566 from WoltLab/strip-html
Fix StringUtil::stripHTML()
Tim Düsterhus [Tue, 4 Jul 2023 14:10:40 +0000 (16:10 +0200)]
Fix the HTML tag stripping regex
The previous regex was incorrect (by attempting to support backslash escapes in
HTML attributes), incomprehensible and inefficient (by allowing for
catastrophic backtracking).
Replace it by a much simpler and more correct version that matches:
- Anything between `<` and `>`.
- That starts with an optional `/` for the closing tag.
- Followed by a single a-zA-Z letter.
- Followed by anything not `>`, except when `>` is either correctly singly or
doubly quoted.
Fixes #5558
Alexander Ebert [Tue, 4 Jul 2023 14:06:26 +0000 (16:06 +0200)]
Fix the sizing of input fields on smartphones
See https://www.woltlab.com/community/thread/300456-editor-block-einf%C3%BCgen-mobil/
Tim Düsterhus [Tue, 4 Jul 2023 13:54:59 +0000 (15:54 +0200)]
Merge pull request #5565 from WoltLab/search-index-strip-html
Use DOMDocument + textContent to strip HTML tags for search
Tim Düsterhus [Tue, 4 Jul 2023 13:53:20 +0000 (15:53 +0200)]
Merge pull request #5564 from WoltLab/search-index-no-context
Fix updating the search index if the index manager does not support contexts
Tim Düsterhus [Tue, 4 Jul 2023 13:51:08 +0000 (15:51 +0200)]
Inline the HTML regex patterns in StringUtil
These are very specific to `StringUtil::stripHTML()` and cannot be usefully
used outside of that method. Inline them to improve readability and to remove
them from the public API.
Alexander Ebert [Tue, 4 Jul 2023 13:46:42 +0000 (15:46 +0200)]
Fix the color of active tooltip buttons
See https://www.woltlab.com/community/thread/300483-aktiver-status-beim-positionieren-von-bildern-nicht-erkennbar/
Tim Düsterhus [Tue, 4 Jul 2023 13:40:52 +0000 (15:40 +0200)]
Fix updating the search index if the index manager does not support contexts
With the current logic `SearchIndexManager::setWithContext()` needs to delegate
to `$this->set()` instead of `$searchIndexManager->set()` for the HTML
stripping to work correctly.
see
db5d43f179789e908febb24418c91260005bbd07
Alexander Ebert [Tue, 4 Jul 2023 13:39:36 +0000 (15:39 +0200)]
Add support for attachments in existing messages
See https://www.woltlab.com/community/thread/300484-eingebettete-dateianh%C3%A4nge-werden-beim-bearbeiten-nicht-angezeigt/
Tim Düsterhus [Tue, 4 Jul 2023 13:09:36 +0000 (15:09 +0200)]
Use DOMDocument + textContent to strip HTML tags for search
This is likely going to result in better (i.e. more correct) results compared
to some naive tag stripping. As an example, DOMDocument will correctly
understand and handle HTML entities, specifically `<` and `>` that *need*
to be encoded for use within HTML.
Updating the search index is a somewhat expensive operation anyway, making it
worth the overhead.
see #5558
Tim Düsterhus [Tue, 4 Jul 2023 11:49:10 +0000 (13:49 +0200)]
Sync update_com.woltlab.wcf_6.0_styleVariables.php with install.sql
see
648e43dde01592a235ca64320ed9342bed25bba0
Alexander Ebert [Tue, 4 Jul 2023 11:45:33 +0000 (13:45 +0200)]
Improve the contrast of the content border
See https://www.woltlab.com/community/thread/300400-missing-visual-separation-between-pinned-and-non-pinned-threads-in-dark-mode/
Tim Düsterhus [Tue, 4 Jul 2023 08:52:02 +0000 (10:52 +0200)]
Rebuild WebComponent bundle
Tim Düsterhus [Tue, 4 Jul 2023 08:08:53 +0000 (10:08 +0200)]
Merge branch '5.5'
Tim Düsterhus [Tue, 4 Jul 2023 08:07:05 +0000 (10:07 +0200)]
Update tslib
Tim Düsterhus [Tue, 4 Jul 2023 08:04:38 +0000 (10:04 +0200)]
Update focus-trap and tabbable
Tim Düsterhus [Tue, 4 Jul 2023 08:02:57 +0000 (10:02 +0200)]
Update esbuild
Tim Düsterhus [Tue, 4 Jul 2023 08:02:21 +0000 (10:02 +0200)]
Merge branch '5.5'
Tim Düsterhus [Tue, 4 Jul 2023 07:59:09 +0000 (09:59 +0200)]
Update npm dependencies
Tim Düsterhus [Mon, 3 Jul 2023 15:36:46 +0000 (17:36 +0200)]
Map the `query` as `non-empty-string` in EditorGetMentionSuggestionsAction
see
13cc9092ccc404276c68b009e545aa4fbfe549e5
Alexander Ebert [Mon, 3 Jul 2023 15:32:12 +0000 (17:32 +0200)]
Stop trying to look up mentions when reaching 24 characters
See https://www.woltlab.com/community/thread/300491-mention-detection-in-editor-is-overeager/
Alexander Ebert [Mon, 3 Jul 2023 14:54:17 +0000 (16:54 +0200)]
Convert plain text quotes into their HTML equivalent
See https://www.woltlab.com/community/thread/300419-beim-zitieren-von-aufz%C3%A4hlungen-werden-umbr%C3%BCche-entfernt/
Alexander Ebert [Mon, 3 Jul 2023 13:26:08 +0000 (15:26 +0200)]
Tone down the border of avatar lists in dark mode
See https://www.woltlab.com/community/thread/300470-avatar-border-dark-theme/
Alexander Ebert [Mon, 3 Jul 2023 13:16:41 +0000 (15:16 +0200)]
Prevent the image file name from overlapping the close button
See https://www.woltlab.com/community/thread/300453-bildtitel-kann-von-schlie%C3%9Fen-button-%C3%BCberdeckt-werden/
Alexander Ebert [Mon, 3 Jul 2023 10:29:32 +0000 (12:29 +0200)]
Hide tooltips on mobile
Fixes WoltLab/editor#38
See https://www.woltlab.com/community/thread/300454-editor-unterstrichen-%C3%BCberdeckt-mobil-zwei-icons/
Alexander Ebert [Mon, 3 Jul 2023 10:26:08 +0000 (12:26 +0200)]
Improve the visuals of the sticky editor toolbar
Alexander Ebert [Mon, 3 Jul 2023 09:32:19 +0000 (11:32 +0200)]
Remove the legacy `interactWithRedactor()` wrapper
Alexander Ebert [Sun, 2 Jul 2023 18:58:25 +0000 (20:58 +0200)]
Add a small spacing from the content to the edge of the screen
See https://www.woltlab.com/community/thread/300282-au%C3%9Fenabstand-sidebarboxen-in-mobiler-ansicht/
Alexander Ebert [Sun, 2 Jul 2023 18:56:46 +0000 (20:56 +0200)]
Sync the appearance of quotes in the editor
Alexander Ebert [Sun, 2 Jul 2023 17:42:16 +0000 (19:42 +0200)]
Scroll to the editor when inserting HTML
See https://www.woltlab.com/community/thread/300446-zitate-einf%C3%BCgen-scrollt-nicht-zum-editor/
Alexander Ebert [Sun, 2 Jul 2023 17:12:04 +0000 (19:12 +0200)]
Use the native `<details>` for spoilers and refresh the design
See WoltLab/WCF#4612
Alexander Ebert [Sun, 2 Jul 2023 16:59:24 +0000 (18:59 +0200)]
Add an extra border to increase the contrast of quote boxes
See https://www.woltlab.com/community/thread/300272-unzureichender-farbkontrast-der-zitate/
Alexander Ebert [Sun, 2 Jul 2023 16:57:22 +0000 (18:57 +0200)]
Slightly refresh the visual appearance of code boxes
Marcel Werk [Sun, 2 Jul 2023 16:00:35 +0000 (18:00 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Sun, 2 Jul 2023 16:00:33 +0000 (18:00 +0200)]
Dont hide style changer in mobile view
Alexander Ebert [Fri, 30 Jun 2023 15:54:07 +0000 (17:54 +0200)]
Improve the visuals of the image viewer controls
See https://www.woltlab.com/community/thread/300325-wenig-abstand-bei-den-steuerelementen-der-bildanzeige/
Alexander Ebert [Fri, 30 Jun 2023 15:34:11 +0000 (17:34 +0200)]
Fix the formatting of embedded content in the message preview
See https://www.woltlab.com/community/thread/300428-large-margin-between-type-article-and-headline-for-embedded-contents/
Alexander Ebert [Fri, 30 Jun 2023 13:16:30 +0000 (15:16 +0200)]
Reintroduce the borders on the side of the inline code
See https://www.woltlab.com/community/thread/300345-inline-code-wieder-mit-seitlichem-rahmen/
Alexander Ebert [Fri, 30 Jun 2023 13:14:50 +0000 (15:14 +0200)]
Add the undo/redo feature to CKEditor
See https://www.woltlab.com/community/thread/300366-editor-r%C3%BCckg%C3%A4ngig/
Marcel Werk [Fri, 30 Jun 2023 12:54:01 +0000 (14:54 +0200)]
Merge pull request #5562 from WoltLab/mail-placeholders
Move replacement of placerholders in mail texts into `UserMailBox`
Marcel Werk [Fri, 30 Jun 2023 12:14:10 +0000 (14:14 +0200)]
Merge pull request #5563 from WoltLab/cleanup-clipboard-checkboxes
Cleanup CSS / JS for clipboard checkboxes
Marcel Werk [Fri, 30 Jun 2023 12:10:03 +0000 (14:10 +0200)]
Fix outdated JS file
Marcel Werk [Fri, 30 Jun 2023 12:08:06 +0000 (14:08 +0200)]
Apply suggestions from code review
Marcel Werk [Fri, 30 Jun 2023 12:05:14 +0000 (14:05 +0200)]
Remove obsolete code
Making the label accessible is no longer necessary, since the checkbox is already accessible.
Marcel Werk [Fri, 30 Jun 2023 12:04:21 +0000 (14:04 +0200)]
Cleanup CSS
Marcel Werk [Fri, 30 Jun 2023 11:58:24 +0000 (13:58 +0200)]
Move replacement of placerholders in mail texts into `UserMailBox`
Also added support for an `{$email}` placeholder.
Alexander Ebert [Fri, 30 Jun 2023 11:45:24 +0000 (13:45 +0200)]
Add a default protocol to protocol-less links
See https://www.woltlab.com/community/thread/300389-vorschau-verlinkung-bei-links-in-texten-falsch-verlinkt/
Alexander Ebert [Thu, 29 Jun 2023 17:39:04 +0000 (19:39 +0200)]
Fix the value for the theme color of the dark mode
The value was previously not set if the style already provided an own theme color.
Alexander Ebert [Thu, 29 Jun 2023 16:02:56 +0000 (18:02 +0200)]
Release 6.0.0 Alpha 3
WoltLab [Thu, 29 Jun 2023 15:38:39 +0000 (15:38 +0000)]
Updating minified JavaScript files
Alexander Ebert [Thu, 29 Jun 2023 15:26:36 +0000 (17:26 +0200)]
Update the CKEditor bundle and translations
Alexander Ebert [Thu, 29 Jun 2023 15:08:23 +0000 (17:08 +0200)]
Fix the font style in CKEditor
Alexander Ebert [Thu, 29 Jun 2023 14:54:41 +0000 (16:54 +0200)]
Fix the shortcut for the editor submissions
See https://www.woltlab.com/community/thread/300307-submitting-the-editor-of-a-conversation-message-using-the-access-key-not-possibl/
Alexander Ebert [Thu, 29 Jun 2023 14:08:49 +0000 (16:08 +0200)]
Reorder the editor toolbar and add logical groups through dividers
Alexander Ebert [Thu, 29 Jun 2023 14:03:21 +0000 (16:03 +0200)]
Move the button to remove the formatting into the formatting group
Alexander Ebert [Thu, 29 Jun 2023 14:00:41 +0000 (16:00 +0200)]
Enforce a consistent design of labels
See https://www.woltlab.com/community/thread/300302-label-f%C3%BCr-link-extrem-klein/
Alexander Ebert [Thu, 29 Jun 2023 13:40:26 +0000 (15:40 +0200)]
Add the missing localization of quote author / code file name/line number
See https://www.woltlab.com/community/thread/300304-nicht-%C3%BCbersetzte-texte-im-editor/
Alexander Ebert [Thu, 29 Jun 2023 13:12:32 +0000 (15:12 +0200)]
Remove the tint of icons in flexible button groups
See https://www.woltlab.com/community/thread/300326-icons-bei-checkboxen-nicht-gut-erkennbar/
Alexander Ebert [Thu, 29 Jun 2023 11:50:35 +0000 (13:50 +0200)]
Improve the hover background of labels in dark mode
See https://www.woltlab.com/community/thread/300408-incorrect-hover-text-color-for-default-colored-labels-in-dark-mode/
Alexander Ebert [Thu, 29 Jun 2023 11:34:42 +0000 (13:34 +0200)]
Restrict the maximum height of CKEditor’s lists
See https://www.woltlab.com/community/thread/300306-problem-mit-drop-down-von-sprachauswahl-bei-code-bl%C3%B6cken/
Alexander Ebert [Thu, 29 Jun 2023 11:24:47 +0000 (13:24 +0200)]
Drop the border radius of the sub menu’s top corners
See https://www.woltlab.com/community/thread/300336-submenu-border-radius-top/
Alexander Ebert [Thu, 29 Jun 2023 11:23:41 +0000 (13:23 +0200)]
Force a default tab width of 4 for code boxes
See https://www.woltlab.com/community/thread/300406-tab-l%C3%A4nge-in-code-block-unterschiedlich-in-editor-und-beitrag/
Alexander Ebert [Thu, 29 Jun 2023 11:21:36 +0000 (13:21 +0200)]
Update the theme color when the color scheme is updated
See https://www.woltlab.com/community/thread/300357-theme-color-im-darkmode/
Tim Düsterhus [Thu, 29 Jun 2023 10:17:01 +0000 (12:17 +0200)]
Merge pull request #5560 from WoltLab/prism-dark
Add dark mode variant for Prism highlighting
Alexander Ebert [Thu, 29 Jun 2023 10:12:14 +0000 (12:12 +0200)]
Fix the background color of an unfocused selection
See https://www.woltlab.com/community/thread/300371-markierter-text-im-dark-mode-ist-kaum-sichtbar/
Tim Düsterhus [Thu, 29 Jun 2023 10:00:21 +0000 (12:00 +0200)]
Check for `[data-color-scheme="light"]` instead of `not([data-color-scheme="dark"])`
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Tim Düsterhus [Thu, 29 Jun 2023 09:18:55 +0000 (11:18 +0200)]
Add dark mode variant for Prism highlighting
see https://www.woltlab.com/community/thread/300315-syntax-highlighting-im-dark-mode-unpassend/
Alexander Ebert [Wed, 28 Jun 2023 17:36:24 +0000 (19:36 +0200)]
Fix the hover state of the link balloon tooltip
See https://www.woltlab.com/community/thread/300338-link-bearbeiten-nicht-optimale-farbwahl/