Tim Düsterhus [Wed, 27 Jan 2021 15:32:32 +0000 (16:32 +0100)]
Merge branch '5.3'
Tim Düsterhus [Wed, 27 Jan 2021 15:31:11 +0000 (16:31 +0100)]
Make update_com.woltlab.wcf_5.3_packageServer.php compatible with WCF_N != 1
joshuaruesweg [Wed, 27 Jan 2021 14:59:14 +0000 (15:59 +0100)]
Merge branch '5.3'
joshuaruesweg [Wed, 27 Jan 2021 14:58:09 +0000 (15:58 +0100)]
Merge branch '5.2' into 5.3
Joshua Rüsweg [Wed, 27 Jan 2021 14:57:30 +0000 (15:57 +0100)]
Merge pull request #3908 from WoltLab/pr_build_package
Add wcfsetup workflow
Tim Düsterhus [Wed, 27 Jan 2021 14:51:42 +0000 (15:51 +0100)]
Merge pull request #3901 from WoltLab/require-multifactor
Implement multi-factor requirement
Alexander Ebert [Wed, 27 Jan 2021 14:50:29 +0000 (15:50 +0100)]
Merge pull request #3906 from WoltLab/item-list-input-event
Use the `input` event to detect the comma on Chromium for Android
Tim Düsterhus [Wed, 27 Jan 2021 14:49:02 +0000 (15:49 +0100)]
Fix informal phrase in de.xml
joshuaruesweg [Wed, 27 Jan 2021 14:30:47 +0000 (15:30 +0100)]
Add wcfsetup workflow
This workflow generates the WCFSetup and stores it as an artifact.
Tim Düsterhus [Wed, 27 Jan 2021 14:09:18 +0000 (15:09 +0100)]
Merge pull request #3907 from WoltLab/mfa-update-multiple-requests
Split update_com.woltlab.wcf_5.4_migrate_multifactor across multiple requests
Tim Düsterhus [Wed, 27 Jan 2021 13:04:11 +0000 (14:04 +0100)]
Split update_com.woltlab.wcf_5.4_migrate_multifactor across multiple requests
Resolves #3796
Alexander Ebert [Wed, 27 Jan 2021 12:23:11 +0000 (13:23 +0100)]
Use the `input` event to detect the comma on Chromium for Android
Tim Düsterhus [Wed, 27 Jan 2021 11:48:57 +0000 (12:48 +0100)]
Merge pull request #3905 from WoltLab/benchmark-parameters
Replace placeholders by actual values in Benchmark
Tim Düsterhus [Wed, 27 Jan 2021 11:39:51 +0000 (12:39 +0100)]
Replace placeholders by actual values in Benchmark
In most cases this allows one to simply copy the query to easily edit it within
a MySQL shell. The code (intentionally) does not handle single quotes
correctly. It also truncates the parameter after 100 characters and handles at
most 30 parameters.
Alexander Ebert [Wed, 27 Jan 2021 11:26:46 +0000 (12:26 +0100)]
Merge branch '5.3'
Alexander Ebert [Wed, 27 Jan 2021 11:20:57 +0000 (12:20 +0100)]
Improved message for rejected credentials on paid packages (#3903)
joshuaruesweg [Wed, 27 Jan 2021 11:03:47 +0000 (12:03 +0100)]
Throw NotImplementedException exception for unsupported method call
Tim Düsterhus [Wed, 27 Jan 2021 10:57:40 +0000 (11:57 +0100)]
Add dev tools description for multi-factor object type definition (#3897)
see #3892
Co-authored-by: Matthias Schmidt <gravatronics@live.com>
joshuaruesweg [Wed, 27 Jan 2021 10:54:50 +0000 (11:54 +0100)]
Change default username in dev installation to 'dev'
Closes #3866
joshuaruesweg [Wed, 27 Jan 2021 10:46:35 +0000 (11:46 +0100)]
Use FQN for internal PHP functions
joshuaruesweg [Wed, 27 Jan 2021 10:42:23 +0000 (11:42 +0100)]
Fix codestyle
joshuaruesweg [Wed, 27 Jan 2021 10:38:40 +0000 (11:38 +0100)]
Update phpBB3 password hash
Closes #3885
Matthias Schmidt [Wed, 27 Jan 2021 09:57:41 +0000 (10:57 +0100)]
Reformat SQL queries in install and update scripts
Marcel Werk [Tue, 26 Jan 2021 15:46:33 +0000 (16:46 +0100)]
missing id attribute
Tim Düsterhus [Tue, 26 Jan 2021 14:58:25 +0000 (15:58 +0100)]
Enforce the multi-factor requirement in ACP
Tim Düsterhus [Tue, 26 Jan 2021 14:40:48 +0000 (15:40 +0100)]
Add TMultifactorRequirementEnforcer
Tim Düsterhus [Tue, 26 Jan 2021 14:30:31 +0000 (15:30 +0100)]
Check for multi-factor requirement in MultifactorDisableForm
Tim Düsterhus [Tue, 26 Jan 2021 14:22:28 +0000 (15:22 +0100)]
Add RejectEverythingFormField
Tim Düsterhus [Tue, 26 Jan 2021 14:17:45 +0000 (15:17 +0100)]
Reduce duplication in MultifactorDisableForm
Tim Düsterhus [Tue, 26 Jan 2021 13:58:12 +0000 (14:58 +0100)]
Add User::requiresMultifactor()
Tim Düsterhus [Tue, 26 Jan 2021 13:49:59 +0000 (14:49 +0100)]
Add requireMultifactor property to user groups
Tim Düsterhus [Tue, 26 Jan 2021 14:15:02 +0000 (15:15 +0100)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Tue, 26 Jan 2021 14:14:48 +0000 (15:14 +0100)]
Merge branch '5.3'
Tim Düsterhus [Tue, 26 Jan 2021 14:12:20 +0000 (15:12 +0100)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Tue, 26 Jan 2021 14:11:49 +0000 (15:11 +0100)]
Merge pull request #3900 from WoltLab/hasOwnerAccess
Fix User::hasOwnerAccess()
Tim Düsterhus [Tue, 26 Jan 2021 14:03:22 +0000 (15:03 +0100)]
Check owner access after checking controller blacklist in RequestHandler
This ensures that the check only happens when absolute required.
Tim Düsterhus [Tue, 26 Jan 2021 14:00:28 +0000 (15:00 +0100)]
Remove caching from User::hasOwnerAccess()
The current caching logic is buggy as reported in issue #3899. This patch
removes this caching, as this method already is quite fast and it also is
seldomly called. Within the frontend it is only called when the user is banned.
Fixes #3899
joshuaruesweg [Tue, 26 Jan 2021 13:08:58 +0000 (14:08 +0100)]
Show content from all content languages for guests
Closes #3713
Tim Düsterhus [Tue, 26 Jan 2021 09:11:15 +0000 (10:11 +0100)]
Remove useless WCFSetup workaround in SessionHandler::needsReauthentication()
Apparently I did not conduct my testing properly yesterday and piled on
non-effective workarounds for the WCFSetup issue. This one is particularly bad,
because I inverted the condition, disabling reauthentication everywhere, except
in WCFSetup.
Thus this patch removes this buggy workaround again.
see
ff5d8cec55f0a953a353165b2d996f84a56838f6
see
4b5f3b084ef062b48eaba18b3f497ba89743ddcd
Alexander Ebert [Mon, 25 Jan 2021 18:36:08 +0000 (19:36 +0100)]
The compression quality was not applied in Imagick
Tim Düsterhus [Mon, 25 Jan 2021 18:13:46 +0000 (19:13 +0100)]
Fix the cookie refresh after WCFSetup
We need to set user_session, as acp_session is gone.
Tim Düsterhus [Mon, 25 Jan 2021 18:13:14 +0000 (19:13 +0100)]
Move the call to registerReauthentication() to WCFSetup
This was forgotten in the previous commit.
Tim Düsterhus [Mon, 25 Jan 2021 18:04:17 +0000 (19:04 +0100)]
Unbreak WCFSetup
Alexander Ebert [Mon, 25 Jan 2021 16:18:28 +0000 (17:18 +0100)]
Dynamic WebP avatars (#3889)
Matthias Schmidt [Mon, 25 Jan 2021 15:31:07 +0000 (16:31 +0100)]
Replace usage of `setObjectTitles()` with `replaceLinks()`
See #3881
Matthias Schmidt [Mon, 25 Jan 2021 15:26:13 +0000 (16:26 +0100)]
Use `UserProfileRuntimeCache` instead of `UserProfile::getUserProfiles()`
See #3880
Alexander Ebert [Mon, 25 Jan 2021 15:25:16 +0000 (16:25 +0100)]
New UI design for the list of attachments (#3890)
* New UI design for the list of attachments
* Exchange the icon on focus (a11y)
* Improved a11y for attachments
* Inconsistent indentation
* Consistent use of whitespaces
* Fix indentation in en.xml
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Matthias Schmidt [Mon, 25 Jan 2021 15:13:11 +0000 (16:13 +0100)]
Replace usage of `LikeHandler` with `ReactionHandler`
… whereever possible.
Matthias Schmidt [Mon, 25 Jan 2021 14:53:14 +0000 (15:53 +0100)]
Stop using `TLegacyUserPropertyAccess`
See #3880
Matthias Schmidt [Mon, 25 Jan 2021 14:30:10 +0000 (15:30 +0100)]
Add dev tools description for flood control object type definition
See #3892
Matthias Schmidt [Mon, 25 Jan 2021 14:22:58 +0000 (15:22 +0100)]
Add button to delete missing phrases logs for phrases existing now (#3896)
Replaces #3716
Marcel Werk [Mon, 25 Jan 2021 14:11:20 +0000 (15:11 +0100)]
Merge pull request #3893 from WoltLab/deprecate-gravatar
Deprecate Gravatar support
Tim Düsterhus [Mon, 25 Jan 2021 14:02:43 +0000 (15:02 +0100)]
Add SCSS Prettiering to .git-blame-ignore-revs
Tim Düsterhus [Mon, 25 Jan 2021 14:02:18 +0000 (15:02 +0100)]
Use prettier for SCSS (#3895)
Tim Düsterhus [Mon, 25 Jan 2021 13:45:19 +0000 (14:45 +0100)]
Add PHPDoc to update scripts
Tim Düsterhus [Mon, 25 Jan 2021 13:34:34 +0000 (14:34 +0100)]
Deprecate Gravatar support
Resolves #3658
Tim Düsterhus [Wed, 8 Jul 2020 12:50:28 +0000 (14:50 +0200)]
Fix parsing of packageName / packageDescription in PackageArchive
Previously a lowercase key remained in the returned array.
Tim Düsterhus [Mon, 25 Jan 2021 12:58:46 +0000 (13:58 +0100)]
Merge branch '5.3'
Tim Düsterhus [Mon, 25 Jan 2021 12:58:27 +0000 (13:58 +0100)]
Tim Düsterhus [Mon, 25 Jan 2021 12:54:58 +0000 (13:54 +0100)]
Tim Düsterhus [Mon, 25 Jan 2021 12:45:21 +0000 (13:45 +0100)]
Add previous commit to .git-blame-ignore-revs
Tim Düsterhus [Mon, 25 Jan 2021 12:44:53 +0000 (13:44 +0100)]
Fix bad merge in EventListenerPackageInstallationPlugin
Tim Düsterhus [Mon, 25 Jan 2021 12:05:50 +0000 (13:05 +0100)]
Apply the wcf1_event_listener database migration in 5.4 as well
see
d836d365d30d44c6140dda17f82b9bd245db03e9
Tim Düsterhus [Mon, 25 Jan 2021 12:03:52 +0000 (13:03 +0100)]
Merge branch '5.3'
Tim Düsterhus [Mon, 25 Jan 2021 12:02:31 +0000 (13:02 +0100)]
Reformat update_com.woltlab.wcf_5.3.3_db.php to use Tabs
Code style for 5.3 expects tabs, not spaces. PHP CodeSniffer complains.
Tim Düsterhus [Mon, 25 Jan 2021 12:01:23 +0000 (13:01 +0100)]
Merge branch '5.3'
Tim Düsterhus [Mon, 25 Jan 2021 11:58:17 +0000 (12:58 +0100)]
Tim Düsterhus [Mon, 25 Jan 2021 11:53:30 +0000 (12:53 +0100)]
Revert "Reformat EventListenerPackageInstallationPlugin to PSR-12"
This reverts commit
9faac4ad4b5d27f9159e531b645ed3f4088adb3a.
Tim Düsterhus [Mon, 25 Jan 2021 11:50:20 +0000 (12:50 +0100)]
Merge pull request #3891 from WoltLab/content-type
Fix content-type response headers
Tim Düsterhus [Mon, 25 Jan 2021 10:45:11 +0000 (11:45 +0100)]
Deprecate ACPSession DBO
Tim Düsterhus [Mon, 25 Jan 2021 10:42:32 +0000 (11:42 +0100)]
Remove obsolete `$session` property from SessionHandler
This property was unused.
Tim Düsterhus [Mon, 25 Jan 2021 10:06:05 +0000 (11:06 +0100)]
Fix content-type for style export
- Use proper application/gzip
- Remove useless charset
Tim Düsterhus [Mon, 25 Jan 2021 10:03:58 +0000 (11:03 +0100)]
Add `charset=UTF-8` to `Content-Type` header
Resolves #3856
Tim Düsterhus [Mon, 25 Jan 2021 09:06:15 +0000 (10:06 +0100)]
Set ->autoFocus() for UserPasswordField in ReauthenticationForm
Tim Düsterhus [Mon, 25 Jan 2021 09:04:44 +0000 (10:04 +0100)]
Add .git-blame-ignore-revs
This is for use with `blame.ignoreRevsFile` in git.
Tim Düsterhus [Mon, 25 Jan 2021 08:18:19 +0000 (09:18 +0100)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Mon, 25 Jan 2021 08:17:56 +0000 (09:17 +0100)]
Whitelist `array_fill` in enterprise mode
Alexander Ebert [Sun, 24 Jan 2021 14:07:13 +0000 (15:07 +0100)]
Merge branch 'reactions-mobile-ux'
Alexander Ebert [Sun, 24 Jan 2021 12:40:16 +0000 (13:40 +0100)]
Display the reaction button on mobile
See #3888
Matthias Schmidt [Sun, 24 Jan 2021 12:17:55 +0000 (13:17 +0100)]
Merge branch '5.3'
Matthias Schmidt [Sun, 24 Jan 2021 12:15:24 +0000 (13:15 +0100)]
Support `environment=all` in event listener PIP GUI
Matthias Schmidt [Sun, 24 Jan 2021 12:13:38 +0000 (13:13 +0100)]
Reformat EventListenerPackageInstallationPlugin to PSR-12
Matthias Schmidt [Sun, 24 Jan 2021 12:02:22 +0000 (13:02 +0100)]
Support `environment=all` for event listeners in database
See #3145
Matthias Schmidt [Sun, 24 Jan 2021 11:53:33 +0000 (12:53 +0100)]
Convert plain links to user profiles to titled links with username
Close #3657
Matthias Schmidt [Sun, 24 Jan 2021 11:47:13 +0000 (12:47 +0100)]
Fix `IDatabaseTableColumn::renameTo()` for PHP < 8
Alexander Ebert [Sat, 23 Jan 2021 15:11:33 +0000 (16:11 +0100)]
Rogue whitespace
Alexander Ebert [Sat, 23 Jan 2021 14:52:22 +0000 (15:52 +0100)]
Inconsistent function names and missing types
Tim Düsterhus [Fri, 22 Jan 2021 17:47:40 +0000 (18:47 +0100)]
Apply PSR-12 code style (#3886)
* Apply PSR-12 code style
* Replaces remaining tabs with spaces in `ViewableMedia::getElementTag()`
* Reformat SQL queries using spaces
* Do not use `use function`
phpcs and phpcs-fixer do not agree on how they should be ordered.
* Disable buggy phpcs rules
* Fix PHPDoc placement in install / update scripts
* Ignore more unfixable errors
* Fix a bunch of line length violations
* Fix a bunch of line length violations
* Fix a bunch of line length violations
* Fix a bunch of line length violations
* Fix a bunch of line length violations
* Fix a bunch of line length violations
* Fix a bunch of line length violations
* Fix a bunch of line length violations
* Code style adjustments
* Fix PHPStorm comment stupidity
* Make phpcs happy
* Code style adjustments
* Make phpcs happy
* Stop touching install.php, test.php and core.functions.php using phpcs-fixer
* Properly ignore core.functions.php for phpcs
Co-authored-by: Matthias Schmidt <gravatronics@live.com>
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Matthias Schmidt [Fri, 22 Jan 2021 14:12:43 +0000 (15:12 +0100)]
Fix `Ui/Message/Manager.getPermission()` for permissions with dashes
Matthias Schmidt [Thu, 21 Jan 2021 15:46:49 +0000 (16:46 +0100)]
Tim Düsterhus [Thu, 21 Jan 2021 15:12:36 +0000 (16:12 +0100)]
Make phpcs happy with PasswordUtil
Tim Düsterhus [Thu, 21 Jan 2021 15:03:17 +0000 (16:03 +0100)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Thu, 21 Jan 2021 15:02:54 +0000 (16:02 +0100)]
Merge branch '5.3'
Tim Düsterhus [Thu, 21 Jan 2021 15:02:28 +0000 (16:02 +0100)]
Merge pull request #3884 from WoltLab/password-phpbb-combined
Add support for phpBB's combined hash
Tim Düsterhus [Wed, 30 Sep 2020 09:39:25 +0000 (11:39 +0200)]
Add support for phpBB's combined hash
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Tim Düsterhus [Thu, 21 Jan 2021 11:45:06 +0000 (12:45 +0100)]
Merge pull request #3858 from WoltLab/session-merge
Merge Frontend and ACP sessions
Tim Düsterhus [Thu, 21 Jan 2021 11:28:54 +0000 (12:28 +0100)]
Remove __reauthenticationLoginAs.tpl from syncTemplates.json
They intentionally differ in contents.
Tim Düsterhus [Thu, 21 Jan 2021 11:24:15 +0000 (12:24 +0100)]
Add logout and change user hint to Reauthentication in ACP
Tim Düsterhus [Thu, 21 Jan 2021 10:49:13 +0000 (11:49 +0100)]
Fix SessionHandler::getCookieTimestep()
The previous commit
563510e451c4b9da820a68006b327413b23d0c30 did not actually
use the $window variable in the division.
Tim Düsterhus [Thu, 21 Jan 2021 10:48:12 +0000 (11:48 +0100)]
Extend the USER_SESSION_LIFETIME to 60 days