Alexander Ebert [Fri, 3 Jun 2022 13:10:21 +0000 (15:10 +0200)]
Enable the upgrade to WoltLab Suite 5.5
Based on
41f100782ce6abe92f144810b719c15e53bf4849
Tim Düsterhus [Fri, 3 Jun 2022 12:21:57 +0000 (14:21 +0200)]
Merge pull request #4849 from WoltLab/package-override-55
Update checks in PackageEnableUpgradeOverrideForm for 5.5
Tim Düsterhus [Fri, 3 Jun 2022 12:18:56 +0000 (14:18 +0200)]
Improve issue description in PackageEnableUpgradeOverrideForm
Tim Düsterhus [Fri, 3 Jun 2022 12:14:54 +0000 (14:14 +0200)]
Fix PackageEnableUpgradeOverrideForm
The form differs from the update scripts by also having a title for each issue.
Tim Düsterhus [Fri, 3 Jun 2022 08:08:54 +0000 (10:08 +0200)]
Update checks in PackageEnableUpgradeOverrideForm for 5.5
- update_com.woltlab.wcf_5.5_ensureInnoDbSearch.php
Tim Düsterhus [Fri, 3 Jun 2022 08:13:41 +0000 (10:13 +0200)]
Drop duplicate empty line in RequestHandler
Alexander Ebert [Thu, 2 Jun 2022 14:11:32 +0000 (16:11 +0200)]
Preset was lacking the inversion of permissions
See https://www.woltlab.com/community/thread/295793-box-kopieren-option-wird-nicht-%C3%BCbernommen/
Alexander Ebert [Thu, 2 Jun 2022 14:02:02 +0000 (16:02 +0200)]
Force a refresh of CodeMirror on tab navigation
See https://www.woltlab.com/community/thread/295824-codemirror-gerne-mal-nicht-initialisiert/
Alexander Ebert [Thu, 2 Jun 2022 08:22:58 +0000 (10:22 +0200)]
Release 5.4.18
Tim Düsterhus [Tue, 31 May 2022 13:42:50 +0000 (15:42 +0200)]
Adjust PHP versions in environment check for 5.5
see
598b72301a2cdcd0f3a0c1196f6fc1107e01650e
(cherry picked from commit
c2ae090f6bf0a0eefd5eaf9796095a4ddd18c23a)
WoltLab [Wed, 1 Jun 2022 14:46:52 +0000 (14:46 +0000)]
Updating minified JavaScript files
Alexander Ebert [Wed, 1 Jun 2022 14:41:15 +0000 (16:41 +0200)]
Release 5.4.17
Alexander Ebert [Wed, 1 Jun 2022 14:40:30 +0000 (16:40 +0200)]
Merge branch '5.3' into 5.4
Alexander Ebert [Wed, 1 Jun 2022 14:37:56 +0000 (16:37 +0200)]
Release 5.3.23
Alexander Ebert [Wed, 1 Jun 2022 14:37:15 +0000 (16:37 +0200)]
Merge branch '5.2' into 5.3
Alexander Ebert [Wed, 1 Jun 2022 14:34:57 +0000 (16:34 +0200)]
Release 5.2.21
Alexander Ebert [Wed, 1 Jun 2022 14:29:04 +0000 (16:29 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Wed, 1 Jun 2022 14:26:21 +0000 (16:26 +0200)]
Release 3.1.29
Tim Düsterhus [Tue, 31 May 2022 14:43:11 +0000 (16:43 +0200)]
Update to setup-node@v3
Tim Düsterhus [Tue, 31 May 2022 14:30:03 +0000 (16:30 +0200)]
Check the WCF_VERSION only if the result might have changed
Tim Düsterhus [Tue, 31 May 2022 14:21:25 +0000 (16:21 +0200)]
Add workflow to check the WCF_VERSION
Tim Düsterhus [Tue, 31 May 2022 13:50:13 +0000 (15:50 +0200)]
Tim Düsterhus [Tue, 31 May 2022 13:41:28 +0000 (15:41 +0200)]
Adjust PHP versions in environment check for 5.4
see
598b72301a2cdcd0f3a0c1196f6fc1107e01650e
Tim Düsterhus [Tue, 31 May 2022 13:39:48 +0000 (15:39 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Tue, 31 May 2022 13:36:26 +0000 (15:36 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Tue, 31 May 2022 13:35:00 +0000 (15:35 +0200)]
Adjust PHP versions in environment check for 5.2
see
598b72301a2cdcd0f3a0c1196f6fc1107e01650e
Tim Düsterhus [Tue, 31 May 2022 13:33:43 +0000 (15:33 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Tue, 31 May 2022 13:31:44 +0000 (15:31 +0200)]
Merge pull request #4840 from WoltLab/system-environment-check
Add basic check for the runtime environment
Tim Düsterhus [Tue, 31 May 2022 13:11:02 +0000 (15:11 +0200)]
Add basic check for the runtime environment
Running WoltLab Suite in an unsupported environment might work for the
majority of requests, some requests might fail very visibly. But there
also is a third type: A request that *appear* to execute properly, but
that subtly behaves incorrectly, due to a change in PHP's behavior.
The latter type is dangerous, as those requests might introduce errors
into the dataset that are very hard to impossible to correct after the
fact because the necessary information to fix up the data is no longer
available.
Prevent this situation from occuring by performing a basic test of the
runtime environment and halting processing early if this test fails to
ensure that it processed as little as possible.
Tim Düsterhus [Tue, 31 May 2022 12:57:44 +0000 (14:57 +0200)]
Enable HTML escaping of `->errorMessage` in packageUpdateServerList.tpl
This is not exploitable for a full-blown XSS attack, as any HTML tags are
stripped. Nonetheless the `"` character can cause issues, as the value is also
displayed in an HTML attribute and the error message contains uncontrolled
content.
Tim Düsterhus [Wed, 25 May 2022 13:43:01 +0000 (15:43 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 25 May 2022 13:33:31 +0000 (15:33 +0200)]
Regenerate composer autoloader
Tim Düsterhus [Wed, 25 May 2022 13:31:40 +0000 (15:31 +0200)]
Tim Düsterhus [Wed, 25 May 2022 13:30:33 +0000 (15:30 +0200)]
Regenerate composer autoloader
Alexander Ebert [Mon, 23 May 2022 17:08:46 +0000 (19:08 +0200)]
Force case-insensitive check for smiley codes
The smiley table uses a case-insensitive unique key for the smiley code.
See https://www.woltlab.com/community/thread/295708-bug-beim-erstellen-eines-smileys-mit-bereits-vorhandenem-smileycode-duplikat/
Tim Düsterhus [Mon, 23 May 2022 07:58:20 +0000 (09:58 +0200)]
Fix typo in de.xml
Tim Düsterhus [Mon, 16 May 2022 09:36:19 +0000 (11:36 +0200)]
Fix `wcf.user.register.error.blacklistMatches` language variable in RegisterForm
Marcel Werk [Sat, 14 May 2022 11:46:05 +0000 (13:46 +0200)]
Truncate error message in cronjob log if necessary
Tim Düsterhus [Thu, 12 May 2022 13:38:20 +0000 (15:38 +0200)]
Merge pull request #4798 from pehbeh/patch-1
Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl
pehbeh [Thu, 12 May 2022 13:31:54 +0000 (15:31 +0200)]
Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl
Tim Düsterhus [Thu, 12 May 2022 11:48:13 +0000 (13:48 +0200)]
Update URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl
Tim Düsterhus [Wed, 11 May 2022 12:56:48 +0000 (14:56 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:56:09 +0000 (14:56 +0200)]
Add the `required` attribute to the recipientID select in contact.tpl
see
a8490749c3ba7014380d55462fc45dd635c1d71c
Tim Düsterhus [Wed, 11 May 2022 12:49:48 +0000 (14:49 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:49:24 +0000 (14:49 +0200)]
Indicate that selecting a recipient is required in contact.tpl
Tim Düsterhus [Wed, 11 May 2022 09:38:47 +0000 (11:38 +0200)]
Drop obsolete update_com.woltlab.wcf_5.4.15_deleteDsStore.php
Tim Düsterhus [Tue, 10 May 2022 07:25:42 +0000 (09:25 +0200)]
Fix English versions of `wcf.user.security.multifactor.backup.authenticationEmail.body.*`
The phrases contained broken template scripting, due to the use of the `'`
apostroph within a single quoted string.
Tim Düsterhus [Fri, 6 May 2022 13:11:45 +0000 (15:11 +0200)]
Remove the codestyle workflow from branches that are not master
Marcel Werk [Sat, 7 May 2022 15:41:59 +0000 (17:41 +0200)]
Merge branch '5.3' into 5.4
Marcel Werk [Sat, 7 May 2022 15:41:46 +0000 (17:41 +0200)]
Merge branch '5.2' into 5.3
Marcel Werk [Sat, 7 May 2022 15:40:48 +0000 (17:40 +0200)]
Revert "Show always an no selection option in custom select options build with the OptionHandler"
This reverts commit
6fef8b82e15794eee5317e6b15bb0670f137315c.
Tim Düsterhus [Thu, 5 May 2022 13:23:19 +0000 (15:23 +0200)]
Update npm dependencies
Tim Düsterhus [Tue, 3 May 2022 13:07:53 +0000 (15:07 +0200)]
Merge pull request #4768 from WoltLab/sitemap-page
Fix handling of CMS pages in sitemap
Tim Düsterhus [Tue, 3 May 2022 11:57:49 +0000 (13:57 +0200)]
Fix handling of CMS pages in sitemap
Delegate the visibility control and access control to the appropriate methods
in \wcf\data\page\Page instead of reimplementing it from scratch. Most notably
the inversion of the page ACL was not implemented correctly within the sitemap.
see
92fba0538afc1d88f411db1a80553af2d17c09b4
Closes #4767
Co-authored-by: mutec <mysterycode@mysterycode.de>
Tim Düsterhus [Mon, 2 May 2022 07:25:38 +0000 (09:25 +0200)]
Merge pull request #4766 from mutec/appmanmudose
fix application management in multi domain setups
mutec [Sun, 1 May 2022 20:53:53 +0000 (22:53 +0200)]
fix application management in multi domain setups
Changing the landing pages of apps was failing since the domain name for single-domain-setups was validated for any case, but is not set when using a multi-domain-setup.
This lead to an un-meaningful error-message saying something is incorrect.
Tim Düsterhus [Thu, 28 Apr 2022 10:36:23 +0000 (12:36 +0200)]
Add the Drupal8 hashing algorithm
Tim Düsterhus [Thu, 28 Apr 2022 10:21:19 +0000 (12:21 +0200)]
Fix the TPhpass algorithm
The salt extraction used `mb_strpos` where `mb_substr` needs to be used.
see
c586e46e62dd1d714b7c7db7911eb6cf5d96cc7e
Tim Düsterhus [Wed, 27 Apr 2022 07:20:17 +0000 (09:20 +0200)]
Match stop words case insensitively in MysqlSearchEngine
Tim Düsterhus [Wed, 27 Apr 2022 07:18:47 +0000 (09:18 +0200)]
Replace MysqlSearchEngine::getStopWords() by ::isStopWord()
Sascha Greuel [Mon, 25 Apr 2022 10:32:11 +0000 (12:32 +0200)]
Set explicit `referrerpolicy` for Vimeo embeds
see
936c0f6d5d3f5a811110f7add4fa688a3e9a8377
see https://www.woltlab.com/community/thread/295351/?postID=
1891462#post1891462
Resolves #4755
Tim Düsterhus [Mon, 25 Apr 2022 10:49:48 +0000 (12:49 +0200)]
Set explicit `referrerpolicy` for YouTube embeds
YouTube requires the `Referer` header to be set for (some) embeds to work. By
using the attribute any `referrer-policy` header set on the top level document
is overridden (e.g. `same-origin`).
Co-authored-by: Sascha Greuel <github@1-2.dev>
Tim Düsterhus [Fri, 22 Apr 2022 13:26:13 +0000 (15:26 +0200)]
Remove reference to CONTRIBUTING.md from README.md
see
5d7b7d602e0f6efb077bffda4b3ecceed8534810
Alexander Ebert [Thu, 21 Apr 2022 13:12:48 +0000 (15:12 +0200)]
Detect italic/underline text pasted from Google Docs
Marcel Werk [Wed, 20 Apr 2022 09:17:27 +0000 (11:17 +0200)]
Fetching a remote avatar didn't work if user doesn't have to permission to upload avatars
joshuaruesweg [Tue, 19 Apr 2022 08:18:31 +0000 (10:18 +0200)]
Fix fetching userID for multilanguage articles
joshuaruesweg [Mon, 18 Apr 2022 08:36:19 +0000 (10:36 +0200)]
Use spaces instead of tabs
joshuaruesweg [Mon, 18 Apr 2022 08:31:40 +0000 (10:31 +0200)]
Prevent firing notifications for awarding own trophies
Alexander Ebert [Thu, 14 Apr 2022 14:57:41 +0000 (16:57 +0200)]
Release 5.4.16
Alexander Ebert [Thu, 14 Apr 2022 14:47:23 +0000 (16:47 +0200)]
Merge branch '5.3' into 5.4
Alexander Ebert [Thu, 14 Apr 2022 14:45:23 +0000 (16:45 +0200)]
Release 5.3.22
Alexander Ebert [Thu, 14 Apr 2022 14:25:02 +0000 (16:25 +0200)]
Removed the outdated `CONTRIBUTING.md`
The file is heavily outdated and badly presented on GitHub. With WoltLab Suite 5.4 we switched to PSR-12 and Prettier anyway, so there is no need to explain any special rules.
Closes #4600
Marcel Werk [Thu, 14 Apr 2022 12:26:23 +0000 (14:26 +0200)]
Attached images with mismatched proportions got mangled
Alexander Ebert [Thu, 14 Apr 2022 09:47:35 +0000 (11:47 +0200)]
Empty code boxes partially collapsed the layout
See https://www.woltlab.com/community/thread/295182-leere-code-box-ist-kaputt/
Tim Düsterhus [Wed, 13 Apr 2022 07:17:30 +0000 (09:17 +0200)]
Fix typo in en.xml
Alexander Ebert [Tue, 12 Apr 2022 13:20:42 +0000 (15:20 +0200)]
Release 5.4.16 dev 1
WoltLab [Tue, 12 Apr 2022 12:39:44 +0000 (12:39 +0000)]
Updating minified JavaScript files
Alexander Ebert [Tue, 12 Apr 2022 12:32:56 +0000 (14:32 +0200)]
Removing an attachment did not purge copies
See https://www.woltlab.com/community/thread/295032-dateianh%C3%A4nge-aktualsieren-sich-nicht-beim-l%C3%B6schen/
WoltLab [Tue, 12 Apr 2022 09:53:44 +0000 (09:53 +0000)]
Updating minified JavaScript files
Alexander Ebert [Mon, 11 Apr 2022 15:05:49 +0000 (17:05 +0200)]
Overlaying images discarded the transparency
See https://www.woltlab.com/community/thread/295124-imagickimageadapter-overlayen-zweier-bilder-mit-alpha-channel-entfernt-transpare/
Alexander Ebert [Mon, 11 Apr 2022 14:00:58 +0000 (16:00 +0200)]
Merge pull request #4700 from WoltLab/54-disallow-default-value-for-blob-text
Disallow default values for BLOB and TEXT columns
Tim Düsterhus [Mon, 11 Apr 2022 11:51:00 +0000 (13:51 +0200)]
Allow `null` in `TUnsupportedDefaultValue`
When fetching the column definition from the database MySQL will return `null`
as the default value for BLOB and TEXT column even if the column itself is
`NOT NULL`.
Alexander Ebert [Mon, 11 Apr 2022 10:45:24 +0000 (12:45 +0200)]
Incorrect code formatting
Alexander Ebert [Mon, 11 Apr 2022 10:41:36 +0000 (12:41 +0200)]
Missing cache reset after manually adding phrases
See https://www.woltlab.com/community/thread/295020-text-hinzuf%C3%BCgen-cache-wird-nicht-geleert/
Tim Düsterhus [Fri, 8 Apr 2022 10:03:23 +0000 (12:03 +0200)]
Remove accidentally added space in MysqlSearchEngine
Tim Düsterhus [Fri, 8 Apr 2022 10:00:53 +0000 (12:00 +0200)]
Do not add the `+` prefix to search terms matching an InnoDB stop word
This is issue is effectively identical to the one fixed in commit
247d9cc51af9cd78395e2e7600bacbc2ffdf918b.
Tim Düsterhus [Wed, 6 Apr 2022 11:02:02 +0000 (13:02 +0200)]
Ignore prefixes that are not separated with a space in MysqlSearchEngine::splitIntoTerms()
Marcel Werk [Tue, 5 Apr 2022 09:20:31 +0000 (11:20 +0200)]
Banning a user without entering an unbanning date leads to error message
Alexander Ebert [Mon, 4 Apr 2022 17:08:41 +0000 (19:08 +0200)]
Detect Firefox in Favico.js based on CSS
See https://www.woltlab.com/community/thread/294994-verwendung-von-installtrigger-in-favico-js-vermeiden/
Alexander Ebert [Mon, 4 Apr 2022 17:01:12 +0000 (19:01 +0200)]
Verify that the active dialog is closable
See https://www.woltlab.com/community/thread/294867-verschachtelte-dialoge-verwerfen-optionen-des-1-dialogs/
Sir-Will [Sun, 3 Apr 2022 01:19:51 +0000 (03:19 +0200)]
Update google console link
Closes #4716
Marcel Werk [Thu, 31 Mar 2022 12:05:56 +0000 (14:05 +0200)]
Article system allowed access to titles of hidden articles
The problem was caused by a redirect to the Canonical URL before the permissions were checked.
Marcel Werk [Tue, 29 Mar 2022 12:36:13 +0000 (14:36 +0200)]
Floating of attachments in simplified HTML did not work properly
Marcel Werk [Tue, 29 Mar 2022 12:01:36 +0000 (14:01 +0200)]
Incorrect handling of GIF cover photos when rebuilding users
Tim Düsterhus [Wed, 23 Mar 2022 08:10:40 +0000 (09:10 +0100)]
Whitelist `basename` in enterprise mode
Tim Düsterhus [Mon, 21 Mar 2022 10:08:46 +0000 (11:08 +0100)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Mon, 21 Mar 2022 10:03:59 +0000 (11:03 +0100)]
Merge pull request #4706 from WoltLab/guzzle-psr7-backport
Update guzzlehttp/psr7 to a custom fork
Tim Düsterhus [Sun, 20 Mar 2022 14:22:29 +0000 (15:22 +0100)]
Update guzzlehttp/psr7 to a custom fork
see WoltLab/guzzle-psr7@
ff7be9fcf7da87f971990b1a61d8a7f2b5aeac9b
see WoltLab/guzzle-psr7@
986596de01529f6e837a5cadfef9ec714ace7914
Tim Düsterhus [Fri, 18 Mar 2022 13:59:50 +0000 (14:59 +0100)]
Prevent possible brick when the upgrade to 5.5 fails between unpacking of files and unpacking of acptemplates
Alexander Ebert [Thu, 17 Mar 2022 16:41:10 +0000 (17:41 +0100)]
Release 5.4.15