GitHub/moto-9609/android_kernel_motorola_exynos9610.git
11 years agostaging: et131x: trivial whitespace and line / character reductions
Mark Einon [Thu, 5 Dec 2013 22:37:46 +0000 (22:37 +0000)]
staging: et131x: trivial whitespace and line / character reductions

Tweak some whitespace, also remove a few redundant lines and
characters (mainly of type 'if (status != 0)' -> 'if (status)').

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: remove unhelpful comments
Mark Einon [Thu, 5 Dec 2013 22:37:45 +0000 (22:37 +0000)]
staging: et131x: remove unhelpful comments

Get rid of some of the more unhelpful comments.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: remove two useless debug statements
Mark Einon [Thu, 5 Dec 2013 22:37:44 +0000 (22:37 +0000)]
staging: et131x: remove two useless debug statements

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: clear up use of TRUEPHY defines
Mark Einon [Thu, 5 Dec 2013 22:37:43 +0000 (22:37 +0000)]
staging: et131x: clear up use of TRUEPHY defines

There are a large number of TRUEPHY defines in the driver, all of which
are unused or unnecessary. Remove / replace these.

As this results in et1310_phy_access_mii_bit() only being used for
reading bits, also change it's name to et1310_phy_read_mii_bit().

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: replace magic number bitmask with defined values
Mark Einon [Thu, 5 Dec 2013 22:55:49 +0000 (22:55 +0000)]
staging: et131x: replace magic number bitmask with defined values

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: Remove unnecessary phydev checks
Mark Einon [Thu, 5 Dec 2013 22:37:41 +0000 (22:37 +0000)]
staging: et131x: Remove unnecessary phydev checks

Several checks for a valid adapter->phydev pointer are made where the
pointer has already been checked previously in the code path.
Remove these redundant checks.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: improve indenting in et131x_adjust_link()
Mark Einon [Thu, 5 Dec 2013 22:37:40 +0000 (22:37 +0000)]
staging: et131x: improve indenting in et131x_adjust_link()

Negate some 'if' checks to return early, allowing a large block of code
to be un-indented.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: disable uframe_sched on the bcm2835
Stephen Warren [Wed, 4 Dec 2013 03:56:05 +0000 (20:56 -0700)]
staging: dwc2: disable uframe_sched on the bcm2835

While Paul said that .uframe_sched should be enabled on the BCM2835,
and doing so works fine with the built-in wired Ethernet, it prevents
my WiFi dongle from operating correctly. Hence, disable the option so
that everything works.

Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: don't compile procfs code when CONFIG_PROC_FS is off
Peng Tao [Tue, 3 Dec 2013 17:54:59 +0000 (01:54 +0800)]
staging/lustre: don't compile procfs code when CONFIG_PROC_FS is off

The patch changes to conditionally compile procfs related source files.
This includes lproc_fid.c, lproc_fld.c, lproc_lov.c, lvfs_lib.c, lproc_mdc.c,
lproc_mgc.c, lprocfs_status.c, lproc_osc.c and sec_lproc.c.

There is a checkpatch warning about usage of simple_strtoul() in the patch.
But it needs to be fixed in a separate patch because it is not related to
CONFIG_PROC_FS breakage here.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: fix undefined reference if CONFIG_PROC_FS is off
Peng Tao [Tue, 3 Dec 2013 17:54:58 +0000 (01:54 +0800)]
staging/lustre: fix undefined reference if CONFIG_PROC_FS is off

When building Lustre with CONFIG_PROC_FS off, we'll get many errors like:

drivers/staging/lustre/lustre/obdclass/llog_test.c:1053: error: implicit declaration of function ‘lprocfs_llog_test_init_vars’
make[3]: *** [drivers/staging/lustre/lustre/obdclass/llog_test.o] Error 1
make[2]: *** [drivers/staging/lustre/lustre/obdclass] Error 2
make[2]: *** Waiting for unfinished jobs....
  CC [M]  drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.o
drivers/staging/lustre/lustre/ptlrpc/pinger.c: In function ‘ptlrpc_pinger_main’:
drivers/staging/lustre/lustre/ptlrpc/pinger.c:331: error: implicit declaration of function ‘obd_update_maxusage’

The patch defines following symbols when CONFIG_PROC_FS is off:
fld_type_proc_dir, obd_update_maxusage(), obd_max_pages, obd_max_alloc, obd_alloc,
obd_pages, lprocfs_llog_test_init_vars().

Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/llite: remove ll_file_get_iov_count
Peng Tao [Tue, 3 Dec 2013 17:54:57 +0000 (01:54 +0800)]
staging/lustre/llite: remove ll_file_get_iov_count

It exactly copies generic_segment_checks() except wrongly calling
access_ok(VERIFY_READ) for aio read range. Drop it and just call
generic_segment_checks() instead.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: fix build error in ll_setxattr_common
Peng Tao [Tue, 3 Dec 2013 17:54:56 +0000 (01:54 +0800)]
staging/lustre: fix build error in ll_setxattr_common

With CONFIG_FS_POSIX_ACL off, we'll get
drivers/staging/lustre/lustre/llite/xattr.c: In function ‘ll_setxattr_common’:
drivers/staging/lustre/lustre/llite/xattr.c:187:7: error: ‘rce’ undeclared (first use in this function)
drivers/staging/lustre/lustre/llite/xattr.c:187:7: note: each undeclared identifier is reported only once for each function it appears in

It was introduced by 7fc1f83 (staging/lustre/llite: extended attribute cache)
that added new reference but didn't take care of CONFIG_FS_POSIX_ACL.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcidio: tidy up the irq request
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:26 +0000 (12:07 -0700)]
staging: comedi: ni_pcidio: tidy up the irq request

The irq is only needed to support async commands. Tidy up the
code that does the request_irq() and remove the noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcimio: tidy up the irq request
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:25 +0000 (12:07 -0700)]
staging: comedi: ni_pcimio: tidy up the irq request

The irq is only needed to support async commands. Tidy up the
code that does the request_irq() and remove the noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl812: use dev->read_subdev
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:24 +0000 (12:07 -0700)]
staging: comedi: pcl812: use dev->read_subdev

Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl812: only init async command members when needed
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:23 +0000 (12:07 -0700)]
staging: comedi: pcl812: only init async command members when needed

The 'len_chanlist' and 'cancel' members of the comedi_subdevice are
only used with async command support. Only initialize them if the irq
was sucessfully requested.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl812: remove unnecessary s->len_chanlist init
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:22 +0000 (12:07 -0700)]
staging: comedi: pcl812: remove unnecessary s->len_chanlist init

The subdevice 'len_chanlist' member is only used with async command
support. Remove the initialization of this member for the subdevices
that do not support commands. The core will then correctly initialize
it to the default value of '1'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove unnecessary s->len_chanlist init
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:21 +0000 (12:07 -0700)]
staging: comedi: pcl818: remove unnecessary s->len_chanlist init

The subdevice 'len_chanlist' member is only used with async command
support. Remove the initialization of this member for the subdevices
that do not support commands. The core will then correctly initialize
it to the default value of '1'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: use dev->read_subdev
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:20 +0000 (12:07 -0700)]
staging: comedi: pcl818: use dev->read_subdev

Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove 'sub_ai' from private data
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:19 +0000 (12:07 -0700)]
staging: comedi: pcl818: remove 'sub_ai' from private data

This member of the private data is a duplicate of the comedi_device
'read_subdev' member. Remove the private data member and use the
comedi_device member instead.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: only init async command members when needed
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:18 +0000 (12:07 -0700)]
staging: comedi: pcl818: only init async command members when needed

The 'len_chanlist' and 'cancel' members of the comedi_subdevice are
only used with async command support. Only initialize them if the irq
was sucessfully requested.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove function trace noise
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:17 +0000 (12:07 -0700)]
staging: comedi: pcl818: remove function trace noise

These kernel messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove unnecessary 'dev->irq' tests
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:16 +0000 (12:07 -0700)]
staging: comedi: pcl818: remove unnecessary 'dev->irq' tests

These functions can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove 'irq_free' from private data
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:15 +0000 (12:07 -0700)]
staging: comedi: pcl818: remove 'irq_free' from private data

This member of the private data is not needed. We can check if
dev->irq is none zero instead. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: use dev->read_subdev
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:14 +0000 (12:07 -0700)]
staging: comedi: pcl816: use dev->read_subdev

Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: remove 'sub_ai' from private data
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:13 +0000 (12:07 -0700)]
staging: comedi: pcl816: remove 'sub_ai' from private data

This member of the private data is a duplicate of the comedi_device
'read_subdev' member. Remove the private data member and use the
comedi_device member instead.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: only init command support if irq is available
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:12 +0000 (12:07 -0700)]
staging: comedi: pcl816: only init command support if irq is available

The async command support requires an irq. Only initialize the subdevice
command support if the request_irq was successfull.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: remove 'irq_free' from private data
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:11 +0000 (12:07 -0700)]
staging: comedi: pcl816: remove 'irq_free' from private data

This member of the private data is not needed. We can check if
dev->irq is none zero instead. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: fix async command hookup
H Hartley Sweeten [Tue, 3 Dec 2013 19:07:10 +0000 (12:07 -0700)]
staging: comedi: s626: fix async command hookup

Only set the SDF_CMD_READ subdev_flag if the irq was sucessfully
requested.

Remove the unnecessary sanity check of dev->irq in s626_ai_cmd().
This callback is only hooked up if the irq is available.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: delete unnecessary variable in function et131x_init
ZHAO Gang [Wed, 4 Dec 2013 07:24:13 +0000 (15:24 +0800)]
staging: et131x: delete unnecessary variable in function et131x_init

Variable u32 numrfd is not necessary in this function.

Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: et131x: change function name
ZHAO Gang [Wed, 4 Dec 2013 07:24:12 +0000 (15:24 +0800)]
staging: et131x: change function name

Change function name from et1310_phy_power_down to et1310_phy_power_switch
to better describe its functionality.

Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: reapply an older patch that was reverted
Greg Kroah-Hartman [Wed, 4 Dec 2013 19:26:20 +0000 (11:26 -0800)]
staging: lustre: reapply an older patch that was reverted

This reapplies part of 9edf0f670bdc8fa8b6676893b0a3bd2bf3 (staging:
lustre: clean up format string usages) as it was reverted in a recent
change to this file.

That proves the big problem of having external trees you have to have
patches flowing back into them from upstream or things break down...

Reported-by: Kees Cook <keescook@chromium.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Peng Tao <bergwolf@gmail.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agovme: remove DEFINE_PCI_DEVICE_TABLE macro
Jingoo Han [Mon, 2 Dec 2013 23:29:48 +0000 (08:29 +0900)]
vme: remove DEFINE_PCI_DEVICE_TABLE macro

Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoVME: Rename vme_slot_get to avoid confusion with reference counting
Martyn Welch [Fri, 8 Nov 2013 11:58:35 +0000 (11:58 +0000)]
VME: Rename vme_slot_get to avoid confusion with reference counting

Traditionally the "get" functions increment the reference count of the
object that is returned, which does not happen with vme_slot_get. The
function vme_slot_get returns the physical VME slot associated with a
particular struct vme_dev. Rename vme_slot_num to avoid any confusion.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoVME: Provide access to VME bus enumeration and fix vme_user match function
Martyn Welch [Fri, 8 Nov 2013 11:58:34 +0000 (11:58 +0000)]
VME: Provide access to VME bus enumeration and fix vme_user match function

The match function for vme_user is completely wrong. It will blindly bind
against the first VME slot on each bus (at this point that would be just the
first bus as the driver can only handle one bus).

The original intention (before some major subsystem changes) was that the
driver bind against the slot to which the bridge was attached in the VME
system and to the bus(es) provided via the "bus" module parameter.

To do this cleanly (i.e. without poking arround in the subsystems internal
stuctures) a functionality has been added to provide access to the bus
enumeration.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: fix sparse non static symbol warning
Wei Yongjun [Thu, 28 Nov 2013 02:27:59 +0000 (10:27 +0800)]
staging: dwc2: fix sparse non static symbol warning

Fixes the following sparse warning:

drivers/staging/dwc2/core.c:2672:6: warning:
 symbol 'dwc2_set_param_uframe_sched' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_atmio16d: remove an unnecessary printk
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:31 +0000 (16:42 -0700)]
staging: comedi: ni_atmio16d: remove an unnecessary printk

This blank line printk is not necessary. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_atmio16d: tidy up the irq support in atmio16d_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:30 +0000 (16:42 -0700)]
staging: comedi: ni_atmio16d: tidy up the irq support in atmio16d_attach()

Tidy up the code that does the request_irq().

Only hookup the commad support if the irq was sucessfully requested.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_atmio16d: remove printk() noise in atmio16d_ai_insn_read()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:29 +0000 (16:42 -0700)]
staging: comedi: ni_atmio16d: remove printk() noise in atmio16d_ai_insn_read()

These printk messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcimio: convert printk() to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:28 +0000 (16:42 -0700)]
staging: comedi: ni_pcimio: convert printk() to dev_dbg()

Convert this printk messages to a dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_tio: remove commented out printk message
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:27 +0000 (16:42 -0700)]
staging: comedi: ni_tio: remove commented out printk message

This printk message is just added noise. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl812: convert printk messages in pcl812_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:26 +0000 (16:42 -0700)]
staging: comedi: pcl812: convert printk messages in pcl812_attach()

Convert the printk messages in this function to dev_{level} mesages.

Remove the ones that are just added noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl812: tidy up the irq support in pcl812_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:25 +0000 (16:42 -0700)]
staging: comedi: pcl812: tidy up the irq support in pcl812_attach()

Tidy up the code that does the request_irq().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: convert printk messages in pcl816_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:24 +0000 (16:42 -0700)]
staging: comedi: pcl816: convert printk messages in pcl816_attach()

Convert the printk messages in this function to dev_{level} mesages.

Remove the ones that are just added noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: remove commented out printk debug
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:23 +0000 (16:42 -0700)]
staging: comedi: pcl816: remove commented out printk debug

These messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: tidy up the irq support in pcl816_attach()
H Hartley Sweeten [Wed, 27 Nov 2013 18:05:19 +0000 (11:05 -0700)]
staging: comedi: pcl816: tidy up the irq support in pcl816_attach()

Tidy up the code that does the request_irq().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: remove TRIG_WAKE_EOS support stub
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:21 +0000 (16:42 -0700)]
staging: comedi: pcl816: remove TRIG_WAKE_EOS support stub

The support code for this command flag is commented out. Just remove
it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: remove commented out outb() macro
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:20 +0000 (16:42 -0700)]
staging: comedi: pcl816: remove commented out outb() macro

This macro is commented out, thankfully... Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: convert printk() messages to dev_{level}
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:19 +0000 (16:42 -0700)]
staging: comedi: pcl818: convert printk() messages to dev_{level}

Convert the remaining printk messsages in this driver to dev_{level}.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: tidy up the irq support in pcl818_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:18 +0000 (16:42 -0700)]
staging: comedi: pcl818: tidy up the irq support in pcl818_attach()

Tidy up the code that does the request_irq().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove board attach noise
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:17 +0000 (16:42 -0700)]
staging: comedi: pcl818: remove board attach noise

These messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove printk function trace messages
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:16 +0000 (16:42 -0700)]
staging: comedi: pcl818: remove printk function trace messages

These messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: remove commented out printk debug
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:15 +0000 (16:42 -0700)]
staging: comedi: pcl818: remove commented out printk debug

These messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcm3724: remove commented out printk debug
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:14 +0000 (16:42 -0700)]
staging: comedi: pcm3724: remove commented out printk debug

These messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: plx9080.h: remove unnecessary printk noise
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:13 +0000 (16:42 -0700)]
staging: comedi: plx9080.h: remove unnecessary printk noise

The timeouts will return -ETIMEDOUT. The printks are just added noise.
Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: rtd520: remove commented out printk debug
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:12 +0000 (16:42 -0700)]
staging: comedi: rtd520: remove commented out printk debug

These messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: mpc624: convert printk messages in mpc624_ai_rinsn()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:11 +0000 (16:42 -0700)]
staging: comedi: mpc624: convert printk messages in mpc624_ai_rinsn()

There's no reason for these messages to be KERN_INFO. Convert them to
dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: mpc624: remove unnecessary printk noise
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:10 +0000 (16:42 -0700)]
staging: comedi: mpc624: remove unnecessary printk noise

The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.

It's also not necessary to set data[n[ = 0 when the read timesout.
Remove that also.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: mpc624: remove unnecessary test
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:09 +0000 (16:42 -0700)]
staging: comedi: mpc624: remove unnecessary test

It's not necessaary to vaidate insn->n passed to the (*insn_read)
function. The for() loop following it will just be a NOP.

Remove the test as well as the printk noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: mpc624: remove commented out printk
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:08 +0000 (16:42 -0700)]
staging: comedi: mpc624: remove commented out printk

This printk is just added noise. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: remove commented out printk
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:07 +0000 (16:42 -0700)]
staging: comedi: dt282x: remove commented out printk

This printk is just added noise. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: convert dt282x_ao_inttrig() messages
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:06 +0000 (16:42 -0700)]
staging: comedi: dt282x: convert dt282x_ao_inttrig() messages

Convert the messages in this function to dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: convert dt282x_ai_dma_interrupt() messages
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:05 +0000 (16:42 -0700)]
staging: comedi: dt282x: convert dt282x_ai_dma_interrupt() messages

Convert the messages in this function to dev_{level}().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: convert dt282x_ao_dma_interrupt() messages
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:04 +0000 (16:42 -0700)]
staging: comedi: dt282x: convert dt282x_ao_dma_interrupt() messages

Convert the messages in this function to dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: remove disable code that disables the irq
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:03 +0000 (16:42 -0700)]
staging: comedi: dt282x: remove disable code that disables the irq

The code that would disable the irq after getting a number of D/A errors
is disabled. Just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: remove unnecessary blank line message
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:02 +0000 (16:42 -0700)]
staging: comedi: dt282x: remove unnecessary blank line message

This blank line message is not needed. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: convert printk() in dt282x_attach to a dev_err()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:01 +0000 (16:42 -0700)]
staging: comedi: dt282x: convert printk() in dt282x_attach to a dev_err()

Convert this printk message into a dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: remove attach noise in dt282x_grab_dma()
H Hartley Sweeten [Tue, 26 Nov 2013 23:42:00 +0000 (16:42 -0700)]
staging: comedi: dt282x: remove attach noise in dt282x_grab_dma()

These messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: tidy up the irq support in dt282x_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:59 +0000 (16:41 -0700)]
staging: comedi: dt282x: tidy up the irq support in dt282x_attach()

An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.

Remove the printk noise about the irq.

Only hookup the async command support if the request_irq() was successful.

Also, only call dt282x_grab_dma() if we have an irq since interrupt support
is needed to support dma.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2815: convert printk's in dt2815_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:58 +0000 (16:41 -0700)]
staging: comedi: dt2815: convert printk's in dt2815_attach()

These messages don't appear to be important enough to warrent KERN_INFO
and KERN_WARNING levels. Convert them dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2815: convert printk's in dt2815_ao_insn()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:57 +0000 (16:41 -0700)]
staging: comedi: dt2815: convert printk's in dt2815_ao_insn()

Convert the printk(KERN_WARNING messages in this function to dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2814: tidy up the irq support in dt2814_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:56 +0000 (16:41 -0700)]
staging: comedi: dt2814: tidy up the irq support in dt2814_attach()

An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.

Remove the printk noise about the irq.

Only hookup the async command support if the request_irq() was successful.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2814: convert a printk(KERN_ERR into a dev_err()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:55 +0000 (16:41 -0700)]
staging: comedi: dt2814: convert a printk(KERN_ERR into a dev_err()

Convert this printk message into a dev_dev().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2814: remove bad printk noise
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:54 +0000 (16:41 -0700)]
staging: comedi: dt2814: remove bad printk noise

This printk could spew a lot of noise while waiting for the ai conversion
to complete. Just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2814: remove unnecessary printk noise
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:53 +0000 (16:41 -0700)]
staging: comedi: dt2814: remove unnecessary printk noise

The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2811: remove disabled interrupt support code
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:52 +0000 (16:41 -0700)]
staging: comedi: dt2811: remove disabled interrupt support code

The interrupt support in this driver is incomplete due to the missing
comedi functions to support async commands.

Since the interrupt code is already disable just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2811: remove disabled dt2811_adtrig() function
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:51 +0000 (16:41 -0700)]
staging: comedi: dt2811: remove disabled dt2811_adtrig() function

This function is not used by the driver. It's also suffering from bitrot
since COMEDI_MDEMAND and COMEDI_MCONTS are not defined anywhere. Just
remove the code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2801: convert printk() messages to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:50 +0000 (16:41 -0700)]
staging: comedi: dt2801: convert printk() messages to dev_dbg()

Convert all the printk() messages in this driver to dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2801: remove commented out printk()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:49 +0000 (16:41 -0700)]
staging: comedi: dt2801: remove commented out printk()

This printk is just added noise. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2801: remove disabled code in dt2801_writedata
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:48 +0000 (16:41 -0700)]
staging: comedi: dt2801: remove disabled code in dt2801_writedata

The code that checks the DT_S_READY status is disabled. Just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dmm32at: convert a printk(KERN_ERR to a dev->err()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:47 +0000 (16:41 -0700)]
staging: comedi: dmm32at: convert a printk(KERN_ERR to a dev->err()

Convert this printk message to a dev_err() message.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dmm32at: tidy up the irq support in dmm32at_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:46 +0000 (16:41 -0700)]
staging: comedi: dmm32at: tidy up the irq support in dmm32at_attach()

An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.

Remove the printk noise about the irq.

Only hookup the async command support if the request_irq() was successful.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dmm32at: remove commented out printk debug
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:45 +0000 (16:41 -0700)]
staging: comedi: dmm32at: remove commented out printk debug

These printk messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dmm32at: remove unnecessary printk noise
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:44 +0000 (16:41 -0700)]
staging: comedi: dmm32at: remove unnecessary printk noise

A timeout will return -ETIMEDOUT. The printks are just added noise.
Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: das16m1: tidy up the irq support in das16m1_attach()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:43 +0000 (16:41 -0700)]
staging: comedi: das16m1: tidy up the irq support in das16m1_attach()

An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if an invalid irq is
selected by the user, or the request_irq() fails, the attach does not
fail.

Remove all the printk noise about the irq.

Only hookup the async command support if the request_irq() was successful.

Tidy up das16m1_irq_bits() a bit. This helper returns the value that needs
to be written to the DAS16M1_INTR_CONTROL register to setup the irq routing.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: cb_pcimdas: remove unnecessary printk noise
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:42 +0000 (16:41 -0700)]
staging: comedi: cb_pcimdas: remove unnecessary printk noise

The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: cb_pcimdas: remove commented out irq init code
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:41 +0000 (16:41 -0700)]
staging: comedi: cb_pcimdas: remove commented out irq init code

This driver does not have interrupt support. Remove the commented out
code that requests the irq.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: c6xdigio: remove commented out function trace messages
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:40 +0000 (16:41 -0700)]
staging: comedi: c6xdigio: remove commented out function trace messages

These commented out messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: c6xdigio: remove commented out subdevice code
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:39 +0000 (16:41 -0700)]
staging: comedi: c6xdigio: remove commented out subdevice code

The code to initialize subdevice[2] is commented out and incomplete.
Just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: adq12b: remove commented out debug message
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:38 +0000 (16:41 -0700)]
staging: comedi: adq12b: remove commented out debug message

Remove the commented out message, it would just be added noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl818: convert some printk's to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:37 +0000 (16:41 -0700)]
staging: comedi: pcl818: convert some printk's to dev_dbg()

Convert these messages to dev_dbg() and tidy them up a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: convert some printk's to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:36 +0000 (16:41 -0700)]
staging: comedi: pcl816: convert some printk's to dev_dbg()

Convert these warning messages to dev_dbg() to minimize the noise.
Also, tidy them up a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl812: convert some printk's to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:35 +0000 (16:41 -0700)]
staging: comedi: pcl812: convert some printk's to dev_dbg()

Convert these debug messages to dev_dbg() and tidy them up a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dmm32at: remove final attach noise and fix return value
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:34 +0000 (16:41 -0700)]
staging: comedi: dmm32at: remove final attach noise and fix return value

The "success" message after an attach is just added noise. Remove it.

The normal return value for "success" is 0.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: adv_pci1710: convert some printk's to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:33 +0000 (16:41 -0700)]
staging: comedi: adv_pci1710: convert some printk's to dev_dbg()

Convert these debug messages to dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcmmio.c: remove kcalloc() failure message
H Hartley Sweeten [Tue, 26 Nov 2013 23:41:32 +0000 (16:41 -0700)]
staging: comedi: pcmmio.c: remove kcalloc() failure message

An allocation failure will have already displayed a message.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: usbip: vhci_hcd.c: removed a space
Aldo Iljazi [Mon, 2 Dec 2013 13:22:29 +0000 (15:22 +0200)]
Staging: usbip: vhci_hcd.c: removed a space

Line 921: Removed the space before the semicolon.

Signed-off-by: Aldo Iljazi <mail@aldo.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agodrivers: staging: ft1000: ft1000-usb: ft1000_debug.c: check return value of get_user...
Chen Gang [Wed, 27 Nov 2013 03:40:58 +0000 (11:40 +0800)]
drivers: staging: ft1000: ft1000-usb: ft1000_debug.c: check return value of get_user() in ft1000_ioctl()

get_user() may fail and cause 'msgsz' uninitialized, so need give a
check. The related warning (with allmodconfig under hexagon):

    CC [M]  drivers/staging/ft1000/ft1000-usb/ft1000_debug.o
  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c: In function 'ft1000_ioctl':
  include/uapi/linux/swab.h:53:9: warning: 'msgsz' may be used uninitialized in this function [-Wuninitialized]
  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c:533:17: note: 'msgsz' was declared here

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: fix potential NULL pointer dereference
Michal Nazarewicz [Fri, 29 Nov 2013 17:10:59 +0000 (18:10 +0100)]
staging: lustre: fix potential NULL pointer dereference

The rest of the code seem to imply that rmf_dumper may indeed be
NULL.  Change the code so that dumping is not even considered if
rmf_dumper callback is not set.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: silicom: remove dead code
Michal Nazarewicz [Fri, 29 Nov 2013 17:05:01 +0000 (18:05 +0100)]
staging: silicom: remove dead code

bus_info field of struct ethtool_drvinfo is an array thus it always
evaluates to true in a boolean context.  Therefore operation
depending on it being false will never be executed.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>