GitHub/moto-9609/android_kernel_motorola_exynos9610.git
10 years agoion: Add dummy driver for testing
John Stultz [Fri, 10 Jan 2014 05:08:37 +0000 (21:08 -0800)]
ion: Add dummy driver for testing

Provide a basic dummy driver to register the ion device
and to install basic SYSTEM and SYSTEM_CONTIG heaps.

This allows for basic testing with ION without having
access to drivers or systems that have been enabled to use
ION.

Cc: Colin Cross <ccross@android.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Jesse Barker <jesse.barker@arm.com>
Cc: Android Kernel Team <kernel-team@android.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: usbduxsigma: removing unneccesay attached info
Bernd Porr [Tue, 7 Jan 2014 21:43:43 +0000 (21:43 +0000)]
staging: comedi: usbduxsigma: removing unneccesay attached info

Comedi core now reports that a device has been attached so that
the driver itself won't need to do it any longer. The driver now
just outputs the offset of the ADC converter which is a soft indicator
of the health of the board and also the user can grep this value
from the kernel log easier for debugging purposes.

Signed-off-by: Bernd Porr <mail@berndporr.me.uk>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: usbduxsigma: return failure of auto attach
Bernd Porr [Tue, 7 Jan 2014 21:43:10 +0000 (21:43 +0000)]
staging: comedi: usbduxsigma: return failure of auto attach

The function usbduxsigma_getstatusinfo() returns a negative
value in case there has been a communication error with
the board. This should always work and if this communication
fails then there is something seriously wrong with the board.
This is now returned to the caller so that it can
terminte the auto attachement. The return command also prevents
printing out the offset value in case of a fault.

Signed-off-by: Bernd Porr <mail@berndporr.me.uk>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: report success/failure of autoconfig
Bernd Porr [Tue, 7 Jan 2014 21:42:25 +0000 (21:42 +0000)]
staging: comedi: report success/failure of autoconfig

Added success message to the driver autoconfig and error
message in case it fails. A success message is required
so that the user can find out which comedi driver has been
associated with which udev device. This also makes troubleshooting
much easier when more than one card is in the computer or
there is a mix of USB and PCI devices.
As Ian suggested we should report both the driver and the board
which might have different names, especially if one driver covers a
range of different boards.

Signed-off-by: Bernd Porr <mail@berndporr.me.uk>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: fix bug destroying subdevice files after parent
Ian Abbott [Tue, 7 Jan 2014 12:38:32 +0000 (12:38 +0000)]
staging: comedi: fix bug destroying subdevice files after parent

`comedi_free_board_dev()` is called (via `comedi_auto_unconfig()` -->
`comedi_release_hardware_device()`) when an auto-configured comedi
device is removed.  This destroys the main sysfs class device and then
calls `comedi_device_cleanup()` to clean up the comedi device.  For
comedi devices that have comedi subdevices that asynchronous commands,
the clean up involves destroying the sysfs class devices associated with
those subdevices.

There is a bug in the above sequence because the sysfs class devices
associated with the comedi subdevices are children of the sysfs class
device associated with the main comedi device.  Therefore they will have
been automatically destroyed when the main sysfs class device is
destroyed.  When they are destroyed again as part of the clean-up, they
will not be found, leading to a warning and a stack trace similar to
this:

------------[ cut here ]------------
WARNING: CPU: 1 PID: 1213 at fs/sysfs/group.c:214
sysfs_remove_group+0x4e/0xa7()
sysfs group ffffffff817504c0 not found for kobject 'comedi4_subd0'
Modules linked in: nfsd auth_rpcgss oid_registry exportfs nfs_acl lockd
bridge stp llc sunrpc fuse binfmt_misc cpufreq_userspace sr_mod
snd_hda_codec_analog cdrom powernow_k8 kvm_amd kvm amplc_pci230(C)
8255(C) comedi(C) pcmcia xhci_hcd ehci_pci pcmcia_core ohci_pci ohci_hcd
ehci_hcd usbcore snd_hda_intel snd_hda_codec snd_pcm k8temp
snd_page_alloc 8139too snd_timer snd soundcore mii usb_common forcedeth
pata_amd
CPU: 1 PID: 1213 Comm: kworker/u4:6 Tainted: G         C
3.13.0-rc5-ija1+ #20
Hardware name: System manufacturer System Product Name/M2N-E, BIOS ASUS
M2N-E ACPI BIOS Revision 5001 03/23/2010
Workqueue: sysfsd sysfs_schedule_callback_work
 0000000000000000 ffff8800bf17fb38 ffffffff814672ce ffff8800bf17fb80
 ffff8800bf17fb70 ffffffff8103470b ffffffff8114f780 0000000000000000
 ffffffff817504c0 ffff8800bf39f410 ffff880139b68670 ffff8800bf17fbd0
Call Trace:
 [<ffffffff814672ce>] dump_stack+0x45/0x56
 [<ffffffff8103470b>] warn_slowpath_common+0x7a/0x93
 [<ffffffff8114f780>] ? sysfs_remove_group+0x4e/0xa7
 [<ffffffff8103476b>] warn_slowpath_fmt+0x47/0x49
 [<ffffffff8114e92d>] ? sysfs_get_dirent_ns+0x5e/0x66
 [<ffffffff8114f780>] sysfs_remove_group+0x4e/0xa7
 [<ffffffff8132aac0>] dpm_sysfs_remove+0x37/0x3b
 [<ffffffff81323781>] device_del+0x3e/0x173
 [<ffffffff813238c3>] device_unregister+0xd/0x18
 [<ffffffff8132392e>] device_destroy+0x33/0x37
 [<ffffffffa0212086>] comedi_free_subdevice_minor+0x80/0x92 [comedi]
 [<ffffffffa02128bb>] comedi_device_detach+0x79/0x152 [comedi]
 [<ffffffffa020f223>] comedi_device_cleanup+0x36/0x57 [comedi]
 [<ffffffffa020f275>] comedi_free_board_dev+0x31/0x3c [comedi]
 [<ffffffffa0211f2a>] comedi_release_hardware_device+0x5a/0x73 [comedi]
 [<ffffffffa0212547>] comedi_auto_unconfig+0xe/0x10 [comedi]
 [<ffffffffa021357c>] comedi_pci_auto_unconfig+0x10/0x12 [comedi]
 [<ffffffff811d2335>] pci_device_remove+0x40/0x8a
 [<ffffffff813261d0>] __device_release_driver+0x84/0xda
 [<ffffffff81326244>] device_release_driver+0x1e/0x2b
 [<ffffffff811cdcb5>] pci_stop_bus_device+0x44/0x87
 [<ffffffff811cdde2>] pci_stop_and_remove_bus_device+0xd/0x18
 [<ffffffff811d3f3d>] remove_callback+0x20/0x2f
 [<ffffffff8114d1f7>] sysfs_schedule_callback_work+0xf/0x70
 [<ffffffff81049498>] process_one_work+0x1d6/0x34c
 [<ffffffff81049a5f>] worker_thread+0x1cf/0x2b5
 [<ffffffff81049890>] ? rescuer_thread+0x258/0x258
 [<ffffffff8104e0e6>] kthread+0xd6/0xde
 [<ffffffff8104e010>] ? kthread_create_on_node+0x160/0x160
 [<ffffffff81472cbc>] ret_from_fork+0x7c/0xb0
 [<ffffffff8104e010>] ? kthread_create_on_node+0x160/0x160
---[ end trace 94722aa2936a7adf ]---

To correct the bug, rearrange `comedi_free_board_dev()` to destroy the
main sysfs class device *after* the clean-up operation.

Thanks to Bernd Porr for finding the bug and his initial attempt to fix
it.

Reported-by: Bernd Porr <mail@berndporr.me.uk>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Cc: Bernd Porr <mail@berndporr.me.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: comedi: fix spacing/style problem in das1800.c (and das6402.c)
Chase Southwood [Mon, 6 Jan 2014 03:46:54 +0000 (21:46 -0600)]
Staging: comedi: fix spacing/style problem in das1800.c (and das6402.c)

This patch fixes a style issue regarding asterisk placement in
das1800.c and das6402.c found by checkpatch.pl.

Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c Camel case and clean up s_uGetRTSCTSRsvTime
Malcolm Priestley [Wed, 8 Jan 2014 20:13:29 +0000 (20:13 +0000)]
staging: vt6656: rxtx.c Camel case and clean up s_uGetRTSCTSRsvTime

White space clean

Remove unneeded comments.

Camel case changes

pDevice,
byRTSRsvType
byPktType
cbFrameLength
wCurrentRate

uRrvTime
uRTSTime
uCTSTime
uAckTime
uDataTime

} -> {

priv,
rsv_type
pkt_type
frame_lenght
current_rate

rrv_time
rts_time
cts_time
ack_time
data_time

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rxtx.c Camel case and clean up s_uGetTxRsvTime
Malcolm Priestley [Wed, 8 Jan 2014 20:08:42 +0000 (20:08 +0000)]
staging: vt6656: rxtx.c Camel case and clean up s_uGetTxRsvTime

White space clean.

Remove unneeded comments.

Camel case changes
pDevice
byPktType
cbFrameLength
wRate
bNeedAck

uDataTime
uAckTime

} -> {

priv
pkt_type
frame_length
rate
need_ack

data_time
ack_time

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: xillybus: Open Firmware driver supporting coherent DMA
Eli Billauer [Mon, 30 Dec 2013 21:16:25 +0000 (23:16 +0200)]
staging: xillybus: Open Firmware driver supporting coherent DMA

If the "dma-coherent" property is present in the device tree, the driver will
not perform cache invalidations. This feature significantly improves data
throughput and reduces CPU load.

Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: xillybus: Changed Open Firmware "compatible" property
Eli Billauer [Mon, 30 Dec 2013 21:16:24 +0000 (23:16 +0200)]
staging: xillybus: Changed Open Firmware "compatible" property

The previous "compatible" string was poorly chosen, but remains in the
match list to support existing DTBs. There is no risk for a naming clash.

Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: xillybus: Added documentation on device tree bindings
Eli Billauer [Mon, 30 Dec 2013 21:16:23 +0000 (23:16 +0200)]
staging: xillybus: Added documentation on device tree bindings

Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: gdm72xx: fix interruptible_sleep_on race
Arnd Bergmann [Thu, 2 Jan 2014 12:07:34 +0000 (13:07 +0100)]
staging: gdm72xx: fix interruptible_sleep_on race

interruptible_sleep_on is racy and going away. This replaces the
use in the gdm72xx driver with the appropriate
wait_event_interruptible_lock_irq.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: serqt_usb2: don't use sleep_on
Arnd Bergmann [Thu, 2 Jan 2014 12:07:33 +0000 (13:07 +0100)]
staging: serqt_usb2: don't use sleep_on

sleep_on and related functions are going away and should not be used
in this driver any more.

This removes the call to interruptible_sleep_on for a wait queue that
is never woken up, and replaces an interruptible_sleep_on_timeout
call with the equivalent wait_event_interruptible_timeout() to
avoid a small race.

Both call sites still look fishy and need more work.

Signed-off-by: Arnd Bergmann <arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org
Cc: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: panel: fix interruptible_sleep_on race
Arnd Bergmann [Thu, 2 Jan 2014 12:07:35 +0000 (13:07 +0100)]
staging: panel: fix interruptible_sleep_on race

interruptible_sleep_on is racy and going away. This replaces the one
caller in the panel driver with the appropriate wait_event_interruptible
variant.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: devel@driverdev.osuosl.org
Cc: Willy Tarreau <willy@meta-x.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dgap: fix checkpatch warnings
Vincent Stehlé [Tue, 31 Dec 2013 10:55:09 +0000 (11:55 +0100)]
staging: dgap: fix checkpatch warnings

Remove a few spaces at beginning and end of line. Remove single statement
braces {}. Remove two FSF boilerplate paragraphs.

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Lidza Louina <lidza.louina@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Scott H Kilau <Scott_Kilau@digi.com>
Cc: Eng.Linux@digi.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dgap: fix missing header inclusion
Vincent Stehlé [Tue, 31 Dec 2013 10:55:08 +0000 (11:55 +0100)]
staging: dgap: fix missing header inclusion

Include slab.h to fix the following compilation error:

  drivers/staging/dgap/dgap_fep5.c: In function ‘dgap_do_config_load’:
  drivers/staging/dgap/dgap_fep5.c:78:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration]

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Lidza Louina <lidza.louina@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Scott H Kilau <Scott_Kilau@digi.com>
Cc: Eng.Linux@digi.com
Cc: trivial@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: DDRInit: fix up some bracing issues.
Gary Rookard [Sat, 28 Dec 2013 22:04:10 +0000 (17:04 -0500)]
Staging: bcm: DDRInit: fix up some bracing issues.

I fixed some brace coding style issues.

Signed-off-by: Gary Alan Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: tidspbridge: Use hashtable implementation
Ivaylo Dimitrov [Sun, 5 Jan 2014 23:17:27 +0000 (01:17 +0200)]
Staging: tidspbridge: Use hashtable implementation

Use upstream hashtable implementation instead of generic code

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8712u: Set device type to wlan
Larry Finger [Tue, 24 Dec 2013 17:22:54 +0000 (11:22 -0600)]
staging: r8712u: Set device type to wlan

The latest version of NetworkManager does not recognize the device as wireless
without this change.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: bcm: clean up a type issue in ConfigureEndPointTypesThroughEEPROM()
Dan Carpenter [Thu, 9 Jan 2014 05:44:29 +0000 (08:44 +0300)]
staging: bcm: clean up a type issue in ConfigureEndPointTypesThroughEEPROM()

We only ever set the highest 4 bytes of ulReg.  This would cause a
problem on big endian systems.  The type should be u32 instead of
unsigned long.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: rtl8187se: fix styling issues in r8180_wx.c
Dan LaManna [Mon, 6 Jan 2014 05:38:51 +0000 (00:38 -0500)]
Staging: rtl8187se: fix styling issues in r8180_wx.c

This is a patch to the r8180_wx.c which fixes various whitespace issues,
brace issues, casting/declaration syntax issues, and increases
clarity in multi-line return statement.

Signed-off-by: Dan LaManna <dan.lamanna@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging rtl8192e: Correcting wrong usage of macro in r8192E_phy.c and removing corres...
Andreas Frembs [Sun, 5 Jan 2014 12:25:37 +0000 (13:25 +0100)]
Staging rtl8192e: Correcting wrong usage of macro in r8192E_phy.c and removing corresponding warning in rtllib_debug.h

We fixed in rtllib_debug.h the following checkpatch warning:
WARNING: do {} while (0) macros should not be semicolon terminated.

After deleting this semicolon we also had to fix the wrong use of this macro in rtl8192e/r8192E_phy.c

Signed-off-by: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de>
Signed-off-by: Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging rtl8192e: Fixing checkpatch error in rtllib_debug.h
Andreas Frembs [Sun, 5 Jan 2014 12:25:36 +0000 (13:25 +0100)]
Staging rtl8192e: Fixing checkpatch error in rtllib_debug.h

In rtllib_debug.h we fixed the following checkpatch error:
ERROR: Macros with complex values should be enclosed in parenthesis

We fixed this with a do {} while (0), because otherwise the compiler complained.

Signed-off-by: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de>
Signed-off-by: Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging rtl8192e: Fixing checkpatch error in rtllib_crypt_tkip.c
Andreas Frembs [Sun, 5 Jan 2014 12:25:35 +0000 (13:25 +0100)]
Staging rtl8192e: Fixing checkpatch error in rtllib_crypt_tkip.c

In rtllib_crypt_tkip.c we fixed the following checkpatch error:
ERROR: space required after that ','

Signed-off-by: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de>
Signed-off-by: Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: rtl8188eu: Fixed spaces before tabs and before close parentheses
Tim Jester-Pfadt [Thu, 2 Jan 2014 23:57:02 +0000 (00:57 +0100)]
Staging: rtl8188eu: Fixed spaces before tabs and before close parentheses

Fixed all space before tab warnings and space before close parenthesis
errors on rtl8188e_spec.h

Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: rtl8188eu: Fixed coding style issues
Tim Jester-Pfadt [Thu, 2 Jan 2014 23:22:59 +0000 (00:22 +0100)]
Staging: rtl8188eu: Fixed coding style issues

Fixed indentation coding style issues on rtw_io.c

Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: rtl8188eu: Fixed coding style issues
Tim Jester-Pfadt [Tue, 31 Dec 2013 02:53:57 +0000 (03:53 +0100)]
Staging: rtl8188eu: Fixed coding style issues

Fixed required and prohibited spaces to make rtw_io.h checkpatch.pl clean

Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging rtl8192e: Fixing checkpatch errors
Matthias Schoepe [Thu, 26 Dec 2013 19:23:32 +0000 (20:23 +0100)]
Staging rtl8192e: Fixing checkpatch errors

We fixed checkpatch errors of the following type:
ERROR: "foo * bar" should be "foo *bar"

The error was fixed in the following files of the rtl8192e staging driver:
rtllib_softmac.c
rtllib_rx.c
rtllib_crypt.c
rtllib.h

There are no functional changes in this patch.

Signed-off-by: Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de>
Signed-off-by: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8187se: Fix trailing whitespace in r8180_hw.h and r8180_wx.c
Masanari Iida [Wed, 25 Dec 2013 16:15:54 +0000 (01:15 +0900)]
staging: rtl8187se: Fix trailing whitespace in r8180_hw.h and r8180_wx.c

This patch fixed "ERROR: trailing whitespace
found by checkpatch.pl in r8180_hw.h and r8180_wx.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8187se: Fix space prohibited before semicolon in r8180_core.c and r8180.h
Masanari Iida [Wed, 25 Dec 2013 16:15:53 +0000 (01:15 +0900)]
staging: rtl8187se: Fix space prohibited before semicolon in r8180_core.c and r8180.h

This patch fixed "Warning: space prohibited before semicolon"
found by checkpatch.pl in r8180_core.c and r8180.h

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: silicom: fix sparse non static symbol warnings
Wei Yongjun [Tue, 24 Dec 2013 00:54:40 +0000 (08:54 +0800)]
Staging: silicom: fix sparse non static symbol warnings

Fixes the following sparse warnings:

drivers/staging/silicom/bypasslib/bypass.c:528:12: warning: symbol 'init_lib_module' was not declared. Should it be static?
drivers/staging/silicom/bypasslib/bypass.c:534:13: warning: symbol 'cleanup_lib_module' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Drop print of build date/time
Josh Triplett [Mon, 23 Dec 2013 21:55:13 +0000 (13:55 -0800)]
staging: rtl8188eu: Drop print of build date/time

The kernel already has this information, and individual drivers
shouldn't duplicate that.  This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove wl_pci.?
Greg Kroah-Hartman [Thu, 9 Jan 2014 18:03:02 +0000 (10:03 -0800)]
staging: wlags49_h2: remove wl_pci.?

These files aren't being built into anything, so remove them.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: debug.h: remove typedef for debug structure
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:55:31 +0000 (09:55 -0800)]
staging: wlags49_h2: debug.h: remove typedef for debug structure

Also move the variable definition into the .h file, so it doesn't have
to be declared in each .c file individually, which is crazy.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: debug.h: fix up some coding style issues.
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:48:53 +0000 (09:48 -0800)]
staging: wlags49_h2: debug.h: fix up some coding style issues.

Minor stuff, just formatting.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove some DBG_TRACE() calls
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:39:47 +0000 (09:39 -0800)]
staging: wlags49_h2: remove some DBG_TRACE() calls

These two calls were not needed, they were just debugging stuff.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove custom ways of creating a module name
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:36:29 +0000 (09:36 -0800)]
staging: wlags49_h2: remove custom ways of creating a module name

Just use KBUILD_MODNAME, don't try to hand-roll the same thing with odd
logic.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove PRINTK()
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:31:38 +0000 (09:31 -0800)]
staging: wlags49_h2: remove PRINTK()

It was just a call to printk() so make that instead.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove DBG_DEFN()
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:30:03 +0000 (09:30 -0800)]
staging: wlags49_h2: remove DBG_DEFN()

It didn't do anything, and no one called it, so remove it.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove DBG_TRAP()
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:29:03 +0000 (09:29 -0800)]
staging: wlags49_h2: remove DBG_TRAP()

It didn't do anything, so just remove it, it's useless.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove DBG_LEAVE()
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:25:23 +0000 (09:25 -0800)]
staging: wlags49_h2: remove DBG_LEAVE()

We have an in-kernel tracing function, use that instead if you really
need to figure out when functions are called and exited.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove DBG_ENTER() macro
Greg Kroah-Hartman [Thu, 9 Jan 2014 17:07:30 +0000 (09:07 -0800)]
staging: wlags49_h2: remove DBG_ENTER() macro

We have an in-kernel tracing function, please use that instead of custom
macros.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove empty DBG_FUNC()
Greg Kroah-Hartman [Thu, 9 Jan 2014 16:57:49 +0000 (08:57 -0800)]
staging: wlags49_h2: remove empty DBG_FUNC()

DBG_FUNC() didn't even do anything, so no need for it to be present in
the code at all.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove some unused macros
Greg Kroah-Hartman [Thu, 9 Jan 2014 16:53:27 +0000 (08:53 -0800)]
staging: wlags49_h2: remove some unused macros

These macros were commented out, so just delete them as they are not
used anywhere.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: remove unneeded MODULE_DATE string
Greg Kroah-Hartman [Thu, 9 Jan 2014 16:49:40 +0000 (08:49 -0800)]
staging: wlags49_h2: remove unneeded MODULE_DATE string

This string makes no sense now that the driver is in the kernel, so
remove it.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rts5139: Drop print of build time
Josh Triplett [Mon, 23 Dec 2013 21:55:19 +0000 (13:55 -0800)]
staging: rts5139: Drop print of build time

The kernel already has this information, and individual drivers
shouldn't duplicate that.  This also eliminates the use of __TIME__,
which makes the build non-deterministic.  (And, without __DATE__,
__TIME__ provided little useful information to begin with.)

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: wlags49_h2: Drop debug macro recording build date/time
Josh Triplett [Mon, 23 Dec 2013 21:55:33 +0000 (13:55 -0800)]
staging: wlags49_h2: Drop debug macro recording build date/time

The kernel already has this information, and individual drivers
shouldn't duplicate that.  This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: usbip: userspace: add support for viewing imported devices
Valentina Manea [Tue, 7 Jan 2014 19:05:56 +0000 (21:05 +0200)]
staging: usbip: userspace: add support for viewing imported devices

As of Matt Mooney's major refactoring in 2011, usbip port
option was left out. Add support for this option in
a manner similar to the old implementation.

Sample output:

Imported USB devices
====================
Port 00: <Port in Use> at Full Speed(12Mbps)
       unknown vendor : unknown product (1687:6211)
       2-1 -> usbip://192.168.122.152:3240/1-1
           -> remote bus/dev 001/002

Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c
Larry Finger [Sun, 22 Dec 2013 23:37:01 +0000 (17:37 -0600)]
staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c

Sparse lists the following:

  CHECK   drivers/staging/rtl8188eu/core/rtw_br_ext.c
drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101:    expected unsigned int *ipxNetAddr
drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101:    got restricted __be32 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123: warning: incorrect type in argument 3 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123:    expected unsigned short *ipxSocketAddr
drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99:    expected unsigned int *ipxNetAddr
drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99:    got restricted __be32 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101:    expected unsigned int *ipxNetAddr
drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101:    got restricted __be32 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121: warning: incorrect type in argument 3 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121:    expected unsigned short *ipxSocketAddr
drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99:    expected unsigned int *ipxNetAddr
drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99:    got restricted __be32 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83:    expected unsigned short *network
drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83:    expected unsigned short *network
drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83:    expected unsigned short *network
drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83:    expected unsigned short *network
drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57:    expected unsigned short [unsigned] [short] <noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57:    got restricted __be16 [usertype] <noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:92:23: warning: restricted __be16 degrades to integer
drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95: warning: incorrect type in argument 3 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95:    expected unsigned short *sid
drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112: warning: incorrect type in argument 3 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112:    expected unsigned short *sid
drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112:    got restricted __be16 *<noident>
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84: warning: incorrect type in argument 3 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84:    expected unsigned int [unsigned] [usertype] len
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84:    got restricted __be16 [usertype] payload_len
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110:    expected int [signed] len
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110:    got restricted __be16 [usertype] payload_len
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1148:70: warning: restricted __be16 degrades to integer
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70: warning: invalid assignment: |=
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70:    left side has type unsigned short
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70:    right side has type restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Fix sparse warning in core/rtw_xmit.c
Larry Finger [Sun, 22 Dec 2013 23:37:00 +0000 (17:37 -0600)]
staging: r8188eu: Fix sparse warning in core/rtw_xmit.c

Sparse reports the following warning:

  CHECK   drivers/staging/rtl8188eu/core/rtw_xmit.c
drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23:    expected unsigned short [usertype] *fctrl
drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23:    got restricted __le16 *<noident>

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Fix sparse warning in core/rtw_pwrctrl.c
Larry Finger [Sun, 22 Dec 2013 23:36:59 +0000 (17:36 -0600)]
staging: r8188eu: Fix sparse warning in core/rtw_pwrctrl.c

Sparse reports the following:

  CHECK   drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol 'rtw_free_pwrctrl_priv' was not declared. Should it be static?

That routine is not used and has been deleted.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Fix sparse warning in core/rtw_sta_mgt.c
Larry Finger [Sun, 22 Dec 2013 23:36:58 +0000 (17:36 -0600)]
staging: r8188eu: Fix sparse warning in core/rtw_sta_mgt.c

Sparse reports the following:

  CHECK   drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:152:6: warning: symbol 'rtw_mfree_all_stainfo' was not declared. Should it be static?

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Eliminate enum ODM_RADIO_PATH in favor of rf_radio_path
Larry Finger [Sun, 22 Dec 2013 23:36:57 +0000 (17:36 -0600)]
staging: r8188eu: Eliminate enum ODM_RADIO_PATH in favor of rf_radio_path

There are two different enum statements that have been combined.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Cleanup of include/hal_intf.h
Larry Finger [Sun, 22 Dec 2013 23:36:56 +0000 (17:36 -0600)]
staging: r8188eu: Cleanup of include/hal_intf.h

This driver only handles RTL8188EU with USB interface, thus several hardware
defines and macros can be removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Additional cleanup of include/odm.h
Larry Finger [Sun, 22 Dec 2013 23:36:55 +0000 (17:36 -0600)]
staging: r8188eu: Additional cleanup of include/odm.h

This driver only works with the USB bus. Accordingly, enum odm_interface_def
can be removed along with all code that uses ODM_ITRF_XXX, where XXX is not USB.

In enum odm_ic_type, only ODM_RTL8188E is used. Remove the enum, all references
to the others, and define the needed value.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove unneeded prototypes from include/odm.h
Larry Finger [Sun, 22 Dec 2013 23:36:54 +0000 (17:36 -0600)]
staging: r8188eu: Remove unneeded prototypes from include/odm.h

This header contains a number of routines that do not to be available
globally. Once this change was made, a number of the routines were not
used, and could be removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Simplify code related to SupportICType
Larry Finger [Sun, 22 Dec 2013 23:36:53 +0000 (17:36 -0600)]
staging: r8188eu: Simplify code related to SupportICType

This member of struct odm_dm_struct is always set to ODM_RTL8188E for this
driver. Accordingly, the code can be simplified. A number of routines
now are no longer needed and are deleted.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Simplify code concerning SupportPlatform
Larry Finger [Sun, 22 Dec 2013 23:36:52 +0000 (17:36 -0600)]
staging: r8188eu: Simplify code concerning SupportPlatform

This member of struct odm_dm_struct is always set to ODM_CE in this driver.
As a result, a number of switch and if statements can be simplified. In
addition, a number of routines are no longer used and can be removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove even more empty routines
Larry Finger [Sun, 22 Dec 2013 23:36:51 +0000 (17:36 -0600)]
staging: r8188eu: Remove even more empty routines

This patch removes the following:

odm_DynamicTxPowerAP
odm_RSSIMonitorCheckMP
odm_RSSIMonitorCheckAP
odm_TXPowerTrackingCheckMP
odm_TXPowerTrackingCheckAP
odm_SwAntDivInit
ODM_SwAntDivChkPerPktRssi
odm_SwAntDivChkAntSwitch
ODM_SwAntDivRestAfterLink
dm_GlobalAdapterCheck
odm_dtc

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove more empty routines
Larry Finger [Sun, 22 Dec 2013 23:36:50 +0000 (17:36 -0600)]
staging: r8188eu: Remove more empty routines

This batch includes

ODM_StartWorkItem
ODM_StopWorkItem
ODM_FreeWorkItem
ODM_AcquireSpinLoc
ODM_ReleaseSpinLock
ODM_ReleaseTimer
ODM_ReleaseAllTimers

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove - number of dummy and unused routines
Larry Finger [Sun, 22 Dec 2013 23:36:49 +0000 (17:36 -0600)]
staging: r8188eu: Remove - number of dummy and unused routines

These routines include:
ODM_StartWorkItem()
ODM_StopWorkItem()
ODM_FreeWorkItem()
ODM_ScheduleWorkItem()
ODM_IsWorkItemScheduled()

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove macro ODM_GetMACReg
Larry Finger [Sun, 22 Dec 2013 23:36:48 +0000 (17:36 -0600)]
staging: r8188eu: Remove macro ODM_GetMACReg

This is equivalent to PHY_GetBBReg.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove macro ODM_SetMACReg
Larry Finger [Sun, 22 Dec 2013 23:36:47 +0000 (17:36 -0600)]
staging: r8188eu: Remove macro ODM_SetMACReg

This is the same as macro PHY_SetBBReg.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove macro ODM_GetRFReg
Larry Finger [Sun, 22 Dec 2013 23:36:46 +0000 (17:36 -0600)]
staging: r8188eu: Remove macro ODM_GetRFReg

This one is a duplicate od macro PHY_QueryRFReg.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove macro ODM_SetRFReg
Larry Finger [Sun, 22 Dec 2013 23:36:45 +0000 (17:36 -0600)]
staging: r8188eu: Remove macro ODM_SetRFReg

It is a duplicate of macro PHY_SetRFReg.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove macro ODM_GetBBReg
Larry Finger [Sun, 22 Dec 2013 23:36:44 +0000 (17:36 -0600)]
staging: r8188eu: Remove macro ODM_GetBBReg

This one is a duplicate of PHY_QueryBBReg.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove macro ODM_SetBBReg
Larry Finger [Sun, 22 Dec 2013 23:36:43 +0000 (17:36 -0600)]
staging: r8188eu: Remove macro ODM_SetBBReg

It is essentially a duplicate of macro PHY_SetBBReg

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove wrapper around mutex_destroy
Larry Finger [Sun, 22 Dec 2013 23:36:42 +0000 (17:36 -0600)]
staging: r8188eu: Remove wrapper around mutex_destroy

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove wrappers _rtw_free_sema, _rtw_up_sema, and _rtw_mutex_init
Larry Finger [Sun, 22 Dec 2013 23:36:41 +0000 (17:36 -0600)]
staging: r8188eu: Remove wrappers _rtw_free_sema, _rtw_up_sema, and _rtw_mutex_init

Any routines that are empty as a result of these changes are also removed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Replace wrapper around sema_init
Larry Finger [Sun, 22 Dec 2013 23:36:40 +0000 (17:36 -0600)]
staging: r8188eu: Replace wrapper around sema_init

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove daemonize conditional
Larry Finger [Sun, 22 Dec 2013 23:36:39 +0000 (17:36 -0600)]
staging: r8188eu: Remove daemonize conditional

The current kernels do not include this entry point. Delete the call.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Replace wrappers for atomic_inc and atomic_inc_return
Larry Finger [Sun, 22 Dec 2013 23:36:38 +0000 (17:36 -0600)]
staging: r8188eu: Replace wrappers for atomic_inc and atomic_inc_return

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove unused atomic_xxx wrappers
Larry Finger [Sun, 22 Dec 2013 23:36:37 +0000 (17:36 -0600)]
staging: r8188eu: Remove unused atomic_xxx wrappers

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Replace wrapper around atomic_set()
Larry Finger [Sun, 22 Dec 2013 23:36:36 +0000 (17:36 -0600)]
staging: r8188eu: Replace wrapper around atomic_set()

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Replace ATOMIC_T with atomic_t
Larry Finger [Sun, 22 Dec 2013 23:36:35 +0000 (17:36 -0600)]
staging: r8188eu: Replace ATOMIC_T with atomic_t

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Remove wrapper code for rtw_suspend_lock_init, rtw_suspend_lock_uni...
Larry Finger [Sun, 22 Dec 2013 23:36:34 +0000 (17:36 -0600)]
staging: r8188eu: Remove wrapper code for rtw_suspend_lock_init, rtw_suspend_lock_uninit, rtw_lock_suspend, and rtw_unlock_suspend

All of these routines are empty.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Replace wrapper rtw_yield_os
Larry Finger [Sun, 22 Dec 2013 23:36:33 +0000 (17:36 -0600)]
staging: r8188eu: Replace wrapper rtw_yield_os

a simple yield() is sufficient.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os
Larry Finger [Sun, 22 Dec 2013 23:36:32 +0000 (17:36 -0600)]
staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os

Each of the uses in the code asks for a sleep of 100 usec or so. On Linux,
these are converted to msleep(1).

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Replace C99 comments with C89 ones and remove unneeded comments in InterfaceRx.c
Matthias Oefelein [Wed, 8 Jan 2014 22:15:10 +0000 (23:15 +0100)]
beeceem: Replace C99 comments with C89 ones and remove unneeded comments in InterfaceRx.c

This patch replaces C99-style with C89-style comments.
Additionally, code fragments that have been commented out are removed;
the same applies to meaningless comments.

Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Fix newline issues at opening braces of conditional statements in InterfaceRx.c
Matthias Oefelein [Wed, 8 Jan 2014 22:15:09 +0000 (23:15 +0100)]
beeceem: Fix newline issues at opening braces of conditional statements in InterfaceRx.c

In InterfaceRx.c, opening braces of (if-)conditionals are mostly
dislocated, meaning they are found behind an extra line break after the
conditional statement.  This patch moves the opening braces accordingly
as specified by the official conding style guidelines.

Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Fix whitespace issues at opening parentheses in InterfaceRx.c
Matthias Oefelein [Wed, 8 Jan 2014 22:15:08 +0000 (23:15 +0100)]
beeceem: Fix whitespace issues at opening parentheses in InterfaceRx.c

Most spaces before opening parentheses (where required) are missing here.
This patch adds spaces at the appropriate spots.

Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Fix broken indentations in InterfaceRx.c
Matthias Oefelein [Wed, 8 Jan 2014 22:15:07 +0000 (23:15 +0100)]
beeceem: Fix broken indentations in InterfaceRx.c

Checkpatch reports a lot of spaces at the beginning of lines and other
wrong indentations. This patch fixes these issues.

Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Fix missing spaces between function arguments in InterfaceRx.c
Matthias Oefelein [Wed, 8 Jan 2014 22:15:06 +0000 (23:15 +0100)]
beeceem: Fix missing spaces between function arguments in InterfaceRx.c

This fix adds missing spaces after commas in function calls/definitions.

Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Fix missing spaces around operators and unwanted spaces around semicolons...
Matthias Oefelein [Wed, 8 Jan 2014 22:15:05 +0000 (23:15 +0100)]
beeceem: Fix missing spaces around operators and unwanted spaces around semicolons in InterfaceRx.c

Checkpatch reports missing spaces around operators; this patch
introduces spaces where needed.
Spaces before semicolons are prohibited by the official coding style
guidelines, those have been fixed as well.

Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Replace C99-style comments with C89 pendants in InterfaceTx.c
Ralph Mueck [Mon, 30 Dec 2013 11:44:24 +0000 (12:44 +0100)]
beeceem: Replace C99-style comments with C89 pendants in InterfaceTx.c

Checkpatch complains about the use of //-comments, thus they are replaced by C89-style comments.

Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Fix position of braces in conditional statements in InterfaceTx.c
Ralph Mueck [Mon, 30 Dec 2013 11:44:23 +0000 (12:44 +0100)]
beeceem: Fix position of braces in conditional statements in InterfaceTx.c

This corrects the position of (opening) braces in if-conditionals to make checkpatch shut up.

Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Add spaces before opening parentheses in if-conditionals in InterfaceTx.c
Ralph Mueck [Mon, 30 Dec 2013 11:44:22 +0000 (12:44 +0100)]
beeceem: Add spaces before opening parentheses in if-conditionals in InterfaceTx.c

This patch adds spaces before the opening parentheses of if-conditionals to comply with offical code styling guidelines.

Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agobeeceem: Fix several whitespace issues in InterfaceTx.c
Ralph Mueck [Mon, 30 Dec 2013 11:44:21 +0000 (12:44 +0100)]
beeceem: Fix several whitespace issues in InterfaceTx.c

This patch takes care of the following issues:
- missing spaces at variable assignments
- missing spaces between function arguments
- spaces at the beginning of a line where tabs should be
- prohibited spaces before a (semi)colon

Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Use is_vmalloc_addr
Laura Abbott [Thu, 2 Jan 2014 21:53:23 +0000 (13:53 -0800)]
staging: lustre: Use is_vmalloc_addr

Instead of manually checking the bounds of VMALLOC_START and
VMALLOC_END, just use is_vmalloc_addr. That's what the function
was designed for.

Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Make LUSTRE_LLITE_LLOOP tristate
Ben Hutchings [Sun, 29 Dec 2013 22:28:15 +0000 (23:28 +0100)]
staging: lustre: Make LUSTRE_LLITE_LLOOP tristate

There seems to be no reason why it can't be a module; in fact that is
currently supposed to be the default.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Remove braces for single statement in kernel_user_comm.c
Masanari Iida [Tue, 24 Dec 2013 16:34:05 +0000 (01:34 +0900)]
staging: lustre: Remove braces for single statement in kernel_user_comm.c

This patch fixed "WARNING: braces {} are not necessary for
single statement blocks" found by checkpatch.pl in
kernel_user_comm.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Fix do not use C99 // comments in lcommon_cl.c
Masanari Iida [Tue, 24 Dec 2013 12:53:19 +0000 (21:53 +0900)]
staging: lustre: Fix do not use C99 // comments in lcommon_cl.c

This patch fixed "ERROR: do not use C99 // comments" found by
checkpatch.pl in lcommon_cl.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Fix space prohibited between function name and open parenthesis...
Masanari Iida [Tue, 24 Dec 2013 12:53:18 +0000 (21:53 +0900)]
staging: lustre: Fix space prohibited between function name and open parenthesis in lcommon_cl.c

This patch fixed "WARNING: space prohibited between function name
and open parenthesis '(' found by checkpatch.pl,
in lustre/lclient/lcommon_cl.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Fix do not use C99 // comments in mgc_request.c
Masanari Iida [Mon, 23 Dec 2013 04:10:34 +0000 (13:10 +0900)]
staging: lustre: Fix do not use C99 // comments in mgc_request.c

This patch fixed "ERROR: do not use C99 // comments"
found by checkpatch.pl in lustre/lustre/mgc_request.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: Fix brace {} are not necessary for single statement blocks
Masanari Iida [Mon, 23 Dec 2013 04:10:33 +0000 (13:10 +0900)]
staging: lustre: Fix brace {} are not necessary for single statement blocks

This patch fixed "WARNING: braces {} are not necessary for
single statement blocks" in lustre/lustre/mgc_request.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agolustre: Fix space required before the open parenthesis in mgc_required.c
Masanari Iida [Mon, 23 Dec 2013 04:10:32 +0000 (13:10 +0900)]
lustre: Fix space required before the open parenthesis in mgc_required.c

This patch fixed "ERROR: space required before the open
parenthesis'('" found by checkpatch.pl in
lustre/lustre/mgc/mgc_request.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agodrivers: dgnc: Include appropriate header file in dgnc_trace.c
Rashika Kheria [Sat, 21 Dec 2013 10:22:38 +0000 (15:52 +0530)]
drivers: dgnc: Include appropriate header file in dgnc_trace.c

Include appropriate header file dgnc/dgnc_trace.h in dgnc_trace.c
because function dgnc_tracer_free() has its prototype declaration in the
header file.

This eliminates the following warning in dgnc_trace.c:
drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for ‘dgnc_tracer_free’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agodrivers: bcm: Remove unused function in nvm.c
Rashika Kheria [Sat, 21 Dec 2013 10:33:22 +0000 (16:03 +0530)]
drivers: bcm: Remove unused function in nvm.c

Remove unused function PropagateCalParamsFromEEPROMToMemory() in nvm.c.

This eliminates the following warning in nvm.c:
drivers/staging/bcm/nvm.c:1369:5: warning: no previous prototype for ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agodrivers: bcm: Mark functions as static in Qos.c
Rashika Kheria [Sat, 21 Dec 2013 10:31:16 +0000 (16:01 +0530)]
drivers: bcm: Mark functions as static in Qos.c

Mark functions MatchSrcIpAddress(), MatchDestIpAddress() and MatchTos()
as static in Qos.c because they are not used outside this file.

This eliminates the following warnings in Qos.c:
drivers/staging/bcm/Qos.c:27:6: warning: no previous prototype for ‘MatchSrcIpAddress’ [-Wmissing-prototypes]
drivers/staging/bcm/Qos.c:61:6: warning: no previous prototype for ‘MatchDestIpAddress’ [-Wmissing-prototypes]
drivers/staging/bcm/Qos.c:94:6: warning: no previous prototype for ‘MatchTos’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agodrivers: sbe-2t3e3: Mark functions as static in ctrl.c
Rashika Kheria [Sat, 21 Dec 2013 10:17:13 +0000 (15:47 +0530)]
drivers: sbe-2t3e3: Mark functions as static in ctrl.c

Mark functions t3e3_set_loopback(), t3e3_reg_read(), t3e3_reg_write(),
t3e3_port_get(), t3e3_port_set(), t3e3_port_get_stats() and
t3e3_port_del_stats() as static in ctrl.c because they are not used
outside this file.

This eliminates the following warnings in ctrl.c:
drivers/staging/sbe-2t3e3/ctrl.c:34:6: warning: no previous prototype for ‘t3e3_set_loopback’ [-Wmissing-prototypes]
drivers/staging/sbe-2t3e3/ctrl.c:98:6: warning: no previous prototype for ‘t3e3_reg_read’ [-Wmissing-prototypes]
drivers/staging/sbe-2t3e3/ctrl.c:135:6: warning: no previous prototype for ‘t3e3_reg_write’ [-Wmissing-prototypes]
drivers/staging/sbe-2t3e3/ctrl.c:167:6: warning: no previous prototype for ‘t3e3_port_get’ [-Wmissing-prototypes]
drivers/staging/sbe-2t3e3/ctrl.c:172:6: warning: no previous prototype for ‘t3e3_port_set’ [-Wmissing-prototypes]
drivers/staging/sbe-2t3e3/ctrl.c:219:6: warning: no previous prototype for ‘t3e3_port_get_stats’ [-Wmissing-prototypes]
drivers/staging/sbe-2t3e3/ctrl.c:285:6: warning: no previous prototype for ‘t3e3_port_del_stats’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>