GitHub/WoltLab/WCF.git
2 years agoMerge branch '5.4'
Tim Düsterhus [Fri, 7 Jan 2022 14:36:31 +0000 (15:36 +0100)]
Merge branch '5.4'

2 years agoMerge pull request #4623 from WoltLab/php8.1-i18n-option
Tim Düsterhus [Fri, 7 Jan 2022 13:52:02 +0000 (14:52 +0100)]
Merge pull request #4623 from WoltLab/php8.1-i18n-option

Fix PHP 8.1 compatibility when saving I18n options

2 years agoDefault missing values to `''` in OptionHandler::validateOption()
Tim Düsterhus [Fri, 7 Jan 2022 08:54:19 +0000 (09:54 +0100)]
Default missing values to `''` in OptionHandler::validateOption()

This is required for PHP 8.1 compatibility of i18n options, as these are
handled separately using I18nHandler.

see b46c272b28ba84892534b31c641a6dd412bb0a1e
see 860e98cff580e299cbbd8cdb7eb50d0113b938cc

2 years agoRevert "Fix PHP 8.1 compatibility when saving I18n options"
Tim Düsterhus [Fri, 7 Jan 2022 08:50:28 +0000 (09:50 +0100)]
Revert "Fix PHP 8.1 compatibility when saving I18n options"

During the discussion within the PR is was decided to opt for a different, less
invasive, fix, because the impact of this change is not really clear.

This reverts commit b46c272b28ba84892534b31c641a6dd412bb0a1e.

2 years agoNested tab menus were not preselected on load
Alexander Ebert [Thu, 6 Jan 2022 19:20:12 +0000 (20:20 +0100)]
Nested tab menus were not preselected on load

See https://www.woltlab.com/community/thread/293819-subtab-direkt-aufrufen-geht-nicht/

2 years agoMerge branch '5.4'
Marcel Werk [Thu, 6 Jan 2022 17:11:23 +0000 (18:11 +0100)]
Merge branch '5.4'

2 years agoMerge branch '5.4' of https://github.com/WoltLab/WCF into 5.4
Marcel Werk [Thu, 6 Jan 2022 17:11:09 +0000 (18:11 +0100)]
Merge branch '5.4' of https://github.com/WoltLab/WCF into 5.4

2 years agosignature_max_image_height caused incorrect size of avatars in quotes within signatures
Marcel Werk [Thu, 6 Jan 2022 17:11:01 +0000 (18:11 +0100)]
signature_max_image_height caused incorrect size of avatars in quotes within signatures

Closes #4625

2 years agoFiltering the user list by a user group discarded the optional columns
Alexander Ebert [Thu, 6 Jan 2022 17:08:45 +0000 (18:08 +0100)]
Filtering the user list by a user group discarded the optional columns

Fix for 9bc86ecf0bd32ed2615023bcf9ae398aafbb23fa

See https://www.woltlab.com/community/thread/293719-detailinfos-innerhalb-benutzergruppen-fehlen-im-acp-seit-update-woltlab-suite-5/

2 years agoMerge pull request #4608 from WoltLab/mobile-menu-v2
Alexander Ebert [Thu, 6 Jan 2022 16:45:39 +0000 (17:45 +0100)]
Merge pull request #4608 from WoltLab/mobile-menu-v2

Overhaul of the mobile menu

2 years agoPage containers did not open on first click
Alexander Ebert [Thu, 6 Jan 2022 16:39:28 +0000 (17:39 +0100)]
Page containers did not open on first click

2 years agoFix PHP 8.1 compatibility when saving I18n options
Tim Düsterhus [Thu, 6 Jan 2022 09:50:13 +0000 (10:50 +0100)]
Fix PHP 8.1 compatibility when saving I18n options

As I18n options are special-cased, they will not be provided in `rawValues`,
thus passing `null` to `->getData()`, which the option types are not prepared
to handle. Before PHP 8.1 this was implicitly treated as an empty string, with
the types introduced to native functions, e.g. `explode()` or `preg_replace()`
this will result in an error.

2 years agoImproved the documentation of modules
Alexander Ebert [Wed, 5 Jan 2022 17:58:31 +0000 (18:58 +0100)]
Improved the documentation of modules

2 years agoMerge pull request #4621 from WoltLab/55-package-update-ui
Alexander Ebert [Tue, 4 Jan 2022 15:35:02 +0000 (16:35 +0100)]
Merge pull request #4621 from WoltLab/55-package-update-ui

Updates the UI/UX for the list of outstanding updates

2 years agoMerge branch 'master' into mobile-menu-v2
Tim Düsterhus [Tue, 4 Jan 2022 15:20:28 +0000 (16:20 +0100)]
Merge branch 'master' into mobile-menu-v2

2 years agoMerge branch 'master' into 55-package-update-ui
Tim Düsterhus [Tue, 4 Jan 2022 15:13:21 +0000 (16:13 +0100)]
Merge branch 'master' into 55-package-update-ui

2 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 4 Jan 2022 15:12:09 +0000 (16:12 +0100)]
Merge branch '5.4'

2 years agoRun prettier on `acp/style/**/*.scss`
Tim Düsterhus [Tue, 4 Jan 2022 15:10:03 +0000 (16:10 +0100)]
Run prettier on `acp/style/**/*.scss`

2 years agoImproved the UI, using a separate phrase for the version update
Alexander Ebert [Tue, 4 Jan 2022 15:06:27 +0000 (16:06 +0100)]
Improved the UI, using a separate phrase for the version update

2 years agoMissing module level comment
Alexander Ebert [Tue, 4 Jan 2022 14:14:27 +0000 (15:14 +0100)]
Missing module level comment

2 years agoIncorrect checkbox behavior
Alexander Ebert [Tue, 4 Jan 2022 14:12:07 +0000 (15:12 +0100)]
Incorrect checkbox behavior

2 years agoForce-enable all updates during an upgrade
Alexander Ebert [Tue, 4 Jan 2022 14:08:08 +0000 (15:08 +0100)]
Force-enable all updates during an upgrade

Fixes #4560

2 years agoRefreshed the UI for the package update view
Alexander Ebert [Tue, 4 Jan 2022 13:25:03 +0000 (14:25 +0100)]
Refreshed the UI for the package update view

2 years agoMerge pull request #4619 from WoltLab/recommend-smtp
Tim Düsterhus [Mon, 3 Jan 2022 14:40:24 +0000 (15:40 +0100)]
Merge pull request #4619 from WoltLab/recommend-smtp

Mark the SMTP email transport as recommended

2 years agoMerge pull request #4615 from WoltLab/55-data-import
Marcel Werk [Mon, 3 Jan 2022 12:52:04 +0000 (13:52 +0100)]
Merge pull request #4615 from WoltLab/55-data-import

Converted data import manager to typescript

2 years agoMerge pull request #4618 from WoltLab/sandbox-implode-loop
Marcel Werk [Mon, 3 Jan 2022 12:31:39 +0000 (13:31 +0100)]
Merge pull request #4618 from WoltLab/sandbox-implode-loop

Sandbox implode loop variables

2 years agoApplied code suggestions
Marcel Werk [Mon, 3 Jan 2022 12:30:40 +0000 (13:30 +0100)]
Applied code suggestions

2 years agoUpdate composer dependencies
Tim Düsterhus [Mon, 3 Jan 2022 11:57:24 +0000 (12:57 +0100)]
Update composer dependencies

2 years agoMerge branch 'master' into mobile-menu-v2
Tim Düsterhus [Mon, 3 Jan 2022 10:01:23 +0000 (11:01 +0100)]
Merge branch 'master' into mobile-menu-v2

2 years agoFix SCSS code style
Tim Düsterhus [Mon, 3 Jan 2022 09:38:35 +0000 (10:38 +0100)]
Fix SCSS code style

see 688e59f11d912acaa3e831aa42ccf83363d9ce24

2 years agoMark the SMTP email transport as recommended
Tim Düsterhus [Mon, 3 Jan 2022 09:21:52 +0000 (10:21 +0100)]
Mark the SMTP email transport as recommended

2 years agoConverted the JavaScript for the package update page
Alexander Ebert [Sun, 2 Jan 2022 16:01:33 +0000 (17:01 +0100)]
Converted the JavaScript for the package update page

2 years agoSandbox implode loop variables
Marcel Werk [Sat, 1 Jan 2022 16:13:01 +0000 (17:13 +0100)]
Sandbox implode loop variables

Closes #4617

2 years agoPrevent blurry dialogs by using CSS grids for positioning
Alexander Ebert [Sat, 1 Jan 2022 15:20:41 +0000 (16:20 +0100)]
Prevent blurry dialogs by using CSS grids for positioning

Fixes #4593

2 years agoMissing return type documentation
Marcel Werk [Sat, 1 Jan 2022 12:56:23 +0000 (13:56 +0100)]
Missing return type documentation

2 years agoCode style fixes
Alexander Ebert [Fri, 31 Dec 2021 18:15:39 +0000 (19:15 +0100)]
Code style fixes

2 years agoMerge branch 'master' into mobile-menu-v2
Alexander Ebert [Fri, 31 Dec 2021 18:09:21 +0000 (19:09 +0100)]
Merge branch 'master' into mobile-menu-v2

2 years agoMinor code improvements
Alexander Ebert [Fri, 31 Dec 2021 18:08:03 +0000 (19:08 +0100)]
Minor code improvements

2 years agoUnified the search bar behavior in the frontend and admin panel
Alexander Ebert [Fri, 31 Dec 2021 18:05:41 +0000 (19:05 +0100)]
Unified the search bar behavior in the frontend and admin panel

2 years agoCleaned up redundant functions
Alexander Ebert [Fri, 31 Dec 2021 17:27:48 +0000 (18:27 +0100)]
Cleaned up redundant functions

2 years agoRemoved the old module for the search bar handling
Alexander Ebert [Fri, 31 Dec 2021 17:16:33 +0000 (18:16 +0100)]
Removed the old module for the search bar handling

2 years agoMerged the search handling into a single module
Alexander Ebert [Fri, 31 Dec 2021 17:14:55 +0000 (18:14 +0100)]
Merged the search handling into a single module

It was previously split between the `Ui/Page/Header/Fixed` and `Ui/Mobile` module. This commit only merges the two with purely compatibility related changes.

2 years agoRemoved "text-transform: uppercase" for better accessibility
Marcel Werk [Fri, 31 Dec 2021 17:09:34 +0000 (18:09 +0100)]
Removed "text-transform: uppercase" for better accessibility

2 years agoSimplified contentHeaderNavigation styling
Marcel Werk [Fri, 31 Dec 2021 16:59:10 +0000 (17:59 +0100)]
Simplified contentHeaderNavigation styling

2 years agoRemoved obsolete language variable
Marcel Werk [Fri, 31 Dec 2021 15:26:59 +0000 (16:26 +0100)]
Removed obsolete language variable

2 years agoMissing language variable
Marcel Werk [Fri, 31 Dec 2021 15:26:39 +0000 (16:26 +0100)]
Missing language variable

2 years agoRemoval of unused components from the previous menu implementation
Alexander Ebert [Fri, 31 Dec 2021 14:21:45 +0000 (15:21 +0100)]
Removal of unused components from the previous menu implementation

2 years agoWorkaround for the search bar in the admin panel
Alexander Ebert [Fri, 31 Dec 2021 14:14:52 +0000 (15:14 +0100)]
Workaround for the search bar in the admin panel

2 years agoThe mobile menu was bricking the login/reauthentication view
Alexander Ebert [Fri, 31 Dec 2021 13:58:12 +0000 (14:58 +0100)]
The mobile menu was bricking the login/reauthentication view

2 years agoOpen and highlight the active menu item on first open
Alexander Ebert [Fri, 31 Dec 2021 13:49:11 +0000 (14:49 +0100)]
Open and highlight the active menu item on first open

2 years agoConverted data import manager to typescript
Marcel Werk [Thu, 30 Dec 2021 15:30:26 +0000 (16:30 +0100)]
Converted data import manager to typescript

2 years agoMain menu support for the admin panel
Alexander Ebert [Thu, 30 Dec 2021 14:20:37 +0000 (15:20 +0100)]
Main menu support for the admin panel

2 years agoDefer the main menu creation into a separate module
Alexander Ebert [Thu, 30 Dec 2021 12:46:58 +0000 (13:46 +0100)]
Defer the main menu creation into a separate module

The admin panel uses a completely different markup that has no common logic with the frontend.

2 years agoAdmin panel menu drop-down menus are now accessible
Alexander Ebert [Wed, 29 Dec 2021 18:50:08 +0000 (19:50 +0100)]
Admin panel menu drop-down menus are now accessible

2 years agoPrototype for the mobile menu of the admin panel
Alexander Ebert [Wed, 29 Dec 2021 18:30:42 +0000 (19:30 +0100)]
Prototype for the mobile menu of the admin panel

2 years agoAdded the missing ARIA labels
Alexander Ebert [Wed, 29 Dec 2021 17:12:05 +0000 (18:12 +0100)]
Added the missing ARIA labels

2 years agoImplemented non-link sub menus
Alexander Ebert [Wed, 29 Dec 2021 16:42:47 +0000 (17:42 +0100)]
Implemented non-link sub menus

2 years agoRegular login link in the menu for guests
Alexander Ebert [Wed, 29 Dec 2021 15:12:49 +0000 (16:12 +0100)]
Regular login link in the menu for guests

2 years agoImproved the menu overflow behavior
Alexander Ebert [Tue, 28 Dec 2021 16:41:06 +0000 (17:41 +0100)]
Improved the menu overflow behavior

2 years agoMenu overflow behavior, indicators for overflowing content
Alexander Ebert [Tue, 28 Dec 2021 16:35:24 +0000 (17:35 +0100)]
Menu overflow behavior, indicators for overflowing content

2 years agoMerge branch '5.4'
Marcel Werk [Tue, 28 Dec 2021 16:18:31 +0000 (17:18 +0100)]
Merge branch '5.4'

2 years agoPasting in ItemList did not work
Marcel Werk [Tue, 28 Dec 2021 16:18:10 +0000 (17:18 +0100)]
Pasting in ItemList did not work

2 years agoGap between menus, safe click area for touch browsers
Alexander Ebert [Mon, 27 Dec 2021 13:42:33 +0000 (14:42 +0100)]
Gap between menus, safe click area for touch browsers

2 years agoRemoved hover states on touch devices
Alexander Ebert [Thu, 23 Dec 2021 16:56:11 +0000 (17:56 +0100)]
Removed hover states on touch devices

2 years agoIncrease the tap target size to 44x44 px
Alexander Ebert [Thu, 23 Dec 2021 16:44:31 +0000 (17:44 +0100)]
Increase the tap target size to 44x44 px

2 years agoIndicator for user menu tabs with unread content
Alexander Ebert [Thu, 23 Dec 2021 16:25:13 +0000 (17:25 +0100)]
Indicator for user menu tabs with unread content

2 years agoMissing indicator for unread content
Alexander Ebert [Thu, 23 Dec 2021 16:08:24 +0000 (17:08 +0100)]
Missing indicator for unread content

2 years agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Thu, 23 Dec 2021 10:25:37 +0000 (11:25 +0100)]
Merge remote-tracking branch 'origin/master'

2 years agoMerge branch '5.4'
Tim Düsterhus [Thu, 23 Dec 2021 10:25:27 +0000 (11:25 +0100)]
Merge branch '5.4'

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 23 Dec 2021 10:24:45 +0000 (11:24 +0100)]
Merge branch '5.3' into 5.4

2 years agoPass the file's basename to the validation regex in StyleEditor::export()
Tim Düsterhus [Thu, 23 Dec 2021 10:19:25 +0000 (11:19 +0100)]
Pass the file's basename to the validation regex in StyleEditor::export()

This fixes 84f62ddac1ba9894a9cbb8791085f7799f3760c8.

2 years agoRelease 5.4.10 5.4.10
Alexander Ebert [Wed, 22 Dec 2021 16:26:57 +0000 (17:26 +0100)]
Release 5.4.10

2 years agoRelease 5.4.10 dev 2 5.4.10_dev_2
Alexander Ebert [Wed, 22 Dec 2021 14:49:35 +0000 (15:49 +0100)]
Release 5.4.10 dev 2

2 years agoRelease 5.3.16 5.3.16
Alexander Ebert [Wed, 22 Dec 2021 14:46:57 +0000 (15:46 +0100)]
Release 5.3.16

2 years agoUpdating minified JavaScript files
WoltLab [Wed, 22 Dec 2021 14:23:59 +0000 (14:23 +0000)]
Updating minified JavaScript files

2 years agoImproper restore of navigation menu icons
Alexander Ebert [Wed, 22 Dec 2021 14:07:29 +0000 (15:07 +0100)]
Improper restore of navigation menu icons

2 years agoImproved UI of scrollable checkbox lists
Marcel Werk [Tue, 21 Dec 2021 14:32:05 +0000 (15:32 +0100)]
Improved UI of scrollable checkbox lists

2 years agoMerge pull request #4611 from WoltLab/5.5-upload-session-cleanup
Joshua Rüsweg [Tue, 21 Dec 2021 12:50:24 +0000 (13:50 +0100)]
Merge pull request #4611 from WoltLab/5.5-upload-session-cleanup

Add UploadHandler session cleanup

2 years agoAdd UploadHandler session cleanup
joshuaruesweg [Tue, 21 Dec 2021 10:30:54 +0000 (11:30 +0100)]
Add UploadHandler session cleanup

Since the sessions stick way longer than with the introduction of the system, it is necessary, to clean up old file uploads in the session storage.

With this patch, a field in the session saves the creation time of the StorageField in the session and delete the field after 24 hours automatically.

2 years agoReintroduced the unread indicators
Alexander Ebert [Mon, 20 Dec 2021 16:50:48 +0000 (17:50 +0100)]
Reintroduced the unread indicators

2 years agoMissing re-enable of body scrolling when the page is not scrolled
Alexander Ebert [Mon, 20 Dec 2021 16:18:44 +0000 (17:18 +0100)]
Missing re-enable of body scrolling when the page is not scrolled

2 years agoMerge pull request #4610 from WoltLab/54-metacode-parse-attributes
Alexander Ebert [Mon, 20 Dec 2021 15:43:35 +0000 (16:43 +0100)]
Merge pull request #4610 from WoltLab/54-metacode-parse-attributes

Enforce a consistent return type

2 years agoEnforce a consistent return type
Alexander Ebert [Mon, 20 Dec 2021 15:10:27 +0000 (16:10 +0100)]
Enforce a consistent return type

The method was designed to always return an array. If the `\base64_code()` fails, it returned `false` instead, which was both unexpected and could fail in PHP 8.1 (autovivification on false, https://wiki.php.net/rfc/autovivification_false)

2 years agoImproved the behavior of the search overlay
Alexander Ebert [Mon, 20 Dec 2021 14:43:23 +0000 (15:43 +0100)]
Improved the behavior of the search overlay

2 years agoAdded missing 'deprecated' tags
Marcel Werk [Mon, 20 Dec 2021 13:16:12 +0000 (14:16 +0100)]
Added missing 'deprecated' tags

2 years agoIntegrate the search bar into the mobile header
Alexander Ebert [Mon, 20 Dec 2021 10:54:52 +0000 (11:54 +0100)]
Integrate the search bar into the mobile header

2 years agoPage menus were too small
Alexander Ebert [Sun, 19 Dec 2021 18:47:47 +0000 (19:47 +0100)]
Page menus were too small

2 years agoIncreased the size of the touch areas of header items
Alexander Ebert [Sun, 19 Dec 2021 18:44:54 +0000 (19:44 +0100)]
Increased the size of the touch areas of header items

2 years agoUnified sidebar position
Marcel Werk [Sun, 19 Dec 2021 18:35:09 +0000 (19:35 +0100)]
Unified sidebar position

2 years agoOverhauled the layout of the mobile header
Alexander Ebert [Sun, 19 Dec 2021 18:11:03 +0000 (19:11 +0100)]
Overhauled the layout of the mobile header

2 years agoRelease 5.4.10 dev 1 5.4.10_dev_1
Alexander Ebert [Fri, 17 Dec 2021 16:38:41 +0000 (17:38 +0100)]
Release 5.4.10 dev 1

2 years agoAdd `wcf.user.3rdparty.login.error.user_aborted` phrase
Tim Düsterhus [Fri, 17 Dec 2021 12:34:12 +0000 (13:34 +0100)]
Add `wcf.user.3rdparty.login.error.user_aborted` phrase

2 years agoMerge branch '5.4'
Tim Düsterhus [Fri, 17 Dec 2021 09:46:40 +0000 (10:46 +0100)]
Merge branch '5.4'

2 years agoFix the include family of "functions" in stack trace sanitization
Tim Düsterhus [Fri, 17 Dec 2021 09:31:27 +0000 (10:31 +0100)]
Fix the include family of "functions" in stack trace sanitization

`include` et al are not actual functions, but language constructs. For this
reason they cannot be reflected, causing their arguments to show as
`[error_during_sanitization]`. Fix this by special casing them to not run the
sanitization, they do not contain sensitive arguments (apart from the path
which is redacted independently later).

2 years agoUpdating minified JavaScript files
WoltLab [Thu, 16 Dec 2021 18:09:39 +0000 (18:09 +0000)]
Updating minified JavaScript files

2 years agoSelection changes on mobile were recognized as clicks
Alexander Ebert [Thu, 16 Dec 2021 18:08:23 +0000 (19:08 +0100)]
Selection changes on mobile were recognized as clicks

2 years agoUpdating minified JavaScript files
WoltLab [Thu, 16 Dec 2021 14:47:59 +0000 (14:47 +0000)]
Updating minified JavaScript files

2 years agoMerge pull request #4605 from WoltLab/search-form-overhaul
Marcel Werk [Thu, 16 Dec 2021 12:46:18 +0000 (13:46 +0100)]
Merge pull request #4605 from WoltLab/search-form-overhaul

Search form overhaul

2 years agoFix deprecation remark in UserUtil::isAvailable*()
Tim Düsterhus [Thu, 16 Dec 2021 10:34:30 +0000 (11:34 +0100)]
Fix deprecation remark in UserUtil::isAvailable*()

see #4602
see 7ce5915fd75e90a4dd2d546b892fe08b6335a273
see 5856dc0cbd396d7d3592480606fbdcc0c3f30f50

2 years agoApplied code suggestions
Marcel Werk [Wed, 15 Dec 2021 17:13:42 +0000 (18:13 +0100)]
Applied code suggestions