GitHub/WoltLab/WCF.git
4 years agoMerge pull request #3624 from WoltLab/deprecate_fileutil_downloadfilefromhttp
Tim Düsterhus [Fri, 23 Oct 2020 11:35:47 +0000 (13:35 +0200)]
Merge pull request #3624 from WoltLab/deprecate_fileutil_downloadfilefromhttp

Use Guzzle instead of FileUtil::downloadFileFromHttp

4 years agoUse Guzzle to download spider list
joshuaruesweg [Wed, 21 Oct 2020 17:22:21 +0000 (19:22 +0200)]
Use Guzzle to download spider list

4 years agoUse Guzzle to download package archives
joshuaruesweg [Wed, 21 Oct 2020 17:10:42 +0000 (19:10 +0200)]
Use Guzzle to download package archives

4 years agoUse Guzzle to test the Gravatar URL
joshuaruesweg [Wed, 21 Oct 2020 15:34:16 +0000 (17:34 +0200)]
Use Guzzle to test the Gravatar URL

4 years agoMerge branch '5.3'
Tim Düsterhus [Fri, 23 Oct 2020 10:50:42 +0000 (12:50 +0200)]
Merge branch '5.3'

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Fri, 23 Oct 2020 10:50:23 +0000 (12:50 +0200)]
Merge branch '5.2' into 5.3

4 years agoWhitelist `get_class` in enterprise mode
Tim Düsterhus [Fri, 23 Oct 2020 10:49:54 +0000 (12:49 +0200)]
Whitelist `get_class` in enterprise mode

4 years agoMerge pull request #3631 from WoltLab/header-cleanup
Tim Düsterhus [Fri, 23 Oct 2020 10:41:26 +0000 (12:41 +0200)]
Merge pull request #3631 from WoltLab/header-cleanup

Clean up response headers

4 years agoRemove `Expires` response header
Tim Düsterhus [Fri, 23 Oct 2020 07:43:14 +0000 (09:43 +0200)]
Remove `Expires` response header

No RFC compliant user-agent will ever take this header into account:

> If a response includes a Cache-Control field with the max-age
> directive (Section 5.2.2.8), a recipient MUST ignore the Expires
> field.

4 years agoRemove `Pragma: no-cache` response header
Tim Düsterhus [Fri, 23 Oct 2020 07:38:57 +0000 (09:38 +0200)]
Remove `Pragma: no-cache` response header

`Pragma: no-cache` is HTTP/1.0 specific. Anything accessing WoltLab Suite
should be able to at least speak HTTP/1.1. HTTP/1.0 does not even define the
`Host` header for hosting multiple sites on a single IP address!

4 years agoRemove `X-UA-Compatible` response header
Tim Düsterhus [Fri, 23 Oct 2020 07:37:06 +0000 (09:37 +0200)]
Remove `X-UA-Compatible` response header

Without support for Internet Explorer we no longer need this header.

4 years agoMerge pull request #3625 from WoltLab/guzzle-sink
Joshua Rüsweg [Thu, 22 Oct 2020 14:49:46 +0000 (16:49 +0200)]
Merge pull request #3625 from WoltLab/guzzle-sink

Remove the explicit passing of a Guzzle sink

4 years agoRemove update files for 5.2 -> 5.3
Tim Düsterhus [Thu, 22 Oct 2020 09:52:42 +0000 (11:52 +0200)]
Remove update files for 5.2 -> 5.3

4 years agoRemove the explicit passing of a Guzzle sink
Tim Düsterhus [Thu, 22 Oct 2020 07:59:57 +0000 (09:59 +0200)]
Remove the explicit passing of a Guzzle sink

4 years agoMerge branch '5.3'
Alexander Ebert [Wed, 21 Oct 2020 16:20:39 +0000 (18:20 +0200)]
Merge branch '5.3'

4 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Wed, 21 Oct 2020 16:20:23 +0000 (18:20 +0200)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 21 Oct 2020 16:20:06 +0000 (18:20 +0200)]
Merge branch '3.1' into 5.2

4 years agoIgnore top-level node_modules/
Tim Düsterhus [Fri, 16 Oct 2020 11:57:29 +0000 (13:57 +0200)]
Ignore top-level node_modules/

4 years agoUpdating minified JavaScript files
WoltLab [Wed, 21 Oct 2020 15:07:48 +0000 (15:07 +0000)]
Updating minified JavaScript files

4 years agoLimit branches for templates workflow
Tim Düsterhus [Wed, 21 Oct 2020 13:43:44 +0000 (15:43 +0200)]
Limit branches for templates workflow

4 years agoMerge branch '5.3' into master
Tim Düsterhus [Wed, 21 Oct 2020 13:43:21 +0000 (15:43 +0200)]
Merge branch '5.3' into master

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Wed, 21 Oct 2020 13:42:15 +0000 (15:42 +0200)]
Merge branch '5.2' into 5.3

4 years agoLimit workflows to release branches
Tim Düsterhus [Wed, 21 Oct 2020 13:39:04 +0000 (15:39 +0200)]
Limit workflows to release branches

Features branches will be tested using a PR.

4 years agoMerge pull request #3622 from WoltLab/workflow-style
Tim Düsterhus [Wed, 21 Oct 2020 13:37:16 +0000 (15:37 +0200)]
Merge pull request #3622 from WoltLab/workflow-style

Add codestyle workflow

4 years agoAdd codestyle workflow
Tim Düsterhus [Wed, 21 Oct 2020 13:03:35 +0000 (15:03 +0200)]
Add codestyle workflow

4 years agoAdd .phpcs.xml
Tim Düsterhus [Wed, 21 Oct 2020 13:18:26 +0000 (15:18 +0200)]
Add .phpcs.xml

4 years agoMerge pull request #3617 from WoltLab/formbuilder-php8
Tim Düsterhus [Wed, 21 Oct 2020 13:13:28 +0000 (15:13 +0200)]
Merge pull request #3617 from WoltLab/formbuilder-php8

Fix PHP 8 support in form builder

4 years agoUse stock OpeningFunctionBraceKernighanRitchie sniff
Tim Düsterhus [Wed, 21 Oct 2020 13:00:21 +0000 (15:00 +0200)]
Use stock OpeningFunctionBraceKernighanRitchie sniff

4 years agoUpdate CodeSniffer ruleset
Tim Düsterhus [Wed, 21 Oct 2020 12:50:06 +0000 (14:50 +0200)]
Update CodeSniffer ruleset

4 years agoMerge branch '5.3' into master
Tim Düsterhus [Wed, 21 Oct 2020 12:47:07 +0000 (14:47 +0200)]
Merge branch '5.3' into master

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Wed, 21 Oct 2020 12:46:52 +0000 (14:46 +0200)]
Merge branch '5.2' into 5.3

4 years agoTighten up the code style a bit
Tim Düsterhus [Wed, 21 Oct 2020 12:46:13 +0000 (14:46 +0200)]
Tighten up the code style a bit

4 years agoMerge pull request #3621 from WoltLab/workflow-templates
Tim Düsterhus [Wed, 21 Oct 2020 11:09:13 +0000 (13:09 +0200)]
Merge pull request #3621 from WoltLab/workflow-templates

Add templates workflow

4 years agoAdd templates workflow
Tim Düsterhus [Wed, 21 Oct 2020 10:38:43 +0000 (12:38 +0200)]
Add templates workflow

4 years agoMerge pull request #3619 from WoltLab/54-minimum-requirements
Tim Düsterhus [Wed, 21 Oct 2020 10:39:29 +0000 (12:39 +0200)]
Merge pull request #3619 from WoltLab/54-minimum-requirements

Update minimum requirements

4 years agoDeprecated string offset in Net_IDNA2 (PHP 7.4)
Alexander Ebert [Mon, 27 Jan 2020 15:32:16 +0000 (16:32 +0100)]
Deprecated string offset in Net_IDNA2 (PHP 7.4)

(cherry picked from commit f1d17510cf7d5aa224ad10936ba4529990de127e)

4 years agoUpdate to Guzzle 7.2
Tim Düsterhus [Tue, 20 Oct 2020 15:08:21 +0000 (17:08 +0200)]
Update to Guzzle 7.2

4 years agoUpdate composer dependencies with updated platform
Tim Düsterhus [Tue, 20 Oct 2020 15:06:34 +0000 (17:06 +0200)]
Update composer dependencies with updated platform

4 years agoIncrease minimum MySQL 8 version to 8.0.19
Tim Düsterhus [Tue, 20 Oct 2020 14:56:55 +0000 (16:56 +0200)]
Increase minimum MySQL 8 version to 8.0.19

Limited by: Nothing really. Ubuntu Focal ships with 8.0.21 which was released
in July 2020. While there should be no good reason to not apply these bugfix
upgrades we'll give a bit of leeway and select 8.0.19 which is from January
2020 and thus one year younger than the previous 8.0.14 which is from January
2019.

4 years agoIncrease minimum MySQL 5 version to 5.7.31
Tim Düsterhus [Tue, 20 Oct 2020 14:52:52 +0000 (16:52 +0200)]
Increase minimum MySQL 5 version to 5.7.31

Limited by: Ubuntu Bionic which has 5.7.31-0ubuntu0.18.04.1.

4 years agoIncrease minimum MariaDB version to 10.1.44
Tim Düsterhus [Tue, 20 Oct 2020 14:50:44 +0000 (16:50 +0200)]
Increase minimum MariaDB version to 10.1.44

Limited by: Ubuntu Bionic which has 1:10.1.44-0ubuntu0.18.04.1.

4 years agoIncrease minimum PHP version to 7.2.24
Tim Düsterhus [Tue, 20 Oct 2020 14:46:31 +0000 (16:46 +0200)]
Increase minimum PHP version to 7.2.24

Limited by: Ubuntu Bionic which has 7.2.24-0ubuntu0.18.04.7.

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Wed, 21 Oct 2020 10:08:22 +0000 (12:08 +0200)]
Merge branch '5.2' into 5.3

4 years agoMerge pull request #3620 from WoltLab/php-syntax-action
Tim Düsterhus [Wed, 21 Oct 2020 10:07:35 +0000 (12:07 +0200)]
Merge pull request #3620 from WoltLab/php-syntax-action

Add php-syntax workflow

4 years agoPin the setup-php action to v2 instead of 2.7.0
Tim Düsterhus [Wed, 21 Oct 2020 08:40:18 +0000 (10:40 +0200)]
Pin the setup-php action to v2 instead of 2.7.0

4 years agoIgnore errors in HTMLPurifier*.autoload-legacy.php
Tim Düsterhus [Wed, 21 Oct 2020 08:35:20 +0000 (10:35 +0200)]
Ignore errors in HTMLPurifier*.autoload-legacy.php

4 years agoFix PHP 8 syntax in DirectoryUtil
Tim Düsterhus [Wed, 21 Oct 2020 08:33:38 +0000 (10:33 +0200)]
Fix PHP 8 syntax in DirectoryUtil

4 years agoRemove PHP syntax check from Travis CI
Tim Düsterhus [Wed, 21 Oct 2020 08:31:58 +0000 (10:31 +0200)]
Remove PHP syntax check from Travis CI

4 years agoSuppress "No Syntax errors detected" output
Tim Düsterhus [Wed, 21 Oct 2020 08:09:44 +0000 (10:09 +0200)]
Suppress "No Syntax errors detected" output

4 years agoAdd php-syntax problem matcher
Tim Düsterhus [Wed, 21 Oct 2020 07:46:50 +0000 (09:46 +0200)]
Add php-syntax problem matcher

4 years agoAdd php-syntax Workflow
Tim Düsterhus [Wed, 21 Oct 2020 07:38:08 +0000 (09:38 +0200)]
Add php-syntax Workflow

4 years agoDisabled the sticky code box header inside dialogs
Alexander Ebert [Tue, 20 Oct 2020 15:11:40 +0000 (17:11 +0200)]
Disabled the sticky code box header inside dialogs

4 years agoSlightly reduced the horizontal padding of `<kbd>` on smaller screens
Alexander Ebert [Tue, 20 Oct 2020 14:45:21 +0000 (16:45 +0200)]
Slightly reduced the horizontal padding of `<kbd>` on smaller screens

4 years agoMerge pull request #3614 from WoltLab/invalidateMailForm-error
Tim Düsterhus [Tue, 20 Oct 2020 12:08:43 +0000 (14:08 +0200)]
Merge pull request #3614 from WoltLab/invalidateMailForm-error

Do not ignore errors in invalidateMailForm update script

4 years agoFix PHP 8 support in form builder
Tim Düsterhus [Tue, 20 Oct 2020 10:02:22 +0000 (12:02 +0200)]
Fix PHP 8 support in form builder

> Message: Method ReflectionParameter::getClass() is deprecated

Fixes #3489

4 years agoHandle http://ns.adobe.com/xmp/extension/ in ExifUtil
Tim Düsterhus [Tue, 20 Oct 2020 08:56:33 +0000 (10:56 +0200)]
Handle ns.adobe.com/xmp/extension/ in ExifUtil

Resolves #3616

4 years agoMerge branch '5.2'
Alexander Ebert [Mon, 19 Oct 2020 13:59:12 +0000 (15:59 +0200)]
Merge branch '5.2'

4 years agoRevert "Fix deprecation warnings in form builder in PHP 8"
Alexander Ebert [Mon, 19 Oct 2020 13:58:54 +0000 (15:58 +0200)]
Revert "Fix deprecation warnings in form builder in PHP 8"

This reverts commit 624e3dd0b234c4bab3e537173421045c7c82590c.

4 years agoFix endless loop in removeExifData when the APP1 signature does not match
Tim Düsterhus [Mon, 19 Oct 2020 13:32:05 +0000 (15:32 +0200)]
Fix endless loop in removeExifData when the APP1 signature does not match

4 years agoDo not ignore errors in invalidateMailForm update script
Tim Düsterhus [Mon, 19 Oct 2020 13:09:06 +0000 (15:09 +0200)]
Do not ignore errors in invalidateMailForm update script

Fixes #3613

4 years agoMerge branch '5.2' into master
Tim Düsterhus [Mon, 19 Oct 2020 11:37:12 +0000 (13:37 +0200)]
Merge branch '5.2' into master

4 years agoIgnore symlink creation failures in DebugFolderEmailTransport
Tim Düsterhus [Mon, 19 Oct 2020 11:36:07 +0000 (13:36 +0200)]
Ignore symlink creation failures in DebugFolderEmailTransport

4 years agoRelease 5.3.0 RC 2 5.3.0_RC_2
Alexander Ebert [Sat, 17 Oct 2020 22:47:03 +0000 (00:47 +0200)]
Release 5.3.0 RC 2

4 years agoMerge branch '5.2'
Matthias Schmidt [Sat, 17 Oct 2020 14:37:15 +0000 (16:37 +0200)]
Merge branch '5.2'

4 years agoFix updating action of foreign key
Matthias Schmidt [Sat, 17 Oct 2020 14:36:53 +0000 (16:36 +0200)]
Fix updating action of foreign key

Close #3610

4 years agoUpdating minified JavaScript files
root [Sat, 17 Oct 2020 12:35:39 +0000 (12:35 +0000)]
Updating minified JavaScript files

4 years agoUse the overhauled notification settings in the admin panel
Alexander Ebert [Sat, 17 Oct 2020 12:04:48 +0000 (14:04 +0200)]
Use the overhauled notification settings in the admin panel

4 years agoUse \hash_equals in CryptoUtil::validateSignedString()
Tim Düsterhus [Wed, 14 Oct 2020 09:24:23 +0000 (11:24 +0200)]
Use \hash_equals in CryptoUtil::validateSignedString()

4 years agoMerge pull request #3607 from WoltLab/import-user-group-option-value
Tim Düsterhus [Thu, 15 Oct 2020 10:53:30 +0000 (12:53 +0200)]
Merge pull request #3607 from WoltLab/import-user-group-option-value

Create user group option values during group import

4 years agoMerge branch '5.2' into master
Tim Düsterhus [Thu, 15 Oct 2020 09:31:36 +0000 (11:31 +0200)]
Merge branch '5.2' into master

4 years agoFixed parameter validation of 'captionEnableHtml'
Marcel Werk [Thu, 15 Oct 2020 09:10:50 +0000 (11:10 +0200)]
Fixed parameter validation of 'captionEnableHtml'

4 years agoFix handling of default headers in HttpFactory::makeClient()
Tim Düsterhus [Thu, 15 Oct 2020 08:56:44 +0000 (10:56 +0200)]
Fix handling of default headers in HttpFactory::makeClient()

If a `headers` array is given the default user agent would not be applied, even
if the `user-agent` key is not part of the `headers` that are given. This
caused Guzzle to use its default user agent.

4 years agoCreate user group option values during group import
Tim Düsterhus [Thu, 15 Oct 2020 08:34:56 +0000 (10:34 +0200)]
Create user group option values during group import

Resolves #3534

4 years agoLog NamedUserException to the console when running in debug mode
Alexander Ebert [Wed, 14 Oct 2020 16:47:16 +0000 (18:47 +0200)]
Log NamedUserException to the console when running in debug mode

Closes #3541

4 years agoMerge pull request #3605 from WoltLab/recommend-curl
Tim Düsterhus [Wed, 14 Oct 2020 12:26:09 +0000 (14:26 +0200)]
Merge pull request #3605 from WoltLab/recommend-curl

Recommend cURL during WCFSetup

4 years agoRecommend cURL during WCFSetup
Tim Düsterhus [Wed, 14 Oct 2020 11:41:38 +0000 (13:41 +0200)]
Recommend cURL during WCFSetup

Resolves #3601

4 years agoMerge pull request #3604 from ChristopherWalz/master
Marcel Werk [Wed, 14 Oct 2020 10:25:55 +0000 (12:25 +0200)]
Merge pull request #3604 from ChristopherWalz/master

Add DatabaseObjectList::setConditionBuilder

4 years agoAdd DatabaseObjectList::setConditionBuilder
Christopher Walz [Wed, 14 Oct 2020 10:16:53 +0000 (12:16 +0200)]
Add DatabaseObjectList::setConditionBuilder

4 years agoMerge branch '5.2'
Marcel Werk [Wed, 14 Oct 2020 09:06:37 +0000 (11:06 +0200)]
Merge branch '5.2'

4 years agoAdded link to new manual
Marcel Werk [Wed, 14 Oct 2020 09:06:14 +0000 (11:06 +0200)]
Added link to new manual

4 years agoMerge branch '5.2'
Alexander Ebert [Tue, 13 Oct 2020 16:03:47 +0000 (18:03 +0200)]
Merge branch '5.2'

4 years agoSuppress the edit button for boxes on touch devices
Alexander Ebert [Tue, 13 Oct 2020 16:03:33 +0000 (18:03 +0200)]
Suppress the edit button for boxes on touch devices

The first tap on the box will trigger the hover, preventing any other elements, such as links, from responding.

4 years agoPrevent the official servers from being disabled
Alexander Ebert [Tue, 13 Oct 2020 14:10:10 +0000 (16:10 +0200)]
Prevent the official servers from being disabled

4 years agoPrepared an update script for the missing database columns in 5.3.0 RC 1
Alexander Ebert [Tue, 13 Oct 2020 13:10:34 +0000 (15:10 +0200)]
Prepared an update script for the missing database columns in 5.3.0 RC 1

4 years agoUpdated the files for the pre upgrade deployment
Alexander Ebert [Tue, 13 Oct 2020 12:59:42 +0000 (14:59 +0200)]
Updated the files for the pre upgrade deployment

4 years agoMySQL 5.7 does not support the syntax for non-capturing groups
Alexander Ebert [Tue, 13 Oct 2020 11:26:48 +0000 (13:26 +0200)]
MySQL 5.7 does not support the syntax for non-capturing groups

4 years agoUse `display: inline-table` to mimic the previous behavior
Alexander Ebert [Tue, 13 Oct 2020 11:25:13 +0000 (13:25 +0200)]
Use `display: inline-table` to mimic the previous behavior

The commit 9b6a008c7c15ce8fb61e45f6e592421af9c3dc54 introduced `table` instead of `inline-block`.

4 years agoMerge pull request #3602 from WoltLab/53-update-style
Tim Düsterhus [Tue, 13 Oct 2020 11:03:35 +0000 (13:03 +0200)]
Merge pull request #3602 from WoltLab/53-update-style

Update defaultStyle after migrating styles

4 years agoMerge pull request #3603 from WoltLab/exception-parse-invalid-stack
Tim Düsterhus [Tue, 13 Oct 2020 10:45:23 +0000 (12:45 +0200)]
Merge pull request #3603 from WoltLab/exception-parse-invalid-stack

Convert exceptions during stack trace parsing to InvalidArgumentExcep…

4 years agoConvert exceptions during stack trace parsing to InvalidArgumentException
Tim Düsterhus [Tue, 13 Oct 2020 10:13:22 +0000 (12:13 +0200)]
Convert exceptions during stack trace parsing to InvalidArgumentException

4 years agoUpdate defaultStyle after migrating styles
Tim Düsterhus [Tue, 13 Oct 2020 09:58:01 +0000 (11:58 +0200)]
Update defaultStyle after migrating styles

It appears that importing the defaultStyle causes the style specific asset folder to be created, leading to issues with the style migration.

4 years agoMerge branch '5.2'
Matthias Schmidt [Mon, 12 Oct 2020 16:52:23 +0000 (18:52 +0200)]
Merge branch '5.2'

4 years agoFix add PIP entry via GUI if only delete element exists in XML file
Matthias Schmidt [Mon, 12 Oct 2020 16:51:54 +0000 (18:51 +0200)]
Fix add PIP entry via GUI if only delete element exists in XML file

Close #3599

4 years agoFix missing language item
Matthias Schmidt [Mon, 12 Oct 2020 16:37:11 +0000 (18:37 +0200)]
Fix missing language item

Close #3597

4 years agoMerge branch '5.2'
Alexander Ebert [Mon, 12 Oct 2020 16:10:59 +0000 (18:10 +0200)]
Merge branch '5.2'

4 years agoMerge pull request #3600 from WoltLab/exception-parse-alphanumeric-code
Alexander Ebert [Mon, 12 Oct 2020 16:10:32 +0000 (18:10 +0200)]
Merge pull request #3600 from WoltLab/exception-parse-alphanumeric-code

Support alphanumeric error code in ExceptionLogUtil::parseException()

4 years agoSupport alphanumeric error code in ExceptionLogUtil::parseException()
Tim Düsterhus [Mon, 12 Oct 2020 16:09:06 +0000 (18:09 +0200)]
Support alphanumeric error code in ExceptionLogUtil::parseException()

PDO error codes might contain letters.

4 years agoFix calling HTTPRequest::getReply() if the response is missing
Tim Düsterhus [Mon, 12 Oct 2020 11:38:32 +0000 (13:38 +0200)]
Fix calling HTTPRequest::getReply() if the response is missing

The only case where the response might be missing is if Guzzle fails to connect
to the remote server (ConnectException). Return default data that is consistent
with 5.2 in this case.

4 years agoMerge branch '5.2'
Alexander Ebert [Sun, 11 Oct 2020 11:42:16 +0000 (13:42 +0200)]
Merge branch '5.2'

4 years agoUse a literal string to avoid escaping
Alexander Ebert [Sun, 11 Oct 2020 11:42:03 +0000 (13:42 +0200)]
Use a literal string to avoid escaping

See #3595