Henry Ptasinski [Thu, 21 Oct 2010 18:04:12 +0000 (11:04 -0700)]
staging: brcm80211: Remove unnecessary header files.
These header files are no longer needed.
Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Henry Ptasinski [Thu, 21 Oct 2010 18:04:11 +0000 (11:04 -0700)]
staging: brcm80211: Remove unnecessary includes from bcmutils.c
Removed includ of bcmip.h and vlan.h, as they're no longer needed.
Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Henry Ptasinski [Thu, 21 Oct 2010 18:04:10 +0000 (11:04 -0700)]
staging: brcm80211: Removed unnecessary pktsetprio() function.
This function is completely unnecessary, as packet classification is done
higher up in the stack. As used, the function actually mis-classifies frames
in some cases since it overwrites the classification done by the stack.
Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 18:17:44 +0000 (11:17 -0700)]
Staging: brcm80211: remove typedefs.h
It's not needed anymore, so remove it and clean up the .h inclusion mess
a bit to get everything to build properly again.
Wow, this needs some unwinding...
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 17:50:21 +0000 (10:50 -0700)]
Staging: brcm80211: remove uintptr typedef usage
Use a unsigned long, that is the proper type for this type of thing on
Linux.
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 17:03:44 +0000 (10:03 -0700)]
Staging: hv: remove struct vmbus_channel_interface
Now that no one uses this structure, remove it, and channel_interface.c
(which is now empty) and the function, vmbus_get_interface() which is
not needed anymore either.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 17:00:19 +0000 (10:00 -0700)]
Staging: hv: remove Open from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:59:06 +0000 (09:59 -0700)]
Staging: hv: storvsc: call vmbus_open directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:58:42 +0000 (09:58 -0700)]
Staging: hv: netvsc: call vmbus_open directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:58:21 +0000 (09:58 -0700)]
Staging: hv: channel: export vmbus_open to modules
Drivers need to call this directly, so export it, like other
vmbus functions.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:54:42 +0000 (09:54 -0700)]
Staging: hv: remove Close from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:53:31 +0000 (09:53 -0700)]
Staging: hv: netvsc: call vmbus_close directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:53:11 +0000 (09:53 -0700)]
Staging: hv: storvsc: call vmbus_close directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:52:22 +0000 (09:52 -0700)]
Staging: hv: channel: export vmbus_close to modules
Drivers need to call this directly, so export it, like other
vmbus functions.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:48:39 +0000 (09:48 -0700)]
Staging: hv: remove SendPacket from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:43:56 +0000 (09:43 -0700)]
Staging: hv: storvsc: call vmbus_sendpacket directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:43:24 +0000 (09:43 -0700)]
Staging: hv: netvsc: call vmbus_sendpacket directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:34:43 +0000 (09:34 -0700)]
Staging: hv: remove SendPacketPageBuffer from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:32:46 +0000 (09:32 -0700)]
Staging: hv: netvsc: call vmbus_sendpacket_pagebuffer directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:29:54 +0000 (09:29 -0700)]
Staging: hv: channel: export vmbus_sendpacket_pagebuffer to modules
Drivers need to call this directly, so export it, like other
vmbus functions.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:28:30 +0000 (09:28 -0700)]
Staging: hv: remove SendPacketMultiPageBuffer from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:26:50 +0000 (09:26 -0700)]
Staging: hv: storvsc: call vmbus_sendpacket_multipagebuffer directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:23:59 +0000 (09:23 -0700)]
Staging: hv: channel: export vmbus_sendpacket_multipagebuffer to modules
Drivers need to call this directly, so export it, like other
vmbus functions.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:16:54 +0000 (09:16 -0700)]
Staging: hv: remove RecvPacket from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:15:14 +0000 (09:15 -0700)]
Staging: hv: storvsc: call vmbus_recvpacket directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:11:00 +0000 (09:11 -0700)]
Staging: hv: remove RecvPacketRaw from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:09:48 +0000 (09:09 -0700)]
Staging: hv: netvsc: call vmbus_receivepacket_raw directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:09:23 +0000 (09:09 -0700)]
Staging: hv: channel: export vmbus_receivepacket_raw to modules
Drivers need to call this directly, so export it, like other
vmbus functions.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 16:05:27 +0000 (09:05 -0700)]
Staging: hv: rename context to channel in struct hv_device
As it really is a channel, not a "context" name it so.
This also entailed making a few more functions typesafe as they were
sending a struct vmbus_channel pointer as a void pointer.
There are still a few more that need to be converted (the osd callbacks
are one), but this is good for now.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 15:55:36 +0000 (08:55 -0700)]
Staging: hv: make *context a real pointer in struct hv_device
This is really the struct vmbus_channel for the device, not a void
pointer, so use the real structure to ensure type safety everywhere.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 15:50:16 +0000 (08:50 -0700)]
Staging: hv: remove EstablishGpadl from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 15:48:19 +0000 (08:48 -0700)]
Staging: hv: netvsc: call vmbus_establish_gpadl directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 15:47:43 +0000 (08:47 -0700)]
Staging: hv: channel: export vmbus_establish_gpadl to modules
Drivers need to call this directly, so export it, like other
vmbus functions.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 15:42:55 +0000 (08:42 -0700)]
Staging: hv: remove TeardownGpadl from struct vmbus_channel_interface
No one calls it anymore, so remove it.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 15:40:55 +0000 (08:40 -0700)]
Staging: hv: netvsc: call vmbus_teardown_gpadl directly
Don't do the interface indirection, it's not needed at all.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 21 Oct 2010 15:39:59 +0000 (08:39 -0700)]
Staging: hv: channel: export vmbus_teardown_gpadl to modules
Drivers need to call this directly, so export it, like other vmbus
functions.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 20 Oct 2010 23:07:11 +0000 (16:07 -0700)]
Staging: hv: make get_channel_info static
This is done by moving it to the only .c file it is used in.
This also allowed us to delete the channel_interface.h file, as it's no
longer needed.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 20 Oct 2010 23:02:49 +0000 (16:02 -0700)]
Staging: hv: vmbus_drv: remove vmbus_child_device_get_info
Just make the call to get_channel_info() directly.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 20 Oct 2010 23:00:37 +0000 (16:00 -0700)]
Staging: hv: remove GetChannelInfo from struct vmbus_driver
It was only set to one value, so just make the call to
get_channel_info() directly.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 20 Oct 2010 22:57:19 +0000 (15:57 -0700)]
Staging: hv: remove GetInfo pointer from struct vmbus_channel_interface
It's only set by one thing, and never called.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 20 Oct 2010 22:55:36 +0000 (15:55 -0700)]
Staging: hv: remove VmbusGetChannelInfo
It's not needed, make the function pointer point to get_channel_info()
instead.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 20 Oct 2010 22:51:57 +0000 (15:51 -0700)]
Staging: hv: make alloc_channel static
It's only used in one file, and is a pretty generic name.
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Wed, 20 Oct 2010 15:47:44 +0000 (18:47 +0300)]
staging: batman-adv: remove useless addr_to_string()
Since all *printf() methods in the kernel understand '%pM' modifier the
conversion to the string is useless beforehand.
Additionally this patch decreases batman_if structure by 20 bytes.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sun, 17 Oct 2010 17:51:24 +0000 (10:51 -0700)]
staging: brcm80211: brcmfmac: add debugfs, display wi-fi statistics
Add debugfs to display wi-fi profile/statistics.
Initially some profile parameters such as dtim_period,
beacon_int will be seen at
/sys/kernel/debug/ieee80211/phy#/netdev:eth#.
This will provide users with current connection status.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sun, 17 Oct 2010 17:42:18 +0000 (10:42 -0700)]
staging: brcm80211: brcmfmac: add profile, beacon_int, dtim_period
Add profile, beacon_int & dtim_period.
This profile can be seen through debugfs.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sun, 17 Oct 2010 17:38:35 +0000 (10:38 -0700)]
staging: brcm80211: brcmfmac: enable passive, active scan selection
Enable passive, active scan selection.
Previously it did active scan and reported
probe response result regardless of active_scan
flag
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
nohee ko [Sun, 17 Oct 2010 17:33:19 +0000 (10:33 -0700)]
staging: brcm80211: brcmfmac: remove unnecessary cflags, WL_ISCAN_DISABLED & WL_ROAM_DISABLED
Remove unnecessary cflags, WL_ISCAN_DISABLED
and WL_ROAM_DISABLED. Iscan is ON and Roam by FW
is OFF by default.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gustavo Silva [Tue, 19 Oct 2010 05:40:42 +0000 (00:40 -0500)]
Staging: frontier: fix coding style issues in tranzport.c
This is a patch to the tranzport.c file that fixes up the following issue
WARNING: please, no space for starting a line x 23
Signed-off-by: Gustavo Silva <silvagustavo@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bob Beers [Sat, 16 Oct 2010 22:06:36 +0000 (18:06 -0400)]
Staging: cxt1e1: multiple definition of max_mtu fix
eliminate multiple definition of max_mtu by renaming
with cxt1e1_ prefix, similarly rename max_mru
Signed-off-by: Bob Beers <bbeers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vasiliy Kulikov [Sun, 17 Oct 2010 14:51:57 +0000 (18:51 +0400)]
staging: speakup: fix memory leak
speakup_init() didn't free first_console if speakup_kobj_init() fails.
Also propagate speakup_kobj_init()'s return code.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vasiliy Kulikov [Sun, 17 Oct 2010 14:51:53 +0000 (18:51 +0400)]
staging: speakup: fix leaks of sysfs groups
speakup_kobj_init() and speakup_kobj_exit() didn't remove
i18n_attr_group and main_attr_group sysfs groups.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Sat, 16 Oct 2010 20:37:27 +0000 (22:37 +0200)]
staging: ft1000: Remove FT1000_INFO typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Sat, 16 Oct 2010 20:37:26 +0000 (22:37 +0200)]
staging: ft1000: Remove dead code from ft1000_hw.c
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Sat, 16 Oct 2010 20:37:25 +0000 (22:37 +0200)]
staging: ft1000: Get rid of using typedef.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Sat, 16 Oct 2010 03:13:39 +0000 (22:13 -0500)]
staging: speakup: varhandlers.c style fixes
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Sat, 16 Oct 2010 03:13:38 +0000 (22:13 -0500)]
staging: speakup: thread.c style fixes
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Sat, 16 Oct 2010 03:13:37 +0000 (22:13 -0500)]
staging: speakup: synth.c style fixes
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Sat, 16 Oct 2010 03:13:36 +0000 (22:13 -0500)]
staging: speakup: serialio.c style fixes
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Sat, 16 Oct 2010 03:13:35 +0000 (22:13 -0500)]
staging: speakup: selection.c style fixes
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Sat, 16 Oct 2010 03:13:34 +0000 (22:13 -0500)]
staging: speakup: main.c style fixes
- fix issues reported by checkpatch.pl
- run code through Lindent
- move some prototypes to speakup.h
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
William Hubbs [Sat, 16 Oct 2010 03:13:33 +0000 (22:13 -0500)]
staging: speakup: i18n.c fix long lines
A help message had to be slightly reworded, but the meaning is the same.
Signed-off-by: William Hubbs <w.d.hubbs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Sat, 16 Oct 2010 10:11:12 +0000 (13:11 +0300)]
staging: wlags49_h2: remove useless DbgHwAddr() method
There is no needs to prepare string for MAC addresses beforehand, due to
kernel's *printf() have '%pM' format option.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andy Shevchenko [Sat, 16 Oct 2010 10:11:11 +0000 (13:11 +0300)]
staging: wlags49_h2: fix format of timeStamp debug output
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Lindner [Tue, 19 Oct 2010 09:59:15 +0000 (11:59 +0200)]
Staging: batman-adv: process OGMs bigger than MAX_AGGREGATION_BYTES
Reported-by: Sam Yeung <sam.cwyeung@gmail.com>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Lindner [Tue, 19 Oct 2010 09:59:14 +0000 (11:59 +0200)]
Staging: batman-adv: fix crash when new OGM is generated
If aggregation is not enabled the local translation table can grow
much bigger and expects to fill a full ethernet packet.
Reported-by: Sam Yeung <sam.cwyeung@gmail.com>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Lindner [Tue, 19 Oct 2010 09:59:13 +0000 (11:59 +0200)]
Staging: batman-adv: protect against ogm packet overflow by checking table length
Reported-by: Sam Yeung <sam.cwyeung@gmail.com>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Lindner [Tue, 19 Oct 2010 09:59:12 +0000 (11:59 +0200)]
Staging: batman-adv: document fragmentation sysfs API
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Linus Lüssing [Tue, 19 Oct 2010 09:59:11 +0000 (11:59 +0200)]
Staging: batman-adv: Fix resizing of broadcast seqno buffers on if deletion
Not only the entries of the deleted interface got erased, but also all
ones with a lower if_num. This commit fixes this issue by setting the
destination appropriately.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Sven Eckelmann [Tue, 19 Oct 2010 09:59:10 +0000 (11:59 +0200)]
Staging: batman-adv: Don't dereference unchecked incoming soft_iface
send_packet derefenced forw_packet->if_incoming and checked if
forw_packet->if_incoming is NULL.
This cannot happen, but still makes irritates when reading through the
functions.
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Sven Eckelmann [Tue, 19 Oct 2010 09:59:09 +0000 (11:59 +0200)]
Staging: batman-adv: Add hash recommendations to TODO
David Miller <davem@davemloft.net> recommended in
20100924.134334.
28812338.davem@davemloft.net that we must make the hash
abstraction helper more efficient and may remove it completely.
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Fri, 15 Oct 2010 19:10:44 +0000 (21:10 +0200)]
Staging: sst: more copy_to_user() changes
Vinod wanted the copy_to_user() calls in this format:
if (copy_to_user())
retval = -EFAULT;
instead of this:
retval = copy_to_user();
if (retval)
retval = -EFAULt;
I've done that for the whole intel_sst_app_interface.c file. In the
process I noticed a couple more places that returned -EBUSY or -EAGAIN
instead of -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Fri, 15 Oct 2010 20:36:48 +0000 (22:36 +0200)]
Staging: intel_sst: off by one bug
This should be >= instead of > or we go passed the end of the array.
Also the arrays are declared with size MAX_NUM_STREAMS. This is the
only place that uses MAX_NUM_STREAMS_MFLD. It seems like asking for
trouble to use two variables for the same information. I've changed
everything to use MAX_NUM_STREAMS.
This bug isn't really harmful. In the worst case, if you enabled
debugging then you would see a message.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Fri, 15 Oct 2010 03:44:07 +0000 (05:44 +0200)]
Staging: intel_sst: return -EFAULT if copy_to_user() fails
copy_to_user() returns the number of bytes remaining to be copied but we
want to return an error code. And that error code is -EFAULT not -EIO.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Haiyang Zhang [Fri, 15 Oct 2010 17:14:07 +0000 (10:14 -0700)]
staging: hv: Convert camel cased functions in channel_mgmt.c to lower case
Convert camel cased functions in channel_mgmt.c to lower case
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Haiyang Zhang [Fri, 15 Oct 2010 17:14:06 +0000 (10:14 -0700)]
staging: hv: Convert camel cased local variable names in channel_mgmt.c to lower case
Convert camel cased local variable names in channel_mgmt.c to lower case
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Haiyang Zhang [Fri, 15 Oct 2010 17:14:05 +0000 (10:14 -0700)]
staging: hv: Convert camel cased parameter in channel_interface.h to lower case
Convert camel cased parameter in channel_interface.h to lower case
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Haiyang Zhang [Fri, 15 Oct 2010 17:14:04 +0000 (10:14 -0700)]
staging: hv: Convert camel cased function names in channel_interface.c to lower cases
Convert camel cased function names in channel_interface.c to lower cases
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Haiyang Zhang [Fri, 15 Oct 2010 17:14:03 +0000 (10:14 -0700)]
staging: hv: Convert camel cased local variables in channel_interface.c to lower cases
Convert camel cased local variables in channel_interface.c to lower cases
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Fri, 15 Oct 2010 13:00:10 +0000 (15:00 +0200)]
staging: tidspbridge: Clean up error-handling code
In the first hunk, 0 is returned on memory allocation failure, even though
other failures return -ENOMEM or other similar values.
In the second hunk, there was error handling code that returned without
freeing psz_path_name.
A simplified version of the semantic match that finds the first problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression ret;
expression x,e1,e2,e3;
@@
ret = 0
... when != ret = e1
*x = \(kmalloc\|kcalloc\|kzalloc\)(...)
... when != ret = e2
if (x == NULL) { ... when != ret = e3
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 07:41:45 +0000 (09:41 +0200)]
staging: ft1000: Use specific error return code for reg_ft1000_netdev().
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 06:57:25 +0000 (08:57 +0200)]
staging: ft1000: Use specific return error codes.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 06:57:24 +0000 (08:57 +0200)]
staging: ft1000: Check return value when init net device.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 12:13:03 +0000 (14:13 +0200)]
staging: ft1000: Remove DRVMGS typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 12:13:02 +0000 (14:13 +0200)]
staging: ft1000: Remove PSEUDO_HDR typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 12:13:01 +0000 (14:13 +0200)]
staging: ft1000: Remove PROV_RECORD typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 12:13:00 +0000 (14:13 +0200)]
staging: ft1000: Remove APP_INFO_BLOCK typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 12:12:59 +0000 (14:12 +0200)]
staging: ft1000: Remove DSPINITMSG typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 12:12:58 +0000 (14:12 +0200)]
staging: ft1000: Remove MEDIAMSG typedef usage.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Fri, 15 Oct 2010 08:51:22 +0000 (10:51 +0200)]
staging: ft1000: Remove unused function ft1000_hbchk()
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Fri, 15 Oct 2010 03:44:58 +0000 (05:44 +0200)]
Staging: intel_sst: cleanup naming a little
&sst_drv_ctx->streams[str_id].lock and &stream->lock are the same.
The mutex_lock() uses &stream->lock so this makes things consistent and
it's nicer to read as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Fri, 15 Oct 2010 03:40:42 +0000 (05:40 +0200)]
Staging: ft1000-usb: use the correct list head
Using pdpram_blk here would cause an oops. We intended to use
&freercvpool.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Tested by: Marek Belisko <marek.belisko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Fri, 15 Oct 2010 03:42:35 +0000 (05:42 +0200)]
Staging: lirc: fix PTR_ERR() check
This is a typo. It's supposed to be IS_ERR() here instead of PTR_ERR().
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Fri, 15 Oct 2010 03:42:00 +0000 (05:42 +0200)]
Staging: ft1000-usb: fix array overflow
The code here is supposed checking if we exited the loop without hitting
a break. The problem is that in the error handling "i" is out of bounds
and it corrupts memory when we do an info->app_info[i].nRxMsgMiss++.
>From the comments, it looks like someone noticed this corruption and
updated the code, but didn't totally fix the problem. The correct fix
is just to remove nRxMsgMiss++ from the error path.
I believe this bug can be triggered remotely.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:24:00 +0000 (19:24 -0500)]
staging: speakup: speakup_dectlk.c: style fixes
* Clean this file based on reports from checkpatch.pl.
* Replace a function-like macro with an inline function.
* Remove an incorrect use of the volatile qualifier. The
previously-volatile variable is now always protected by a spinlock.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:23:59 +0000 (19:23 -0500)]
staging: speakup: speakup_txprt.c: style fixes
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:23:58 +0000 (19:23 -0500)]
staging: speakup: speakup_spkout.c: style fixes
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:23:57 +0000 (19:23 -0500)]
staging: speakup: speakup_soft.c: style fixes
* Clean this file based on reports from checkpatch.pl.
* Make the file_operations structure const.
* Use strict_strtoul instead of simple_strtoul.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:23:56 +0000 (19:23 -0500)]
staging: speakup: speakup_ltlk.c: style fixes
* Clean this file based on reports from checkpatch.pl.
* Remove an unused function-like macro.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:23:55 +0000 (19:23 -0500)]
staging: speakup: speakup_keypc.c: style fixes
* Clean this file based on reports from checkpatch.pl.
* Eliminate the unused synth_readable macro.
* Convert function-like macros to inline functions.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Christopher Brannon [Fri, 15 Oct 2010 00:23:54 +0000 (19:23 -0500)]
staging: speakup: speakup_dummy.c: style fixes
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>