GitHub/WoltLab/WCF.git
3 years agoPrevent the removal of the package servers for `5.3` to preserve the credentials
Alexander Ebert [Wed, 23 Dec 2020 17:12:16 +0000 (18:12 +0100)]
Prevent the removal of the package servers for `5.3` to preserve the credentials

3 years agoPreserve the package server credentials when upgrading from 5.2 -> 5.3
Alexander Ebert [Mon, 21 Dec 2020 16:41:54 +0000 (17:41 +0100)]
Preserve the package server credentials when upgrading from 5.2 -> 5.3

Fixes #3805

3 years agoUpdating minified JavaScript files
WoltLab [Mon, 21 Dec 2020 13:54:52 +0000 (13:54 +0000)]
Updating minified JavaScript files

3 years ago`const` trips the requirejs compiler
Alexander Ebert [Mon, 21 Dec 2020 13:53:34 +0000 (14:53 +0100)]
`const` trips the requirejs compiler

3 years agoprevented unnecessary duplicate generation of the option tree
Marcel Werk [Mon, 21 Dec 2020 10:29:55 +0000 (11:29 +0100)]
prevented unnecessary duplicate generation of the option tree

3 years agoFix copy and paste error in error output in styleAdd.tpl
Tim Düsterhus [Mon, 21 Dec 2020 10:13:36 +0000 (11:13 +0100)]
Fix copy and paste error in error output in styleAdd.tpl

3 years agoFix copy and paste error in image size validation in StyleAddForm
Tim Düsterhus [Mon, 21 Dec 2020 10:10:49 +0000 (11:10 +0100)]
Fix copy and paste error in image size validation in StyleAddForm

3 years agoUpdating minified JavaScript files
WoltLab [Sun, 20 Dec 2020 13:16:33 +0000 (13:16 +0000)]
Updating minified JavaScript files

3 years ago`const` trips the requirejs compiler
Alexander Ebert [Sun, 20 Dec 2020 13:15:12 +0000 (14:15 +0100)]
`const` trips the requirejs compiler

3 years agoUpdating minified JavaScript files
WoltLab [Sun, 20 Dec 2020 12:02:41 +0000 (12:02 +0000)]
Updating minified JavaScript files

3 years agoRequire label for `CheckboxFormField`
Matthias Schmidt [Sun, 20 Dec 2020 10:05:19 +0000 (11:05 +0100)]
Require label for `CheckboxFormField`

3 years agoImproved the scroll behavior on mobile devices
Alexander Ebert [Sat, 19 Dec 2020 22:55:32 +0000 (23:55 +0100)]
Improved the scroll behavior on mobile devices

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Fri, 18 Dec 2020 18:33:51 +0000 (19:33 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4
Matthias Schmidt [Fri, 18 Dec 2020 18:33:23 +0000 (19:33 +0100)]
Fix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4

See #3792

3 years agoFix missing variable error in DatabaseTableChangeProcessor
Matthias Schmidt [Fri, 18 Dec 2020 18:32:51 +0000 (19:32 +0100)]
Fix missing variable error in DatabaseTableChangeProcessor

See #3792

3 years agoFix updating action of foreign key
Matthias Schmidt [Fri, 18 Dec 2020 18:26:29 +0000 (19:26 +0100)]
Fix updating action of foreign key

See c64a33b40a7e601a6005f7ca247f7d2ecb52a393

3 years agoAdd CheckboxFormField (#3812)
Peter Lohse [Fri, 18 Dec 2020 18:17:12 +0000 (19:17 +0100)]
Add CheckboxFormField (#3812)

* added implementation of a checkbox form field for boolen values

* fixed indentation

* added __checkboxFormField to syncTemplates.json

* added missing comma

3 years agoRTL fix for code boxes
Marcel Werk [Fri, 18 Dec 2020 14:47:22 +0000 (15:47 +0100)]
RTL fix for code boxes

3 years agoMerge pull request #3818 from WoltLab/empty-style-preview
Tim Düsterhus [Fri, 18 Dec 2020 12:53:16 +0000 (13:53 +0100)]
Merge pull request #3818 from WoltLab/empty-style-preview

Fix style previews pointing to the style's asset folder

3 years agoFix style previews pointing to the style's asset folder
Tim Düsterhus [Fri, 18 Dec 2020 12:44:57 +0000 (13:44 +0100)]
Fix style previews pointing to the style's asset folder

update_com.woltlab.wcf_5.3.1_style.php created this situation when the style
did not have a preview image, due to a missing check for a non-empty `image` /
`image2x` property.

3 years agoMerge pull request #3817 from WoltLab/count-category-options
Marcel Werk [Fri, 18 Dec 2020 11:16:38 +0000 (12:16 +0100)]
Merge pull request #3817 from WoltLab/count-category-options

Improved detection of empty option categories

3 years agoRemoved obsolete parameter
Marcel Werk [Thu, 17 Dec 2020 18:20:09 +0000 (19:20 +0100)]
Removed obsolete parameter

3 years agoPermit the use of `is_null` in templates when running in the enterprise mode
Alexander Ebert [Thu, 17 Dec 2020 16:57:43 +0000 (17:57 +0100)]
Permit the use of `is_null` in templates when running in the enterprise mode

3 years agoImproved detection of empty option categories
Marcel Werk [Thu, 17 Dec 2020 15:20:13 +0000 (16:20 +0100)]
Improved detection of empty option categories

3 years agoFix typo in de.xml
Tim Düsterhus [Thu, 17 Dec 2020 08:14:29 +0000 (09:14 +0100)]
Fix typo in de.xml

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 15 Dec 2020 17:19:37 +0000 (18:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix hiding/showing tab menu entries due to form builder dependencies
Matthias Schmidt [Tue, 15 Dec 2020 17:19:21 +0000 (18:19 +0100)]
Fix hiding/showing tab menu entries due to form builder dependencies

3 years agoMerge pull request #3810 from WoltLab/user-group-option-limited-removal
Alexander Ebert [Tue, 15 Dec 2020 10:42:36 +0000 (11:42 +0100)]
Merge pull request #3810 from WoltLab/user-group-option-limited-removal

Prevent the unintentional removal of values for groups that are not being edited

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 14 Dec 2020 19:13:35 +0000 (20:13 +0100)]
Merge branch '5.2' into 5.3

3 years agoExcempt the admin panel from application overrides
Alexander Ebert [Mon, 14 Dec 2020 19:13:04 +0000 (20:13 +0100)]
Excempt the admin panel from application overrides

Fixes #3762

3 years agoPrevent the unintentional removal of values for groups that are not being edited
Alexander Ebert [Mon, 14 Dec 2020 17:44:41 +0000 (18:44 +0100)]
Prevent the unintentional removal of values for groups that are not being edited

3 years agoMerge pull request #3807 from WoltLab/imagick-quantize-images
Alexander Ebert [Mon, 14 Dec 2020 13:13:27 +0000 (14:13 +0100)]
Merge pull request #3807 from WoltLab/imagick-quantize-images

Greatly improve the performance of GIF processing with ImageMagick

3 years agoRemoved the legacy workaround for ancient ImageMagick versions
Alexander Ebert [Mon, 14 Dec 2020 12:43:18 +0000 (13:43 +0100)]
Removed the legacy workaround for ancient ImageMagick versions

3 years agoTypo
Alexander Ebert [Sun, 13 Dec 2020 19:05:13 +0000 (20:05 +0100)]
Typo

3 years agoPrevent the trophy content being squished together
Alexander Ebert [Sat, 12 Dec 2020 18:11:39 +0000 (19:11 +0100)]
Prevent the trophy content being squished together

3 years agoGreatly improve the performance of GIF processing with ImageMagick
Alexander Ebert [Sat, 12 Dec 2020 17:41:36 +0000 (18:41 +0100)]
Greatly improve the performance of GIF processing with ImageMagick

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sat, 12 Dec 2020 14:01:52 +0000 (15:01 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3799 from WoltLab/nonnull_in_primary_key
Matthias Schmidt [Sat, 12 Dec 2020 14:00:52 +0000 (15:00 +0100)]
Merge pull request #3799 from WoltLab/nonnull_in_primary_key

Validate primary indices with null columns in PHP DB API

3 years agoReload styleEditor after updating image path
joshuaruesweg [Fri, 11 Dec 2020 10:48:22 +0000 (11:48 +0100)]
Reload styleEditor after updating image path
Because the style is compiled after the variables have been set, we have to reload the style object once with the correct `imagePath` so that it can be used correctly in the initial compilation.

3 years agoRemove obsolete PACKAGE_ID check in ImportCLICommand
Tim Düsterhus [Thu, 10 Dec 2020 13:21:03 +0000 (14:21 +0100)]
Remove obsolete PACKAGE_ID check in ImportCLICommand

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 9 Dec 2020 17:43:05 +0000 (18:43 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix doubled validation errors for CaptchaFormField
Matthias Schmidt [Wed, 9 Dec 2020 17:42:41 +0000 (18:42 +0100)]
Fix doubled validation errors for CaptchaFormField

3 years agoValidate primary indices with null columns in PHP DB API
Matthias Schmidt [Wed, 9 Dec 2020 16:13:59 +0000 (17:13 +0100)]
Validate primary indices with null columns in PHP DB API

Close #3792

3 years agoRestored the user online location for profiles
Alexander Ebert [Wed, 9 Dec 2020 00:23:31 +0000 (01:23 +0100)]
Restored the user online location for profiles

There has been a change in 5.3 that introduced the `$userOnline` value, however this is the target user itself and not the user's content they are viewing. The `$user` variable is useless, because it is a plain `User` object that is not compatible with `{$user}`.

3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:56:41 +0000 (13:56 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:54:49 +0000 (13:54 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 7 Dec 2020 20:00:31 +0000 (21:00 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 7 Dec 2020 20:00:11 +0000 (21:00 +0100)]
Merge branch '3.1' into 5.2

3 years agoForce the use of the attachment thumbnail if the original is inaccessible
Alexander Ebert [Mon, 7 Dec 2020 19:58:02 +0000 (20:58 +0100)]
Force the use of the attachment thumbnail if the original is inaccessible

3 years agoWorkaround for the misaligned caret in Safari caused by 0x200B
Alexander Ebert [Mon, 7 Dec 2020 19:02:58 +0000 (20:02 +0100)]
Workaround for the misaligned caret in Safari caused by 0x200B

3 years agoImproved the iOS WebKit click detection inside the editor margin
Alexander Ebert [Mon, 7 Dec 2020 17:16:08 +0000 (18:16 +0100)]
Improved the iOS WebKit click detection inside the editor margin

3 years agoForce a whitespace before and after inserted smileys
Alexander Ebert [Mon, 7 Dec 2020 16:27:54 +0000 (17:27 +0100)]
Force a whitespace before and after inserted smileys

3 years agoMerge pull request #3793 from WoltLab/style-import-permissions
Tim Düsterhus [Mon, 7 Dec 2020 15:52:12 +0000 (16:52 +0100)]
Merge pull request #3793 from WoltLab/style-import-permissions

Validate package installation permissions in StyleImportForm

3 years agoValidate package installation permissions in StyleImportForm
Tim Düsterhus [Mon, 7 Dec 2020 14:56:53 +0000 (15:56 +0100)]
Validate package installation permissions in StyleImportForm

3 years agoMerge pull request #3786 from WoltLab/like-rebuild
Joshua Rüsweg [Mon, 7 Dec 2020 12:59:44 +0000 (13:59 +0100)]
Merge pull request #3786 from WoltLab/like-rebuild

Optimize LikeRebuildDataWorker performance

3 years agoOnly close the user panel drop-downs if no key modifier was pressed
Alexander Ebert [Sun, 6 Dec 2020 21:48:54 +0000 (22:48 +0100)]
Only close the user panel drop-downs if no key modifier was pressed

3 years agoDiscard the current selection when saving a quote
Alexander Ebert [Sun, 6 Dec 2020 20:16:16 +0000 (21:16 +0100)]
Discard the current selection when saving a quote

3 years agoPrevent the tooltip being selectable while the user changes the selection
Alexander Ebert [Sun, 6 Dec 2020 20:10:59 +0000 (21:10 +0100)]
Prevent the tooltip being selectable while the user changes the selection

3 years agoUnified behavior of the notification list and the corresponding menu drop-down
Alexander Ebert [Sun, 6 Dec 2020 19:35:08 +0000 (20:35 +0100)]
Unified behavior of the notification list and the corresponding menu drop-down

3 years agoConsistent width of menus in the mobile menu
Alexander Ebert [Sun, 6 Dec 2020 19:19:58 +0000 (20:19 +0100)]
Consistent width of menus in the mobile menu

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 6 Dec 2020 14:09:45 +0000 (15:09 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix dependencies for single media form field
Matthias Schmidt [Sun, 6 Dec 2020 14:09:17 +0000 (15:09 +0100)]
Fix dependencies for single media form field

3 years agoAdd missing space after comma in ReactionHandler::renderInlineList()
Tim Düsterhus [Sat, 5 Dec 2020 18:08:14 +0000 (19:08 +0100)]
Add missing space after comma in ReactionHandler::renderInlineList()

3 years agoSimplify selection of existing like objects in LikeRebuildDataWorker
Tim Düsterhus [Fri, 4 Dec 2020 14:59:43 +0000 (15:59 +0100)]
Simplify selection of existing like objects in LikeRebuildDataWorker

Since the previous commit it is expected that only a single objectTypeID is hit
per worker execution in the usual case, because all objects for a single
objectTypeID are processed before proceeding to the next objectTypeID. This
patch optimizes this case by sending a separate query per objectTypeID to fetch
the existing like objects instead of combining all the objects in a single
query.

This should help MySQL in optimizing the query, because the objectTypeID (which
is the first column in the UNIQUE KEY on wcf1_like_object) is fixed for a
single query and this is immediately obvious without needing to scan all the
tuples passed to the IN(…) condition.

In the general case the number of queries does not change. In the iterations
where the last objectID for an objectTypeID is reached two queries will be sent
instead of a single one. Those two combined should be more efficient that the
single old query, though.

3 years agoAllow LikeRebuildDataWorker to leverage the wcf1_like.objectTypeID key for sorting
Tim Düsterhus [Fri, 4 Dec 2020 14:52:10 +0000 (15:52 +0100)]
Allow LikeRebuildDataWorker to leverage the wcf1_like.objectTypeID key for sorting

3 years agoMerge branch '5.2'
joshuaruesweg [Fri, 4 Dec 2020 10:35:16 +0000 (11:35 +0100)]
Merge branch '5.2'

3 years agoIgnore invalid file ids during deleting uploaded files
joshuaruesweg [Fri, 4 Dec 2020 10:33:53 +0000 (11:33 +0100)]
Ignore invalid file ids during deleting uploaded files
There can be several reasons why the files are no longer known. We can ignore this and simply return a success message so that it doesn't pop up in the frontend when unknown files are deleted.

3 years agoFix detecting images with capitalised file extensions
joshuaruesweg [Fri, 4 Dec 2020 10:23:53 +0000 (11:23 +0100)]
Fix detecting images with capitalised file extensions

3 years agoOnly rebuild favicons if there is a new image uploaded
joshuaruesweg [Fri, 4 Dec 2020 10:05:10 +0000 (11:05 +0100)]
Only rebuild favicons if there is a new image uploaded

3 years agoFix updating pageLogo in StyleAction
joshuaruesweg [Fri, 4 Dec 2020 09:09:32 +0000 (10:09 +0100)]
Fix updating pageLogo in StyleAction

3 years agoImproved wrapping of reaction filter buttons on mobile
Marcel Werk [Wed, 2 Dec 2020 15:38:11 +0000 (16:38 +0100)]
Improved wrapping of reaction filter buttons on mobile

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Tue, 1 Dec 2020 12:35:47 +0000 (13:35 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Tue, 1 Dec 2020 12:34:59 +0000 (13:34 +0100)]
Merge branch '3.1' into 5.2

3 years agoIncorrect version comparison for accessible packages
Alexander Ebert [Tue, 1 Dec 2020 12:32:47 +0000 (13:32 +0100)]
Incorrect version comparison for accessible packages

3 years agoPrevent rewriting filenames for processed files
joshuaruesweg [Tue, 1 Dec 2020 10:58:14 +0000 (11:58 +0100)]
Prevent rewriting filenames for processed files

3 years agoFix copy and paste error in en.xml
Tim Düsterhus [Fri, 27 Nov 2020 08:40:14 +0000 (09:40 +0100)]
Fix copy and paste error in en.xml

see 9e2ccd976daa8646b2b86f4d27e52d3f226ff94e

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 26 Nov 2020 12:51:25 +0000 (13:51 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3763 from WoltLab/http-request-timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:33:41 +0000 (12:33 +0100)]
Merge pull request #3763 from WoltLab/http-request-timeout

HTTP request timeouts

3 years agoSet an explicit timeout for ImageProxyAction's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:29:23 +0000 (12:29 +0100)]
Set an explicit timeout for ImageProxyAction's HttpClient

3 years agoSet an explicit timeout for FontManager's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:28:03 +0000 (12:28 +0100)]
Set an explicit timeout for FontManager's HttpClient

3 years agoReplace HTTPRequest's timeout by connect_timeout + read_timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:26:00 +0000 (12:26 +0100)]
Replace HTTPRequest's timeout by connect_timeout + read_timeout

The timeout in 5.2 only applied to the connect() syscall. Guzzle's timeout
option applies to the total transfer. Replace it by connect_timeout +
read_timeout for backwards compatibility for code that expected the actual
transfer to take an arbitrary amount of time.

3 years agoFix typo in de.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:34:03 +0000 (09:34 +0100)]
Fix typo in de.xml

3 years agoUpdate the orphanedComments remark in package.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:18:46 +0000 (09:18 +0100)]
Update the orphanedComments remark in package.xml

3 years agoFix typo in informal German phrases
Jannis Grimm [Wed, 25 Nov 2020 03:04:31 +0000 (04:04 +0100)]
Fix typo in informal German phrases

Verweide -> Vermeide

Closes #3752

[Tim: rephrased the commit message]

3 years agoImproved randomized sort order of related articles
Marcel Werk [Tue, 24 Nov 2020 17:44:34 +0000 (18:44 +0100)]
Improved randomized sort order of related articles

3 years agoRelease 5.3.1 5.3.1
Alexander Ebert [Mon, 23 Nov 2020 15:38:18 +0000 (16:38 +0100)]
Release 5.3.1

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 15:34:03 +0000 (16:34 +0100)]
Merge branch '5.2' into 5.3

3 years agoMissing check for empty object ids 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 15:11:56 +0000 (16:11 +0100)]
Missing check for empty object ids

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 14:55:09 +0000 (15:55 +0100)]
Merge branch '5.2' into 5.3

3 years agorandomized sort order of related articles
Marcel Werk [Mon, 23 Nov 2020 14:19:48 +0000 (15:19 +0100)]
randomized sort order of related articles

3 years agoChanged related articles to new layout
Marcel Werk [Mon, 23 Nov 2020 14:19:02 +0000 (15:19 +0100)]
Changed related articles to new layout

3 years agoRelease 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 13:43:06 +0000 (14:43 +0100)]
Release 5.2.10

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 23 Nov 2020 13:36:42 +0000 (14:36 +0100)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.18 3.1.18
Alexander Ebert [Mon, 23 Nov 2020 13:29:11 +0000 (14:29 +0100)]
Release 3.1.18

3 years agoUse modified package servers when running in enterprise mode
Alexander Ebert [Mon, 23 Nov 2020 11:30:45 +0000 (12:30 +0100)]
Use modified package servers when running in enterprise mode

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 23 Nov 2020 08:31:54 +0000 (09:31 +0100)]
Merge branch '5.2' into 5.3

3 years agoWhitelist `iterator_count` in enterprise mode
Tim Düsterhus [Mon, 23 Nov 2020 08:27:54 +0000 (09:27 +0100)]
Whitelist `iterator_count` in enterprise mode

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Sun, 22 Nov 2020 17:36:43 +0000 (18:36 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sun, 22 Nov 2020 17:31:49 +0000 (18:31 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #3744 from Krymonota/patch-18
Alexander Ebert [Sun, 22 Nov 2020 16:58:44 +0000 (17:58 +0100)]
Merge pull request #3744 from Krymonota/patch-18

Add missing JSDoc to `EmailSmtpTest`