From: Robin Dong <sanbai@taobao.com>
Date: Mon, 11 Jul 2011 15:43:59 +0000 (-0400)
Subject: ext4: remove redundant goto in ext4_ext_insert_extent()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ffb505ff0f7b52318dea46dd139107a8371b4ad7;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git

ext4: remove redundant goto in ext4_ext_insert_extent()

If eh->eh_entries is smaller than eh->eh_max, the routine will
go to the "repeat" and then go to "has_space" directlly ,
since argument "depth" and "eh" are not even changed.

Therefore, goto "has_space" directly and remove redundant "repeat" tag.

Signed-off-by: Robin Dong <sanbai@taobao.com>
---

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index c969ae23a535..9cbdcb2110f5 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1723,7 +1723,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
 		goto merge;
 	}
 
-repeat:
 	depth = ext_depth(inode);
 	eh = path[depth].p_hdr;
 	if (le16_to_cpu(eh->eh_entries) < le16_to_cpu(eh->eh_max))
@@ -1745,7 +1744,7 @@ repeat:
 			ext_debug("next leaf isn't full(%d)\n",
 				  le16_to_cpu(eh->eh_entries));
 			path = npath;
-			goto repeat;
+			goto has_space;
 		}
 		ext_debug("next leaf has no free space(%d,%d)\n",
 			  le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max));