From: Colin Ian King Date: Thu, 13 Apr 2017 14:13:46 +0000 (+0100) Subject: staging: rtl8723bs: remove redundant comparisons of unsigned ints with >= 0 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ff8d351d71f3261c964ce90d43ce6907e79e5fc4;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git staging: rtl8723bs: remove redundant comparisons of unsigned ints with >= 0 The comparison of mode >= 0 is redundant as mode is a u32 and this is always true. Remove this redundant code. Detected with CoverityScan ("Unsigned compared against 0") Signed-off-by: Colin Ian King Reviewed-by: Hans de Goede Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c index 51cef55d3f76..fc6b94d59c37 100644 --- a/drivers/staging/rtl8723bs/core/rtw_debug.c +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c @@ -1031,7 +1031,7 @@ ssize_t proc_set_ht_enable(struct file *file, const char __user *buffer, size_t if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { sscanf(tmp, "%d ", &mode); - if (pregpriv && mode >= 0 && mode < 2) { + if (pregpriv && mode < 2) { pregpriv->ht_enable = mode; printk("ht_enable =%d\n", pregpriv->ht_enable); } @@ -1150,7 +1150,7 @@ ssize_t proc_set_rx_ampdu(struct file *file, const char __user *buffer, size_t c sscanf(tmp, "%d ", &mode); - if (pregpriv && mode >= 0 && mode < 2) { + if (pregpriv && mode < 2) { pmlmeinfo->bAcceptAddbaReq = mode; DBG_871X("pmlmeinfo->bAcceptAddbaReq =%d\n", pmlmeinfo->bAcceptAddbaReq); if (mode == 0) { @@ -1191,7 +1191,7 @@ ssize_t proc_set_en_fwps(struct file *file, const char __user *buffer, size_t co if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { sscanf(tmp, "%d ", &mode); - if (pregpriv && mode >= 0 && mode < 2) { + if (pregpriv && mode < 2) { pregpriv->check_fw_ps = mode; DBG_871X("pregpriv->check_fw_ps =%d\n", pregpriv->check_fw_ps); }