From: Marcel Werk <burntime@woltlab.com>
Date: Sun, 7 Oct 2018 17:22:45 +0000 (+0200)
Subject: Improved a11y of the share buttons
X-Git-Tag: 5.2.0_Alpha_1~364^2~12
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ff703de324083caf54e6b4563404be0cdc4018fd;p=GitHub%2FWoltLab%2FWCF.git

Improved a11y of the share buttons

See #2713
---

diff --git a/com.woltlab.wcf/templates/shareButtons.tpl b/com.woltlab.wcf/templates/shareButtons.tpl
index 6bf80c9aaf..cdd793af0f 100644
--- a/com.woltlab.wcf/templates/shareButtons.tpl
+++ b/com.woltlab.wcf/templates/shareButtons.tpl
@@ -4,7 +4,7 @@
 	<ul class="inlineList">
 		{if 'Facebook'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsShareFacebook" title="{lang}wcf.message.share.facebook{/lang}">
+				<a href="#" class="button jsShareFacebook" title="{lang}wcf.message.share.facebook{/lang}">
 					<span class="icon icon24 fa-facebook-official"></span>
 					<span>{lang}wcf.message.share.facebook{/lang}</span>
 				</a>
@@ -12,7 +12,7 @@
 		{/if}
 		{if 'Twitter'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsShareTwitter" title="{lang}wcf.message.share.twitter{/lang}">
+				<a href="#" class="button jsShareTwitter" title="{lang}wcf.message.share.twitter{/lang}">
 					<span class="icon icon24 fa-twitter"></span>
 					<span>{lang}wcf.message.share.twitter{/lang}</span>
 				</a>
@@ -20,7 +20,7 @@
 		{/if}
 		{if 'Google'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsShareGoogle" title="{lang}wcf.message.share.google{/lang}">
+				<a href="#" class="button jsShareGoogle" title="{lang}wcf.message.share.google{/lang}">
 					<span class="icon icon24 fa-google-plus-official"></span>
 					<span>{lang}wcf.message.share.google{/lang}</span>
 				</a>
@@ -28,7 +28,7 @@
 		{/if}
 		{if 'Reddit'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsShareReddit" title="{lang}wcf.message.share.reddit{/lang}">
+				<a href="#" class="button jsShareReddit" title="{lang}wcf.message.share.reddit{/lang}">
 					<span class="icon icon24 fa-reddit"></span>
 					<span>{lang}wcf.message.share.reddit{/lang}</span>
 				</a>
@@ -36,7 +36,7 @@
 		{/if}
 		{if 'WhatsApp'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsShareWhatsApp" title="{lang}wcf.message.share.whatsApp{/lang}">
+				<a href="#" class="button jsShareWhatsApp" title="{lang}wcf.message.share.whatsApp{/lang}">
 					<span class="icon icon24 fa-whatsapp jsTooltip"></span>
 					<span>{lang}wcf.message.share.whatsApp{/lang}</span>
 				</a>
@@ -44,7 +44,7 @@
 		{/if}
 		{if 'LinkedIn'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsShareLinkedIn" title="{lang}wcf.message.share.linkedIn{/lang}">
+				<a href="#" class="button jsShareLinkedIn" title="{lang}wcf.message.share.linkedIn{/lang}">
 					<span class="icon icon24 fa-linkedin jsTooltip"></span>
 					<span>{lang}wcf.message.share.linkedIn{/lang}</span>
 				</a>
@@ -52,7 +52,7 @@
 		{/if}
 		{if 'Pinterest'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsSharePinterest" title="{lang}wcf.message.share.pinterest{/lang}">
+				<a href="#" class="button jsSharePinterest" title="{lang}wcf.message.share.pinterest{/lang}">
 					<span class="icon icon24 fa-pinterest-p jsTooltip"></span>
 					<span>{lang}wcf.message.share.pinterest{/lang}</span>
 				</a>
@@ -60,7 +60,7 @@
 		{/if}
 		{if 'XING'|in_array:$__share_buttons_providers}
 			<li>
-				<a class="button jsShareXing" title="{lang}wcf.message.share.xing{/lang}">
+				<a href="#" class="button jsShareXing" title="{lang}wcf.message.share.xing{/lang}">
 					<span class="icon icon24 fa-xing jsTooltip"></span>
 					<span>{lang}wcf.message.share.xing{/lang}</span>
 				</a>