From: Johannes Berg Date: Mon, 25 Feb 2008 09:11:50 +0000 (+0100) Subject: mac80211: add missing "break" statement in mesh code X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ff59dc76e6e996092e4e11f4a6a370702428ead5;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git mac80211: add missing "break" statement in mesh code This inserts a missing break statement which, if hit, would cause the code to fall-through and unlock a spinlock twice. Noticed via sparse's "lock count wrong in basic block" warning and careful code inspection. Signed-off-by: Johannes Berg Cc: Luis Carlos Cobo Signed-off-by: John W. Linville --- diff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c index 0b0e8d7eb9c7..c2f4fe7a30b6 100644 --- a/net/mac80211/mesh_plink.c +++ b/net/mac80211/mesh_plink.c @@ -691,6 +691,7 @@ void mesh_rx_plink_frame(struct net_device *dev, struct ieee80211_mgmt *mgmt, spin_unlock_bh(&sta->plink_lock); mesh_plink_frame_tx(dev, PLINK_CLOSE, sta->addr, llid, plid, reason); + break; case OPN_ACPT: if (del_timer(&sta->plink_timer)) sta_info_put(sta);