From: Guo Chao <yan@linux.vnet.ibm.com>
Date: Mon, 7 Jan 2013 04:40:25 +0000 (-0500)
Subject: ext4: remove duplicate call to ext4_bread() in ext4_init_new_dir()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=fef0ebdb229bedce888b63923e2a1ba4e6c6a84c;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git

ext4: remove duplicate call to ext4_bread() in ext4_init_new_dir()

This fixes a buffer cache leak when creating a directory, introduced
in commit a774f9c20.

Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Tao Ma <boyu.mt@taobao.com>
---

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index f8be1c288a1c..f9ed946a448e 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2368,7 +2368,6 @@ static int ext4_init_new_dir(handle_t *handle, struct inode *dir,
 	}
 
 	inode->i_size = EXT4_I(inode)->i_disksize = blocksize;
-	dir_block = ext4_bread(handle, inode, 0, 1, &err);
 	if (!(dir_block = ext4_bread(handle, inode, 0, 1, &err))) {
 		if (!err) {
 			err = -EIO;