From: Dan Carpenter Date: Thu, 10 May 2012 07:33:02 +0000 (+0300) Subject: gma500: silence an unused variable warning X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=fcf92202e7bc2e8513ae045e3ec61e79c1c9e690;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git gma500: silence an unused variable warning If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that: drivers/gpu/drm/gma500/opregion.c:154:6: warning: unused variable ‘max’ [-Wunused-variable] Which give me a chance to use the new config_enabled() macro. :) Signed-off-by: Dan Carpenter Acked-by: Paul Menzel Acked-by: Alan Cox Signed-off-by: Dave Airlie --- diff --git a/drivers/gpu/drm/gma500/opregion.c b/drivers/gpu/drm/gma500/opregion.c index aa9e89f7e4c2..4f186eca3a30 100644 --- a/drivers/gpu/drm/gma500/opregion.c +++ b/drivers/gpu/drm/gma500/opregion.c @@ -149,7 +149,6 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) struct drm_psb_private *dev_priv = dev->dev_private; struct opregion_asle *asle = dev_priv->opregion.asle; struct backlight_device *bd = dev_priv->backlight_device; - u32 max; DRM_DEBUG_DRIVER("asle set backlight %x\n", bclp); @@ -163,11 +162,12 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) if (bclp > 255) return ASLE_BACKLIGHT_FAILED; -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE - max = bd->props.max_brightness; - bd->props.brightness = bclp * max / 255; - backlight_update_status(bd); -#endif + if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) { + int max = bd->props.max_brightness; + bd->props.brightness = bclp * max / 255; + backlight_update_status(bd); + } + asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID; return 0;