From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 9 May 2014 11:59:16 +0000 (+0300)
Subject: applicom: dereferencing NULL on error path
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=fc7be702474fe5c795592047940c702783736294;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git

applicom: dereferencing NULL on error path

commit 8bab797c6e5724a43b7666ad70860712365cdb71 upstream.

This is a static checker fix.  The "dev" variable is always NULL after
the while statement so we would be dereferencing a NULL pointer here.

Fixes: 819a3eba4233 ('[PATCH] applicom: fix error handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
index 974321a2508d..14790304b84b 100644
--- a/drivers/char/applicom.c
+++ b/drivers/char/applicom.c
@@ -345,7 +345,6 @@ out:
 			free_irq(apbs[i].irq, &dummy);
 		iounmap(apbs[i].RamIO);
 	}
-	pci_disable_device(dev);
 	return ret;
 }