From: Tim Düsterhus <duesterhus@woltlab.com>
Date: Fri, 30 Oct 2020 10:28:28 +0000 (+0100)
Subject: Make everything @typescript-eslint/no-unused-vars clean
X-Git-Tag: 5.4.0_Alpha_1~666^2~11
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=fb1fe5c491a453fb9bd376f85682b06f02fadf50;p=GitHub%2FWoltLab%2FWCF.git

Make everything @typescript-eslint/no-unused-vars clean
---

diff --git a/.eslintrc.js b/.eslintrc.js
index 65070d272f..04aec1c84f 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -20,5 +20,11 @@ module.exports = {
     "@typescript-eslint/no-unsafe-call": 0,
     "@typescript-eslint/no-unsafe-member-access": 0,
     "@typescript-eslint/no-unsafe-return": 0,
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        "argsIgnorePattern": "^_"
+      }
+    ]
   }
 };
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/CallbackList.js b/wcfsetup/install/files/js/WoltLabSuite/Core/CallbackList.js
index 865d610d1f..0d7795c8bf 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/CallbackList.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/CallbackList.js
@@ -37,7 +37,7 @@ define(["require", "exports"], function (require, exports) {
         forEach(identifier, callback) {
             var _a;
             if (identifier === null) {
-                this._callbacks.forEach((callbacks, identifier) => {
+                this._callbacks.forEach((callbacks, _identifier) => {
                     callbacks.forEach(callback);
                 });
             }
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/I18n/Plural.js b/wcfsetup/install/files/js/WoltLabSuite/Core/I18n/Plural.js
index 82843bf9f3..f57471651e 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/I18n/Plural.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/I18n/Plural.js
@@ -141,7 +141,7 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Tibetan
-        bo(n) { },
+        bo(_n) { },
         // Bosnian
         bs(n) {
             const v = Plural.getV(n);
@@ -270,7 +270,7 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Indonesian
-        id(n) { },
+        id(_n) { },
         // Icelandic
         is(n) {
             const f = Plural.getF(n);
@@ -278,9 +278,9 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Japanese
-        ja(n) { },
+        ja(_n) { },
         // Javanese
-        jv(n) { },
+        jv(_n) { },
         // Georgian
         ka(n) {
             if (n == 1)
@@ -292,14 +292,14 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Khmer
-        km(n) { },
+        km(_n) { },
         // Kannada
         kn(n) {
             if (n >= 0 && n <= 1)
                 return PLURAL_ONE;
         },
         // Korean
-        ko(n) { },
+        ko(_n) { },
         // Kurdish
         ku(n) {
             if (n == 1)
@@ -316,7 +316,7 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Lao
-        lo(n) { },
+        lo(_n) { },
         // Lithuanian
         lt(n) {
             const mod10 = n % 10;
@@ -361,7 +361,7 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Malay
-        ms(n) { },
+        ms(_n) { },
         // Maltese
         mt(n) {
             const mod100 = n % 100;
@@ -373,7 +373,7 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_MANY;
         },
         // Burmese
-        my(n) { },
+        my(_n) { },
         // Norwegian
         no(n) {
             if (n == 1)
@@ -486,9 +486,9 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Tajik
-        tg(n) { },
+        tg(_n) { },
         // Thai
-        th(n) { },
+        th(_n) { },
         // Turkmen
         tk(n) {
             if (n == 1)
@@ -515,9 +515,9 @@ define(["require", "exports", "tslib", "../StringUtil"], function (require, expo
                 return PLURAL_ONE;
         },
         // Vietnamese
-        vi(n) { },
+        vi(_n) { },
         // Chinese
-        zh(n) { },
+        zh(_n) { },
     };
     return Plural;
 });
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Template.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Template.js
index 16d68aa2c0..92f9572e8b 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Template.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Template.js
@@ -55,7 +55,7 @@ define(["require", "exports", "tslib", "./Template.grammar", "./StringUtil", "./
          *
          * @param  {object}  v  Parameters to pass to the template.
          */
-        fetch(v) {
+        fetch(_v) {
             // this will be replaced in the init function
             throw new Error("This Template is not initialized.");
         }
@@ -66,7 +66,7 @@ define(["require", "exports", "tslib", "./Template.grammar", "./StringUtil", "./
         get: function () {
             throw new Error("WCF.Template.callbacks is no longer supported");
         },
-        set: function (value) {
+        set: function (_value) {
             throw new Error("WCF.Template.callbacks is no longer supported");
         },
     });
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Confirmation.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Confirmation.js
index 256677aacb..e5ffacd24b 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Confirmation.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Confirmation.js
@@ -31,7 +31,7 @@ define(["require", "exports", "tslib", "../Core", "../Language", "./Dialog"], fu
             this.confirmButton = document.createElement("button");
             this.confirmButton.classList.add("buttonPrimary");
             this.confirmButton.textContent = Language.get("wcf.global.confirmation.confirm");
-            this.confirmButton.addEventListener("click", (ev) => this._confirm());
+            this.confirmButton.addEventListener("click", (_ev) => this._confirm());
             formSubmit.appendChild(this.confirmButton);
             const cancelButton = document.createElement("button");
             cancelButton.textContent = Language.get("wcf.global.confirmation.cancel");
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js
index 7d3bee5ba3..b4b22c1dd9 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js
@@ -24,7 +24,6 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Change/Listener", "./S
     let _dialogFullHeight = false;
     const _dialogObjects = new WeakMap();
     const _dialogToObject = new Map();
-    let _focusedBeforeDialog;
     let _keyupListener;
     const _validCallbacks = ["onBeforeClose", "onClose", "onShow"];
     // list of supported `input[type]` values for dialog submit
@@ -85,7 +84,6 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Change/Listener", "./S
             Listener_1.default.add("Ui/Dialog", () => {
                 this._initStaticDialogs();
             });
-            UiScreen.setDialogContainer(_container);
             window.addEventListener("resize", () => {
                 _dialogs.forEach((dialog) => {
                     if (!Core.stringToBool(dialog.dialog.getAttribute("aria-hidden"))) {
@@ -432,8 +430,6 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Change/Listener", "./S
                 _container.setAttribute("aria-hidden", "false");
                 _container.setAttribute("close-on-click", data.backdropCloseOnClick ? "true" : "false");
                 _activeDialog = id;
-                // Keep a reference to the currently focused element to be able to restore it later.
-                _focusedBeforeDialog = document.activeElement;
                 // Set the focus to the first focusable child of the dialog element.
                 const closeButton = data.header.querySelector(".dialogCloseButton");
                 if (closeButton)
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList.js
index 7260b2c7d5..2cd0c4d941 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/ItemList.js
@@ -16,7 +16,6 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Traverse", "../Languag
     Suggestion_1 = tslib_1.__importDefault(Suggestion_1);
     Simple_1 = tslib_1.__importDefault(Simple_1);
     Util_1 = tslib_1.__importDefault(Util_1);
-    let _activeId = "";
     const _data = new Map();
     /**
      * Creates the DOM structure for target element. If `element` is a `<textarea>`
@@ -120,7 +119,6 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Traverse", "../Languag
      */
     function keyDown(event) {
         const input = event.currentTarget;
-        _activeId = input.id;
         const lastItem = input.parentElement.previousElementSibling;
         if (event.key === "Backspace") {
             if (input.value.length === 0) {
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Header/Fixed.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Header/Fixed.js
index 6ce133f916..b4fe87d3b3 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Header/Fixed.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Header/Fixed.js
@@ -17,7 +17,6 @@ define(["require", "exports", "tslib", "../../../Event/Handler", "../../Alignmen
     UiScreen = tslib_1.__importStar(UiScreen);
     let _isMobile = false;
     let _pageHeader;
-    let _pageHeaderContainer;
     let _pageHeaderPanel;
     let _pageHeaderSearch;
     let _searchInput;
@@ -94,7 +93,6 @@ define(["require", "exports", "tslib", "../../../Event/Handler", "../../Alignmen
      */
     function init() {
         _pageHeader = document.getElementById("pageHeader");
-        _pageHeaderContainer = document.getElementById("pageHeaderContainer");
         initSearchBar();
         UiScreen.on("screen-md-down", {
             match() {
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Screen.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Screen.js
index 2a3f61c936..00ac334de0 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Screen.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Screen.js
@@ -14,7 +14,6 @@ define(["require", "exports", "tslib", "../Core", "../Environment"], function (r
     Core = tslib_1.__importStar(Core);
     Environment = tslib_1.__importStar(Environment);
     const _mql = new Map();
-    let _dialogContainer;
     let _scrollDisableCounter = 0;
     let _scrollOffsetFrom;
     let _scrollTop = 0;
@@ -163,13 +162,9 @@ define(["require", "exports", "tslib", "../Core", "../Environment"], function (r
     }
     exports.pageOverlayIsActive = pageOverlayIsActive;
     /**
-     * Sets the dialog container element. This method is used to
-     * circumvent a possible circular dependency, due to `Ui/Dialog`
-     * requiring the `Ui/Screen` module itself.
+     * @deprecated 5.4 - This method is a noop.
      */
-    function setDialogContainer(container) {
-        _dialogContainer = container;
-    }
+    function setDialogContainer(_container) { }
     exports.setDialogContainer = setDialogContainer;
     function _getQueryObject(query) {
         if (typeof query !== "string" || query.trim() === "") {
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/CallbackList.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/CallbackList.ts
index 988d2b8242..99e93e558d 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/CallbackList.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/CallbackList.ts
@@ -38,7 +38,7 @@ class CallbackList {
    */
   forEach(identifier: string | null, callback: (cb: Callback) => unknown): void {
     if (identifier === null) {
-      this._callbacks.forEach((callbacks, identifier) => {
+      this._callbacks.forEach((callbacks, _identifier) => {
         callbacks.forEach(callback);
       });
     } else {
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/I18n/Plural.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/I18n/Plural.ts
index eef3242a3e..445b3a3a29 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/I18n/Plural.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/I18n/Plural.ts
@@ -151,7 +151,7 @@ const Plural = {
   },
 
   // Tibetan
-  bo(n: number) {},
+  bo(_n: number) {},
 
   // Bosnian
   bs(n: number): string | undefined {
@@ -276,7 +276,7 @@ const Plural = {
   },
 
   // Indonesian
-  id(n: number) {},
+  id(_n: number) {},
 
   // Icelandic
   is(n: number): string | undefined {
@@ -286,10 +286,10 @@ const Plural = {
   },
 
   // Japanese
-  ja(n: number) {},
+  ja(_n: number) {},
 
   // Javanese
-  jv(n: number) {},
+  jv(_n: number) {},
 
   // Georgian
   ka(n: number): string | undefined {
@@ -302,7 +302,7 @@ const Plural = {
   },
 
   // Khmer
-  km(n: number) {},
+  km(_n: number) {},
 
   // Kannada
   kn(n: number): string | undefined {
@@ -310,7 +310,7 @@ const Plural = {
   },
 
   // Korean
-  ko(n: number) {},
+  ko(_n: number) {},
 
   // Kurdish
   ku(n: number): string | undefined {
@@ -328,7 +328,7 @@ const Plural = {
   },
 
   // Lao
-  lo(n: number) {},
+  lo(_n: number) {},
 
   // Lithuanian
   lt(n: number): string | undefined {
@@ -375,7 +375,7 @@ const Plural = {
   },
 
   // Malay
-  ms(n: number) {},
+  ms(_n: number) {},
 
   // Maltese
   mt(n: number): string | undefined {
@@ -387,7 +387,7 @@ const Plural = {
   },
 
   // Burmese
-  my(n: number) {},
+  my(_n: number) {},
 
   // Norwegian
   no(n: number): string | undefined {
@@ -503,10 +503,10 @@ const Plural = {
   },
 
   // Tajik
-  tg(n: number) {},
+  tg(_n: number) {},
 
   // Thai
-  th(n: number) {},
+  th(_n: number) {},
 
   // Turkmen
   tk(n: number): string | undefined {
@@ -535,10 +535,10 @@ const Plural = {
   },
 
   // Vietnamese
-  vi(n: number) {},
+  vi(_n: number) {},
 
   // Chinese
-  zh(n: number) {},
+  zh(_n: number) {},
 };
 
 export = Plural;
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Template.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Template.ts
index 4769360328..11edf783d4 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Template.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Template.ts
@@ -63,7 +63,7 @@ class Template {
    *
    * @param  {object}  v  Parameters to pass to the template.
    */
-  fetch(v: object): string {
+  fetch(_v: object): string {
     // this will be replaced in the init function
     throw new Error("This Template is not initialized.");
   }
@@ -75,7 +75,7 @@ Object.defineProperty(Template, "callbacks", {
   get: function () {
     throw new Error("WCF.Template.callbacks is no longer supported");
   },
-  set: function (value) {
+  set: function (_value) {
     throw new Error("WCF.Template.callbacks is no longer supported");
   },
 });
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Confirmation.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Confirmation.ts
index 0da77a3516..cde445dc40 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Confirmation.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Confirmation.ts
@@ -44,7 +44,7 @@ class UiConfirmation implements DialogCallbackObject {
     this.confirmButton = document.createElement("button");
     this.confirmButton.classList.add("buttonPrimary");
     this.confirmButton.textContent = Language.get("wcf.global.confirmation.confirm");
-    this.confirmButton.addEventListener("click", (ev) => this._confirm());
+    this.confirmButton.addEventListener("click", (_ev) => this._confirm());
     formSubmit.appendChild(this.confirmButton);
 
     const cancelButton = document.createElement("button");
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts
index f74b1f6302..241a7ff5b6 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts
@@ -32,7 +32,6 @@ const _dialogs = new Map<ElementId, DialogData>();
 let _dialogFullHeight = false;
 const _dialogObjects = new WeakMap<DialogCallbackObject, DialogInternalData>();
 const _dialogToObject = new Map<ElementId, DialogCallbackObject>();
-let _focusedBeforeDialog: Element | null;
 let _keyupListener: (event: KeyboardEvent) => boolean;
 const _validCallbacks = ["onBeforeClose", "onClose", "onShow"];
 
@@ -107,8 +106,6 @@ const UiDialog = {
       this._initStaticDialogs();
     });
 
-    UiScreen.setDialogContainer(_container);
-
     window.addEventListener("resize", () => {
       _dialogs.forEach((dialog) => {
         if (!Core.stringToBool(dialog.dialog.getAttribute("aria-hidden"))) {
@@ -518,9 +515,6 @@ const UiDialog = {
       _container.setAttribute("close-on-click", data.backdropCloseOnClick ? "true" : "false");
       _activeDialog = id;
 
-      // Keep a reference to the currently focused element to be able to restore it later.
-      _focusedBeforeDialog = document.activeElement;
-
       // Set the focus to the first focusable child of the dialog element.
       const closeButton = data.header.querySelector(".dialogCloseButton");
       if (closeButton) closeButton.setAttribute("inert", "true");
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/ItemList.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/ItemList.ts
index 16828591a3..c41e37423c 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/ItemList.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/ItemList.ts
@@ -15,7 +15,6 @@ import UiDropdownSimple from "./Dropdown/Simple";
 import { DatabaseObjectActionPayload } from "../Ajax/Data";
 import DomUtil from "../Dom/Util";
 
-let _activeId = "";
 const _data = new Map<string, ElementData>();
 
 /**
@@ -134,7 +133,6 @@ function handleLimit(elementId: string): void {
  */
 function keyDown(event: KeyboardEvent): void {
   const input = event.currentTarget as HTMLInputElement;
-  _activeId = input.id;
 
   const lastItem = input.parentElement!.previousElementSibling as HTMLElement | null;
   if (event.key === "Backspace") {
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Page/Header/Fixed.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Page/Header/Fixed.ts
index a2efebc8c3..db261f881a 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Page/Header/Fixed.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Page/Header/Fixed.ts
@@ -16,7 +16,6 @@ import * as UiScreen from "../../Screen";
 let _isMobile = false;
 
 let _pageHeader: HTMLElement;
-let _pageHeaderContainer: HTMLElement;
 let _pageHeaderPanel: HTMLElement;
 let _pageHeaderSearch: HTMLElement;
 let _searchInput: HTMLInputElement;
@@ -110,7 +109,6 @@ function closeSearchBar(): void {
  */
 export function init(): void {
   _pageHeader = document.getElementById("pageHeader")!;
-  _pageHeaderContainer = document.getElementById("pageHeaderContainer")!;
 
   initSearchBar();
 
diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Screen.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Screen.ts
index f5005127f1..ea076172b5 100644
--- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Screen.ts
+++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Screen.ts
@@ -13,7 +13,6 @@ import * as Environment from "../Environment";
 
 const _mql = new Map<string, MediaQueryData>();
 
-let _dialogContainer: Element;
 let _scrollDisableCounter = 0;
 let _scrollOffsetFrom: string;
 let _scrollTop = 0;
@@ -179,13 +178,9 @@ export function pageOverlayIsActive(): boolean {
 }
 
 /**
- * Sets the dialog container element. This method is used to
- * circumvent a possible circular dependency, due to `Ui/Dialog`
- * requiring the `Ui/Screen` module itself.
+ * @deprecated 5.4 - This method is a noop.
  */
-export function setDialogContainer(container: Element): void {
-  _dialogContainer = container;
-}
+export function setDialogContainer(_container: Element): void {}
 
 function _getQueryObject(query: string): MediaQueryData {
   if (typeof (query as any) !== "string" || query.trim() === "") {