From: Matthias Schmidt Date: Fri, 6 Nov 2020 13:45:07 +0000 (+0100) Subject: Fix storing ids in `Ui/Dialog` elements X-Git-Tag: 5.4.0_Alpha_1~629 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=fa4154601eac75216a2229e5e20855c24629d3a4;p=GitHub%2FWoltLab%2FWCF.git Fix storing ids in `Ui/Dialog` elements See b6b1bdd4461e8a841b3d0aff02043aef5acceb3a --- diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js index 01ed6e661c..5d881c2d04 100644 --- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js +++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js @@ -290,7 +290,7 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Change/Listener", "./S dialog.classList.add("dialogContainer"); dialog.setAttribute("aria-hidden", "true"); dialog.setAttribute("role", "dialog"); - dialog.id = id; + dialog.dataset.id = id; const header = document.createElement("header"); dialog.appendChild(header); const titleId = Util_1.default.getUniqueId(); diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts index 203e47488d..f7bbd73031 100644 --- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts +++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts @@ -348,7 +348,7 @@ const UiDialog = { dialog.classList.add("dialogContainer"); dialog.setAttribute("aria-hidden", "true"); dialog.setAttribute("role", "dialog"); - dialog.id = id; + dialog.dataset.id = id; const header = document.createElement("header"); dialog.appendChild(header);