From: Alexander Ebert <ebert@woltlab.com>
Date: Thu, 5 Oct 2023 16:09:02 +0000 (+0200)
Subject: Rename `getId()` to `getElementID()`
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=fa254c0b1864ed1495c503261644f4b748076554;p=GitHub%2FWoltLab%2FWCF.git

Rename `getId()` to `getElementID()`

The naming is more in line with the PHP API and makes it clear that this is not the label group’s id.
---

diff --git a/wcfsetup/install/files/acp/templates/articleAdd.tpl b/wcfsetup/install/files/acp/templates/articleAdd.tpl
index 08422a3737..d9e999885e 100644
--- a/wcfsetup/install/files/acp/templates/articleAdd.tpl
+++ b/wcfsetup/install/files/acp/templates/articleAdd.tpl
@@ -171,7 +171,7 @@
 		
 		{foreach from=$labelPickers item=labelPicker}
 			<dl>
-				<dt><label for="{$labelPicker->getId()}">{$labelPicker->labelGroup->getTitle()}</label></dt>
+				<dt><label for="{$labelPicker->getElementID()}">{$labelPicker->labelGroup->getTitle()}</label></dt>
 				<dd>
 					{@$labelPicker->toHtml()}
 					{if $errorField == 'label' && $errorType[$labelPicker->labelGroup->groupID]|isset}
diff --git a/wcfsetup/install/files/lib/system/label/LabelPicker.class.php b/wcfsetup/install/files/lib/system/label/LabelPicker.class.php
index 75ebcfc197..60322c603a 100644
--- a/wcfsetup/install/files/lib/system/label/LabelPicker.class.php
+++ b/wcfsetup/install/files/lib/system/label/LabelPicker.class.php
@@ -35,14 +35,14 @@ final class LabelPicker
                 ></woltlab-core-label-picker>
             EOT,
             $this->selected,
-            $this->getId(),
+            $this->getElementID(),
             $this->labelGroup->getTitle(),
             StringUtil::encodeHTML(JSON::encode($labels)),
             $this->labelGroup->groupID,
         );
     }
 
-    public function getId(): string
+    public function getElementID(): string
     {
         return "labelGroup{$this->labelGroup->groupID}";
     }