From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Date: Mon, 1 Jun 2009 01:18:55 +0000 (+0000) Subject: f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=fa202592796499dade5b3854643eaf0eed4d34ba;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback Network device TX is never run in IRQ context, and skb is freed outside of the IRQ-disabling spin lock. So checking for IRQ was a waste of time here. Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: David S. Miller <davem@davemloft.net> --- diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c index c1abeb89b413..54451ee02298 100644 --- a/drivers/usb/gadget/f_phonet.c +++ b/drivers/usb/gadget/f_phonet.c @@ -255,7 +255,7 @@ out_unlock: spin_unlock_irqrestore(&port->lock, flags); out: if (unlikely(skb)) { - dev_kfree_skb_any(skb); + dev_kfree_skb(skb); dev->stats.tx_dropped++; } return 0;