From: John W. Linville Date: Fri, 29 Apr 2011 19:04:58 +0000 (-0400) Subject: mwifiex: fix copy-n-paste 'thinko' for tsf_val X-Git-Tag: MMI-PSA29.97-13-9~19291^2~16^2~229 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f9c2fdbab1f1854f2bfcc75c326d0f4537ec2a7e;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git mwifiex: fix copy-n-paste 'thinko' for tsf_val CC [M] drivers/net/wireless/mwifiex/join.o drivers/net/wireless/mwifiex/join.c: In function ‘mwifiex_cmd_802_11_associate’: drivers/net/wireless/mwifiex/join.c:119:8: warning: ‘tsf_val’ may be used uninitialized in this function drivers/net/wireless/mwifiex/join.c:103:12: note: ‘tsf_val’ was declared here Looks like a copy-n-paste error, identical lines are a few lines below the ones removed, with an actual memcpy to tsf_val in between... Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/mwifiex/join.c b/drivers/net/wireless/mwifiex/join.c index 23d2d0b9a527..042eb7701d04 100644 --- a/drivers/net/wireless/mwifiex/join.c +++ b/drivers/net/wireless/mwifiex/join.c @@ -116,9 +116,6 @@ mwifiex_cmd_append_tsf_tlv(struct mwifiex_private *priv, u8 **buffer, memcpy(*buffer, &tsf_tlv, sizeof(tsf_tlv.header)); *buffer += sizeof(tsf_tlv.header); - memcpy(*buffer, &tsf_val, sizeof(tsf_val)); - *buffer += sizeof(tsf_val); - memcpy(&tsf_val, bss_desc->time_stamp, sizeof(tsf_val)); dev_dbg(priv->adapter->dev, "info: %s: TSF offset calc: %016llx - "