From: Linus Walleij Date: Tue, 22 Dec 2015 14:47:39 +0000 (+0100) Subject: mfd: htc-egpio: Be sure to clamp return value X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f7d623669648d2a8d7e81671294c26e480ddcc79;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git mfd: htc-egpio: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Philipp Zabel Signed-off-by: Linus Walleij Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/htc-egpio.c b/drivers/mfd/htc-egpio.c index 6ccaf90d98fd..e4f4a31b76d9 100644 --- a/drivers/mfd/htc-egpio.c +++ b/drivers/mfd/htc-egpio.c @@ -163,7 +163,7 @@ static int egpio_get(struct gpio_chip *chip, unsigned offset) value = egpio_readw(ei, reg); pr_debug("readw(%p + %x) = %x\n", ei->base_addr, reg << ei->bus_shift, value); - return value & bit; + return !!(value & bit); } static int egpio_direction_input(struct gpio_chip *chip, unsigned offset)