From: Paul Gortmaker Date: Wed, 11 Jul 2012 21:35:01 +0000 (-0400) Subject: tipc: limit error messages relating to memory leak to one line X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f705ab956b3a0377181c9d73b235ad5bf4020937;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git tipc: limit error messages relating to memory leak to one line With the default name table size of 1024, it is possible that the sanity check in tipc_nametbl_stop could spam out 1024 essentially identical error messages if memory was corrupted or similar. Limit it to issuing no more than a single message. The actual chain number (i.e. 0 --> 1023) wouldn't provide any useful insight if/when such an instance happened, so don't bother printing out that value. Signed-off-by: Paul Gortmaker --- diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c index 13fb9d559ea5..cade0acda4ef 100644 --- a/net/tipc/name_table.c +++ b/net/tipc/name_table.c @@ -940,8 +940,10 @@ void tipc_nametbl_stop(void) /* Verify name table is empty, then release it */ write_lock_bh(&tipc_nametbl_lock); for (i = 0; i < tipc_nametbl_size; i++) { - if (!hlist_empty(&table.types[i])) - err("tipc_nametbl_stop(): hash chain %u is non-null\n", i); + if (hlist_empty(&table.types[i])) + continue; + err("tipc_nametbl_stop(): orphaned hash chain detected\n"); + break; } kfree(table.types); table.types = NULL;