From: Tim Düsterhus <timwolla@googlemail.com>
Date: Tue, 8 Jan 2019 10:16:24 +0000 (+0100)
Subject: Apply suggestions from code review
X-Git-Tag: 5.2.0_Alpha_1~296^2~49
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f6f6d04283d577bb84478334c550cde82bb1873f;p=GitHub%2FWoltLab%2FWCF.git

Apply suggestions from code review

Use explicit comparison
See #2825

Co-Authored-By: joshuaruesweg <josh@wcflabs.de>
---

diff --git a/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php b/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php
index b43a9caa92..d827cc0ed6 100644
--- a/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php
+++ b/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php
@@ -121,7 +121,7 @@ class AJAXFileUploadAction extends AbstractSecureAction {
 				'filename' => $file->getFilename(),
 				'icon' => $file->getIconName(),
 				'filesize' => FileUtil::formatFilesize($file->filesize),
-				'image' => ($file->viewableImage) ? $file->getImage() : null, 
+				'image' => $file->viewableImage ? $file->getImage() : null, 
 				'uniqueFileId' => $file->getUniqueFileId()
 			];
 		}
diff --git a/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php b/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php
index 9dafd645ab..2515b11847 100644
--- a/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php
+++ b/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php
@@ -137,7 +137,7 @@ class UploadHandler extends SingletonFactory {
 		
 		/** @var UploadFile $storageFile */
 		foreach ($storage[$internalId]['files'] as $id => $storageFile) {
-			if ($storageFile->getUniqueFileId() == $uniqueFileId) {
+			if ($storageFile->getUniqueFileId() === $uniqueFileId) {
 				unset($storage[$internalId]['files'][$id]);
 				break;
 			}
@@ -195,7 +195,7 @@ class UploadHandler extends SingletonFactory {
 		}
 		
 		foreach ($this->getFilesForInternalId($internalId) as $file) {
-			if ($file->getUniqueFileId() == $uniqueFileId) {
+			if ($file->getUniqueFileId() === $uniqueFileId) {
 				return $file;
 			}
 		}