From: Lorenzo Bianconi Date: Mon, 17 Jul 2017 17:38:58 +0000 (+0200) Subject: iio: humidity: hts221: do not overwrite reserved data during power-down X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f6f58d9d93fdb53f24b0086ce1c51d3388aa6e53;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git iio: humidity: hts221: do not overwrite reserved data during power-down GENMASK(6, 3) in CTRL_REG1 and GENMASK(6, 2) in CTRL_REG2 are marked reserved. Do not changed the original value (not declared in the datasheet) during power-down/suspend routines. Fixes: e4a70e3e7d84 (iio: humidity: add support to hts221 rh/temp device) Fixes: b7079eeac5da (iio: humidity: hts221: add power management support) Signed-off-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index 47a29b2da1ce..6e5847386a45 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -305,11 +305,10 @@ int hts221_power_on(struct hts221_hw *hw) int hts221_power_off(struct hts221_hw *hw) { - __le16 data = 0; int err; - err = hw->tf->write(hw->dev, HTS221_REG_CNTRL1_ADDR, sizeof(data), - (u8 *)&data); + err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, + HTS221_ENABLE_MASK, false); if (err < 0) return err; @@ -692,11 +691,10 @@ static int __maybe_unused hts221_suspend(struct device *dev) { struct iio_dev *iio_dev = dev_get_drvdata(dev); struct hts221_hw *hw = iio_priv(iio_dev); - __le16 data = 0; int err; - err = hw->tf->write(hw->dev, HTS221_REG_CNTRL1_ADDR, sizeof(data), - (u8 *)&data); + err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, + HTS221_ENABLE_MASK, false); return err < 0 ? err : 0; }