From: Alexander Ebert <ebert@woltlab.com>
Date: Tue, 4 Jan 2022 14:12:07 +0000 (+0100)
Subject: Incorrect checkbox behavior
X-Git-Tag: 5.5.0_Alpha_1~243^2~3
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f6cfdd6cf32eab01f69fa69cac294ba896862397;p=GitHub%2FWoltLab%2FWCF.git

Incorrect checkbox behavior
---

diff --git a/com.woltlab.wcf/package.xml b/com.woltlab.wcf/package.xml
index dac30a57bf..32eca15732 100644
--- a/com.woltlab.wcf/package.xml
+++ b/com.woltlab.wcf/package.xml
@@ -5,7 +5,7 @@
 		<packagedescription>Free CMS and web-framework, designed for awesome websites and communities.</packagedescription>
 		<packagedescription language="de">Freies CMS und Web-Framework, das eindrucksvolle Websites und Communities ermöglicht.</packagedescription>
 		<isapplication>1</isapplication>
-		<version>5.4.0</version>
+		<version>5.5.0 Alpha 1</version>
 		<date>2021-12-22</date>
 	</packageinformation>
 	
diff --git a/ts/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.ts b/ts/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.ts
index f1ab6edd32..88cd0313cf 100644
--- a/ts/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.ts
+++ b/ts/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.ts
@@ -62,14 +62,14 @@ class AcpUiPackageUpdateManager implements DialogCallbackObject {
   }
 
   private updateSubmitButtonState(): void {
-    let isValid = true;
+    let disableButton = true;
     this.packages.forEach((checkbox) => {
-      if (checkbox && !checkbox.checked) {
-        isValid = false;
+      if (!checkbox || checkbox.checked) {
+        disableButton = false;
       }
     });
 
-    this.submitButton.disabled = !isValid;
+    this.submitButton.disabled = disableButton;
   }
 
   private getSelectedPackages(): Record<string, string> {
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.js
index 07d995d188..0313de15f2 100644
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.js
@@ -23,13 +23,13 @@ define(["require", "exports", "tslib", "../../../../Ajax", "../../../../Language
             });
         }
         updateSubmitButtonState() {
-            let isValid = true;
+            let disableButton = true;
             this.packages.forEach((checkbox) => {
-                if (checkbox && !checkbox.checked) {
-                    isValid = false;
+                if (!checkbox || checkbox.checked) {
+                    disableButton = false;
                 }
             });
-            this.submitButton.disabled = !isValid;
+            this.submitButton.disabled = disableButton;
         }
         getSelectedPackages() {
             const packages = {};
diff --git a/wcfsetup/install/files/lib/system/WCF.class.php b/wcfsetup/install/files/lib/system/WCF.class.php
index 20e8494a85..3e47fcee76 100644
--- a/wcfsetup/install/files/lib/system/WCF.class.php
+++ b/wcfsetup/install/files/lib/system/WCF.class.php
@@ -53,7 +53,7 @@ if (!@\ini_get('date.timezone')) {
 }
 
 // define current woltlab suite version
-\define('WCF_VERSION', '5.4.0');
+\define('WCF_VERSION', '5.5.0 Alpha 1');
 
 // define current API version
 // @deprecated 5.2