From: Guenter Roeck <linux@roeck-us.net>
Date: Wed, 12 Feb 2014 05:38:31 +0000 (-0800)
Subject: hwmon: (smm665): Return error from i2c_smbus_read_word_swapped
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f44e5c5cf9303daac57be0aa01bc0e8f29f1b9bd;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

hwmon: (smm665): Return error from i2c_smbus_read_word_swapped

There is no reason to replace one error code with another,
and returning -1 as error code is wrong anyway.

Smatch log:
drivers/hwmon/smm665.c:225 smm665_read_adc() info: why not propagate 'rv'
from i2c_smbus_read_word_swapped() instead of (-1)?

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---

diff --git a/drivers/hwmon/smm665.c b/drivers/hwmon/smm665.c
index d9e1b7de78da..4ef5802df6d8 100644
--- a/drivers/hwmon/smm665.c
+++ b/drivers/hwmon/smm665.c
@@ -222,7 +222,7 @@ static int smm665_read_adc(struct smm665_data *data, int adc)
 	rv = i2c_smbus_read_word_swapped(client, 0);
 	if (rv < 0) {
 		dev_dbg(&client->dev, "Failed to read ADC value: error %d", rv);
-		return -1;
+		return rv;
 	}
 	/*
 	 * Validate/verify readback adc channel (in bit 11..14).