From: Dan Carpenter Date: Fri, 27 May 2016 10:34:35 +0000 (+0300) Subject: atm: iphase: off by one in rx_pkt() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f2633d2eaaab773ea8b29cea3785cf0f8a8872a5;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git atm: iphase: off by one in rx_pkt() The iadev->rx_open[] array holds "iadev->num_vc" pointers (this code assumes that pointers are 32 bits). So the > here should be >= or else we could end up reading a garbage pointer from one element beyond the end of the array. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index 7d00f2994738..809dd1e02091 100644 --- a/drivers/atm/iphase.c +++ b/drivers/atm/iphase.c @@ -1128,7 +1128,7 @@ static int rx_pkt(struct atm_dev *dev) /* make the ptr point to the corresponding buffer desc entry */ buf_desc_ptr += desc; if (!desc || (desc > iadev->num_rx_desc) || - ((buf_desc_ptr->vc_index & 0xffff) > iadev->num_vc)) { + ((buf_desc_ptr->vc_index & 0xffff) >= iadev->num_vc)) { free_desc(dev, desc); IF_ERR(printk("IA: bad descriptor desc = %d \n", desc);) return -1;