From: Markus Hofstaetter Date: Wed, 11 Nov 2015 11:40:29 +0000 (+0100) Subject: leds: call led_pwm_set() in leds-pwm to enforce default LED_OFF X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f16703360da7731a057df2ffa902306819c22398;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git leds: call led_pwm_set() in leds-pwm to enforce default LED_OFF Some PWMs are disabled by default or the default pin setting does not match the LED_OFF state (e.g., active-low leds). Hence, the driver may end up reporting 0 brightness, but the leds are actually on using full brightness, because it never enforces its default configuration. So enforce it by calling led_pwm_set() after successfully registering the device. Tested on a Phytec phyFLEX i.MX6Q board based on kernel v3.19.5. Signed-off-by: Markus Hofstaetter Tested-by: Markus Hofstaetter Signed-off-by: Jacek Anaszewski --- diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index bc501930b54b..410ff0468245 100644 --- a/drivers/leds/leds-pwm.c +++ b/drivers/leds/leds-pwm.c @@ -124,6 +124,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, ret = led_classdev_register(dev, &led_data->cdev); if (ret == 0) { priv->num_leds++; + led_pwm_set(&led_data->cdev, led_data->cdev.brightness); } else { dev_err(dev, "failed to register PWM led for %s: %d\n", led->name, ret);