From: Johan Hovold Date: Fri, 10 Feb 2012 12:20:50 +0000 (+0100) Subject: USB: serial: use dev_err_console in generic write X-Git-Tag: MMI-PSA29.97-13-9~17266^2~22^2~121^2~7 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f1475a00a11b07e6ac7f97971466c1bfbf491957;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git USB: serial: use dev_err_console in generic write Use dev_err_console in write path so that an error at least gets reported once. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c index e129fcd69fd9..2a2fa2d0489d 100644 --- a/drivers/usb/serial/generic.c +++ b/drivers/usb/serial/generic.c @@ -217,10 +217,8 @@ retry: clear_bit(i, &port->write_urbs_free); result = usb_submit_urb(urb, GFP_ATOMIC); if (result) { - if (!port->port.console) { - dev_err(&port->dev, "%s - error submitting urb: %d\n", + dev_err_console(port, "%s - error submitting urb: %d\n", __func__, result); - } set_bit(i, &port->write_urbs_free); spin_lock_irqsave(&port->lock, flags); port->tx_bytes -= count;