From: Horms <horms@verge.net.au>
Date: Fri, 3 Feb 2006 01:03:18 +0000 (-0800)
Subject: [IPV4]: Remove suprious use of goto out: in icmp_reply
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=f00c401b9b5f0a90e2eb05705f5988fbda0b082b;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

[IPV4]: Remove suprious use of goto out: in icmp_reply

This seems to be an artifact of the follwoing commit in February '02.

e7e173af42dbf37b1d946f9ee00219cb3b2bea6a

In a nutshell, goto out and return actually do the same thing,
and both are called in this function. This patch removes out.

Signed-Off-By: Horms <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index 105039eb7629..6bc0887b0834 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -385,7 +385,7 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb)
 	u32 daddr;
 
 	if (ip_options_echo(&icmp_param->replyopts, skb))
-		goto out;
+		return;
 
 	if (icmp_xmit_lock())
 		return;
@@ -416,7 +416,6 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb)
 	ip_rt_put(rt);
 out_unlock:
 	icmp_xmit_unlock();
-out:;
 }