From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Wed, 22 Apr 2009 14:03:15 +0000 (+0100)
Subject: radio_si470x: Fix free memory corruption
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ec5f5bf80501abfe2da2897cfcde8452b545aacb;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git

radio_si470x: Fix free memory corruption

The release path for a disconnected device frees the object then unlocks
the mutex in the freed object...

Found by Dan Carpenter using Smatch

Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/media/radio/radio-si470x.c b/drivers/media/radio/radio-si470x.c
index 92c297796a9f..bd945d04dc90 100644
--- a/drivers/media/radio/radio-si470x.c
+++ b/drivers/media/radio/radio-si470x.c
@@ -1200,7 +1200,7 @@ static int si470x_fops_release(struct file *file)
 			video_unregister_device(radio->videodev);
 			kfree(radio->buffer);
 			kfree(radio);
-			goto unlock;
+			goto done;
 		}
 
 		/* stop rds reception */