From: Christophe Ricard Date: Sun, 25 Jan 2015 22:33:26 +0000 (+0100) Subject: NFC: st21nfca: Remove skb_pipe_list and skb_pipe_info useless allocation X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ec03ff1a8f9a9e065fe905dd34078d272d8de6ea;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git NFC: st21nfca: Remove skb_pipe_list and skb_pipe_info useless allocation skb_pipe_list and skb_pipe_info are allocated in nfc_hci_send_cmd. alloc_skb on those buffer are then useless. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz --- diff --git a/drivers/nfc/st21nfca/st21nfca.c b/drivers/nfc/st21nfca/st21nfca.c index 880193b4a053..0667272cca98 100644 --- a/drivers/nfc/st21nfca/st21nfca.c +++ b/drivers/nfc/st21nfca/st21nfca.c @@ -118,18 +118,6 @@ static int st21nfca_hci_load_session(struct nfc_hci_dev *hdev) NFC_HCI_TERMINAL_HOST_ID, 0 }; - skb_pipe_list = alloc_skb(ST21NFCA_HCI_LLC_MAX_SIZE, GFP_KERNEL); - if (!skb_pipe_list) { - r = -ENOMEM; - goto free_list; - } - - skb_pipe_info = alloc_skb(ST21NFCA_HCI_LLC_MAX_SIZE, GFP_KERNEL); - if (!skb_pipe_info) { - r = -ENOMEM; - goto free_info; - } - /* On ST21NFCA device pipes number are dynamics * A maximum of 16 pipes can be created at the same time * If pipes are already created, hci_dev_up will fail. @@ -212,7 +200,6 @@ static int st21nfca_hci_load_session(struct nfc_hci_dev *hdev) memcpy(hdev->init_data.gates, st21nfca_gates, sizeof(st21nfca_gates)); free_info: kfree_skb(skb_pipe_info); -free_list: kfree_skb(skb_pipe_list); return r; }