From: Jean-Philippe Brucker Date: Thu, 1 Jun 2017 18:22:01 +0000 (+0100) Subject: dmaengine: pl330: fix warning in pl330_remove X-Git-Tag: MMI-PSA29.97-13-9~5502^2 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ebcdaee4cebb3a8d0d702ab5e9392373672ec1de;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git dmaengine: pl330: fix warning in pl330_remove When removing a device with less than 9 IRQs (AMBA_NR_IRQS), we'll get a big WARN_ON from devres.c because pl330_remove calls devm_free_irqs for unallocated irqs. Similarly to pl330_probe, check that IRQ number is present before calling devm_free_irq. Signed-off-by: Jean-Philippe Brucker Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 8b0da7fa520d..e90a7a0d760a 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -3008,7 +3008,8 @@ static int pl330_remove(struct amba_device *adev) for (i = 0; i < AMBA_NR_IRQS; i++) { irq = adev->irq[i]; - devm_free_irq(&adev->dev, irq, pl330); + if (irq) + devm_free_irq(&adev->dev, irq, pl330); } dma_async_device_unregister(&pl330->ddma);