From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Date: Tue, 22 Jul 2014 15:02:08 +0000 (+0900)
Subject: ALSA: bebob: Correction for return value of special_clk_ctl_put() in error
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=eb12f72ee7245ca207818b9efd10be2641494502;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

ALSA: bebob: Correction for return value of special_clk_ctl_put() in error

This commit is a supplement to my previous patch.
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-July/079190.html

The special_clk_ctl_put() still returns 0 in error handling case. It should
return -EINVAL.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c
index d6d6ff8cb8dd..70faa3a32526 100644
--- a/sound/firewire/bebob/bebob_maudio.c
+++ b/sound/firewire/bebob/bebob_maudio.c
@@ -381,7 +381,7 @@ static int special_clk_ctl_put(struct snd_kcontrol *kctl,
 
 	id = uval->value.enumerated.item[0];
 	if (id >= ARRAY_SIZE(special_clk_labels))
-		return 0;
+		return -EINVAL;
 
 	mutex_lock(&bebob->mutex);