From: Marcel Werk <burntime@woltlab.com>
Date: Fri, 4 Dec 2020 11:27:04 +0000 (+0100)
Subject: Adjusted handling of empty breadcrumbs
X-Git-Tag: 5.4.0_Alpha_1~566
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ea631258e9c5f143d2001a3a9bb720df780698bd;p=GitHub%2FWoltLab%2FWCF.git

Adjusted handling of empty breadcrumbs
---

diff --git a/com.woltlab.wcf/templates/ampFooter.tpl b/com.woltlab.wcf/templates/ampFooter.tpl
index b94e36991c..c76cd1d636 100644
--- a/com.woltlab.wcf/templates/ampFooter.tpl
+++ b/com.woltlab.wcf/templates/ampFooter.tpl
@@ -42,8 +42,11 @@
 			<ol class="breadcrumbs">
 				{assign var=__breadcrumbsDepth value=0}
 				{foreach from=$__wcf->getBreadcrumbs() item=$breadcrumb}
-					<li><a href="{$breadcrumb->getURL()}">{$breadcrumb->getLabel()}</a></li>
-					{assign var=__breadcrumbsDepth value=$__breadcrumbsDepth + 1}
+					{* skip breadcrumbs that do not expose a visible label *}
+					{if $breadcrumb->getLabel()}
+						<li><a href="{$breadcrumb->getURL()}">{$breadcrumb->getLabel()}</a></li>
+						{assign var=__breadcrumbsDepth value=$__breadcrumbsDepth + 1}
+					{/if}
 				{/foreach}
 			</ol>
 		</amp-sidebar>
diff --git a/com.woltlab.wcf/templates/pageMenuMobile.tpl b/com.woltlab.wcf/templates/pageMenuMobile.tpl
index c43dd23c07..7dc604ebb5 100644
--- a/com.woltlab.wcf/templates/pageMenuMobile.tpl
+++ b/com.woltlab.wcf/templates/pageMenuMobile.tpl
@@ -63,15 +63,18 @@
 			{content}
 				{assign var=__breadcrumbsDepth value=0}
 				{foreach from=$__wcf->getBreadcrumbs() item=$breadcrumb}
-					<li class="menuOverlayItem">
-						<a href="{$breadcrumb->getURL()}" class="menuOverlayItemLink">
-							<span{if $__breadcrumbsDepth} style="padding-left: {$__breadcrumbsDepth * 20}px" {/if} class="box24">
-								<span class="icon icon24 fa-{if $__breadcrumbsDepth}caret-right{else}home{/if}"></span>
-								<span class="menuOverlayItemTitle">{$breadcrumb->getLabel()}</span>
-							</span>
-						</a>
-					</li>
-					{assign var=__breadcrumbsDepth value=$__breadcrumbsDepth + 1}
+					{* skip breadcrumbs that do not expose a visible label *}
+					{if $breadcrumb->getLabel()}
+						<li class="menuOverlayItem">
+							<a href="{$breadcrumb->getURL()}" class="menuOverlayItemLink">
+								<span{if $__breadcrumbsDepth} style="padding-left: {$__breadcrumbsDepth * 20}px" {/if} class="box24">
+									<span class="icon icon24 fa-{if $__breadcrumbsDepth}caret-right{else}home{/if}"></span>
+									<span class="menuOverlayItemTitle">{$breadcrumb->getLabel()}</span>
+								</span>
+							</a>
+						</li>
+						{assign var=__breadcrumbsDepth value=$__breadcrumbsDepth + 1}
+					{/if}
 				{/foreach}
 			{/content}
 		{/hascontent}