From: David Howells Date: Wed, 16 Dec 2009 00:47:46 +0000 (-0800) Subject: FS-Cache: Avoid maybe-used-uninitialised warning on variable X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ea58ceb543b45d45b257a86eaf9d60c94e8adcf2;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git FS-Cache: Avoid maybe-used-uninitialised warning on variable Andrew Morton's compiler sees the following warning in FS-Cache: fs/fscache/object-list.c: In function 'fscache_objlist_lookup': fs/fscache/object-list.c:94: warning: 'obj' may be used uninitialized in this function which my compiler doesn't. This is a false positive as obj can only be used in the comparison against minobj if minobj has been set to something other than NULL, but for that to happen, obj has to be first set to something. Deal with this by preclearing obj too. Reported-by: Andrew Morton Signed-off-by: David Howells Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/fscache/object-list.c b/fs/fscache/object-list.c index e590242fa41a..3221a0c7944e 100644 --- a/fs/fscache/object-list.c +++ b/fs/fscache/object-list.c @@ -91,7 +91,7 @@ EXPORT_SYMBOL(fscache_object_destroy); */ static struct fscache_object *fscache_objlist_lookup(loff_t *_pos) { - struct fscache_object *pobj, *obj, *minobj = NULL; + struct fscache_object *pobj, *obj = NULL, *minobj = NULL; struct rb_node *p; unsigned long pos;