From: Steve French <sfrench@us.ibm.com>
Date: Tue, 12 Jul 2011 18:24:43 +0000 (+0000)
Subject: [CIFS] update limit for snprintf in cifs_construct_tcon
X-Git-Tag: MMI-PSA29.97-13-9~18962^2~1
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ea1be1a3c3c4b2bbc32aeb7995e18336c8060e0e;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

[CIFS] update limit for snprintf in cifs_construct_tcon

In 34c87901e113 "Shrink stack space usage in cifs_construct_tcon" we
change the size of the username name buffer from MAX_USERNAME_SIZE
(256) to 28.  This call to snprintf() needs to be updated as well.
Reported by Dan Carpenter.

Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index dbd669cc5bc7..ccc1afa0bf3b 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3485,7 +3485,7 @@ cifs_construct_tcon(struct cifs_sb_info *cifs_sb, uid_t fsuid)
 		goto out;
 	}
 
-	snprintf(username, MAX_USERNAME_SIZE, "krb50x%x", fsuid);
+	snprintf(username, sizeof(username), "krb50x%x", fsuid);
 	vol_info->username = username;
 	vol_info->local_nls = cifs_sb->local_nls;
 	vol_info->linux_uid = fsuid;