From: Takashi Iwai <tiwai@suse.de>
Date: Thu, 12 Mar 2015 15:57:51 +0000 (+0100)
Subject: ALSA: control: Fix breakage of user ctl element addition
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e79d74ab25339437447478e4dfe2b35c5b560512;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

ALSA: control: Fix breakage of user ctl element addition

In the commit [2225e79b9b03: 'ALSA: core: reduce stack usage related
to snd_ctl_new()'], the id field of the newly added kctl is untouched,
thus all attribute like name string remain empty.  The fix is just to
add the forgotten memcpy of the id field.

Fixes: 2225e79b9b03 ('ALSA: core: reduce stack usage related to snd_ctl_new()')
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/core/control.c b/sound/core/control.c
index 54a412af3224..d677c27746e9 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1267,6 +1267,7 @@ static int snd_ctl_elem_add(struct snd_ctl_file *file,
 	err = snd_ctl_new(&kctl, count, access, file);
 	if (err < 0)
 		return err;
+	memcpy(&kctl->id, &info->id, sizeof(kctl->id));
 	kctl->private_data = kzalloc(sizeof(struct user_element) + private_size,
 				     GFP_KERNEL);
 	if (kctl->private_data == NULL) {