From: David S. Miller Date: Mon, 15 Oct 2007 08:36:24 +0000 (-0700) Subject: [NIU]: Fix write past end of array in niu_pci_probe_sprom(). X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e6a5fdf56e3a5fc179cd8c8c19081a9a11882b0c;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git [NIU]: Fix write past end of array in niu_pci_probe_sprom(). Noticed by Coverity checker and reported by Adrian Bunk. Signed-off-by: David S. Miller --- diff --git a/drivers/net/niu.c b/drivers/net/niu.c index 43bfe7e6b6f5..54166bdeae96 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -6213,7 +6213,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np) val = nr64(ESPC_MOD_STR_LEN); niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n", (unsigned long long) val); - if (val > 8 * 4) + if (val >= 8 * 4) return -EINVAL; for (i = 0; i < val; i += 4) { @@ -6229,7 +6229,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np) val = nr64(ESPC_BD_MOD_STR_LEN); niudbg(PROBE, "SPROM: BD_MOD_STR_LEN[%llu]\n", (unsigned long long) val); - if (val > 4 * 4) + if (val >= 4 * 4) return -EINVAL; for (i = 0; i < val; i += 4) {