From: Alexander Levin Date: Sat, 3 Jun 2017 03:39:13 +0000 (+0000) Subject: perf/core: Don't release cred_guard_mutex if not taken X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=e5aeee51f6b4fb22e851105ee6d8ad211c40a214;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git perf/core: Don't release cred_guard_mutex if not taken If we failed to acquire task's cred_guard_mutex we shouldn't proceed to release it in the error path. Fixes: a63fbed776c ("perf/tracing/cpuhotplug: Fix locking order") Signed-off-by: Alexander Levin Cc: peterz@infradead.org Cc: rostedt@goodmis.org Cc: mathieu.desnoyers@efficios.com Cc: mhiramat@kernel.org Cc: paulmck@linux.vnet.ibm.com Cc: bigeasy@linutronix.de Link: http://lkml.kernel.org/r/20170603033903.12056-1-alexander.levin@verizon.com Signed-off-by: Thomas Gleixner --- diff --git a/kernel/events/core.c b/kernel/events/core.c index b97cda4d1777..1f1b8cdaca2d 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9878,7 +9878,7 @@ SYSCALL_DEFINE5(perf_event_open, if (task) { err = mutex_lock_interruptible(&task->signal->cred_guard_mutex); if (err) - goto err_cred; + goto err_task; /* * Reuse ptrace permission checks for now.